roger 1.4.5 → 1.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c24e57e95788bdd88359a7e8d02a380a4a75f3e4
-  data.tar.gz: a367cd14e6f5d835e006f4447fd981ab2b4d3bb7
+  metadata.gz: ff392fddffc0c128c0f1c2ed637a0fb34cfa056d
+  data.tar.gz: 8732e488d0ad390ebcf49aba40bf6a654446b6bf
 SHA512:
-  metadata.gz: 15a711d5f391dcc2a6f080526323e831fc15cc5687a353a73d55f9fce227fa2632efb999b334fd16b7c376c34fa62190b37ce544008c49458ce220dfe5d57720
-  data.tar.gz: 78ef19b99cdf2d2c84b96f119a86f05a2305979cff5f243ab8a2d9141b635c1ac67d425c6904d5ae2a9d7faf00b072460b8d82d561096dd600f95c0902d1f593
+  metadata.gz: d9c61357b6b2497f66e4f01ae627ed8ea20cc8cbe96f9a71db15ac15737019da9fecdd9e606723cdff76443b78f4328f1c3ac5dee3fafeca7ab4c3294b0b365d
+  data.tar.gz: 73320c598c51c6585c7cc82d5ab84f23446adea024371a67e42c7e26ca6f89fb8001d05b3ba97861c1450b8ed646ba7cf5c3b25ab78a29856f5dcc7554389eb6

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 1.4.6
+* Allow setting target_path in dir finalizer
+* Always create target_paths if they don't exist
+
 ## Version 1.4.5
 * Allow setting target_path in zip finalizer
 

data/lib/roger/release/finalizers/dir.rb

@@ -7,12 +7,19 @@ module Roger::Release::Finalizers
   #
   class Dir < Base
     # @option options :prefix Prefix to put before the version (default = "html")
-    def call(release, options = {})
-      options = {}.update(@options)
-      options.update(options) if options
+    def call(release, call_options = {})
+      options = {
+        prefix: "html",
+        target_path: release.target_path
+      }.update(@options)
+      options.update(call_options) if call_options
 
-      name = [(options[:prefix] || "html"), release.scm.version].join("-")
-      target_path = release.target_path + name
+      name = [options[:prefix], release.scm.version].join("-")
+
+      target_dir = Pathname.new(options[:target_path])
+      FileUtils.mkdir_p(target_dir) unless target_dir.exist?
+
+      target_path = target_dir + name
 
       release.log(self, "Finalizing release to #{target_path}")
 

data/lib/roger/release/finalizers/zip.rb

@@ -16,8 +16,10 @@ module Roger::Release::Finalizers
 
       options.update(call_options) if call_options
 
+      target_path = ensure_target_path(options[:target_path])
+
       name = [options[:prefix], release.scm.version].join("-") + ".zip"
-      zip_path = Pathname.new(options[:target_path]) + name
+      zip_path = target_path + name
 
       release.log(self, "Finalizing release to #{zip_path}")
 
@@ -32,6 +34,12 @@ module Roger::Release::Finalizers
 
     protected
 
+    def ensure_target_path(path)
+      target_path = Pathname.new(path)
+      FileUtils.mkdir_p(target_path) unless target_path.exist?
+      target_path
+    end
+
     def cleanup_existing_zip(release, path)
       return unless File.exist?(path)
 

data/lib/roger/version.rb

@@ -1,4 +1,4 @@
 # Roger main namespace
 module Roger
-  VERSION = "1.4.5"
+  VERSION = "1.4.6"
 end

data/test/unit/release/finalizers/dir_test.rb

@@ -39,5 +39,32 @@ module Roger
 
       assert_not_same original_ctime, File.ctime(dir)
     end
+
+    def test_target_path
+      finalizer = Roger::Release::Finalizers::Dir.new
+      dir = @release.project.construct.directory("rel")
+
+      finalizer.call(@release, target_path: dir)
+
+      assert File.exist?(dir + "html-1.0.0")
+    end
+
+    def test_target_path_with_string
+      finalizer = Roger::Release::Finalizers::Dir.new
+      dir = @release.project.construct.directory("rel")
+
+      finalizer.call(@release, target_path: dir.to_s)
+
+      assert File.exist?(dir + "html-1.0.0")
+    end
+
+    def test_target_path_will_be_created_if_nonexistent
+      finalizer = Roger::Release::Finalizers::Dir.new
+      dir = @release.target_path + "rel"
+
+      finalizer.call(@release, target_path: dir)
+
+      assert File.exist?(dir + "html-1.0.0")
+    end
   end
 end

data/test/unit/release/finalizers/zip_test.rb

@@ -57,5 +57,14 @@ module Roger
 
       assert File.exist?(dir + "html-1.0.0.zip")
     end
+
+    def test_target_path_will_be_created_if_nonexistent
+      finalizer = Roger::Release::Finalizers::Zip.new
+      dir = @release.build_path + "downloads"
+
+      finalizer.call(@release, target_path: dir)
+
+      assert File.exist?(dir + "html-1.0.0.zip")
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roger
 version: !ruby/object:Gem::Version
-  version: 1.4.5
+  version: 1.4.6
 platform: ruby
 authors:
 - Flurin Egger