roda 3.71.0 → 3.72.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d5460d6cecb4f9b9acfedd05f5b14793bb9aefa2df2a8c29c559da319df87ee4
-  data.tar.gz: 75c3c8803abef4e27cac592a88597e8f9cd098be39bf1d0c1b1192175fd1f8e2
+  metadata.gz: d5c28e38d35f59176f159798f68d82bbd30df62a5907ace3a3750b1daf7b4fe6
+  data.tar.gz: cb5fd8d5a9d665bc820c55ccbf1fd6a068873ae3e265a1f877bbdf82b51c4d6e
 SHA512:
-  metadata.gz: 6efc49bb205012a7ce50bc3c300d924a149de33416a35870f11efed492251c331804b970c967e47a481b0ddb0a83507c5926c1dc32069941b4edd2bd56df09e5
-  data.tar.gz: 698b7e7daae4cd0712a20a1e3e274f7ba3cdb9068eefdeb3bb5f043f2d437cdd5dda961ce91d88794e22a8ca3ef5825e3f8bd3f92ff933eab772c352dd17c2ee
+  metadata.gz: d8710537511b8f332c443fd41bd279c99de53c0bc9618cd92f763ab7d354f70c4496ba9eafa076438087b5ab52f36e69f649aa00d2fb6f07d5315b7d61aef4a1
+  data.tar.gz: e0af216b465facc81e81ab8a495d472685c26aa6b2c1d56c0e48631586555f78f4d5922ac5ee92c6118a08b8162ee35866dc5708155bdbed70d5851b2ff8339b

data/CHANGELOG

@@ -1,3 +1,11 @@
+= 3.72.0 (2023-09-12)
+
+* Add invalid_request_body plugin for custom handling of invalid request bodies (jeremyevans)
+
+* Warn when defining method that expects 1 argument when block requires multiple arguments when :check_arity option is set to :warn (jeremyevans)
+
+* Implement the match_hooks plugin using the match_hook_args plugin (jeremyevans)
+
 = 3.71.0 (2023-08-14)
 
 * Add match_hook_args plugin, similar to match_hooks but support matchers and block args as hook arguments (jeremyevans)

data/doc/release_notes/3.72.0.txt

@@ -0,0 +1,48 @@
+= New Features
+
+* An invalid_request_body plugin has been added for allowing custom
+  handling of invalid request bodies.  Roda uses Rack's request body
+  parsing, and by default invalid request bodies can result in
+  different exceptions based on how the body is invalid and which
+  version of Rack is in use.
+
+  If you want to treat an invalid request body as the submission of
+  no parameters, you can use the :empty_hash argument when loading
+  the plugin:
+
+    plugin :invalid_request_body, :empty_hash
+
+  If you want to return a empty 400 (Bad Request) response if an
+  invalid request body is submitted, you can use the :empty_400
+  argument when loading the plugin:
+
+    plugin :invalid_request_body, :empty_400
+
+  If you want to raise a Roda::RodaPlugins::InvalidRequestBody::Error
+  exception if an invalid request body is submitted (which makes it
+  easier to handle these exceptions when using the error_handler
+  plugin), you can use the :raise argument when loading the plugin:
+
+    plugin :invalid_request_body, :raise
+
+  For custom behavior, you can pass a block when loading the plugin
+  The block is called with the exception Rack raised when parsing the
+  body. The block will be used to define a method in the application's
+  RodaRequest class.  It can either return a hash of parameters, or
+  you can raise a different exception, or you can halt processing and
+  return a response:
+
+    plugin :invalid_request_body do |exception|
+      # To treat the exception raised as a submitted parameter
+      {body_error: exception}
+    end
+
+= Other Improvements
+
+* When using the check_arity: :warn Roda option, Roda now correctly
+  warns when defining a method that expects a single argument when
+  the provided block requires multiple arguments.
+
+* The match_hooks plugin is now implemented using the match_hook_args
+  plugin, simplifying the implementation.  This change should be
+  transparent unless you were reaching into the internals.

data/lib/roda/plugins/invalid_request_body.rb

@@ -0,0 +1,107 @@
+# frozen-string-literal: true
+
+#
+class Roda
+  module RodaPlugins
+    # The invalid_request_body plugin allows for custom handling of invalid request
+    # bodies.  Roda uses Rack for parsing request bodies, so by default, any
+    # invalid request bodies would result in Rack raising an exception, and the
+    # exception could change for different reasons the request body is invalid.
+    # This plugin overrides RodaRequest#POST (which parses parameters from request
+    # bodies), and if parsing raises an exception, it allows for custom behavior.
+    # 
+    # If you want to treat an invalid request body as the submission of no parameters,
+    # you can use the :empty_hash argument when loading the plugin:
+    #
+    #   plugin :invalid_request_body, :empty_hash
+    #
+    # If you want to return a empty 400 (Bad Request) response if an invalid request
+    # body is submitted, you can use the :empty_400 argument when loading the plugin:
+    #
+    #   plugin :invalid_request_body, :empty_400
+    #
+    # If you want to raise a Roda::RodaPlugins::InvalidRequestBody::Error exception
+    # if an invalid request body is submitted (which makes it easier to handle these
+    # exceptions when using the error_handler plugin), you can use the :raise argument
+    # when loading the plugin:
+    #
+    #   plugin :invalid_request_body, :raise
+    #
+    # For custom behavior, you can pass a block when loading the plugin.  The block
+    # is called with the exception Rack raised when parsing the body. The block will
+    # be used to define a method in the application's RodaRequest class.  It can either
+    # return a hash of parameters, or you can raise a different exception, or you
+    # can halt processing and return a response:
+    #
+    #   plugin :invalid_request_body do |exception|
+    #     # To treat the exception raised as a submitted parameter
+    #     {body_error: exception}
+    #   end
+    module InvalidRequestBody
+      # Exception class raised for invalid request bodies.
+      Error = Class.new(RodaError)
+
+      # Set the action to use (:empty_400, :empty_hash, :raise) for invalid request bodies,
+      # or use a block for custom behavior.
+      def self.configure(app, action=nil, &block)
+        if action
+          if block
+            raise RodaError, "cannot provide both block and action when loading invalid_request_body plugin"
+          end
+
+          method = :"handle_invalid_request_body_#{action}"
+          unless RequestMethods.private_method_defined?(method)
+            raise RodaError, "invalid invalid_request_body action provided: #{action}"
+          end
+
+          app::RodaRequest.send(:alias_method, :handle_invalid_request_body, method)
+        elsif block
+          app::RodaRequest.class_eval do
+            define_method(:handle_invalid_request_body, &block)
+            alias handle_invalid_request_body handle_invalid_request_body
+          end
+        else
+          raise RodaError, "must provide block or action when loading invalid_request_body plugin"
+        end
+
+        app::RodaRequest.send(:private, :handle_invalid_request_body)
+      end
+
+      module RequestMethods
+        # Handle invalid request bodies as configured if the default behavior
+        # raises an exception.
+        def POST
+          super
+        rescue => e 
+          handle_invalid_request_body(e)
+        end
+
+        private
+
+        # Return an empty 400 HTTP response for invalid request bodies.
+        def handle_invalid_request_body_empty_400(e)
+          response.status = 400
+          headers = response.headers
+          headers.clear
+          headers[RodaResponseHeaders::CONTENT_TYPE] = 'text/html'
+          headers[RodaResponseHeaders::CONTENT_LENGTH] ='0'
+          throw :halt, response.finish_with_body([])
+        end
+
+        # Treat invalid request bodies by using an empty hash as the
+        # POST params.
+        def handle_invalid_request_body_empty_hash(e)
+          {}
+        end
+
+        # Raise a specific error for all invalid request bodies,
+        # to allow for easy rescuing using the error_handler plugin.
+        def handle_invalid_request_body_raise(e)
+          raise Error, e.message
+        end
+      end
+    end
+
+    register_plugin(:invalid_request_body, InvalidRequestBody)
+  end
+end

data/lib/roda/plugins/match_hook.rb

@@ -6,7 +6,8 @@ class Roda
     # The match_hook plugin adds hooks that are called upon a successful match
     # by any of the matchers.  The hooks do not take any arguments.  If you would
     # like hooks that pass the arguments/matchers and values yielded to the route block,
-    # use the match_hook_args plugin.
+    # use the match_hook_args plugin. This uses the match_hook_args plugin internally,
+    # but doesn't pass the matchers and values yielded.
     #
     #   plugin :match_hook
     #
@@ -14,56 +15,18 @@ class Roda
     #     logger.debug("#{request.matched_path} matched. #{request.remaining_path} remaining.")
     #   end
     module MatchHook
-      def self.configure(app)
-        app.opts[:match_hooks] ||= []
+      def self.load_dependencies(app)
+        app.plugin :match_hook_args
       end
 
       module ClassMethods
-        # Freeze the array of hook methods when freezing the app
-        def freeze
-          opts[:match_hooks].freeze
-          super
-        end
-
         # Add a match hook.
         def match_hook(&block)
-          opts[:match_hooks] << define_roda_method("match_hook", 0, &block)
-
-          if opts[:match_hooks].length == 1
-            class_eval("alias _match_hook #{opts[:match_hooks].first}", __FILE__, __LINE__)
-          else
-            class_eval("def _match_hook; #{opts[:match_hooks].join(';')} end", __FILE__, __LINE__)
-          end
-
-          public :_match_hook
-
+          meth = define_roda_method("match_hook", 0, &block)
+          add_match_hook{|_,_| send(meth)}
           nil
         end
       end
-
-      module InstanceMethods
-        # Default empty method if no match hooks are defined.
-        def _match_hook
-        end
-      end
-
-      module RequestMethods
-        private
-
-        # Call the match hook if yielding to the block before yielding to the block.
-        def if_match(_)
-          super do |*a|
-            scope._match_hook
-            yield(*a)
-          end
-        end
-
-        # Call the match hook before yielding to the block
-        def always
-          scope._match_hook
-          super
-        end
-      end
     end
 
     register_plugin :match_hook, MatchHook

data/lib/roda/version.rb

@@ -4,7 +4,7 @@ class Roda
   RodaMajorVersion = 3
 
   # The minor version of Roda, updated for new feature releases of Roda.
-  RodaMinorVersion = 71
+  RodaMinorVersion = 72
 
   # The patch version of Roda, updated only for bug fixes from the last
   # feature release.

data/lib/roda.rb

@@ -88,6 +88,7 @@ class Roda
           end
           call_meth = meth
 
+          # RODA4: Switch to false # :warn in last Roda 3 version
           if (check_arity = opts.fetch(:check_arity, true)) && !block.lambda?
             required_args, optional_args, rest, keyword = _define_roda_method_arg_numbers(block)
 
@@ -117,6 +118,9 @@ class Roda
                 alias_method meth, meth
                 meth = :"#{meth}_arity"
               elsif required_args > 1
+                if check_arity == :warn
+                  RodaPlugins.warn "Arity mismatch in block passed to define_roda_method. Expected Arity 1, but multiple arguments required for #{block.inspect}"
+                end
                 b = block
                 block = lambda{|r| instance_exec(r, &b)} # Fallback
               end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roda
 version: !ruby/object:Gem::Version
-  version: 3.71.0
+  version: 3.72.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-14 00:00:00.000000000 Z
+date: 2023-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -245,6 +245,7 @@ extra_rdoc_files:
 - doc/release_notes/3.7.0.txt
 - doc/release_notes/3.70.0.txt
 - doc/release_notes/3.71.0.txt
+- doc/release_notes/3.72.0.txt
 - doc/release_notes/3.8.0.txt
 - doc/release_notes/3.9.0.txt
 files:
@@ -323,6 +324,7 @@ files:
 - doc/release_notes/3.7.0.txt
 - doc/release_notes/3.70.0.txt
 - doc/release_notes/3.71.0.txt
+- doc/release_notes/3.72.0.txt
 - doc/release_notes/3.8.0.txt
 - doc/release_notes/3.9.0.txt
 - lib/roda.rb
@@ -386,6 +388,7 @@ files:
 - lib/roda/plugins/host_authorization.rb
 - lib/roda/plugins/indifferent_params.rb
 - lib/roda/plugins/inject_erb.rb
+- lib/roda/plugins/invalid_request_body.rb
 - lib/roda/plugins/json.rb
 - lib/roda/plugins/json_parser.rb
 - lib/roda/plugins/link_to.rb