roda 3.64.0 → 3.65.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 715e94da6acab0fa1c5e8409051f3faf0800ca56874d8640fa8f00c2ac432322
-  data.tar.gz: 79d9f75da1af54c8288918f722dff874433c7935a996180311344a24acc751ec
+  metadata.gz: d1c9c4301b4c90cb2f2c7a2d190986b4b6c68c4e1eb4b0be59bdba2aebdf6780
+  data.tar.gz: 576b15ba70cdab634638bce683ba8ee8ac93feb9fe5f3ae8982cf6ae07c6d686
 SHA512:
-  metadata.gz: 507d5395d337ae4e6c13a3ace905a605ecad5690bf8ceabd8d40bf3c9e2b162649a2a6cb79d1422c8c560396f4abdf891d8f3543b9866cd4f20e944acb4b6347
-  data.tar.gz: 37cdd77e3b2894ca55370d638e411e3bf10005101d83939a970b242a4750aa2df929994343c20546cdd6046553897e4d7cde19788f10c2406eb5b446d31e97d5
+  metadata.gz: 91b24c2bbcb2d2c27c14f242d620fab9d5e838f68bc102887018e41e4e05f5eb93718ab312c727a32ac4ab6df0dbcf4d0bb134499674dee71e991e953ecac85b
+  data.tar.gz: 9fe4592c67425c171926368d1121841dcafae686eb6822439536c24040788049041f34dffae22fde1ba2905f63c0e3abd13a5938ea263f4b143fdb94219e66f1

data/CHANGELOG

@@ -1,3 +1,11 @@
+= 3.65.0 (2023-02-13)
+
+* Make indifferent_params plugin work with changes in rack main branch (jeremyevans)
+
+* Add autoload_named_routes plugin for autoloading file for a named route when there is a request for that route (jeremyevans)
+
+* Make path method in path plugin accept class name string/symbol with :class_name option to register classes without forcing autoloads (jeremyevans)
+
 = 3.64.0 (2023-01-12)
 
 * Automatically expand paths for autoload_hash_branches files, so that relative paths work (jeremyevans)

data/doc/release_notes/3.65.0.txt

@@ -0,0 +1,12 @@
+= New Features
+
+* An autoload_named_routes plugin has been added for autoloading files
+  for a named route setup by the named_routes plugin when there is a
+  request for that route.
+
+= Other Improvements
+
+* The path method in the path plugin now supports a :class_name option.
+  You can set this option to true and use a class name String/Symbol
+  to register paths for classes without referencing the related class,
+  useful when autoloading the class.

data/lib/roda/plugins/autoload_named_routes.rb

@@ -0,0 +1,65 @@
+# frozen-string-literal: true
+
+#
+class Roda
+  module RodaPlugins
+    # The autoload_named_routes plugin builds on the named_routes plugin and allows for
+    # delaying loading of a file containing a named route for an application until there
+    # is a request that uses the named route. This can be useful in development
+    # to improvement startup time by not loading all named routes up front.  It can also be
+    # useful in testing subsets of an application by only loading the named routes being
+    # tested.
+    #
+    # You can specify a single hash branch for autoloading:
+    #
+    #   plugin :autoload_named_route
+    #   autoload_named_route(:route_name, '/absolute/path/to/file')
+    #   autoload_named_route(:namespace, :route_name, 'relative/path/to/file')
+    #
+    # Note that unlike the +route+ method defined by the named_routes plugin, when providing
+    # a namespace, the namespace comes before the route name and not after.
+    #
+    # When the autoloaded file is required, it should redefine the same
+    # named route.  If it does not, requests to the named route will be ignored (as if the
+    # related named route block was empty).
+    #
+    # When freezing an application, all named routes are automatically loaded, because
+    # autoloading named routes does not work for frozen applications.
+    module AutoloadNamedRoutes
+      def self.load_dependencies(app)
+        app.plugin :named_routes
+      end
+
+      def self.configure(app)
+        app.opts[:autoload_named_route_files] ||= []
+      end
+
+      module ClassMethods
+        # Autoload the given file when there is request for the named route.
+        # The given file should configure the named route specified.
+        def autoload_named_route(namespace=nil, name, file)
+          file = File.expand_path(file)
+          opts[:autoload_named_route_files] << file
+          routes = opts[:namespaced_routes][namespace] ||= {}
+          meth = routes[name] = define_roda_method(routes[name] || "named_routes_#{namespace}_#{name}", 1) do |r|
+            loc = method(routes[name]).source_location
+            require file
+            # Avoid infinite loop in case method is not overridden
+            if method(meth).source_location != loc
+              send(meth, r)
+            end
+          end
+          nil
+        end
+
+        # Eagerly load all autoloaded named routes when freezing the application.
+        def freeze
+          opts.delete(:autoload_named_route_files).each{|file| require file}
+          super
+        end
+      end
+    end
+
+    register_plugin(:autoload_named_routes, AutoloadNamedRoutes)
+  end
+end

data/lib/roda/plugins/indifferent_params.rb

@@ -53,9 +53,18 @@ class Roda
           
           class Params < Rack::QueryParser::Params
             if Rack.release >= '3'
-              def initialize
-                @size   = 0
-                @params = Hash.new(&INDIFFERENT_PROC)
+              # rack main branch compatibility
+              # :nocov:
+              if Params < Hash
+                def initialize
+                  super(&INDIFFERENT_PROC)
+                end
+              # :nocov:
+              else
+                def initialize
+                  @size   = 0
+                  @params = Hash.new(&INDIFFERENT_PROC)
+                end
               end
             else
               def initialize(limit = Rack::Utils.key_space_limit)

data/lib/roda/plugins/path.rb

@@ -26,6 +26,9 @@ class Roda
     #   path Quux do |quux, path|
     #     "/quux/#{quux.id}/#{path}"
     #   end
+    #   path 'FooBar', class_name: true do |foobar|
+    #     "/foobar/#{foobar.id}"
+    #   end
     #
     #   route do |r|
     #     r.post 'foo' do
@@ -65,9 +68,18 @@ class Roda
     #
     # Note that if :add_script_name, :relative, :url, or :url_only is used, the path method will also create a
     # <tt>_*_path</tt> private method.
+    #
+    # If the path class method is passed a string or symbol as the first argument, and the second argument
+    # is a hash with the :class_name option passed, the symbol/string is treated as a class name.
+    # This enables the use of class-based paths without forcing autoloads for the related
+    # classes.  If the plugin is not registering classes by name, this will use the symbol or
+    # string to find the related class.
     module Path
       DEFAULT_PORTS = {'http' => 80, 'https' => 443}.freeze
 
+      # Regexp for valid constant names, to prevent code execution.
+      VALID_CONSTANT_NAME_REGEXP = /\A(?:::)?([A-Z]\w*(?:::[A-Z]\w*)*)\z/.freeze
+
       # Initialize the path classes when loading the plugin. Options:
       # :by_name :: Register classes by name, which is friendlier when reloading code (defaults to
       #             true in development mode)
@@ -97,11 +109,20 @@ class Roda
 
         # Create a new instance method for the named path.  See plugin module documentation for options.
         def path(name, path=nil, opts=OPTS, &block)
-          if name.is_a?(Class)
-            raise RodaError, "can't provide path or options when calling path with a class" unless path.nil? && opts.empty?
+          if name.is_a?(Class) || (path.is_a?(Hash) && (class_name = path[:class_name]))
+            raise RodaError, "can't provide path when calling path with a class" if path && !class_name
+            raise RodaError, "can't provide options when calling path with a class" unless opts.empty?
             raise RodaError, "must provide a block when calling path with a class" unless block
             if self.opts[:path_class_by_name]
-              name = name.name
+              if class_name
+                name = name.to_s
+              else
+                name = name.name
+              end
+            elsif class_name
+              name = name.to_s
+              raise RodaError, "invalid class name passed when using class_name option" unless VALID_CONSTANT_NAME_REGEXP =~ name
+              name = Object.class_eval(name, __FILE__, __LINE__)
             end
             path_classes[name] = block
             self.opts[:path_class_methods][name] = define_roda_method("path_#{name}", :any, &block)

data/lib/roda/version.rb

@@ -4,7 +4,7 @@ class Roda
   RodaMajorVersion = 3
 
   # The minor version of Roda, updated for new feature releases of Roda.
-  RodaMinorVersion = 64
+  RodaMinorVersion = 65
 
   # The patch version of Roda, updated only for bug fixes from the last
   # feature release.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roda
 version: !ruby/object:Gem::Version
-  version: 3.64.0
+  version: 3.65.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-12 00:00:00.000000000 Z
+date: 2023-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -237,6 +237,7 @@ extra_rdoc_files:
 - doc/release_notes/3.62.0.txt
 - doc/release_notes/3.63.0.txt
 - doc/release_notes/3.64.0.txt
+- doc/release_notes/3.65.0.txt
 - doc/release_notes/3.7.0.txt
 - doc/release_notes/3.8.0.txt
 - doc/release_notes/3.9.0.txt
@@ -308,6 +309,7 @@ files:
 - doc/release_notes/3.62.0.txt
 - doc/release_notes/3.63.0.txt
 - doc/release_notes/3.64.0.txt
+- doc/release_notes/3.65.0.txt
 - doc/release_notes/3.7.0.txt
 - doc/release_notes/3.8.0.txt
 - doc/release_notes/3.9.0.txt
@@ -325,6 +327,7 @@ files:
 - lib/roda/plugins/assets.rb
 - lib/roda/plugins/assets_preloading.rb
 - lib/roda/plugins/autoload_hash_branches.rb
+- lib/roda/plugins/autoload_named_routes.rb
 - lib/roda/plugins/backtracking_array.rb
 - lib/roda/plugins/branch_locals.rb
 - lib/roda/plugins/caching.rb
@@ -463,7 +466,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: Routing tree web toolkit