roda 3.37.0 → 3.38.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de8c769572875e477058b48557b22861b9de731fa3b00b20a3022a67c929609d
-  data.tar.gz: 5cacc0d7b988bd3dc5bafbc30fcac145f6f67ddcc0e7809e1fc9cd60d8a16273
+  metadata.gz: 5b28900f838d40c98d868225a5d2f0e1fcfd24ccf0bdbf770f0ccb79ac2ba2fe
+  data.tar.gz: 8f2c37b04485af74a1e8c2c68f5eeb31b0531d82b4f55c6df4145cfe344cf86f
 SHA512:
-  metadata.gz: 1bf7df28d82f31820cd19c29b5a3f0f3afbbae2c41cf05974b16698c7ffb1725e924491874ddbb3f355a88990d4aab6d5b5b38f2d9c7612a548bfe0e3701ac2e
-  data.tar.gz: 32fca636d6324d29958cbcdf5c949c413eaeda7b74a701032d5766a60ec6b3f2db7ec262268dac697c3b3f5f9b183e127ddf265c7ba5015578969bc7f8be02a2
+  metadata.gz: e2cb67bbc5509acba608530dc8641059cb4aa450f8cf0bdca82f57dabba48c751a50e770f902b0ed64da63d2988c89884e074991a49956d03188ea8efaab7793
+  data.tar.gz: 66a2ad67a5f4abd5e275f77eddde74f4dd6430c222cf208d9aafc01577fbfae548367f8b71864834cb4067ae530ece68df66165c4352bfc151b35bee8c5e2041

data/CHANGELOG

@@ -1,3 +1,7 @@
+= 3.38.0 (2020-11-16)
+
+* Make error_email and error_mail plugins rescue invalid parameter errors when preparing the email body (jeremyevans)
+
 = 3.37.0 (2020-10-16)
 
 * Add custom_matchers plugin, for supporting arbitrary objects as matchers (jeremyevans)

data/doc/release_notes/3.38.0.txt

@@ -0,0 +1,5 @@
+= Improvements
+
+* The error_email and error_mail plugins now rescue invalid parameter
+  errors when preparing the email body, because you generally don't
+  want your error handler to raise an exception.

data/lib/roda/plugins/error_email.rb

@@ -54,6 +54,13 @@ class Roda
         :body=>lambda do |s, e|
           format = lambda{|h| h.map{|k, v| "#{k.inspect} => #{v.inspect}"}.sort.join("\n")}
 
+          begin
+            params = s.request.params
+            params = (format[params] unless params.empty?)
+          rescue
+            params = 'Invalid Parameters!'
+          end
+
           message = String.new
           message << <<END
 Path: #{s.request.path}
@@ -73,12 +80,12 @@ ENV:
 #{format[s.env]}
 END
 
-          unless s.request.params.empty?
+          if params
             message << <<END
 
 Params:
 
-#{format[s.request.params]}
+#{params}
 END
           end
 

data/lib/roda/plugins/error_mail.rb

@@ -71,6 +71,13 @@ class Roda
 
           format = lambda{|h| h.map{|k, v| "#{k.inspect} => #{v.inspect}"}.sort.join("\n")}
 
+          begin
+            params = request.params
+            params = (format[params] unless params.empty?)
+          rescue
+            params = 'Invalid Parameters!'
+          end
+
           message = String.new
           message << <<END
 Path: #{request.path}
@@ -91,12 +98,12 @@ ENV:
 #{format[env]}
 END
 
-          unless request.params.empty?
+          if params
             message << <<END
 
 Params:
 
-#{format[request.params]}
+#{params}
 END
           end
 

data/lib/roda/version.rb

@@ -4,7 +4,7 @@ class Roda
   RodaMajorVersion = 3
 
   # The minor version of Roda, updated for new feature releases of Roda.
-  RodaMinorVersion = 37
+  RodaMinorVersion = 38
 
   # The patch version of Roda, updated only for bug fixes from the last
   # feature release.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roda
 version: !ruby/object:Gem::Version
-  version: 3.37.0
+  version: 3.38.0
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-16 00:00:00.000000000 Z
+date: 2020-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -213,6 +213,7 @@ extra_rdoc_files:
 - doc/release_notes/3.35.0.txt
 - doc/release_notes/3.36.0.txt
 - doc/release_notes/3.37.0.txt
+- doc/release_notes/3.38.0.txt
 files:
 - CHANGELOG
 - MIT-LICENSE
@@ -251,6 +252,7 @@ files:
 - doc/release_notes/3.35.0.txt
 - doc/release_notes/3.36.0.txt
 - doc/release_notes/3.37.0.txt
+- doc/release_notes/3.38.0.txt
 - doc/release_notes/3.4.0.txt
 - doc/release_notes/3.5.0.txt
 - doc/release_notes/3.6.0.txt