roda-live_reload 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f8faae85a0ba898de7ce83d5b905570d07ecaa4
-  data.tar.gz: b83c72c1b71e96d5e15565efafbbcc1e90398993
+  metadata.gz: 6367cdd275c3f632b6c937cfbc7d7d58010c77cb
+  data.tar.gz: 7f72d32b0be9a90cb99541459b961ea683f1a011
 SHA512:
-  metadata.gz: ded2a543fc75e3ceab786041e7dce1761e7f3516f563169d858fc2b56541c098e650d11a55746302428e9e6f63c2fb4851e605f8980bcb33729e1299d1e04a9c
-  data.tar.gz: b13e1dd71c80ed0b84a3fafbf5ce8f07ceadc4c299e8d27e96f0cb16a511850cf602593064724149176eb7b97f22b5b02eb2f32b2b325f7816ac02cf814ea76b
+  metadata.gz: 547ea080239703245875cd61f518887c115c8b6b3a0fdfd1602dd15869e9c723004590a1004256f28cc0e51ac96d8a6ac62e3e800fa88d5777c358fa24433c2a
+  data.tar.gz: bec1dd5b716392ec227559739d810f9fa2a9e6ac26594a22f961c9831aaa477dd6036068f6e0e6e9f6d46752585f41344b234563b8ac62a122608c4f031ba599

data/README.md

@@ -38,6 +38,13 @@ class App < Roda
 end
 ```
 
+## Caveats
+
+Live Reloading mechanism may not work with Webrick. Tested with Puma.
+
+A new SIGINT trap is set per request, possibly bulldozing any previously set SIGINT.
+This may not be an issue for most, but it's something to be aware of.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/adam12/roda-live_reload.

data/lib/roda/plugins/live_reload.rb

@@ -26,7 +26,14 @@ module Roda::RodaPlugins # :nodoc:
 
           xhr.open("GET", "/_live_reload", true);
 
-          xhr.onprogress = function() {
+          xhr.onprogress = function(e) {
+            /* Try to prevent memory leak */
+            if (e.loaded > 1000) {
+              window.location.reload();
+            }
+          };
+
+          xhr.onload = function(e) {
             window.location.reload();
           };
 
@@ -35,10 +42,9 @@ module Roda::RodaPlugins # :nodoc:
             setTimeout(reconnect, 1000);
           };
 
-          xhr.onabort = function() {
-            console.log("Reconnecting after abort");
-            setTimeout(reconnect, 1000);
-          };
+          window.addEventListener("beforeunload", function(e) {
+            xhr.abort();
+          }, true);
 
           xhr.send();
         })();
@@ -66,14 +72,26 @@ module Roda::RodaPlugins # :nodoc:
       # Setup the live reload endpoint
       def live_reload(opts = {}, &block)
         on("_live_reload") do
+          logger.info "Live Reload listener attached" if logger
           reader, writer = IO.pipe
 
           LiveReload.synchronize do
             LiveReload.listeners.push(writer)
           end
 
+          # I wish Rack would provide a shutdown indicator
+          trap(:INT) { exit }
+
           scope.stream(loop: true) do |out|
-            out << reader.gets
+            if IO.select([reader], nil, nil, 1)
+              out.close
+            else
+              out << 0
+            end
+          end
+
+          LiveReload.synchronize do
+            LiveReload.listeners.delete(writer)
           end
         end
       end
@@ -104,7 +122,13 @@ module Roda::RodaPlugins # :nodoc:
         puts "Changes", modified, added, removed
 
         LiveReload.listeners.each do |writer|
-          writer.puts "Changes"
+          begin
+            writer << 1
+          rescue Errno::EPIPE
+            LiveReload.synchronize do
+              LiveReload.listeners.delete(writer)
+            end
+          end
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: roda-live_reload
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Adam Daniels
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-16 00:00:00.000000000 Z
+date: 2017-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roda
@@ -86,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Live reloading for Roda