rocketjob_mission_control 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 841a844611078eb6e374b46c7da8026adb5e1af4
-  data.tar.gz: 810b1f18daf8ebf333a5cace7771f97294aaaee9
+  metadata.gz: 95c31dad97c24947bcd03965186d8e2e3a18d9e6
+  data.tar.gz: '064995269a737889937e84659e86160d8b0a7c26'
 SHA512:
-  metadata.gz: 53d73b5170970540fb19bc514cb319b3f3924799f5a0fec97f1d4a0a83da57d93b97d53197f7ea3fc544e9fcc4ad7102bd5c461d42eab8215b1536ff7bfe3d9b
-  data.tar.gz: 9c869b611740289e4fc9743bd80980e297d72324cca4c0cb4dc578bfcd3cfc5cd0c26f0c6d7a9492d390977938ac98f5d69edcda64e909b83bbbbfa9aa976828
+  metadata.gz: 0a5a5b0ce3cae2cd1964deef79a70f2d35fabe7348e4e8f01e86fe22059d0c2dad02ffd82a32bd4442cbce9d2b149b62d088b4851393d818225030ec72bdfe4d
+  data.tar.gz: 4fda4abf731c3c5487d7bcf2601d4b528d2ff6f887a91cb9ce059860f0802ae617ffcde72f0ec07f605ede8e6326c1cd3015f8a78e50c3e58ed3675d54f3fbb2

data/Rakefile

@@ -1,3 +1,7 @@
+# Setup bundler to avoid having to run bundle exec all the time.
+require 'rubygems'
+require 'bundler/setup'
+
 APP_RAKEFILE = File.expand_path('../rjmc/Rakefile', __FILE__)
 load 'rails/tasks/engine.rake'
 
@@ -21,4 +25,10 @@ Rake::TestTask.new(:test) do |t|
   t.warning = false
 end
 
-task default: :test
+# By default run tests against all appraisals
+if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
+  require 'appraisal'
+  task default: 'app:appraisal'
+else
+  task default: :test
+end

data/app/assets/javascripts/rocket_job_mission_control/base.js

@@ -1,12 +1,16 @@
-$(document).ready(() => toggleCanvas());
+'use strict';
 
-var toggleCanvas = () =>
-  $('[data-toggle=offcanvas]').click(function () {
+$(document).ready(function () {
+  return toggleCanvas();
+});
+
+var toggleCanvas = function toggleCanvas() {
+  return $('[data-toggle=offcanvas]').click(function () {
     $(this).toggleClass('visible-xs text-center');
     $(this).find('i').toggleClass('fa-chevron-right fa-chevron-left');
     $('.row-offcanvas').toggleClass('active');
     $('#lg-menu').toggleClass('hidden-xs').toggleClass('visible-xs');
     $('#xs-menu').toggleClass('visible-xs').toggleClass('hidden-xs');
     return $('#btnShow').toggle();
-  })
-;
+  });
+};

data/app/assets/javascripts/rocket_job_mission_control/datatable.js

@@ -1,40 +1,79 @@
-var RjmcDatatable = class RjmcDatatable {
-  constructor(table, columns, opts) {
+'use strict';
+
+var _createClass = function () {
+  function defineProperties(target, props) {
+    for (var i = 0; i < props.length; i++) {
+      var descriptor          = props[i];
+      descriptor.enumerable   = descriptor.enumerable || false;
+      descriptor.configurable = true;
+      if ("value" in descriptor) descriptor.writable = true;
+      Object.defineProperty(target, descriptor.key, descriptor);
+    }
+  }
+
+  return function (Constructor, protoProps, staticProps) {
+    if (protoProps) defineProperties(Constructor.prototype, protoProps);
+    if (staticProps) defineProperties(Constructor, staticProps);
+    return Constructor;
+  };
+}();
+
+function _classCallCheck(instance, Constructor) {
+  if (!(instance instanceof Constructor)) {
+    throw new TypeError("Cannot call a class as a function");
+  }
+}
+
+var RjmcDatatable = function () {
+  function RjmcDatatable(table, columns, opts) {
+    _classCallCheck(this, RjmcDatatable);
+
     this.reloadTable = this.reloadTable.bind(this);
-    if (opts == null) { opts = {}; }
-    this.table = $(table);
-    this.columns = columns;
-    this.ordering = opts.ordering != null ? opts.ordering : true;
-    this.searching = opts.searching != null ? opts.searching : true;
+    if (opts == null) {
+      opts = {};
+    }
+    this.table      = $(table);
+    this.columns    = columns;
+    this.ordering   = opts.ordering != null ? opts.ordering : true;
+    this.searching  = opts.searching != null ? opts.searching : true;
     this.pageLength = opts.pageLength != null ? opts.pageLength : 100;
-    this.order = opts.order != null ? opts.order : [];
-    this.reload = $("[data-behavior='reload']");
+    this.order      = opts.order != null ? opts.order : [];
+    this.reload     = $("[data-behavior='reload']");
     this.initializeTable();
     this.setEvents();
   }
 
-  initializeTable() {
-    return this.data = this.table.DataTable({
-      pagingType: 'full_numbers',
-      pageLength: this.pageLength,
-      responsive: true,
-      ajax: this.table.data('source'),
-      processing: true,
-      serverSide: true,
-      columns: this.columns,
-      ordering: this.ordering,
-      searching: this.searching,
-      order: this.order
-    });
-  }
+  _createClass(RjmcDatatable, [{
+    key:   'initializeTable',
+    value: function initializeTable() {
+      return this.data = this.table.DataTable({
+        pagingType: 'full_numbers',
+        pageLength: this.pageLength,
+        responsive: true,
+        ajax:       this.table.data('source'),
+        processing: true,
+        serverSide: true,
+        columns:    this.columns,
+        ordering:   this.ordering,
+        searching:  this.searching,
+        order:      this.order
+      });
+    }
+  }, {
+    key:   'setEvents',
+    value: function setEvents() {
+      return this.reload.on('click', this.reloadTable);
+    }
+  }, {
+    key:   'reloadTable',
+    value: function reloadTable() {
+      var icon = this.reload.find('i');
+      icon.addClass('fa-spin');
+      return this.data.ajax.reload(function () {
+        return icon.removeClass('fa-spin');
+      });
+    }
+  }]);
 
-  setEvents() {
-    return this.reload.on('click', this.reloadTable);
-  }
-
-  reloadTable() {
-    let icon = this.reload.find('i');
-    icon.addClass('fa-spin');
-    return this.data.ajax.reload(() => icon.removeClass('fa-spin'));
-  }
-};
+  return RjmcDatatable;
+}();

data/app/assets/javascripts/rocket_job_mission_control/dirmon_entries.js

@@ -1,15 +1,19 @@
-$(document).on('ready', function() {
-  $('.filter .state-toggle').on('change', function() {
-    let active_states = $('.filter :checked');
-    let param_string = "?";
-    active_states.each((_, state) => param_string += `states[]=${$(state).attr('id')}&`);
-    return window.location.href = window.location.href.replace( /[\?#].*|$/, param_string );
+'use strict';
+
+$(document).on('ready', function () {
+  $('.filter .state-toggle').on('change', function () {
+    var active_states = $('.filter :checked');
+    var param_string  = "?";
+    active_states.each(function (_, state) {
+      return param_string += 'states[]=' + $(state).attr('id') + '&';
+    });
+    return window.location.href = window.location.href.replace(/[\?#].*|$/, param_string);
   });
 
   if ($('#properties').length) {
-    return $('#properties').on('click', function() {
-      let params = $('#new_rocket_job_dirmon_entry').serialize();
-      let new_dirmon_path = $('#properties').data('url') + `?${params}`;
+    return $('#properties').on('click', function () {
+      var params          = $('#new_rocket_job_dirmon_entry').serialize();
+      var new_dirmon_path = $('#properties').data('url') + ('?' + params);
       return window.location = new_dirmon_path;
     });
   }

data/app/assets/javascripts/rocket_job_mission_control/selectize.js

@@ -1,6 +1,8 @@
-$(document).on('ready', () =>
-  $('select.selectize').selectize({
+'use strict';
+
+$(document).on('ready', function () {
+  return $('select.selectize').selectize({
     create:       true,
     hideSelected: true
-  })
-);
+  });
+});

data/lib/rocket_job_mission_control/version.rb

@@ -1,3 +1,3 @@
 module RocketJobMissionControl
-  VERSION = '3.0.0'
+  VERSION = '3.0.1'
 end

data/test/controllers/rocket_job_mission_control/application_controller_test.rb

@@ -5,43 +5,36 @@ module RocketJobMissionControl
     def index
       @time_zone = Time.zone
 
-      render text: 'Time Zoned'
+      render plain: 'Time Zoned'
     end
   end
 
   class ApplicationControllerTest < ActionController::TestCase
     describe TestController do
       describe '#with_time_zone' do
-        let(:session_params) { {} }
-        let(:expected_time_zone) { 'UTC' }
-
-        before do
-          get :index, {}, session_params
-        end
-
-        describe 'with a session present' do
-          describe 'that contains a time zone' do
-            let(:expected_time_zone) { 'America/Los_Angeles' }
-            let(:session_params) { {'time_zone' => expected_time_zone} }
-
-            it 'sets the time zone correctly' do
-              assert_equal expected_time_zone, assigns(:time_zone).name
-            end
+        it 'uses correct timezone with session and time_zone set' do
+          if Rails.version.to_i >= 5
+            session['time_zone'] = 'America/Los_Angeles'
+            get :index
+          else
+            get :index, {}, {'time_zone' => 'America/Los_Angeles'}
           end
+          assert_equal 'America/Los_Angeles', assigns(:time_zone).name
+        end
 
-          describe 'that does not contain a time zone' do
-            let(:session_params) { {'user_id' => '42'} }
-
-            it 'sets the time zone correctly' do
-              assert_equal expected_time_zone, assigns(:time_zone).name
-            end
+        it 'uses correct timezone with session, but no time_zone set' do
+          if Rails.version.to_i >= 5
+            session['user_id'] = '42'
+            get :index
+          else
+            get :index, {}, {'user_id' => '42'}
           end
+          assert_equal 'UTC', assigns(:time_zone).name
         end
 
-        describe 'with no session present' do
-          it 'sets the time zone correctly' do
-            assert_equal expected_time_zone, assigns(:time_zone).name
-          end
+        it 'uses correct timezone without a session' do
+          get :index
+          assert_equal 'UTC', assigns(:time_zone).name
         end
       end
     end

data/test/controllers/rocket_job_mission_control/dirmon_entries_controller_test.rb

@@ -37,7 +37,11 @@ module RocketJobMissionControl
       describe 'PATCH #enable' do
         describe 'when transition is allowed' do
           before do
-            patch :enable, id: existing_dirmon_entry.id
+            if Rails.version.to_i >= 5
+              patch :enable, params: {id: existing_dirmon_entry.id}
+            else
+              patch :enable, id: existing_dirmon_entry.id
+            end
           end
 
           it do
@@ -52,7 +56,11 @@ module RocketJobMissionControl
         describe 'when transition is not allowed' do
           before do
             existing_dirmon_entry.enable!
-            patch :enable, id: existing_dirmon_entry.id
+            if Rails.version.to_i >= 5
+              patch :enable, params: {id: existing_dirmon_entry.id}
+            else
+              patch :enable, id: existing_dirmon_entry.id
+            end
           end
 
           it 'succeeds' do
@@ -69,7 +77,11 @@ module RocketJobMissionControl
         describe 'when transition is allowed' do
           before do
             existing_dirmon_entry.enable!
-            patch :disable, id: existing_dirmon_entry.id
+            if Rails.version.to_i >= 5
+              patch :disable, params: {id: existing_dirmon_entry.id}
+            else
+              patch :disable, id: existing_dirmon_entry.id
+            end
           end
 
           it do
@@ -83,7 +95,11 @@ module RocketJobMissionControl
 
         describe 'when transition is not allowed' do
           before do
-            patch :disable, id: existing_dirmon_entry.id
+            if Rails.version.to_i >= 5
+              patch :disable, params: {id: existing_dirmon_entry.id}
+            else
+              patch :disable, id: existing_dirmon_entry.id
+            end
           end
 
           it 'succeeds' do
@@ -100,7 +116,11 @@ module RocketJobMissionControl
         let(:entry_params) { {} }
 
         before do
-          get :new, entry_params
+          if Rails.version.to_i >= 5
+            get :new, params: entry_params
+          else
+            get :new, entry_params
+          end
         end
 
         it 'succeeds' do
@@ -153,7 +173,11 @@ module RocketJobMissionControl
       describe 'PATCH #update' do
         describe 'with valid parameters' do
           before do
-            patch :update, id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {pattern: 'the_path2', job_class_name: job_class_name}
+            if Rails.version.to_i >= 5
+              patch :update, params: {id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {pattern: 'the_path2', job_class_name: job_class_name}}
+            else
+              patch :update, id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {pattern: 'the_path2', job_class_name: job_class_name}
+            end
           end
 
           it 'redirects to the updated entry' do
@@ -168,7 +192,11 @@ module RocketJobMissionControl
 
         describe 'with invalid parameters' do
           before do
-            patch :update, id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {job_class_name: 'FakeAndBadJob'}
+            if Rails.version.to_i >= 5
+              patch :update, params: {id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {job_class_name: 'FakeAndBadJob'}}
+            else
+              patch :update, id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {job_class_name: 'FakeAndBadJob'}
+            end
           end
 
           it 'renders the edit template' do
@@ -194,7 +222,11 @@ module RocketJobMissionControl
           end
 
           before do
-            post :create, rocket_job_dirmon_entry: dirmon_params
+            if Rails.version.to_i >= 5
+              post :create, params: {rocket_job_dirmon_entry: dirmon_params}
+            else
+              post :create, rocket_job_dirmon_entry: dirmon_params
+            end
           end
 
           it 'creates the entry' do
@@ -233,7 +265,11 @@ module RocketJobMissionControl
           end
 
           before do
-            post :create, rocket_job_dirmon_entry: dirmon_params
+            if Rails.version.to_i >= 5
+              post :create, params: {rocket_job_dirmon_entry: dirmon_params}
+            else
+              post :create, rocket_job_dirmon_entry: dirmon_params
+            end
           end
 
           describe 'on model attributes' do
@@ -251,7 +287,11 @@ module RocketJobMissionControl
 
       describe 'GET #edit' do
         before do
-          get :edit, id: existing_dirmon_entry.id
+          if Rails.version.to_i >= 5
+            get :edit, params: {id: existing_dirmon_entry.id}
+          else
+            get :edit, id: existing_dirmon_entry.id
+          end
         end
 
         it 'succeeds' do
@@ -266,7 +306,11 @@ module RocketJobMissionControl
       describe 'GET #show' do
         describe 'with an invalid id' do
           before do
-            get :show, id: 42
+            if Rails.version.to_i >= 5
+              get :show, params: {id: 42}
+            else
+              get :show, id: 42
+            end
           end
 
           it 'redirects' do
@@ -280,7 +324,11 @@ module RocketJobMissionControl
 
         describe 'with a valid id' do
           before do
-            get :show, id: existing_dirmon_entry.id
+            if Rails.version.to_i >= 5
+              get :show, params: {id: existing_dirmon_entry.id}
+            else
+              get :show, id: existing_dirmon_entry.id
+            end
           end
 
           it 'succeeds' do
@@ -295,7 +343,13 @@ module RocketJobMissionControl
 
       describe 'DELETE #destroy' do
         describe 'with a valid id' do
-          before { delete :destroy, id: existing_dirmon_entry.id }
+          before do
+            if Rails.version.to_i >= 5
+              delete :destroy, params: {id: existing_dirmon_entry.id}
+            else
+              delete :destroy, id: existing_dirmon_entry.id
+            end
+          end
 
           it 'redirects to index' do
             assert_redirected_to dirmon_entries_path

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rocketjob_mission_control
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Michael Cloutier
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-02 00:00:00.000000000 Z
+date: 2017-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails