rocketjob_mission_control 3.0.0.rc1 → 3.0.0

data/app/views/rocket_job_mission_control/servers/index.html.erb

@@ -0,0 +1,56 @@
+<div id='servers'>
+  <div class='server-list'>
+    <div class='list'>
+      <div class='row'>
+        <div class='col-md-6'>
+          <h2><%= @description %> Servers</h2>
+        </div>
+        <div class='col-md-6'>
+          <div class='col-sm-10'>
+            <div class='server-collection-actions'>
+              <ol>
+                <div class='btn-group'>
+                  <% Array(@actions).each do |action| %>
+                    <%= link_to(
+                            "#{action.to_s.humanize.capitalize}",
+                            rocket_job_mission_control.update_all_servers_path(server_action: action),
+                            method: :patch,
+                            data:   {confirm: t(:confirm, scope: [:server, :update_all], action: action.to_s.singularize.humanize.downcase)},
+                            class:  'btn btn-default')
+                    %>
+                  <% end %>
+                </div>
+              </ol>
+            </div>
+          </div>
+          <div class='col-sm-2 pull-right'>
+            <div class='btn btn-default pull-right dt-reload' data-behavior='reload'>
+              <i class='fa fa-refresh'></i>
+            </div>
+          </div>
+        </div>
+      </div>
+      <table class='table datatable servers-datatable' data-source='<%= @data_table_url %>' style='width: 100%'>
+        <thead>
+        <tr>
+          <th>Hostname : PID</th>
+          <th>Workers (Current/Max)</th>
+          <th>Started</th>
+          <th>Heartbeat</th>
+          <th>Actions</th>
+        </tr>
+        </thead>
+        <tbody></tbody>
+      </table>
+    </div>
+  </div>
+</div>
+
+<script>
+  jQuery(function () {
+    new RjmcDatatable(
+      $('.servers-datatable'),
+      [{data: '0'}, {data: '1'}, {data: '2'}, {data: '3'}, {data: '4', orderable: false}]
+    );
+  });
+</script>

data/config/locales/en.yml

@@ -37,20 +37,18 @@ en:
         one:   "1 year" # default was: "almost 1 year"
         other: "%{count} years" # default was: "almost %{count} years"
   server:
+    find:
+      failure: "Could not find server with id: %{id}!"
     stop:
-      success: "Server successfully stopped."
       failure: "Error attempting to stop server."
     destroy:
-      success: "Server successfully destroyed."
+      success: "Server successfully destroyed. All jobs running on this server have been re-queued for processing on other servers."
       failure: "Error attempting to destroy server."
     pause:
-      success: "Server successfully paused."
       failure: "Error attempting to pause server."
     resume:
-      success: "Server successfully resumed."
       failure: "Error attempting to resume server."
     update_all:
-      success: "Servers have been %{server_action}."
       invalid: "Action not allowed."
       confirm: "Are you sure you want to %{action} servers?"
   job:
@@ -65,17 +63,12 @@ en:
     find:
       failure: "Could not find entry with id: %{id}!"
     create:
-      success: "Dirmon successfully created."
       failure: "Error attempting to create."
     destroy:
-      success: "Dirmon successfully destroyed."
       failure: "Error attempting to destroy Dirmon."
     enable:
-      success: "Dirmon successfully enabled."
       failure: "Error attempting to enable Dirmon."
     disable:
-      success: "Dirmon successfully disabled."
       failure: "Error attempting to disable Dirmon."
     update:
-      success: "Dirmon has been updated."
       invalid: "Error attempting to update Dirmon."

data/config/routes.rb

@@ -2,13 +2,13 @@ RocketJobMissionControl::Engine.routes.draw do
 
   resources :jobs, only: [:index, :show, :update, :destroy, :edit] do
     collection do
-      get :running,   to: 'jobs/index_filters#running'
-      get :scheduled, to: 'jobs/index_filters#scheduled'
-      get :completed, to: 'jobs/index_filters#completed'
-      get :queued,    to: 'jobs/index_filters#queued'
-      get :paused,    to: 'jobs/index_filters#paused'
-      get :failed,    to: 'jobs/index_filters#failed'
-      get :aborted,   to: 'jobs/index_filters#aborted'
+      get :running,   to: 'jobs#running'
+      get :scheduled, to: 'jobs#scheduled'
+      get :completed, to: 'jobs#completed'
+      get :queued,    to: 'jobs#queued'
+      get :paused,    to: 'jobs#paused'
+      get :failed,    to: 'jobs#failed'
+      get :aborted,   to: 'jobs#aborted'
     end
 
     member do
@@ -19,18 +19,19 @@ RocketJobMissionControl::Engine.routes.draw do
       patch :retry
       patch :run_now
       get   :exceptions
+      get   :exception
     end
-    resources :failures, controller: 'jobs/failures', only: :index
   end
 
   resources :active_workers, only: :index
 
   resources :servers, only: [:index, :destroy] do
     collection do
-      get :starting, to: 'servers/index_filters#starting'
-      get :running, to: 'servers/index_filters#running'
-      get :paused, to: 'servers/index_filters#paused'
-      get :stopping, to: 'servers/index_filters#stopping'
+      get :starting, to: 'servers#starting'
+      get :running,  to: 'servers#running'
+      get :paused,   to: 'servers#paused'
+      get :stopping, to: 'servers#stopping'
+      get :zombie,   to: 'servers#zombie'
     end
 
     member do
@@ -45,10 +46,10 @@ RocketJobMissionControl::Engine.routes.draw do
 
   resources :dirmon_entries do
     collection do
-      get :pending,   to: 'dirmon_entries/index_filters#pending'
-      get :enabled, to: 'dirmon_entries/index_filters#enabled'
-      get :failed, to: 'dirmon_entries/index_filters#failed'
-      get :disabled,    to: 'dirmon_entries/index_filters#disabled'
+      get :pending,  to: 'dirmon_entries#pending'
+      get :enabled,  to: 'dirmon_entries#enabled'
+      get :failed,   to: 'dirmon_entries#failed'
+      get :disabled, to: 'dirmon_entries#disabled'
     end
 
     member do
@@ -57,5 +58,7 @@ RocketJobMissionControl::Engine.routes.draw do
     end
   end
 
-  root to: "jobs/index_filters#running"
+  get 'rocket_job_mission_control/test' => 'test#index' if Rails.env.test?
+
+  root to: "jobs#running"
 end

data/lib/rocket_job_mission_control/engine.rb

@@ -2,6 +2,16 @@ module RocketJobMissionControl
   class Engine < ::Rails::Engine
     isolate_namespace RocketJobMissionControl
 
+    require 'rocketjob'
+    require 'jquery-rails'
+    require 'bootstrap-sass'
+    require 'sass-rails'
+    require 'jquery-datatables-rails'
+    begin
+      require 'rocketjob_pro'
+    rescue LoadError
+    end
+
     config.to_prepare do
       Rails.application.config.assets.precompile += %w(
         rocket_job_mission_control/rocket-icon-64x64.png

data/lib/rocket_job_mission_control/version.rb

@@ -1,3 +1,3 @@
 module RocketJobMissionControl
-  VERSION = '3.0.0.rc1'
+  VERSION = '3.0.0'
 end

data/test/compare_hashes.rb

@@ -0,0 +1,17 @@
+def compare_array_of_hashes(expected, actual)
+  expected.each_with_index do |expected_hash, index|
+    compare_hash(expected_hash, actual[index])
+  end
+end
+
+def compare_hash(expected_hash, actual_hash)
+  expected_hash.each_pair do |key, expected|
+    actual = actual_hash[key]
+    if expected.is_a?(Regexp)
+      assert_match expected, actual, "#{key} does not match. Expected #{expected.inspect}. Actual #{actual.inspect}"
+    else
+      assert_equal expected, actual, "#{key} not equal. Expected #{expected.inspect}. Actual #{actual.inspect}"
+    end
+  end
+end
+

data/test/controllers/rocket_job_mission_control/application_controller_test.rb

@@ -0,0 +1,49 @@
+require_relative '../../test_helper'
+
+module RocketJobMissionControl
+  class TestController < ApplicationController
+    def index
+      @time_zone = Time.zone
+
+      render text: 'Time Zoned'
+    end
+  end
+
+  class ApplicationControllerTest < ActionController::TestCase
+    describe TestController do
+      describe '#with_time_zone' do
+        let(:session_params) { {} }
+        let(:expected_time_zone) { 'UTC' }
+
+        before do
+          get :index, {}, session_params
+        end
+
+        describe 'with a session present' do
+          describe 'that contains a time zone' do
+            let(:expected_time_zone) { 'America/Los_Angeles' }
+            let(:session_params) { {'time_zone' => expected_time_zone} }
+
+            it 'sets the time zone correctly' do
+              assert_equal expected_time_zone, assigns(:time_zone).name
+            end
+          end
+
+          describe 'that does not contain a time zone' do
+            let(:session_params) { {'user_id' => '42'} }
+
+            it 'sets the time zone correctly' do
+              assert_equal expected_time_zone, assigns(:time_zone).name
+            end
+          end
+        end
+
+        describe 'with no session present' do
+          it 'sets the time zone correctly' do
+            assert_equal expected_time_zone, assigns(:time_zone).name
+          end
+        end
+      end
+    end
+  end
+end

data/test/controllers/rocket_job_mission_control/dirmon_entries_controller_test.rb

@@ -0,0 +1,417 @@
+require_relative '../../test_helper'
+require_relative '../../compare_hashes'
+
+module RocketJobMissionControl
+  class DirmonEntriesControllerTest < ActionController::TestCase
+
+    describe DirmonEntriesController do
+      before do
+        RocketJob::DirmonEntry.delete_all
+      end
+
+      let :job_class_name do
+        'RocketJob::Jobs::SimpleJob'
+      end
+
+      let :existing_dirmon_entry do
+        RocketJob::DirmonEntry.create!(
+          name:           'Test',
+          job_class_name: job_class_name,
+          pattern:        'the_path'
+        )
+      end
+
+      dirmon_entry_states = RocketJob::DirmonEntry.aasm.states.collect(&:name)
+
+      let :one_dirmon_entry_for_every_state do
+        dirmon_entry_states.collect do |state|
+          RocketJob::DirmonEntry.create!(
+            name:           'Test',
+            job_class_name: job_class_name,
+            pattern:        'the_path',
+            state:          state
+          )
+        end
+      end
+
+      describe 'PATCH #enable' do
+        describe 'when transition is allowed' do
+          before do
+            patch :enable, id: existing_dirmon_entry.id
+          end
+
+          it do
+            assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
+          end
+
+          it 'changes the state to enabled' do
+            assert existing_dirmon_entry.reload.enabled?
+          end
+        end
+
+        describe 'when transition is not allowed' do
+          before do
+            existing_dirmon_entry.enable!
+            patch :enable, id: existing_dirmon_entry.id
+          end
+
+          it 'succeeds' do
+            assert_response :success
+          end
+
+          it 'alerts the user' do
+            assert_equal I18n.t(:failure, scope: [:dirmon_entry, :enable]), flash[:alert]
+          end
+        end
+      end
+
+      describe 'PATCH #disable' do
+        describe 'when transition is allowed' do
+          before do
+            existing_dirmon_entry.enable!
+            patch :disable, id: existing_dirmon_entry.id
+          end
+
+          it do
+            assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
+          end
+
+          it 'changes the state to disabled' do
+            assert existing_dirmon_entry.reload.disabled?
+          end
+        end
+
+        describe 'when transition is not allowed' do
+          before do
+            patch :disable, id: existing_dirmon_entry.id
+          end
+
+          it 'succeeds' do
+            assert_response :success
+          end
+
+          it 'alerts the user' do
+            assert_equal I18n.t(:failure, scope: [:dirmon_entry, :disable]), flash[:alert]
+          end
+        end
+      end
+
+      describe 'GET #new' do
+        let(:entry_params) { {} }
+
+        before do
+          get :new, entry_params
+        end
+
+        it 'succeeds' do
+          assert_response :success
+        end
+
+        it 'assigns a new entry' do
+          assert assigns(:dirmon_entry).present?
+          refute assigns(:dirmon_entry).persisted?
+        end
+
+        describe 'with form params' do
+          let(:entry_params) { {rocket_job_dirmon_entry: {name: 'new entry'}} }
+
+          it 'succeeds' do
+            assert_response :success
+          end
+
+          it 'assigns the params to new entry' do
+            assert_equal 'new entry', assigns(:dirmon_entry).name
+          end
+
+          describe 'with a valid job_class_name' do
+            let(:entry_params) { {rocket_job_dirmon_entry: {job_class_name: 'NoParamsJob'}} }
+
+            it 'succeeds' do
+              assert_response :success
+            end
+
+            it 'assigns the job class' do
+              assert_equal 'NoParamsJob', assigns(:dirmon_entry).job_class_name
+            end
+          end
+
+          describe 'with an invalid job_class_name' do
+            let(:entry_params) { {rocket_job_dirmon_entry: {job_class_name: 'BadJob'}} }
+
+            it 'succeeds' do
+              assert_response :success
+            end
+
+            it 'adds an error' do
+              assert assigns(:dirmon_entry).errors[:job_class_name].present?
+            end
+          end
+        end
+
+      end
+
+      describe 'PATCH #update' do
+        describe 'with valid parameters' do
+          before do
+            patch :update, id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {pattern: 'the_path2', job_class_name: job_class_name}
+          end
+
+          it 'redirects to the updated entry' do
+            assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
+          end
+
+          it 'updates the entry' do
+            #follow_redirect!
+            #assert_equal 'the_path2', existing_dirmon_entry.reload.pattern
+          end
+        end
+
+        describe 'with invalid parameters' do
+          before do
+            patch :update, id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {job_class_name: 'FakeAndBadJob'}
+          end
+
+          it 'renders the edit template' do
+            assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
+          end
+
+          it 'alerts the user' do
+            #follow_redirect!
+            #assert_select 'div.message', "job_class_name: #{I18n.t(:failure, scope: [:dirmon_entry, :disable])}"
+          end
+        end
+      end
+
+      describe 'POST #create' do
+        describe 'with valid parameters' do
+          let(:dirmon_params) do
+            {
+              name:           'Test',
+              pattern:        '/files/*',
+              job_class_name: job_class_name,
+              properties:     {description: '', priority: '42'}
+            }
+          end
+
+          before do
+            post :create, rocket_job_dirmon_entry: dirmon_params
+          end
+
+          it 'creates the entry' do
+            assert assigns(:dirmon_entry).persisted?
+          end
+
+          it 'has no errors' do
+            assert assigns(:dirmon_entry).errors.messages.empty?
+          end
+
+          it 'redirects to created entry' do
+            assert_redirected_to dirmon_entry_path(assigns(:dirmon_entry))
+          end
+
+          it 'does not save blank properties' do
+            assert_nil assigns(:dirmon_entry).properties[:description]
+          end
+
+          it 'saves properties' do
+            assert_equal '42', assigns(:dirmon_entry).properties[:priority]
+          end
+
+          [:name, :pattern, :job_class_name].each do |attribute|
+            it "assigns the correct value for #{attribute}" do
+              assert_equal dirmon_params[attribute], assigns(:dirmon_entry)[attribute]
+            end
+          end
+        end
+
+        describe 'with invalid parameters' do
+          let(:dirmon_params) do
+            {
+              name:           'Test',
+              job_class_name: 'FakeAndBadJob'
+            }
+          end
+
+          before do
+            post :create, rocket_job_dirmon_entry: dirmon_params
+          end
+
+          describe 'on model attributes' do
+            it 'renders the new template' do
+              assert_response :success
+              assert_template :new
+            end
+
+            it 'has errors on the entry' do
+              refute assigns(:dirmon_entry).valid?
+            end
+          end
+        end
+      end
+
+      describe 'GET #edit' do
+        before do
+          get :edit, id: existing_dirmon_entry.id
+        end
+
+        it 'succeeds' do
+          assert_response :success
+        end
+
+        it 'assigns the entry' do
+          assert_equal existing_dirmon_entry, assigns(:dirmon_entry)
+        end
+      end
+
+      describe 'GET #show' do
+        describe 'with an invalid id' do
+          before do
+            get :show, id: 42
+          end
+
+          it 'redirects' do
+            assert_redirected_to dirmon_entries_path
+          end
+
+          it 'adds a flash alert message' do
+            assert_equal I18n.t(:failure, scope: [:dirmon_entry, :find], id: 42), flash[:alert]
+          end
+        end
+
+        describe 'with a valid id' do
+          before do
+            get :show, id: existing_dirmon_entry.id
+          end
+
+          it 'succeeds' do
+            assert_response :success
+          end
+
+          it 'assigns the entry' do
+            assert assigns(:dirmon_entry).present?
+          end
+        end
+      end
+
+      describe 'DELETE #destroy' do
+        describe 'with a valid id' do
+          before { delete :destroy, id: existing_dirmon_entry.id }
+
+          it 'redirects to index' do
+            assert_redirected_to dirmon_entries_path
+          end
+
+          it 'deletes the entry' do
+            refute RocketJob::DirmonEntry.where(id: existing_dirmon_entry.id).exists?
+          end
+        end
+      end
+
+      ([:index] + dirmon_entry_states).each do |state|
+        describe "GET ##{state}" do
+          describe 'html' do
+            describe "with no #{state} entries" do
+              before do
+                get state
+              end
+
+              it 'succeeds' do
+                assert_response :success
+              end
+
+              it 'renders template' do
+                assert_template :index
+              end
+            end
+
+            describe "with #{state} entries" do
+              before do
+                one_dirmon_entry_for_every_state
+                get state
+              end
+
+              it 'succeeds' do
+                assert_response :success
+              end
+
+              it 'renders template' do
+                assert_template :index
+              end
+            end
+          end
+
+          describe 'json' do
+            describe "with #{state} entries" do
+              before do
+                get state, format: :json
+              end
+
+              it 'succeeds' do
+                assert_response :success
+                json     = JSON.parse(response.body)
+                expected = {
+                  "data"            => [],
+                  "draw"            => 0,
+                  "recordsFiltered" => 0,
+                  "recordsTotal"    => 0
+                }
+                assert_equal expected, json
+              end
+            end
+
+            describe "with #{state} entries" do
+              before do
+                one_dirmon_entry_for_every_state
+                get state, format: :json
+              end
+
+              it 'succeeds' do
+                assert_response :success
+                json          = JSON.parse(response.body)
+                expected_data = {
+                  pending:  {
+                    "0"           => "        <a href=\"/dirmon_entries/#{RocketJob::DirmonEntry.pending.first.id}\">\n          <i class=\"fa fa-inbox pending\" style=\"font-size: 75%\" title=\"pending\"></i>\n          Test\n        </a>\n",
+                    "1"           => "RocketJob::Jobs::SimpleJob",
+                    "2"           => "the_path",
+                    "DT_RowClass" => "card callout callout-pending"
+                  },
+                  enabled:  {
+                    "0"           => "        <a href=\"/dirmon_entries/#{RocketJob::DirmonEntry.enabled.first.id}\">\n          <i class=\"fa fa-check enabled\" style=\"font-size: 75%\" title=\"enabled\"></i>\n          Test\n        </a>\n",
+                    "1"           => "RocketJob::Jobs::SimpleJob",
+                    "2"           => "the_path",
+                    "DT_RowClass" => "card callout callout-enabled"
+                  },
+                  failed:   {
+                    "0"           => "        <a href=\"/dirmon_entries/#{RocketJob::DirmonEntry.failed.first.id}\">\n          <i class=\"fa fa-exclamation-triangle failed\" style=\"font-size: 75%\" title=\"failed\"></i>\n          Test\n        </a>\n",
+                    "1"           => "RocketJob::Jobs::SimpleJob",
+                    "2"           => "the_path",
+                    "DT_RowClass" => "card callout callout-failed"
+                  },
+                  disabled: {
+                    "0"           => "        <a href=\"/dirmon_entries/#{RocketJob::DirmonEntry.disabled.first.id}\">\n          <i class=\"fa fa-stop disabled\" style=\"font-size: 75%\" title=\"disabled\"></i>\n          Test\n        </a>\n",
+                    "1"           => "RocketJob::Jobs::SimpleJob",
+                    "2"           => "the_path",
+                    "DT_RowClass" => "card callout callout-disabled"
+                  }
+                }
+
+                if state == :index
+                  assert_equal 0, json['draw']
+                  assert_equal 4, json['recordsTotal']
+                  assert_equal 4, json['recordsFiltered']
+                  assert_equal [expected_data[:pending], expected_data[:enabled], expected_data[:failed], expected_data[:disabled]], json['data']
+                else
+                  assert_equal 0, json['draw']
+                  assert_equal 1, json['recordsTotal']
+                  assert_equal 1, json['recordsFiltered']
+                  assert_equal [expected_data[state]], json['data']
+                end
+              end
+            end
+          end
+
+        end
+      end
+    end
+  end
+end