rocketgate-ruby 0.0.1.pre → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e174cdc0ab9153dd12a64e537d7f49da9e44b49d
-  data.tar.gz: 64b9018aa9f8c1266aa234e638c18772a563d147
+  metadata.gz: 28ba6e05d3abf64e99ab11caadb6680476ddb495
+  data.tar.gz: 5e68e3770a729a27803d551ac538947859440f59
 SHA512:
-  metadata.gz: a1cbd4b6a8ebc773c8c3847ad26619e69624fd268703ff23f741b6b2440be5fe919605db38dafd7c51eef12cfb177e80af48e008aa0e74458b4d3bd29778bb8c
-  data.tar.gz: 3c1695751188219814e250c6966ee38052205fbfaf79c82dc91ffe95f485def41eb263c8bc3c9bc2e4aaba7f61c271e7986cc5f03e6fadf2983621a93179d100
+  metadata.gz: 269107a4cf88a3c3c590290d083f4f27519a932e2a1dde051e5131a32dd9726ae15285344f332e61a4e34244f5c032165ee28d7e5a04d27d020dc83f7cc383f4
+  data.tar.gz: 49ecba34b191d1388ac81c2dfd22e43d37d7f4ed95b9f242efc19667db95aaa38afc8c8e62cb27e69f174909e2c320ca6eef2631c426f85f9c3bb5e7b8f515b7

data/lib/rocketgate/authorization.rb

@@ -1,8 +1,10 @@
 module RocketGate
   class Authorization
     attr_accessor :auth_code, :avs_response, :cvv_response, :reason_code,
-                  :approved_amount, :approved_currency, :card_hash,
-                  :card_expiration, :card_last_four, :reference_id
+                  :approved_amount, :approved_currency, :customer_id, :card_hash,
+                  :card_expiration, :card_last_four, :card_type, :card_description,
+                  :card_country, :issuer_network, :issuer_url, :issuer_name,
+                  :issuer_phone, :reference_id
 
     def avs_ok?
       if RocketGate.configuration.require_avs

data/lib/rocketgate/request.rb

@@ -26,19 +26,21 @@ module RocketGate
       config = RocketGate.configuration
       config.validate!
 
-      params = {
+      base_params = {
         version:          config.request_version,
         merchantID:       config.merchant_id,
         merchantPassword: config.merchant_password
       }
+      verification_params = {}
 
-      params.merge!({
-        avsCheck:         yes_or_ignore(config.require_avs),
-        cvv2Check:        yes_or_ignore(config.require_cvv),
-        scrub:            yes_or_ignore(config.require_scrub)
-      }) unless transaction && transaction.is_referenced?
+      unless transaction.nil?
+        verification_params[:cvv2Check] = yes_or_ignore(config.require_cvv) unless transaction.is_hashed?
+        verification_params[:avsCheck]  = yes_or_ignore(config.require_avs)
+        verification_params[:scrub]     = yes_or_ignore(config.require_scrub)
+        base_params.merge!(verification_params) unless transaction.is_referenced?
+      end
 
-      params
+      base_params
     end
 
     def yes_or_ignore(boolean)

data/lib/rocketgate/response.rb

@@ -14,17 +14,31 @@ module RocketGate
     def build!
       @response_code = RocketGate::ResponseCode::RESPONSE[find_value('responseCode')]
 
+      card_type = RocketGate::ResponseCode::CARD_TYPE[find_value('cardDebitCredit')]
+      pay_type  = find_value('payType').downcase.to_sym rescue :credit
+
       @authorization = RocketGate::Authorization.new.tap do |auth|
         auth.avs_response       = RocketGate::ResponseCode::AVS[find_value('avsResponse')]
         auth.cvv_response       = RocketGate::ResponseCode::CVV[find_value('cvv2Code')]
         auth.reason_code        = RocketGate::ResponseCode::REASON[find_value('reasonCode')]
+        auth.card_type          = card_type || pay_type
+
+        auth.issuer_network     = RocketGate::ResponseCode::CARD_BRAND[find_value('cardType')]
+        auth.issuer_name        = find_value('cardIssuerName')
+        auth.issuer_phone       = find_value('cardIssuerPhone')
+        auth.issuer_url         = find_value('cardIssuerURL')
+
         auth.auth_code          = find_value('authNo')
         auth.reference_id       = find_value('guidNo')
         auth.approved_amount    = find_value('approvedAmount').to_f
         auth.approved_currency  = find_value('approvedCurrency')
+        auth.customer_id        = find_value('merchantCustomerID')
+
         auth.card_hash          = find_value('cardHash')
         auth.card_expiration    = find_value('cardExpiration')
         auth.card_last_four     = find_value('cardLastFour')
+        auth.card_description   = find_value('cardDescription')
+        auth.card_country       = find_value('cardCountry')
       end
     end
 
@@ -35,7 +49,12 @@ module RocketGate
           tx.type = RocketGate::Transaction::TYPE[:confirmation]
         end
 
-        RocketGate.send_request!(RocketGate::Request.new(confirmation))
+        confirmation_response = RocketGate.send_request!(RocketGate::Request.new(confirmation))
+        if confirmation_response.success?
+          return self # return self instead of the empty confirmation response
+        else
+          raise RocketGate::AuthorizationError.new("Unable to confirm transaction: #{confirmation_response.response_code}")
+        end
       else
         raise RocketGate::AuthorizationError.new('Unable to confirm unauthorized transaction')
       end

data/lib/rocketgate/transaction.rb

@@ -64,12 +64,16 @@ module RocketGate
       @type ||= TYPE[:auth]
     end
 
+    def is_hashed?
+      credit_card && !credit_card.card_hash.nil?
+    end
+
     def is_referenced?
       [ TYPE[:confirmation], TYPE[:ticket], TYPE[:void] ].include?(type) && !reference_id.nil?
     end
 
     def valid?
-      is_referenced? || super
+      is_referenced? || is_hashed? || super
     end
   end
 end

data/lib/rocketgate/version.rb

@@ -1,3 +1,3 @@
 module RocketGate
-  VERSION = "0.0.1.pre"
+  VERSION = "0.0.2"
 end

data/spec/connection_spec.rb

@@ -51,7 +51,7 @@ describe RocketGate::Connection do
       expect(Net::HTTP::Post).to receive(:new).with('/path', {
         'Accept'       => 'text/xml',
         'Content-Type' => 'text/xml',
-        'User-Agent'   => 'rocketgate-ruby/0.0.1.pre'
+        'User-Agent'   => 'rocketgate-ruby/0.0.2'
       }).and_return(request)
       expect(request).to receive(:body=).with('test')
       subject

data/spec/integration_spec.rb

@@ -29,7 +29,7 @@ describe 'RocketGate Integration Certification Test Cases', integration: true do
         cc.number           = '4012 8888 8888 1881'
         cc.exp_month        = '08'
         cc.exp_year         = '2042'
-        cc.cvv              = '1111'
+        cc.cvv              = '111'
       end
     end
   end
@@ -60,6 +60,8 @@ describe 'RocketGate Integration Certification Test Cases', integration: true do
       expect(ticket_response.authorization.card_last_four).to eq '1881'
       expect(ticket_response.authorization.card_expiration).to eq '0842'
       expect(ticket_response.authorization.card_hash).to eq '3RPN+a+d07r0bOlq7NcWPKvzgcyyHmPxXw+hCxxmP6k='
+      expect(ticket_response.authorization.card_type).to eq :credit
+      expect(ticket_response.authorization.issuer_network).to eq :visa
       expect(ticket_response.authorization.reference_id).not_to be_nil
     end
   end

data/spec/request_spec.rb

@@ -20,6 +20,7 @@ describe RocketGate::Request do
     let(:config) { RocketGate.configuration }
 
     it 'returns a hash that respects configuration' do
+      request.transaction = double(:transaction, is_referenced?: false, is_hashed?: false)
       expect(subject[:version]).to eq 'R1.2'
       expect(subject[:merchantID]).to eq '1'
       expect(subject[:merchantPassword]).to eq 'testpassword'
@@ -29,7 +30,7 @@ describe RocketGate::Request do
     end
 
     context 'when the transaction is referenced' do
-      before { request.transaction = double(:transaction, is_referenced?: true) }
+      before { request.transaction = double(:transaction, is_referenced?: true, is_hashed?: true) }
 
       it 'does not include AVS, CVV or Scrub configuration' do
         expect(subject[:version]).to eq 'R1.2'
@@ -75,7 +76,7 @@ describe RocketGate::Request do
     end
 
     it 'matches the expected xml output' do
-      expected = %Q{<?xml version="1.0" encoding="UTF-8"?><gatewayRequest><version>R1.2</version><merchantID>1</merchantID><merchantPassword>testpassword</merchantPassword><avsCheck>IGNORE</avsCheck><cvv2Check>YES</cvv2Check><scrub>YES</scrub><amount>10.97</amount><currency>GBP</currency><merchantInvoiceID>abbb2170-6a71-4d96-aa8f-ceb8b7d1a7ca</merchantInvoiceID><transactionType>CC_AUTH</transactionType><cardNo>4111111111111111</cardNo><expireMonth>02</expireMonth><expireYear>2015</expireYear><cvv2>999</cvv2><merchantCustomerID>Customer-1</merchantCustomerID><customerFirstName>Test</customerFirstName><customerLastName>Person</customerLastName><billingAddress>123 Fake Street</billingAddress><billingCity>Beverly Hills</billingCity><billingState>CA</billingState><billingZipCode>90210</billingZipCode><billingCountry>US</billingCountry><email>test@example.com</email><ipAddress>127.0.0.1</ipAddress></gatewayRequest>}
+      expected = %Q{<?xml version="1.0" encoding="UTF-8"?><gatewayRequest><version>R1.2</version><merchantID>1</merchantID><merchantPassword>testpassword</merchantPassword><cvv2Check>YES</cvv2Check><avsCheck>IGNORE</avsCheck><scrub>YES</scrub><amount>10.97</amount><currency>GBP</currency><merchantInvoiceID>abbb2170-6a71-4d96-aa8f-ceb8b7d1a7ca</merchantInvoiceID><transactionType>CC_AUTH</transactionType><cardNo>4111111111111111</cardNo><expireMonth>02</expireMonth><expireYear>2015</expireYear><cvv2>999</cvv2><merchantCustomerID>Customer-1</merchantCustomerID><customerFirstName>Test</customerFirstName><customerLastName>Person</customerLastName><billingAddress>123 Fake Street</billingAddress><billingCity>Beverly Hills</billingCity><billingState>CA</billingState><billingZipCode>90210</billingZipCode><billingCountry>US</billingCountry><email>test@example.com</email><ipAddress>127.0.0.1</ipAddress></gatewayRequest>}
       expect(subject).to eq expected
     end
   end

data/spec/response_spec.rb

@@ -52,7 +52,7 @@ describe RocketGate::Response do
 
     before do
       allow(response).to receive(:success?).and_return(success)
-      allow(RocketGate).to receive(:send_request!).and_return(:ok)
+      allow(RocketGate).to receive(:send_request!).and_return(response)
     end
 
     context 'when the request was successful' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rocketgate-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.1.pre
+  version: 0.0.2
 platform: ruby
 authors:
 - Chris Cashwell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-07 00:00:00.000000000 Z
+date: 2014-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -236,12 +236,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: RocketGate Payment Gateway integration for Ruby