rocket_tag 0.5.4 → 0.5.5

data/README.md

@@ -93,11 +93,6 @@ then the two below would not be identical.
     model.tagged_similar :on => ["skills", "habits"]
     model.tagged_similar
 
-Find similar models based on tags on every context and return in decending order
-of 'tags_count'. Note that each tag is still scoped according to it's context
-
-    model.tagged_similar  
-
 Find popular tags and generate tags clouds for specific scopes
 
     User.where{email="bradphelan@xtargets.com"}.documents.popular_tags
@@ -117,7 +112,8 @@ and you can access the field *tags_count* on each Tag instance returned
 by the above query. Generating the CSS and html for your tag cloud
 is outside the scope of this project but it should be easy to do.
 
-== Contributing to rocket_tag
+Contributing to rocket_tag
+--------------------------
  
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it
@@ -127,7 +123,8 @@ is outside the scope of this project but it should be easy to do.
 * Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
 * Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
 
-== Copyright
+Copyright
+---------
 
 Copyright (c) 2011 Brad Phelan. See LICENSE.txt for
 further details.

data/VERSION

@@ -1 +1 @@
-0.5.4
+0.5.5

data/lib/rocket_tag/taggable.rb

@@ -4,16 +4,6 @@ module Squeel
     module ActiveRecord
       module RelationExtensions
 
-        # The purpose of this call is to close a query and make
-        # it behave as a simple table or view. If a query has
-        # aggregate functions applied then downstream active
-        # relation chaining causes unpredictable behaviour.
-        #
-        # This call isolates the group by behaviours.
-        def isolate_group_by_as(type)
-          type.from(self.arel.as(type.table_name))
-        end
-
         # We really only want to group on id for practical
         # purposes but POSTGRES requires that a group by outputs
         # all the column names not under an aggregate function.
@@ -33,7 +23,6 @@ module RocketTag
   module Taggable
     def self.included(base)
       base.extend ClassMethods
-      #base.send :include, InstanceMethods
     end
 
     class Manager
@@ -135,28 +124,6 @@ module RocketTag
         @rocket_tag ||= RocketTag::Taggable::Manager.new(self)
       end
 
-      # Provides the tag counting functionality by adding an
-      # aggregate count on id. Assumes valid a join has been
-      # made.
-      #
-      # Note that I should be able to chain count tags to 
-      # the relation instead of passing the rel parameter in
-      # however my tests fails with wrong counts. This is
-      # not so elegant
-      #
-      # rel can be passed as the last expression in a block
-      # if desired.
-      def tags_count(type=self)
-        if block_given?
-          rel = yield
-        end
-        rel.select('*').
-        select{count(~id).as(tags_count)}.
-        group_by_all_columns.
-        order("tags_count DESC").
-        isolate_group_by_as(type)
-      end
-
       def is_valid_context? context
           rocket_tag.contexts.include? context
       end
@@ -278,7 +245,7 @@ module RocketTag
           select('*').
           order("tags_count desc")
 
-        # Isolate the aggregate uery by wrapping it as
+        # Isolate the aggregate query by wrapping it as
         #
         # select * from ( ..... ) tags
         q = RocketTag::Tag.from(q.arel.as(RocketTag::Tag.table_name))

data/rocket_tag.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "rocket_tag"
-  s.version = "0.5.4"
+  s.version = "0.5.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brad Phelan"]

data/spec/rocket_tag/taggable_spec.rb

@@ -358,13 +358,13 @@ describe TaggableModel do
 
       describe "tag cloud calculations" do
         it "should return tags on an association and the counts thereof" do
-          @user0.taggable_models.popular_tags.each do |tag|
-            puts "#{tag.name}\t#{tag.tags_count}"
-          end
-          puts "-------------"
-          @user1.taggable_models.popular_tags.each do |tag|
-            puts "#{tag.name}\t#{tag.tags_count}"
-          end
+#           @user0.taggable_models.popular_tags.each do |tag|
+#             puts "#{tag.name}\t#{tag.tags_count}"
+#           end
+#           puts "-------------"
+#           @user1.taggable_models.popular_tags.each do |tag|
+#             puts "#{tag.name}\t#{tag.tags_count}"
+#           end
 
           # Check that the tags_count on each tag is in
           # descending order.

metadata

@@ -2,7 +2,7 @@
 name: rocket_tag
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.5.4
+  version: 0.5.5
 platform: ruby
 authors: 
 - Brad Phelan
@@ -144,7 +144,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -4496343297606785835
+      hash: -401049524358643574
       segments: 
       - 0
       version: "0"