robworley-rack-noie 1.0 → 1.0.1

data/README.markdown

@@ -5,7 +5,7 @@ a favor: it shows the way out of your website to poor souls out there using Inte
 
 # installation
 
-    sudo gem install robworley-rack-noie
+    sudo gem install robworley-rack-noie -s http://gemcutter.org
 
 # usage
 

data/lib/noie.rb

@@ -24,7 +24,7 @@ module Rack
 
     def is_ie?(ua_string)
       # We need at least one digit to be able to get the version, hence the \d
-      ua_string.match(/MSIE \d/) ? true : false
+      ua_string.match(/MSIE \d/) && !ua_string.match(/MS Web Services Client Protocol/) ? true : false
     end
 
     def ie_version(ua_string)
@@ -32,7 +32,7 @@ module Rack
     end
 
     def kick_it
-      [301, {'Location' => @options[:redirect]}, ['Fail browser is fail']]
+      [301, {'Location' => @options[:redirect]}, ['User agent not permitted.']]
     end
 
     def enforce_noie?(env)

data/test/noie_test.rb

@@ -39,6 +39,12 @@ class NoieTest < Test::Unit::TestCase
     assert_equal "Hi Internets!", response.body
   end
 
+  def test_dotnet_soap_client_is_not_considered_ie
+    request  = Rack::MockRequest.new(Rack::NoIE.new(TestApp.new, {:redirect => 'http://slashdot.org'}))
+    response = request.get('/', {'HTTP_USER_AGENT' => 'Mozilla/4.0 (compatible; MSIE 6.0; MS Web Services Client Protocol 2.0.50727.3615)'})
+    assert_equal "Hi Internets!", response.body
+  end
+
   def test_allows_if_UA_version_greater_than_minimum
     request  = Rack::MockRequest.new(Rack::NoIE.new(TestApp.new, {:redirect => 'http://slashdot.org'}))
     response = request.get('/', {'HTTP_USER_AGENT' => 'Mozilla/4.0 (compatible; MSIE 8.0; Windows XP)'})

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: robworley-rack-noie
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 21
   prerelease: 
   segments: 
   - 1
   - 0
-  version: "1.0"
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - Julio Cesar Ody