robust_excel_ole 1.1.6 → 1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb0b1d72f09a87508b2d3f42a909b76de9230232
-  data.tar.gz: 54e2a4230a0833cb672881a49da5e105b3b74895
+  metadata.gz: 11b718a2903204d3521cdfad3ef539537841dd06
+  data.tar.gz: 07a2911b36560a7f505c17914ed441c3ee2add3c
 SHA512:
-  metadata.gz: de86c09449b9bc6c93915ef14cb898077d6243bc19012ce002a81a5d6828f8c4cb5ffaee8ed7a75c1d7ae0f8e1ad77b92dbd5d194af44393714578c2149c5a11
-  data.tar.gz: b43dfe70f03b3197d09710eeccb72fc696ae425b65b8a3ffbe36a94b0b61ce0a03e91ceb2929631aa33f22648f90362e1623d818b54b0e2fe97a5a00c971f39e
+  metadata.gz: 7086927359fd13e8f573ab33eb7aa81ba8d7f19ffcdf1b42d2a61fdfa02414bcfbeabc6846114a0eebddf30b8f28f5d14682f756222122b404bf237bc784a217
+  data.tar.gz: eb1e7673ba0fbb4402e8fd81669a2f9d80b75f7305044aa8093ca15260d3573178c6e30c79e671e9ed6997b6e1b79bbf30301b86ca78e60124faed430b82c4c2

data/lib/robust_excel_ole/version.rb

@@ -1,3 +1,3 @@
 module RobustExcelOle
-  VERSION = "1.1.6"
+  VERSION = "1.2"
 end

data/spec/book_spec.rb

@@ -375,7 +375,7 @@ describe Book do
 
       context "with :if_unsaved => :alert or :if_unsaved => :excel" do
         before do
-         @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"
+         @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
         end
 
         after do
@@ -398,9 +398,9 @@ describe Book do
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
-          #expect{
-          #  Book.open(@simple_file, :if_unsaved => :alert)
-          #  }.to raise_error(ExcelREOError, /user canceled or runtime error/)
+          expect{
+            Book.open(@simple_file, :if_unsaved => :alert)    
+            }.to raise_error(UnexpectedREOError)
           @book.should be_alive
         end
 
@@ -420,9 +420,9 @@ describe Book do
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
-          #expect{
-          #  Book.open(@simple_file, :if_unsaved => :excel)
-          #  }.to raise_error(ExcelREOError, /user canceled or runtime error/)
+          expect{
+            Book.open(@simple_file, :if_unsaved => :excel)
+          }.to raise_error(UnexpectedREOError)
           @book.should be_alive
         end
 
@@ -1223,7 +1223,7 @@ describe Book do
     context "with focus" do
 
       before do
-        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"        
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"        
         @book = Book.open(@simple_file, :visible => true)
         @book2 = Book.open(@another_simple_file, :visible => true)
       end

data/spec/book_specs/book_misc_spec.rb

@@ -1044,7 +1044,7 @@ describe Book do
     context "with focus" do
 
       before do
-        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"        
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"        
         @book = Book.open(@simple_file, :visible => true)
         @book.excel.displayalerts = false
         @book2 = Book.open(@another_simple_file, :visible => true)

data/spec/book_specs/book_open_spec.rb

@@ -1599,60 +1599,34 @@ describe Book do
     context "with :if_unsaved" do
 
       before do
-        @book = Book.open(@simple_file1)
-        sheet = @book.sheet(1)
-        #@book.add_sheet(@sheet, :as => 'a_name')
-        @old_value = sheet[1,1].Value
-        sheet[1,1] = (sheet[1,1].value == "foo" ? "bar" : "foo")
-        @new_value = sheet[1,1].Value
-        @book.Saved.should be false
+        @book = Book.open(@simple_file)
+        @sheet = @book.sheet(1)
+        @book.add_sheet(@sheet, :as => 'a_name')
       end
 
       after do
         @book.close(:if_unsaved => :forget)
-      end
-
-      it "should open the book in a new excel instance, if :if_unsaved is :new_excel" do
-        new_book = Book.open(@simple_file1, :if_unsaved => :new_excel)
-        new_book.excel.should_not == @book.excel
-        @book.should be_alive
-        @book.Saved.should be false
-        new_book.should be_alive
-        new_book.Saved.should be true
-        new_book.sheet(1)[1,1].Value.should == @old_value
-        #new_book.filename.should == @book.filename
-        new_book.excel.should_not == @book.excel       
-        new_book.close
+        @new_book.close rescue nil
       end
 
       it "should raise an error, if :if_unsaved is :raise" do
         expect {
-          new_book = Book.open(@simple_file1, :if_unsaved => :raise)
+          @new_book = Book.open(@simple_file, :if_unsaved => :raise)
         }.to raise_error(WorkbookNotSaved, /workbook is already open but not saved: "workbook.xls"/)
       end
 
       it "should let the book open, if :if_unsaved is :accept" do
-        new_book = Book.open(@simple_file1, :if_unsaved => :accept)
+        expect {
+          @new_book = Book.open(@simple_file, :if_unsaved => :accept)
+          }.to_not raise_error
         @book.should be_alive
-        new_book.should be_alive
-        new_book.Saved.should be false      
-        @book.Saved.should be false  
-        new_book.sheet(1)[1,1].Value.should == @new_value
-        new_book.should == @book
-      end
-
-      it "should open book and close old book, if :if_unsaved is :forget" do
-        new_book = Book.open(@simple_file1, :if_unsaved => :forget)
-        @book.should_not be_alive
-        new_book.should be_alive
-        new_book.Saved.should be true
-        new_book.sheet(1)[1,1].Value.should == @old_value
-        #@new_book.filename.downcase.should == @simple_file.downcase
+        @new_book.should be_alive
+        @new_book.should == @book
       end
 
-      context "with :if_unsaved => :alert" do
+      context "with :if_unsaved => :alert or :if_unsaved => :excel" do
         before do
-         @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"
+         @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
         end
 
         after do
@@ -1662,16 +1636,12 @@ describe Book do
         it "should open the new book and close the unsaved book, if user answers 'yes'" do
           # "Yes" is the  default. --> language independent
           @key_sender.puts "{enter}"
-          new_book = Book.open(@simple_file1, :if_unsaved => :alert)
-          new_book.should be_alive
-          #@book.should_not be_alive
-          #new_book.filename.downcase.should == @simple_file.downcase
-          new_book.Saved.should be true
-          new_book.sheet(1)[1,1].Value.should == @old_value
+          @new_book = Book.open(@simple_file1, :if_unsaved => :alert)
+          @new_book.should be_alive
+          @new_book.filename.downcase.should == @simple_file1.downcase
+          @book.should_not be_alive
         end
-      end
-=begin
-        # only for Excel2007:
+
         it "should not open the new book and not close the unsaved book, if user answers 'no'" do
           # "No" is right to "Yes" (the  default). --> language independent
           # strangely, in the "no" case, the question will sometimes be repeated three times
@@ -1680,33 +1650,20 @@ describe Book do
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           expect{
-            Book.open(@simple_file1, :if_unsaved => :alert)
-            }.to raise_error(ExcelREOError, "user canceled or runtime error")
+            Book.open(@simple_file, :if_unsaved => :alert)    
+            }.to raise_error(UnexpectedREOError)
           @book.should be_alive
         end
-    
-=end      
-
-      context "with :if_unsaved => :excel" do
-        before do
-         @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '../helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"
-        end
-
-        after do
-          @key_sender.close
-        end
 
         it "should open the new book and close the unsaved book, if user answers 'yes'" do
           # "Yes" is the  default. --> language independent
           @key_sender.puts "{enter}"
-          new_book = Book.open(@simple_file1, :if_unsaved => :excel)
-          new_book.should be_alive
+          @new_book = Book.open(@simple_file1, :if_unsaved => :excel)
+          @new_book.should be_alive
+          @new_book.filename.downcase.should == @simple_file1.downcase
           #@book.should_not be_alive
-          new_book.Saved.should be true
-          new_book.sheet(1)[1,1].Value.should == @old_value
         end
 
-=begin
         it "should not open the new book and not close the unsaved book, if user answers 'no'" do
           # "No" is right to "Yes" (the  default). --> language independent
           # strangely, in the "no" case, the question will sometimes be repeated three times
@@ -1715,24 +1672,11 @@ describe Book do
           @key_sender.puts "{right}{enter}"
           @key_sender.puts "{right}{enter}"
           expect{
-            Book.open(@simple_file1, :if_unsaved => :excel)
-            }.to raise_error(ExcelREOError, "user canceled or runtime error")
+            Book.open(@simple_file, :if_unsaved => :excel)
+          }.to raise_error(UnexpectedREOError)
           @book.should be_alive
         end
-=end        
-
-      end
-
-      it "should raise an error, if :if_unsaved is default" do
-        expect {
-          new_book = Book.open(@simple_file1, :if_unsaved => :raise)
-        }.to raise_error(WorkbookNotSaved, /workbook is already open but not saved: "workbook.xls"/)
-      end
 
-      it "should raise an error, if :if_unsaved is invalid option" do
-        expect {
-          new_book = Book.open(@simple_file1, :if_unsaved => :invalid_option)
-        }.to raise_error(OptionInvalid, ":if_unsaved: invalid option: :invalid_option")
       end
     end
 

data/spec/book_specs/book_save_spec.rb

@@ -36,7 +36,7 @@ describe Book do
 
   after do
     Excel.kill_all
-   # rm_tmp(@dir)
+    #rm_tmp(@dir)
   end
 
   describe "save" do
@@ -380,7 +380,9 @@ describe Book do
 
           it "should save if user answers 'yes'" do
             # "Yes" is to the left of "No", which is the  default. --> language independent
-            @key_sender.puts "{left}{enter}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
+            @key_sender.puts "{right}{right}{right}{enter}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
+            #@key_sender.puts "{left}{enter}"
+            #@key_sender.puts "{left}{enter}"
             @book.save_as(@simple_save_file1, :if_exists => :alert)
             File.exist?(@simple_save_file1).should be true
             File.size?(@simple_save_file1).should > @garbage_length
@@ -390,14 +392,12 @@ describe Book do
             new_book.close
             @book.excel.DisplayAlerts.should == displayalert_value
           end
-
           it "should not save if user answers 'no'" do
             # Just give the "Enter" key, because "No" is the default. --> language independent
             # strangely, in the "no" case, the question will sometimes be repeated three times
             @key_sender.puts "{enter}"
             @key_sender.puts "{enter}"
             @key_sender.puts "{enter}"
-            #@key_sender.puts "%{n}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
             @book.save_as(@simple_save_file1, :if_exists => :alert)
             File.exist?(@simple_save_file1).should be true
             File.size?(@simple_save_file1).should == @garbage_length
@@ -410,7 +410,6 @@ describe Book do
             @key_sender.puts "{right}{enter}"
             @key_sender.puts "{right}{enter}"
             @key_sender.puts "{right}{enter}"
-            #@key_sender.puts "%{n}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
             @book.save_as(@simple_save_file1, :if_exists => :alert)
             File.exist?(@simple_save_file1).should be true
             File.size?(@simple_save_file1).should == @garbage_length
@@ -435,7 +434,9 @@ describe Book do
 
           it "should save if user answers 'yes'" do
             # "Yes" is to the left of "No", which is the  default. --> language independent
-            @key_sender.puts "{left}{enter}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
+            @key_sender.puts "{right}{right}{right}{enter}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
+            #@key_sender.puts "{left}{enter}"
+            #@key_sender.puts "{left}{enter}"
             @book.save_as(@simple_save_file1, :if_exists => :excel)
             File.exist?(@simple_save_file1).should be true
             File.size?(@simple_save_file1).should > @garbage_length
@@ -443,6 +444,7 @@ describe Book do
             new_book = Book.open(@simple_save_file1, :excel => :new)
             new_book.should be_a Book
             new_book.close
+ 
             @book.excel.DisplayAlerts.should == displayalert_value
           end
 
@@ -452,7 +454,6 @@ describe Book do
             @key_sender.puts "{enter}"
             @key_sender.puts "{enter}"
             @key_sender.puts "{enter}"
-            #@key_sender.puts "%{n}" #, :initial_wait => 0.2, :if_target_missing=>"Excel window not found")
             @book.save_as(@simple_save_file1, :if_exists => :excel)
             File.exist?(@simple_save_file1).should be true
             File.size?(@simple_save_file1).should == @garbage_length

data/spec/helpers/key_sender.rb

@@ -60,7 +60,8 @@ class KeySender # :nodoc: #
 end
 
 if __FILE__ == $0
-  key_sender = KeySender.new(ARGV[1])
+  key_sender = KeySender.new(ARGV[0]) 
+  #key_sender = KeySender.new(ARGV[1])
   while not $stdin.eof? do
     key_sequence = $stdin.gets.chomp
     key_sender.send key_sequence

data/spec/sheet_spec.rb

@@ -35,7 +35,7 @@ describe Sheet do
   describe ".initialize" do
     context "when open sheet protected(with password is 'protect')" do
       before do
-        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Office Excel" '  , "w"
+        @key_sender = IO.popen  'ruby "' + File.join(File.dirname(__FILE__), '/helpers/key_sender.rb') + '" "Microsoft Excel" '  , "w"
         @book_protect = Book.open(@protected_file, :visible => true, :read_only => true, :force_excel => :new)
         @book_protect.excel.displayalerts = false
         @key_sender.puts "{p}{r}{o}{t}{e}{c}{t}{enter}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: robust_excel_ole
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: '1.2'
 platform: ruby
 authors:
 - traths
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-20 00:00:00.000000000 Z
+date: 2018-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec