robust_excel_ole 0.2.0.5 → 0.2.0.6

data/README.rdoc

@@ -1,13 +1,19 @@
 = RobustExcelOle
 
-This is a simple fork from tomiacannondale's wrap_excel adapted to Ruby 1.8.6.
+robust_excel_ole wraps the win32ole, and uses the Excel operations with ruby.
+
+== Description
+
+robust_excel_ole started as a simple fork from tomiacannondale's wrap_excel adapted to Ruby 1.8.6.
 The functionality of wrap_excel is optimised and extended by new features.
 
 This is work in progress.
 
-== Description
-
-RobustExcelOle wraps the win32ole, and uses the Excel operations with ruby.
+Notice some features in robust_excel_ole that are not compatible with wrap_excel:
+* +save_as+ instead of +save+.
+* +open+ uses by default a running Excel application instead of creating a new one,
+  and opens a book by default in writable mode instead of read_only 
+* +close+ closes the workbook instead of closing all workbooks and the Excel application.
 
 == Requirements
 
@@ -20,156 +26,135 @@ RobustExcelOle wraps the win32ole, and uses the Excel operations with ruby.
 
 == Usage
 
-=== open a book
+=== Open a book.
 
-Open a book.
+Example:
 
-book = RobustExcelOle::Book.open('./sample.xls')
+  book = RobustExcelOle::Book.open('./sample.xls')
 
-Open a book with a block.
+Open a book with a block. 
+The semantics is similar to, e.g.,  File.open.
 
   RobustExcelOle::Book.open('./sample.xls') do |book|
     # do something
   end
+                  
 
 Options are the following:
 
-[:reuse]         boolean (default true)  use an already open Excel-application 
-[:read_only]     boolean (default false) open in read-only mode  
-[:displayalerts] boolean (default false) allow display alerts in Excel   
-[:visible]       boolean (default false) make visibe in Excel                  
+[:reuse]         boolean (default: true). use an already open Excel-application 
+[:read_only]     boolean (default: false). open in read-only mode  
+[:displayalerts] boolean (default: false). allow display alerts in Excel   
+[:visible]       boolean (default: false). make visibe in Excel                  
 [:if_unsaved]    :raise (default), :accept, :forget, :new_app, :excel
-                 if an unsaved book with the same name is open
-          
-:raise 
-
-Raise an exception. Don't open the book.
-
-:accept  
-
-Let the unsaved book open.                  
-                 
-:forget  
-
-Close the unsaved book, open the new book.
-
-:new_app 
-
-Open the new book in a new Excel application.
-
-:excel   
-
-Give control to Excel.
-
-
 [:if_unsaved_other_book]  :raise (default), :save, :forget, :new_app
-                          if an unsaved book with same name in a different path is open,
-                 
-:raise 
-
-Raise an exception. Don't open the book.
-
-:save    
+                         
 
-Save and close the unsaved book and open the new book.
+The option :if_unsaved  : 
 
-:forget  
+If an unsaved book with the same name is open, then
+          
+[:raise ]  Raise an exeption. Don't open the book.
+[:accept]  Let the unsaved book open.                  
+[:forget]  Close the unsaved book, open the new book.
+[:new_app] Open the new book in a new Excel application
+[:excel]   Give control to Excel.
 
-Close the unsaved book, open the new book
-                
-:new_app 
+The option :if_unsaved_other_book :
 
-Open the new book in a new Excel application
+If an unsaved book with same name in a different path is open, then
+                 
+[:raise]   Raise an exception. Don't open the book.
+[:save]    Save and close the unsaved book and open the new book.
+[:forget]  Close the unsaved book, open the new book.
+[:new_app] Open the new book in a new Excel application.
 
 
 Examples:
 
 Open a book.
 
-book = RobustExcelOle::Book.open('./sample.xls')
+  book = RobustExcelOle::Book.open('./sample.xls')
 
 Open another book in the same Excel application.
 
-new_book = RobustExcelOle::Book.open('./different.xls')
+  new_book = RobustExcelOle::Book.open('./different.xls')
 
 Open another book in a new Excel applications.
 
-new_book = RobustExcelOle::Book.open('./different.xls', :reuse => false)
+  new_book = RobustExcelOle::Book.open('./different.xls', :reuse => false)
 
 Change the book (see below).
 
-sheet = book[0]
-book.add_sheet(sheet, :as => 'copyed_name')
+  sheet = book[0]
+  book.add_sheet(sheet, :as => 'copyed_name')
 
-Let the unsaved book open, when open a book while a book with the same name is unsaved and open.
+Let the unsaved book open, when opening a book and a book with the same name is unsaved and open.
 
-new_book = RobustExcelOle::Book.open('./sample.xls', :if_unsaved => accept)
+  new_book = RobustExcelOle::Book.open('./sample.xls', :if_unsaved => accept)
 
-=== save a book
+=== Save a book.
 
-Save a book.
+Simple save:
 
-book.save
+  book.save
 
 Save a book with a file name.
 
-book.save_as('./another_sample.xls')
+  book.save_as('./another_sample.xls')
 
 Options are the following:
 
-[:if_exists] :overwrite, :excel, :raise (default)
-
-:overwrite: 
-
-Delete the old file and write the file.
+[:if_exists] :raise (default), :overwrite, :excel
 
-:excel
+The option :if_exists :
 
-Give the control to Excel.
+If a book with the file name already exists, then
 
-:raise
+[:raise]     Raise an exeption. Don't write the file.
+[:overwrite] Delete the existing file and write the file. If the book is open in an Excel application, then raise an exeption.
+[:excel]     Give the control to Excel.
 
-Raise an exception. Don't write the file.
 
 Example:
 
 Overwrite a book with the same name.
 
-book.save('./another_sample.xls', :if_exists => :overwrite)  
+  book.save('./another_sample.xls', :if_exists => :overwrite)  
 
 === == (equal)
 
-Check whether two books are identical.
+Check whether two referenced Excel workbooks are identical.
 
 Example.
 
-if (book == new_book) then
-  puts "the books are identical"
-end
+  if (book == new_book) then
+    puts "the workbooks are identical"
+  end
 
 === alive?
 
-Check whether the book is alive.
-
-book.alive?
+Check whether the referenced Excel workbook responds to methods.
 
-Example.
+Example:
 
-if book.alive? then 
-  puts "the book is alive"
-end
+  if book.alive? then 
+    puts "the book is alive"
+  end
 
 === filename
 
 Get the file name of the book.
 
-book.filename
+Example:
+
+  book.filename
 
-=== close a book
+=== Close a book.
 
-Close a book
+Example:
 
-book.close
+  book.close
 
 Options are the following:
 
@@ -178,7 +163,7 @@ Options are the following:
                  
 :raise 
 
-Raise an exception. Don't close the book                  
+Raise an exception. Don't close the book.                  
                  
 :save            
 
@@ -190,11 +175,11 @@ Close the book.
     
 :excel           
 
-Give control to Excel
+Give control to Excel.
 
 
 
-=== access sheet
+=== Access a sheet.
 
 A sheet object can be accessed with a Book#[] method.
 
@@ -204,7 +189,7 @@ Access a sheet object with the sheet name.
 
     book['Sheet1']
 
-=== access row or column
+=== Access a row or a column.
 
 A sheet object is enumerable. Use the methods Sheet#each_column, Sheet#each_row or Sheet#each.
 
@@ -221,7 +206,7 @@ A sheet object is enumerable. Use the methods Sheet#each_column, Sheet#each_row
     # do something with column_range
   end
 
-=== access cell
+=== Access a cell.
 
 Read a cell from a sheet object.
 
@@ -241,7 +226,8 @@ If you want to do something that not provide a function, you can use win32ole me
 
 == Support
 
-This is work in progress. Please don't hesitate to contact us and to report issues and feature requests to github Issues. https://github.com/Thomas008/robust_excel_ole/issues
+This is work in progress. Please contact us and to report issues and feature requests to github Issues. 
+https://github.com/Thomas008/robust_excel_ole/issues
 
 == Collaborate
 

data/examples/example1.rb

@@ -0,0 +1,35 @@
+# example 1: open a book, print the cells, rows, and columns of a sheet
+
+require File.join(File.dirname(__FILE__), '../lib/robust_excel_ole')
+
+module RobustExcelOle
+
+	ExcelApp.close_all
+	begin
+	  filename = '../spec/data/simple.xls'
+	  book = RobustExcelOle::Book.open(filename)
+	  sheet = book[0]
+	  cell = sheet[0,0]
+	  i = 0
+	  sheet.each do |cell|
+	  	i = i + 1
+	  	puts "#{i}. cell: #{cell.value}"
+	  end
+	  i = 0
+	  sheet.each_row do |row|
+	  	i = i + 1
+	  	puts "#{i}. row: #{row.value}"
+	  end
+	  i = 0
+	  sheet.each_column do |column|
+	  i = i + 1
+	  	puts "#{i}. column: #{column.value}"
+	  end
+	  sheet[0,0] = "complex"
+	  book.save
+	  book.close
+	ensure
+		  ExcelApp.close_all
+	end
+
+end

data/examples/example2.rb

@@ -0,0 +1,33 @@
+# example 2: open a book in a running Excel application and in a new one. make visible
+
+require File.join(File.dirname(__FILE__), '../lib/robust_excel_ole')
+
+module RobustExcelOle
+
+    ExcelApp.close_all
+    begin
+   	  dir = '../spec/data/'
+	  file_name1 = dir + 'simple.xls'
+	  file_name2 = dir + 'different_simple.xls'
+	  file_name3 = dir + 'different_simple.xls'
+	  file_name4 = dir + 'book_with_blank.xls'
+	  book1 = RobustExcelOle::Book.open(file_name1)   # open a book in a new Excel application since no Excel is open
+	  ExcelApp.reuse_if_possible.Visible = true       # make Excel visible
+	  sleep 2
+	  book2 = RobustExcelOle::Book.open(file_name2)   # open a new book in the same Excel application
+	  sleep 2                                         # (by default:  :reuse => true)
+	  book3 = RobustExcelOle::Book.open(file_name3, :reuse => false, :visible => true) 
+	                                                  # open another book in a new Excel application, make Excel visible
+	  sleep 2 
+	  book4 = RobustExcelOle::Book.open(file_name4, :reuse => true, :visible => true)   
+	                                                  # open anther book, and use a running Excel application
+	  sleep 2                                        # (Excel chooses the first Excel application)        
+	  book1.close                                     # close the books
+	  book2.close                                             
+      book3.close
+      book4.close                                         
+	ensure
+  	  ExcelApp.close_all                              # close workbooks, quit Excel application
+	end
+
+end

data/examples/example3.rb

@@ -0,0 +1,32 @@
+# example 3: open a book, simple save, save_as, close
+
+require File.join(File.dirname(__FILE__), '../lib/robust_excel_ole')
+
+module RobustExcelOle
+
+    ExcelApp.close_all
+    begin
+   	  dir = '../spec/data/'
+	  file_name = dir + 'simple.xls'
+	  other_file_name = dir + 'different_simple.xls'
+	  book = RobustExcelOle::Book.open(file_name)                # open a book.  default:  :read_only => false
+	  ExcelApp.reuse_if_possible.Visible = true                  # make Excel visible
+	  sheet = book[0]                                            # access a sheet
+	  sleep 1     
+	  sheet[0,0] = 
+	    sheet[0,0].value == "simple" ? "complex" : "simple"        # change a cell
+	  sleep 1
+	  book.save                                                  # simple save
+	  begin
+	  	book.save_as(other_file_name)                            # save_as :  default :if_exists => :raise 
+	  rescue ExcelErrorSave => msg
+	  	puts "save_as error: #{msg.message}"
+	  end
+	  book.save_as(other_file_name, :if_exists => :overwrite)    # save_as with :if_exists => :overwrite
+	  puts "save_as: saved successfully with option :if_exists => :overwrite"
+	  book.close                                                 # close the book
+	ensure
+  	  ExcelApp.close_all                                         # close workbooks, quit Excel application
+	end
+
+end

data/examples/example4.rb

@@ -0,0 +1,29 @@
+# example 4: open with read_only mode. save, close 
+
+require File.join(File.dirname(__FILE__), '../lib/robust_excel_ole')
+
+module RobustExcelOle
+
+    ExcelApp.close_all
+    begin
+   	  dir = '../spec/data/'
+	  file_name = dir + 'simple.xls'
+	  other_file_name = dir + 'different_simple.xls'
+	  # open a book with read_only and make Excel visible
+	  book = RobustExcelOle::Book.open(file_name, :read_only => true, :visible => true) 
+	  sheet = book[0]                                     # access a sheet
+	  sleep 1     
+	  sheet[0,0] = 
+	    sheet[0,0].value == "simple" ? "complex" : "simple" # change a cell
+	  sleep 1
+	  begin
+	    book.save                                         # simple save. 
+	  rescue ExcelErrorSave => msg                        # raises exception because book is opened in of read_only mode
+	    puts "save_as error: #{msg.message}"
+	  end
+	  book.close                                          # close the book without saving it. 
+	ensure
+  	  ExcelApp.close_all                                  # close workbooks, quit Excel application
+	end
+
+end

data/examples/example5.rb

@@ -0,0 +1,35 @@
+# example 5: open with :if_unsaved => :accept, close with :if_unsaved => :save 
+
+require File.join(File.dirname(__FILE__), '../lib/robust_excel_ole')
+
+module RobustExcelOle
+
+    ExcelApp.close_all
+    begin
+	  file_name = '../spec/data/simple.xls' 
+	  book = RobustExcelOle::Book.open(file_name)                      # open a book 
+	  sheet = book[0]                                                  # access a sheet
+	  sheet[0,0] = sheet[0,0].value == "simple" ? "complex" : "simple" # change a cell
+	  begin
+	    new_book = RobustExcelOle::Book.open(file_name)     # open another book with the same file name
+	  rescue ExcelErrorOpen => msg                          # by default: raises an exception:
+	    puts "open error: #{msg.message}"                   # a book with the same name is already open and unsaved 
+	  end
+	  new_book = RobustExcelOle::Book.open(file_name, :if_unsaved => :accept) # open another book with the same file name 
+	                                                                          # and let the unsaved book open
+	  if book.alive? && new_book.alive? then                                      # check whether the referenced workbooks
+	  	puts "open with :if_unsaved => :accept : the two books are alive." # respond to methods
+	  end
+	  begin                                                                   
+	  	book.close                                          # close the book. by default: raises an exception:
+	  rescue ExcelErrorClose => msg                         #   book is unsaved
+	  	puts "close error: #{msg.message}"
+	  end
+	  book.close(:if_unsaved => :save)                      # save the book before closing it 
+	  puts "closed the book successfully with option :if_unsaved => :save"
+	  new_book.close                                        # close the other book. It is already saved.
+	ensure
+  	  ExcelApp.close_all                                    # close workbooks, quit Excel application
+	end
+
+end

data/lib/robust_excel_ole/book.rb

@@ -41,7 +41,7 @@ module RobustExcelOle
         :if_unsaved_other_book => :raise
       }.merge(opts)
       excel_app_options = {:reuse => true}.merge(opts).delete_if{|k,v| 
-        k== :if_read_only || k== :unsaved || k == :if_unsaved_other_book}
+        k== :read_only || k== :if_unsaved || k == :if_unsaved_other_book}
       if not File.exist?(file)
         raise ExcelErrorOpen, "file #{file} not found"
       end
@@ -50,7 +50,8 @@ module RobustExcelOle
       @workbook = workbooks.Item(File.basename(file)) rescue nil
       if @workbook then
         blocked_by_other_book = (File.basename(file) == File.basename(@workbook.Fullname)) && 
-                                (not (file == @workbook.Fullname.gsub("\\","/")))
+                                (not (absolute_path(file) == @workbook.Fullname))
+                                #(not (file == @workbook.Fullname.gsub("\\","/")))
         if blocked_by_other_book then
           case @options[:if_unsaved_other_book]
           when :raise
@@ -60,8 +61,8 @@ module RobustExcelOle
           when :forget
             @workbook.Close
           when :new_app
-            @options[:reuse] = false
-            @excel_app = ExcelApp.new(@options)
+            excel_app_options[:reuse] = false
+            @excel_app = ExcelApp.new(excel_app_options)
             @workbook = nil
           else
             raise ExcelErrorOpen, ":if_unsaved_other_book: invalid option"
@@ -81,8 +82,8 @@ module RobustExcelOle
               old_displayalerts = @excel_app.DisplayAlerts  # :nodoc:
               @excel_app.DisplayAlerts = true  # :nodoc:
             when :new_app
-              @options[:reuse] = false
-              @excel_app = ExcelApp.new(@options)
+              excel_app_options[:reuse] = false
+              @excel_app = ExcelApp.new(excel_app_options)
               @workbook = nil
             else
               raise ExcelErrorOpen, ":if_unsaved: invalid option"
@@ -119,17 +120,13 @@ module RobustExcelOle
     #
     # options:
     #  :if_unsaved    if book is unsaved
-    #                 :raise   -> raise an exception       (default)             
-    #                 :save    -> save the book before it is closed                  
-    #                 :forget  -> close the book 
-    #                 :excel   -> give control to excel
-    def close(opts={ })
-      @options = {
-        :if_unsaved => :raise,
-      }.merge(opts)
-      if ((alive?) && (not @workbook.Saved)) then
-        #puts "book not saved"
-        case @options[:if_unsaved]
+    #                      :raise   -> raise an exception       (default)             
+    #                      :save    -> save the book before it is closed                  
+    #                      :forget  -> close the book 
+    #                      :excel   -> give control to excel
+    def close(opts = {:if_unsaved => :raise})
+      if ((alive?) && (not @workbook.Saved) && (not @options[:read_only])) then
+        case opts[:if_unsaved]
         when :raise
           raise ExcelErrorClose, "book is unsaved (#{File.basename(filename)})"
         when :save
@@ -146,9 +143,9 @@ module RobustExcelOle
       begin
         @workbook.Close if alive?
         @workbook = nil unless alive?
-        raise ExcelUserCanceled, "close: canceled by user" if alive? && @options[:if_unsaved] == :excel && (not @workbook.Saved)
+        raise ExcelUserCanceled, "close: canceled by user" if alive? && opts[:if_unsaved] == :excel && (not @workbook.Saved)
       ensure
-        if @options[:if_unsaved] == :excel then
+        if opts[:if_unsaved] == :excel then
           @excel_app.DisplayAlerts = old_displayalerts  # :nodoc:  
         end
       end
@@ -173,7 +170,7 @@ module RobustExcelOle
       @workbook.Fullname.tr('\\','/') rescue nil
     end
 
-    #returns true, if the full book names and excel appications are identical, false, otherwise  
+    # returns true, if the full book names and excel appications are identical, false, otherwise  
     def == other_book
       other_book.is_a?(Book) &&
       @excel_app == other_book.excel_app &&
@@ -186,7 +183,7 @@ module RobustExcelOle
     # saves a book.
     # returns true, if successfully saved, nil otherwise
     def save
-      raise IOError, "Not opened for writing(open with :read_only option)" if @options[:read_only]
+      raise ExcelErrorSave, "Not opened for writing (opened with :read_only option)" if @options[:read_only]
       if @workbook then
         @workbook.Save 
         true
@@ -215,8 +212,14 @@ module RobustExcelOle
       if File.exist?(file) then
         case opts[:if_exists]
         when :overwrite
-          File.delete(file) 
-          #File.delete(absolute_path(File.join(dirname, basename)))
+          # if a book is open with the name of file, then raise error
+          open_workbook = ExcelApp.reuse_if_possible.Workbooks(basename) rescue nil
+          #workbook_file = @excel_app.Workbooks(basename) rescue nil
+          if open_workbook == nil then
+            File.delete(file) 
+          else
+            raise ExcelErrorSave, "book is open and used in Excel"
+          end
         when :excel 
           old_displayalerts = @excel_app.DisplayAlerts  # :nodoc:
           @excel_app.DisplayAlerts = true  # :nodoc:
@@ -285,23 +288,23 @@ module RobustExcelOle
 
 end
 
-class ExcelUserCanceled < RuntimeError
+class ExcelUserCanceled < RuntimeError # :nodoc: #
 end
 
-class ExcelError < RuntimeError
+class ExcelError < RuntimeError    # :nodoc: #
 end
 
-class ExcelErrorSave < ExcelError
+class ExcelErrorSave < ExcelError   # :nodoc: #
 end
 
-class ExcelErrorSaveFailed < ExcelErrorSave  
+class ExcelErrorSaveFailed < ExcelErrorSave  # :nodoc: #
 end
 
-class ExcelErrorSaveUnknown < ExcelErrorSave  
+class ExcelErrorSaveUnknown < ExcelErrorSave  # :nodoc: #
 end
 
-class ExcelErrorOpen < ExcelError
+class ExcelErrorOpen < ExcelError   # :nodoc: #
 end
 
-class ExcelErrorClose < ExcelError
+class ExcelErrorClose < ExcelError    # :nodoc: #
 end

data/lib/robust_excel_ole/excel_app.rb

@@ -58,9 +58,9 @@ module RobustExcelOle
         #trc_info :obj_Parent, o.Parent rescue nil
         begin
           o.ole_free
-          puts "olefree OK"
+          #puts "olefree OK"
         rescue
-          puts "olefree_error: #{$!}"
+          #puts "olefree_error: #{$!}"
           #puts $!.backtrace.first(9).join "\n"
         end
       end

data/lib/robust_excel_ole/version.rb

@@ -1,3 +1,3 @@
 module RobustExcelOle
-  VERSION = "0.2.0.5"
+  VERSION = "0.2.0.6"
 end

data/spec/book_spec.rb

@@ -10,7 +10,7 @@ describe RobustExcelOle::Book do
 
   before(:all) do
     excel_app = RobustExcelOle::ExcelApp.new(:reuse => true)
-    open_books = excel_app == nil ? 0 : excel_app.Workbooks.Count 
+    open_books = excel_app == nil ? 0 : excel_app.Workbooks.Count
     puts "*** open books *** : #{open_books}" if open_books > 0
     RobustExcelOle::ExcelApp.close_all
   end
@@ -156,7 +156,7 @@ describe RobustExcelOle::Book do
             it "should belong to the same Excel application" do
               @new_book.excel_app.should == @book.excel_app
               @different_book.excel_app.should == @book.excel_app
-            end     
+            end
           end
         end
       end
@@ -166,7 +166,7 @@ describe RobustExcelOle::Book do
         before do
           @book = RobustExcelOle::Book.open(@simple_file)
           @sheet = @book[0]
-          @book.add_sheet(@sheet, :as => 'copyed_name')
+          @book.add_sheet(@sheet, :as => 'a_name')
         end
 
         after do
@@ -207,7 +207,7 @@ describe RobustExcelOle::Book do
 
           it "should open the new book and close the unsaved book, if user answers 'yes'" do
             # "Yes" is the  default. --> language independent
-            @key_sender.puts "{enter}" 
+            @key_sender.puts "{enter}"
             @new_book = RobustExcelOle::Book.open(@simple_file, :if_unsaved => :excel)
             @book.should_not be_alive
             @new_book.should be_alive
@@ -258,7 +258,7 @@ describe RobustExcelOle::Book do
         simple_file_other_path = @dir + '/more_data/simple.xls'
         @book = RobustExcelOle::Book.open(simple_file_other_path)
         @sheet = @book[0]
-        @book.add_sheet(@sheet, :as => 'copyed_name')
+        @book.add_sheet(@sheet, :as => 'a_name')
       end
 
       after do
@@ -322,17 +322,35 @@ describe RobustExcelOle::Book do
 
       it "should close book" do
         expect{
-          @book.close  
-        }.to_not raise_error   
-        @book.should_not be_alive    
+          @book.close
+        }.to_not raise_error
+        @book.should_not be_alive
+      end
+    end
+
+    context "with unsaved book and with :read_only" do
+      before do
+        @book = RobustExcelOle::Book.open(@simple_file, :read_only => true)
+        @sheet_count = @book.workbook.Worksheets.Count
+        @book.add_sheet(@sheet, :as => 'a_name')
+      end
+
+      it "should close the unsaved book without error and without saving" do
+        expect{
+          @book.close
+          }.to_not raise_error
+        new_book = RobustExcelOle::Book.open(@simple_file)
+        new_book.workbook.Worksheets.Count.should ==  @sheet_count
+        new_book.close
       end
+
     end
 
     context "with unsaved book" do
       before do
         @book = RobustExcelOle::Book.open(@simple_file)
         @sheet_count = @book.workbook.Worksheets.Count
-        @book.add_sheet(@sheet, :as => 'copyed_name')
+        @book.add_sheet(@sheet, :as => 'a_name')
         @sheet = @book[0]
       end
 
@@ -397,7 +415,7 @@ describe RobustExcelOle::Book do
             # "Yes" is the  default. "No" is right of "Yes", "Cancel" is right of "No" --> language independent
             @key_sender.puts  "{right}" * position + "{enter}"
             ole_workbook = @book.workbook
-            excel_app = @book.excel_app 
+            excel_app = @book.excel_app
             displayalert_value = @book.excel_app.DisplayAlerts
             if answer == :cancel then
               expect {
@@ -440,11 +458,11 @@ describe RobustExcelOle::Book do
   end
 
   describe "save" do
-    
+
     context "with simple save" do
       it "should save for a file opened without :read_only" do
         @book = RobustExcelOle::Book.open(@simple_file)
-        @book.add_sheet(@sheet, :as => 'copyed_name')
+        @book.add_sheet(@sheet, :as => 'a_name')
         @new_sheet_count = @book.workbook.Worksheets.Count
         expect {
           @book.save
@@ -457,8 +475,7 @@ describe RobustExcelOle::Book do
         @book = RobustExcelOle::Book.open(@simple_file, :read_only => true)
         expect {
           @book.save
-        }.to raise_error(IOError,
-                     "Not opened for writing(open with :read_only option)")
+        }.to raise_error(ExcelErrorSave, "Not opened for writing (opened with :read_only option)")
         @book.close
       end
     end
@@ -527,6 +544,17 @@ describe RobustExcelOle::Book do
           @book.close
         end
 
+        it "should raise an error if the book is open" do
+          File.delete @simple_save_file rescue nil
+          FileUtils.copy @simple_file, @simple_save_file
+          # fails with :reuse => false
+          book_save = RobustExcelOle::Book.open(@simple_save_file, :reuse => false)
+          expect{
+            @book.save_as(@simple_save_file, :if_exists => :overwrite)
+            }.to raise_error(ExcelErrorSave, "book is open and used in Excel")
+          book_save.close
+        end
+
         it "should save to simple_save_file.xls with :if_exists => :overwrite" do
           File.delete @simple_save_file rescue nil
           File.open(@simple_save_file,"w") do | file |
@@ -621,7 +649,6 @@ describe RobustExcelOle::Book do
             @book.excel_app.DisplayAlerts.should == displayalert_value
           end
 
-
         end
 
         it "should save to 'simple_save_file.xls' with :if_exists => nil" do
@@ -658,12 +685,12 @@ describe RobustExcelOle::Book do
       end
 
       after do
-        @book.close 
+        @book.close
       end
 
       it "should return right absoute path name" do
         @book.absolute_path(@simple_file).gsub("\\","/").should == @book.filename
-      end 
+      end
     end
 
     context "with alive?" do
@@ -673,7 +700,7 @@ describe RobustExcelOle::Book do
       end
 
       after do
-        @book.close 
+        @book.close
       end
 
       it "should return true, if book is alive" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: robust_excel_ole
 version: !ruby/object:Gem::Version 
-  hash: 85
+  hash: 83
   prerelease: false
   segments: 
   - 0
   - 2
   - 0
-  - 5
-  version: 0.2.0.5
+  - 6
+  version: 0.2.0.6
 platform: ruby
 authors: 
 - traths
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-09-25 00:00:00 +02:00
+date: 2014-09-28 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -132,6 +132,11 @@ files:
 - LICENSE
 - README.rdoc
 - Rakefile
+- examples/example1.rb
+- examples/example2.rb
+- examples/example3.rb
+- examples/example4.rb
+- examples/example5.rb
 - lib/robust_excel_ole.rb
 - lib/robust_excel_ole/book.rb
 - lib/robust_excel_ole/cell.rb