roart 0.1.6 → 0.1.7

data/History.txt

@@ -1,3 +1,6 @@
+==0.1.7 / 2010-30-11
+Added some new error classes, add removed any extraneous raise 'text' (via jrbingham)
+
 ==0.1.6 / 2010-03-09
 Updated the search feature to pull all the ticket information at the same time, instead of only loading the id and subject.
 Fixed tests that were failing because of out-of-order strings.

data/lib/roart.rb

@@ -2,7 +2,7 @@ require 'rubygems'
 module Roart
 
   # :stopdoc:
-  VERSION = '0.1.6'
+  VERSION = '0.1.7'
   LIBPATH = ::File.expand_path(::File.dirname(__FILE__)) + ::File::SEPARATOR
   PATH = ::File.dirname(LIBPATH) + ::File::SEPARATOR
   # :startdoc:

data/lib/roart/connection.rb

@@ -16,7 +16,7 @@ module Roart
 
     def initialize(conf)
       if conf.is_a?(String)
-        raise "Loading Config File not yet implemented"
+        raise RoartError, "Loading Config File not yet implemented"
       elsif conf.class.name == Hash.name #TODO: Figure out why conf.is_a?(Hash) doesn't work
         @conf = conf
       end
@@ -25,7 +25,7 @@ module Roart
         add_methods!
         @connection = ConnectionAdapter.new(@conf)
       else
-        raise "Configuration Error"
+        raise RoartError, "Configuration Error"
       end
     end
 

data/lib/roart/errors.rb

@@ -8,4 +8,6 @@ module Roart
   
   class TicketSystemInterfaceError < RoartError; end
   
+  class TicketNotFoundError < RoartError; end
+  
 end

data/lib/roart/ticket.rb

@@ -65,16 +65,12 @@ module Roart
         payload.delete("text")
         payload.delete("id") # Can't have text in an update, only create, use comment for updateing
         payload = payload.to_content_format
-        puts payload
         resp = self.class.connection.post(uri, :content => payload)
-        puts resp
         resp = resp.split("\n")
-        raise "Ticket Update Failed" unless resp.first.include?("200")
+        raise TicketSystemError, "Ticket Update Failed" unless resp.first.include?("200")
         resp.each do |line|
-          puts "line"
           if line.match(/^# Ticket (\d+) updated./)
             self.after_update
-            puts "FOUND"
             return true
           else
             #TODO: Add warnign to ticket
@@ -95,14 +91,14 @@ module Roart
       payload = comment.to_content_format
       resp = self.class.connection.post(uri, :content => payload)
       resp = resp.split("\n")
-      raise "Ticket Comment Failed" unless resp.first.include?("200")
+      raise TicketSystemError, "Ticket Comment Failed" unless resp.first.include?("200")
       !!resp[2].match(/^# Message recorded/)
     end
 
     # works just like save, but if the save fails, it raises an exception instead of silently returning false
     #
     def save!
-      raise "Ticket Create Failed" unless self.save
+      raise TicketSystemError, "Ticket Create Failed" unless self.save
       true
     end
 
@@ -118,7 +114,7 @@ module Roart
         payload = @attributes.to_content_format
         resp = self.class.connection.post(uri, :content => payload)
         resp = resp.split("\n")
-        raise "Ticket Create Failed" unless resp.first.include?("200")
+        raise TicketSystemError, "Ticket Create Failed" unless resp.first.include?("200")
         resp.each do |line|
           if tid = line.match(/^# Ticket (\d+) created./)
             @attributes[:id] = tid[1].to_i
@@ -133,7 +129,7 @@ module Roart
       end
 
       def create! #:nodoc:
-        raise "Ticket Create Failed" unless self.create
+        raise TicketSystemError, "Ticket Create Failed" unless self.create
         true
       end
 
@@ -273,7 +269,7 @@ module Roart
       end
 
       def find_by_ids(args, options) #:nodoc:
-        raise "First argument must be :all or :first, or an ID with no hash options" unless args.first.is_a?(Fixnum) || args.first.is_a?(String)
+        raise ArgumentError, "First argument must be :all or :first, or an ID with no hash options" unless args.first.is_a?(Fixnum) || args.first.is_a?(String)
         get_ticket_by_id(args.first)
       end
 
@@ -292,7 +288,7 @@ module Roart
 
       def page_list_array(uri) #:nodoc:
         page = self.connection.get(uri)
-        raise TicketSystemError, "Can't get ticket." unless page
+        raise TicketSystemInterfaceError, "Can't get ticket." unless page
         page = page.split("\n")
         status = page.delete_at(0)
         if status.include?("200")

data/lib/roart/ticket_page.rb

@@ -7,6 +7,7 @@ module Roart
     def to_hash
       hash = HashWithIndifferentAccess.new
       self.delete_if{|x| !x.include?(":")}
+      raise TicketNotFoundError, "No tickets matching search criteria found." if self.size == 0
       self.each do |ln|
         ln = ln.split(":")
         key = nil
@@ -35,6 +36,7 @@ module Roart
     def to_search_array
       array = Array.new
       self.delete_if{|x| !x.include?(":")}
+      raise TicketNotFoundError, "No tickets matching search criteria found." if self.size == 0
       self.each do |ln|
         hash = Hash.new
         ln = ln.split(":")

data/roart.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{roart}
-  s.version = "0.1.6"
+  s.version = "0.1.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["PJ Davis"]
-  s.date = %q{2010-03-09}
+  s.date = %q{2010-03-11}
   s.description = %q{Interface for working with Request Tracker (RT) tickets inspired by ActiveRecord.}
   s.email = %q{pj.davis@gmail.com}
   s.extra_rdoc_files = ["History.txt", "README.rdoc", "spec/test_data/full_history.txt", "spec/test_data/search_ticket.txt", "spec/test_data/single_history.txt", "spec/test_data/ticket.txt"]

data/spec/roart/ticket_spec.rb

@@ -405,7 +405,7 @@ describe "Ticket" do
         @mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/1/edit', {:content => @post_data}).and_return("RT/3.6.6 400 Not OK\n\n# U's A SUKKA, FOO!.")
         ticket = Roart::Ticket.send(:instantiate, @payload.update(:id => 1))
         ticket.subject = 'An Old Ticket'
-        lambda {ticket.save}.should raise_error
+        lambda {ticket.save}.should raise_error(Roart::TicketSystemError)
       end
       
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: roart
 version: !ruby/object:Gem::Version 
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors: 
 - PJ Davis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-09 00:00:00 -06:00
+date: 2010-03-11 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency