roart 0.1.9 → 0.1.10

data/History.txt

@@ -1,3 +1,5 @@
+==0.1.10 / 2010-10-07
+Fix creation of tickets with fields containing new lines (via hennk)
 ==0.1.9 / 2010-05-23
 Removed the String/Hash extensions copied from ActiveSupport and just added a dependency on ActiveSupport. Removed to_hash added to Array, as it conflicts with ActiveSupport's deep_merge. (via hennk)
 ==0.1.8 / 2010-03-16

data/lib/roart.rb

@@ -5,7 +5,7 @@ require 'active_support/core_ext'
 module Roart
 
   # :stopdoc:
-  VERSION = '0.1.9'
+  VERSION = '0.1.10'
   LIBPATH = ::File.expand_path(::File.dirname(__FILE__)) + ::File::SEPARATOR
   PATH = ::File.dirname(LIBPATH) + ::File::SEPARATOR
   # :startdoc:

data/lib/roart/core/content_formatter.rb

@@ -0,0 +1,12 @@
+module Roart
+  class ContentFormatter
+    # The following is only based on quick trial&error on my part. The RT Api (at least in 3.6) does not have good documentation.
+    # Strings in a RT request:
+    #  - are not allowed to contain '\r'
+    #  - must use equally padded new-lines to distinguish them from the beginning of a new field (we use 2-space padding)
+    def self.format_string(string)
+      string.gsub("\r", '').gsub("\n", "\n  ")
+    end
+
+  end
+end

data/lib/roart/core/hash.rb

@@ -2,6 +2,7 @@ class Hash
   def to_content_format
     fields = self.map do |key,value|
       unless value.nil?
+        value = Roart::ContentFormatter.format_string(value.to_s)
         if key.to_s.match(/^cf_.+/)
           "CF-#{key.to_s[3..key.to_s.length].gsub(/_/, " ").camelize.humanize}: #{value}"
         else

data/roart.gemspec

@@ -2,15 +2,15 @@
 
 Gem::Specification.new do |s|
   s.name = %q{roart}
-  s.version = "0.1.9"
+  s.version = "0.1.10"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["PJ Davis"]
-  s.date = %q{2010-09-15}
+  s.date = %q{2010-10-07}
   s.description = %q{Interface for working with Request Tracker (RT) tickets inspired by ActiveRecord.}
   s.email = %q{pj.davis@gmail.com}
   s.extra_rdoc_files = ["History.txt", "README.rdoc", "spec/test_data/full_history.txt", "spec/test_data/search_ticket.txt", "spec/test_data/single_history.txt", "spec/test_data/ticket.txt"]
-  s.files = ["History.txt", "README.rdoc", "Rakefile", "lib/roart.rb", "lib/roart/callbacks.rb", "lib/roart/connection.rb", "lib/roart/connection_adapter.rb", "lib/roart/connection_adapters/mechanize_adapter.rb", "lib/roart/core/hash.rb", "lib/roart/errors.rb", "lib/roart/history.rb", "lib/roart/roart.rb", "lib/roart/ticket.rb", "lib/roart/ticket_page.rb", "lib/roart/validations.rb", "roart.gemspec", "spec/roart/callbacks_spec.rb", "spec/roart/connection_adapter_spec.rb", "spec/roart/connection_spec.rb", "spec/roart/core/hash_spec.rb", "spec/roart/history_spec.rb", "spec/roart/roart_spec.rb", "spec/roart/ticket_page_spec.rb", "spec/roart/ticket_spec.rb", "spec/roart/validation_spec.rb", "spec/roart_spec.rb", "spec/spec_helper.rb", "spec/test_data/full_history.txt", "spec/test_data/search_ticket.txt", "spec/test_data/single_history.txt", "spec/test_data/ticket.txt"]
+  s.files = ["History.txt", "README.rdoc", "Rakefile", "lib/roart.rb", "lib/roart/callbacks.rb", "lib/roart/connection.rb", "lib/roart/connection_adapter.rb", "lib/roart/connection_adapters/mechanize_adapter.rb", "lib/roart/core/content_formatter.rb", "lib/roart/core/hash.rb", "lib/roart/errors.rb", "lib/roart/history.rb", "lib/roart/roart.rb", "lib/roart/ticket.rb", "lib/roart/ticket_page.rb", "lib/roart/validations.rb", "roart.gemspec", "spec/roart/callbacks_spec.rb", "spec/roart/connection_adapter_spec.rb", "spec/roart/connection_spec.rb", "spec/roart/core/content_formatter_spec.rb", "spec/roart/core/hash_spec.rb", "spec/roart/history_spec.rb", "spec/roart/roart_spec.rb", "spec/roart/ticket_page_spec.rb", "spec/roart/ticket_spec.rb", "spec/roart/validation_spec.rb", "spec/roart_spec.rb", "spec/spec_helper.rb", "spec/test_data/full_history.txt", "spec/test_data/search_ticket.txt", "spec/test_data/single_history.txt", "spec/test_data/ticket.txt"]
   s.homepage = %q{http://github.com/pjdavis/roart}
   s.rdoc_options = ["--main", "README.rdoc"]
   s.require_paths = ["lib"]

data/spec/roart/core/content_formatter_spec.rb

@@ -0,0 +1,23 @@
+require File.join(File.dirname(__FILE__), %w[ .. .. spec_helper])
+
+describe 'content formatter' do
+  before do
+    @formatter = Roart::ContentFormatter
+  end
+
+  describe 'formatting strings' do
+    it "should remove \\r characters" do
+      @formatter.format_string("a\r\ntext with\ndifferent\rnew\r\nlines").should_not include("\r")
+    end
+
+    it "should pad new lines with 2 spaces" do
+      @formatter.format_string("a\ntext with\n\ndifferent\nnew\n  \nlines").should == "a\n" +
+                                                                                      "  text with\n" +
+                                                                                      "  \n" +
+                                                                                      "  different\n" +
+                                                                                      "  new\n" +
+                                                                                      "    \n" +
+                                                                                      "  lines"
+    end
+  end
+end

data/spec/roart/core/hash_spec.rb

@@ -12,5 +12,11 @@ describe 'hash extentions' do
     payload = {:cf_stuff => 'field'}
     payload.to_content_format.should == "CF-Stuff: field"
   end
-  
+
+  it 'should use our content formatter for strings' do
+    payload = {:subject => 'A new ticket', :queue => 'My queue', :text => "A text"}
+    Roart::ContentFormatter.should_receive(:format_string).at_least(:once)
+    payload.to_content_format
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: roart
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 15
   prerelease: false
   segments: 
   - 0
   - 1
-  - 9
-  version: 0.1.9
+  - 10
+  version: 0.1.10
 platform: ruby
 authors: 
 - PJ Davis
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-15 00:00:00 -05:00
+date: 2010-10-07 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -72,6 +72,7 @@ files:
 - lib/roart/connection.rb
 - lib/roart/connection_adapter.rb
 - lib/roart/connection_adapters/mechanize_adapter.rb
+- lib/roart/core/content_formatter.rb
 - lib/roart/core/hash.rb
 - lib/roart/errors.rb
 - lib/roart/history.rb
@@ -83,6 +84,7 @@ files:
 - spec/roart/callbacks_spec.rb
 - spec/roart/connection_adapter_spec.rb
 - spec/roart/connection_spec.rb
+- spec/roart/core/content_formatter_spec.rb
 - spec/roart/core/hash_spec.rb
 - spec/roart/history_spec.rb
 - spec/roart/roart_spec.rb