roar 0.11.1 → 0.11.2

data/CHANGES.markdown

@@ -1,3 +1,7 @@
+## 0.11.2
+
+* The request body in POST, PUT and PATCH is now actually sent in HttpVerbs. Thanks to @nleguen for finding this embarrassing bug. That's what happens when you don't have proper tests, kids!
+
 ## 0.11.1
 
 * Since some users don't have access to my local hard-drive we now really require representable-1.2.2.

data/lib/roar/representer/transport/net_http.rb

@@ -13,15 +13,15 @@ module Roar
         end
         
         def post_uri(uri, body, as)
-          do_request(Net::HTTP::Post, uri, as)
+          do_request(Net::HTTP::Post, uri, as, body)
         end
         
         def put_uri(uri, body, as)
-          do_request(Net::HTTP::Put, uri, as)
+          do_request(Net::HTTP::Put, uri, as, body)
         end
         
         def patch_uri(uri, body, as)
-          do_request(Net::HTTP::Patch, uri, as)
+          do_request(Net::HTTP::Patch, uri, as, body)
         end
         
         def delete_uri(uri, as)

data/lib/roar/version.rb

@@ -1,3 +1,3 @@
 module Roar
-  VERSION = "0.11.1"
+  VERSION = "0.11.2"
 end

data/test/fake_server.rb

@@ -1,10 +1,34 @@
 require "bundler/setup"
-require 'sinatra/base'
+require "sinatra/base"
+require "roar/representer/json"
 
 class FakeServer < Sinatra::Base
-
   set :raise_errors, false
 
+  module BandRepresenter
+    include Roar::Representer::JSON
+    
+    property :name
+    property :label
+  end
+  
+  class Band
+    attr_reader :name, :label
+    
+    def name=(value)
+      @name = value.upcase
+    end
+    
+    def label=(value)
+      @label = value.upcase
+    end
+  end
+  
+  def consume_band
+    Band.new.extend(BandRepresenter).from_json(request.body.string)
+  end
+  
+  
   get "/method" do
     "<method>get</method>"
   end
@@ -31,19 +55,20 @@ class FakeServer < Sinatra::Base
 
   post "/bands" do
     #if request.content_type =~ /xml/
-    body  '{"label": "n/a", "name": "Strung Out", "links": [{"href":"http://search", "rel": "search"}, {"href":"http://band/strungout", "rel": "self"}]}'
+    body consume_band.to_json
+    
     status 201
   end
   
   put "/bands/strungout" do
     # DISCUSS: as long as we don't agree on what to return in PUT/PATCH, let's return an updated document.
-    {:name => "Strung Out", :label => "Fat Wreck"}.to_json
+    body consume_band.to_json
     #status 204
   end
 
   patch '/bands/strungout' do
     # DISCUSS: as long as we don't agree on what to return in PUT/PATCH, let's return an updated document.
-    {:name => 'Strung Out', :label => 'Fat Mike'}.to_json
+    body consume_band.to_json
     #status 204
   end
 
@@ -54,40 +79,4 @@ class FakeServer < Sinatra::Base
   delete '/banks/metallica' do
     status 204
   end
-
-  require './test/order_representers'
-  JSON::Order.class_eval do
-    def items_url
-      "http://roar.example.com/orders/1/items"
-    end
-    def order_url(order)
-      "http://roar.example.com/orders/#{order}"
-    end
-    def represented
-      1
-    end
-    
-  end
-  
-  
-  post "/orders" do
-    incoming = JSON::Order.deserialize(request.body.string)
-    # create new record
-    
-    # render new record
-    
-    JSON::Order.from_attributes(incoming.to_attributes).serialize
-  end
-  
-  post "/orders/1/items" do
-    incoming = JSON::Item.deserialize(request.body.string)
-    
-    JSON::Item.from_attributes(incoming.to_attributes).serialize
-  end
-  
-  get "/orders/1" do
-    JSON::Order.new(:client_id => 1, :items => [JSON::Item.new(:article_id => "666-S", :amount => 1)]).serialize
-  end
-  
 end
-

data/test/http_verbs_feature_test.rb

@@ -3,12 +3,7 @@ require 'roar/representer/feature/http_verbs'
 require 'roar/representer/json'
 
 class HttpVerbsTest < MiniTest::Spec
-  module BandRepresenter
-    include Roar::Representer::JSON
-    
-    property :name
-    property :label
-  end
+  BandRepresenter = FakeServer::BandRepresenter
   
   # keep this class clear of Roar modules.
   class Band
@@ -80,8 +75,8 @@ class HttpVerbsTest < MiniTest::Spec
         assert_equal nil, @band.label
         
         @band.post("http://roar.example.com/bands", "application/xml")
-        assert_equal "Strung Out", @band.name
-        assert_equal "n/a", @band.label
+        assert_equal "STRUNG OUT", @band.name
+        assert_equal nil, @band.label
       end
     end
     
@@ -90,8 +85,8 @@ class HttpVerbsTest < MiniTest::Spec
         @band.name   = "Strung Out"
         @band.label  = "Fat Wreck"
         @band.put("http://roar.example.com/bands/strungout", "application/xml")
-        assert_equal "Strung Out", @band.name
-        assert_equal "Fat Wreck", @band.label
+        assert_equal "STRUNG OUT", @band.name
+        assert_equal "FAT WRECK", @band.label
       end
     end
     
@@ -99,7 +94,7 @@ class HttpVerbsTest < MiniTest::Spec
       it 'does something' do
         @band.label  = 'Fat Mike'
         @band.patch("http://roar.example.com/bands/strungout", "application/xml")
-        assert_equal 'Fat Mike', @band.label
+        assert_equal 'FAT MIKE', @band.label
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: roar
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.11.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-05 00:00:00.000000000 Z
+date: 2012-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable