rma-payment-gateway 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc31ce3ef352488d411e27123665afbe880004be3ae232e18c021e25d2221d87
-  data.tar.gz: 52aaece35817e948239e8a7d7f8184fce8715e928508c8996f310616ab711dfa
+  metadata.gz: 7e2093f132f0620f9d9455eae15c1d2b4b2a7eb31fc4cfab608fe0244683c50b
+  data.tar.gz: e62e9cef18f17683d4eb208f56dc09ca8d3991fa7ce7471f73dc93672d6854b0
 SHA512:
-  metadata.gz: fc2689e5f19f3e9a92b7261f529071d3b55cf3cc55e0e9269dce09b267a0e94bb57f083a97e43875001214e37088197df9422f7aad15354d13aac99b48be0912
-  data.tar.gz: 5aa1c1f656d85fd7b5734340910e5e77094f461aace32e70679a3dedd162ad458cc1fb035358b0496ae5c7c30970fa9585da2a3a570dca0b12bd863c0bfc8775
+  metadata.gz: '0699e0a7456ca06ebac7a52e187b58aab1cab83ebf0cf835c10d78aa6d42891fba070094ade6ddc3d46b91d3780dd4a50783ae77fa8b83e250250a90bd3fb956'
+  data.tar.gz: '088a8cc8091ddbbde76bf65ea34ed473e6f51a4f4a64aedbb7d0b26801a70f20a21e5cc74c24c2091d4aad87bf297e4469a0cf231838435ef3c57d20463e6f42'

data/lib/rma/payment/gateway/account_inquiry.rb

@@ -33,7 +33,7 @@ module Rma
 
           validate_account_inquiry_response!(response)
 
-          response["result"]
+          response
         rescue StandardError => e
           raise AuthenticationError, "Failed to fetch account inquiry: #{e.message}"
         end
@@ -51,15 +51,10 @@ module Rma
         end
 
         def validate_account_inquiry_response!(response)
-          unless response.is_a?(Hash) && response["result"]["bfs_responseCode"] == "00"
-            error_detail = response["result"]["bfs_responseDesc"] || "Unknown error"
+          unless response.is_a?(Hash) && response["bfs_responseCode"] == "00"
+            error_detail = response["bfs_responseDesc"] || "Unknown error"
             raise AuthenticationError, "Account inquiry failed: #{error_detail}"
           end
-
-          # :nocov:
-          return if response["result"]
-          raise AuthenticationError, "No response data in response"
-          # :nocov:
         end
       end
     end

data/lib/rma/payment/gateway/authorization.rb

@@ -32,7 +32,7 @@ module Rma
 
           validate_authorization_response!(response)
 
-          response["result"]
+          response
         rescue StandardError => e
           raise AuthenticationError, "Failed to authorize: #{e.message}"
         end
@@ -62,15 +62,10 @@ module Rma
         end
 
         def validate_authorization_response!(response)
-          unless response.is_a?(Hash) && response["result"]["bfs_responseCode"] == "00"
-            error_detail = response["result"]["bfs_responseDesc"] || "Unknown error"
+          unless response.is_a?(Hash) && response["bfs_responseCode"] == "00"
+            error_detail = response["bfs_responseDesc"] || "Unknown error"
             raise AuthenticationError, "Authorization failed: #{error_detail}"
           end
-
-          # :nocov:
-          return if response["result"]
-          raise AuthenticationError, "No response data in response"
-          # :nocov:
         end
       end
     end

data/lib/rma/payment/gateway/client.rb

@@ -2,6 +2,7 @@
 
 require "faraday"
 require "json"
+require "openssl"
 
 module Rma
   module Payment
@@ -17,13 +18,17 @@ module Rma
       #
       # @param config [Rma::Payment::Gateway::Configuration] Configuration instance
       class Client
-        attr_reader :config, :access_token, :private_key
+        attr_reader :config, :access_token
 
         def initialize(config = nil)
           @config = config || Rma::Payment::Gateway.configuration
           validate_configuration!
         end
 
+        def private_key
+          @private_key ||= load_private_key
+        end
+
         # Authorization methods
         def authorization
           @authorization ||= Authorization.new(self)
@@ -41,7 +46,8 @@ module Rma
 
         # HTTP request methods
         def post(body: {}, headers: {})
-          request(:post, body: body, headers: headers)
+          signed = body.empty? ? body : body.merge(bfs_checkSum: compute_checksum(body))
+          request(:post, body: signed, headers: headers)
         end
 
         def get(headers: {})
@@ -50,6 +56,23 @@ module Rma
 
         private
 
+        def compute_checksum(params)
+          sorted_values = params.sort_by { |k, _| k }.to_h.values.join("|")
+          signature = private_key.sign(OpenSSL::Digest.new("SHA1"), sorted_values)
+          signature.unpack1("H*")&.upcase
+        end
+
+        def load_private_key
+          key_content = if !config.rsa_key_path.to_s.strip.empty?
+                          File.read(config.rsa_key_path)
+                        else
+                          config.rsa_key
+                        end
+          OpenSSL::PKey::RSA.new(key_content)
+        rescue OpenSSL::PKey::RSAError => e
+          raise ConfigurationError, "Invalid RSA key: #{e.message}"
+        end
+
         def validate_configuration!
           raise ConfigurationError, "Configuration is required" if config.nil?
           return if config.valid?
@@ -99,13 +122,13 @@ module Rma
 
         def handle_client_error(response)
           body = parse_body(response.body) || {}
-          error_message = body.dig("result", "bfs_responseDesc") || "Client error"
+          error_message = body["bfs_responseDesc"] || "Client error"
           raise InvalidParameterError, error_message
         end
 
         def handle_server_error(response)
           body = parse_body(response.body) || {}
-          error_message = body.dig("result", "bfs_responseDesc") || "Server error"
+          error_message = body["bfs_responseDesc"] || "Server error"
           raise APIError, error_message
         end
 

data/lib/rma/payment/gateway/debit_request.rb

@@ -30,7 +30,7 @@ module Rma
 
           validate_debit_request_response!(response)
 
-          response["result"]
+          response
         rescue StandardError => e
           raise AuthenticationError, "Failed to fetch debit request: #{e.message}"
         end
@@ -47,15 +47,10 @@ module Rma
         end
 
         def validate_debit_request_response!(response)
-          unless response.is_a?(Hash) && response["result"]["bfs_responseCode"] == "00"
-            error_detail = response["result"]["bfs_responseDesc"] || "Unknown error"
+          unless response.is_a?(Hash) && response["bfs_responseCode"] == "00"
+            error_detail = response["bfs_responseDesc"] || "Unknown error"
             raise AuthenticationError, "Debit request failed: #{error_detail}"
           end
-
-          # :nocov:
-          return if response["result"]
-          raise AuthenticationError, "No response data in response"
-          # :nocov:
         end
       end
     end

data/lib/rma/payment/gateway/version.rb

@@ -3,7 +3,7 @@
 module Rma
   module Payment
     module Gateway
-      VERSION = "1.0.2"
+      VERSION = "1.0.3"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rma-payment-gateway
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Tashi Dendup