risbn 0.3.0 → 0.4.0

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.4.0

data/lib/risbn/gdata.rb

@@ -44,7 +44,7 @@ class RISBN
     # returns an openstruct with a massaged version of the original xml data.
     def data
       return @data if @data
-      h, data = to_hash, OpenStruct.new
+      h, data = to_hash, BookData.new
 
       data.creator       = h[:creator]
       data.date          = h[:date]
@@ -74,6 +74,15 @@ class RISBN
       @data = data
     end
 
+    class BookData < OpenStruct
+      def to_hash
+        @table.dup
+      end
+
+      def keys
+        @table.keys
+      end
+    end
   end
 end
 

data/lib/risbn/version.rb

@@ -1,3 +1,3 @@
 class RISBN
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/risbn.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{risbn}
-  s.version = "0.3.0"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Emmanuel Oga"]

data/spec/gdata_spec.rb

@@ -16,23 +16,28 @@ describe RISBN::GData do
     expect { RISBN::GData(RISBN("6660596101992")) }.to raise_exception(RISBN::InvalidISBN)
   end
 
-  context "retrieving gdata" do
-    before do
-      @isbn = RISBN("9780596101992")
-      @isbn.gdata.stub!(:xml).and_return(File.read(GDATA_FIXTURE_PATH))
-    end
+  context "#data" do
+    let(:isbn) { RISBN("9780596101992") }
+    before     { isbn.gdata.stub!(:xml).and_return(File.read(GDATA_FIXTURE_PATH)) }
 
-    it "returns an OpenStruct" do
-      @isbn.gdata.data.should be_an_instance_of(OpenStruct)
+    let(:required_keys) do
+      more = [:open_access, :rating_max, :rating_min, :thumbnail_url,
+              :info_url, :annotation_url, :alternate_url, :self_url]
+      isbn.gdata.to_hash.keys.uniq - [:link, :openAccess] + more
     end
 
-    it "maps the attributes of the hash form of google response to an struct" do
-      additional_keys = [:open_access, :rating_max, :rating_min, :thumbnail_url,
-        :info_url, :annotation_url, :alternate_url, :self_url]
+    subject { isbn.gdata.data }
+
+    it { should be_an_instance_of(RISBN::GData::BookData) }
+
+    it "maps the attributes of the hash form of the google response to an struct" do
+      required_keys.each { |key| should respond_to(key) }
+    end
 
-      ( @isbn.gdata.to_hash.keys.uniq - [:link, :openAccess] + additional_keys).each do |key|
-        @isbn.gdata.data.should respond_to(key)
-      end
+    it "is able to convert the struct to a hash and return its keys" do
+      isbn.gdata.data.to_hash.should  be_an_instance_of(Hash)
+      isbn.gdata.data.keys.should     be_an_instance_of(Array)
+      isbn.gdata.data.keys.should_not be_empty
     end
   end
 end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Emmanuel Oga