riq 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd6bba86a2ba09b2838876cd6f8d979f0733637b
-  data.tar.gz: 9395c9de8e2aebecae9b0e70aeeae5adb408aa24
+  metadata.gz: 6136c5fd54ce8c3defd3fa0fbae6a8f2084ebbc5
+  data.tar.gz: ed279d5a24bdda5b71410e40df1e04f8ed209ca9
 SHA512:
-  metadata.gz: d94a8868d52a52cda09b076963179f8de1b79b8634c825f1944abb9b67a74e0dc7bf0ffd1e69e1d3c5a279215295057fc881937b023a562b33c22ea1a4dad3db
-  data.tar.gz: 2cdbc60e04c4ae047ef23469a1bae43198a06c9fca90ffadfa704c7deb193aab8b367c8619fdfbf6bfe71f5cf8447ea16369b8e7ab5959f9c6c5ec72a611a09d
+  metadata.gz: 4a4e64454749eb8f2a69022e1491fce1d3ea9ac0a0608e1cb04c675b379c103e3cacf7e6fa95ddc4f2ca37bc83c9d9962f37dfa93ffb484f284ea4a44dd6ee75
+  data.tar.gz: c4085e4a073aa080be3edb01831c681599b2851f5601c2360801dbb671481edc26fe99784657987c61f36eb0ae9f78dc8dc94492fd174cc6ce66a704dbe2935c

data/.travis.yml

@@ -3,5 +3,6 @@ rvm:
     # could add more here- what's a good spread?
     - 2.0.0
     - 2.1.2
+    - 2.2.3
 install: bundle install
 script: rake test

data/lib/riq/list_item.rb

@@ -13,17 +13,25 @@ module RIQ
     attr_reader :modified_date
     attr_reader :created_date
 
+    # @example create a list item
+    #   # vanilla
+    #   RIQ::ListItem.new
+    #   # with a list id
+    #   RIQ::ListItem(lid: 'abc123') # OR RIQ.list('abc123').list_item
     def initialize(id = nil, lid: nil)
       if id.is_a? Hash
+        # init with data
         super(id)
-      elsif id.nil? && lid.nil?
+      elsif id.nil?
+        # vanilla object
         super(nil)
-      elsif id.nil? && !lid.nil?
-        super(nil)
-        @list_id = lid
-      elsif id.nil? || lid.nil?
+        # maybe init with lid
+        @list_id = lid unless lid.nil?
+      elsif lid.nil?
+        # has id, but not lid, that's an error
         raise RIQError, 'ObjectID and List ID are required'
       else
+        # grabbing a specific listitem, fetch it
         super("#{lid}/listitems/#{id}")
       end
     end
@@ -115,5 +123,11 @@ module RIQ
       end
       self
     end
+
+    def pre_save
+      if @list_id.nil?
+        raise RIQError, 'List ID is required'
+      end
+    end
   end
 end

data/lib/riq/riq_obj.rb

@@ -60,6 +60,7 @@ module RIQ
 
     # Creates or updates the object
     def save(options = nil)
+      pre_save
       if @id.nil?
         # create
         init(@client.post(node, payload, options: options).symbolize)
@@ -92,6 +93,10 @@ module RIQ
       raise RIQError, 'This should be overwritten'
     end
 
+    def pre_save
+      # do any validation necessary
+    end
+
     # def exists
     #   if @id.nil?
     #     false

data/riq.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'riq'
-  spec.version       = '1.2.1'
+  spec.version       = '1.2.2'
   spec.authors       = ['David Brownman']
   spec.email         = ['david@relateiq.com']
   spec.homepage      = "https://github.com/relateiq/ruby-sdk"

data/test/test_contact.rb

@@ -56,9 +56,9 @@ describe RIQ::Contact do
       begin
         @c.add(:name, {value: 'Jenny'})
       rescue RIQ::RIQError
-        nil.must_be_nil
+        assert(true)
       else
-        1.must_be_nil
+        assert(false)
       end
     end
   end

data/test/test_event.rb

@@ -28,9 +28,9 @@ describe RIQ::Event do
       begin
         @e.save
       rescue RIQ::HTTPError
-        nil.must_be_nil
+        assert(true)
       else
-        1.must_be_nil
+        assert(false)
       end
     end
 
@@ -53,9 +53,9 @@ describe RIQ::Event do
       begin
         @e.add_participant(:blarg, 'bad type')
       rescue RIQ::RIQError
-        nil.must_be_nil
+        assert(true)
       else
-        1.must_be_nil
+        assert(false)
       end
     end
   end

data/test/test_helper.rb

@@ -7,6 +7,7 @@ unless ENV['RIQ_TEST_API_KEY'] && ENV['RIQ_TEST_API_SECRET']
   Dotenv.load
 end
 
+# use directory, not locally installed copy
 require_relative '../lib/riq'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))

data/test/test_list_item.rb

@@ -47,5 +47,16 @@ describe RIQ::ListItem do
 
       @li.field_value(0).wont_equal start
     end
+
+    it 'should fail without a list id' do
+      @li = RIQ::ListItem.new
+      begin
+        @li.save
+      rescue RIQ::RIQError
+        assert(true)
+      else
+        assert(false)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: riq
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - David Brownman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-16 00:00:00.000000000 Z
+date: 2015-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -151,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Ruby RIQ API client