right_support 2.8.34 → 2.8.35

data/VERSION

@@ -1 +1 @@
-2.8.34
+2.8.35

data/lib/right_support/rack/request_logger.rb

@@ -21,6 +21,7 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 require 'logger'
+require 'rack'
 
 module RightSupport::Rack
 
@@ -72,7 +73,7 @@ module RightSupport::Rack
       if env['sinatra.error'] && !env['sinatra.error.handled']
         log_exception(logger, env['sinatra.error'])
       end
-      log_request_end(logger, status, header, began_at) if enabled
+      log_request_end(logger, status, header, body, began_at) if enabled
 
       return [status, header, body]
     rescue Exception => e
@@ -147,22 +148,29 @@ module RightSupport::Rack
     # @param [Time] began_at time of the Rack request beginning
     #
     # @return [TrueClass] always true
-    def log_request_end(logger, status, headers, began_at)
+    def log_request_end(logger, status, headers, body, began_at)
       duration = (Time.now - began_at) * 1000
 
-      content_length = if headers['Content-Length']
-        headers['Content-Length'].to_s
+      # Downcase keys in the headers Hash for case-insensitive comparisons
+      safe_headers = Hash[*headers.map {|k,v| [k.downcase, v]}.flatten]
+
+      content_length = if safe_headers['content-length']
+        safe_headers['content-length']
       else
-        '-'
+        if body.is_a?(Array)
+          body.reduce(0) {|accum, e| accum += e.bytesize}
+        else
+          body.bytesize
+        end
       end
 
       params = [
         duration,
-        status,
-        content_length,
+        "#{status} #{Rack::Utils::HTTP_STATUS_CODES[status]}",
+        content_length.to_s,
       ]
 
-      logger.info %Q{Completed in %dms | %d | %s bytes} % params
+      logger.info %Q{Completed in %dms | %s | %s bytes} % params
     end
 
     # Log exception

data/right_support.gemspec

@@ -2,16 +2,14 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: right_support 2.8.34 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "right_support"
-  s.version = "2.8.34"
+  s.version = "2.8.35"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2014-11-04"
+  s.date = "2014-11-12"
   s.description = "A toolkit of useful, reusable foundation code created by RightScale."
   s.email = "support@rightscale.com"
   s.extra_rdoc_files = [
@@ -148,11 +146,12 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "https://github.com/rightscale/right_support"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.2.0"
+  s.require_paths = ["lib"]
+  s.rubygems_version = "1.8.23"
   s.summary = "Reusable foundation code."
 
   if s.respond_to? :specification_version then
-    s.specification_version = 4
+    s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<rake>, ["~> 10.0"])

data/spec/net/request_balancer_spec.rb

@@ -276,7 +276,7 @@ describe RightSupport::Net::RequestBalancer do
       end
 
       it 'performs an initial resolution' do
-        @balancer.instance_variable_get("@resolved_at").to_f.should be_close(Time.now.to_f, 1.0)
+        @balancer.instance_variable_get("@resolved_at").to_f.should be_within(1.0).of(Time.now.to_f)
         @balancer.instance_variable_get("@ips").should include('1.1.1.1')
         @balancer.instance_variable_get("@ips").should include('2.2.2.2')
         @balancer.instance_variable_get("@ips").should include('3.3.3.3')

data/spec/stats/helpers_spec.rb

@@ -29,10 +29,12 @@ describe RightSupport::Stats do
   before(:all) do
     @helpers = RightSupport::Stats
     @original_recent_size = RightSupport::Stats::Activity::RECENT_SIZE
+    RightSupport::Stats::Activity.send(:remove_const, :RECENT_SIZE) # Silence warning
     RightSupport::Stats::Activity.const_set(:RECENT_SIZE, 10)
   end
 
   after(:all) do
+    RightSupport::Stats::Activity.send(:remove_const, :RECENT_SIZE) # Silence warning
     RightSupport::Stats::Activity.const_set(:RECENT_SIZE, @original_recent_size)
   end
 

data/spec/validation/openssl_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe RightSupport::Validation::OpenSSL do
-  GOOD_PEM_PUB_RSA            = read_fixture('good_pub_rsa.pem')
-  GOOD_PEM_PRIV_RSA           = read_fixture('good_priv_rsa.pem')
-  GOOD_ENCRYPTED_PEM_PRIV_RSA = read_fixture('encrypted_priv_rsa.pem')
-  GOOD_SSH_PUB_RSA            = read_fixture('good_pub_rsa.ssh')
-  GOOD_SSH_PUB_DSA            = read_fixture('good_pub_dsa.ssh')
-  GOOD_PEM_PRIV_DSA           = read_fixture('good_priv_dsa.pem')
+  GOOD_PEM_PUB_RSA            = read_fixture('good_pub_rsa.pem') unless const_defined?('GOOD_PEM_PUB_RSA')
+  GOOD_PEM_PRIV_RSA           = read_fixture('good_priv_rsa.pem') unless const_defined?('GOOD_PEM_PRIV_RSA')
+  GOOD_ENCRYPTED_PEM_PRIV_RSA = read_fixture('encrypted_priv_rsa.pem') unless const_defined?('GOOD_ENCRYPTED_PEM_PRIV_RSA')
+  GOOD_SSH_PUB_RSA            = read_fixture('good_pub_rsa.ssh') unless const_defined?('GOOD_SSH_PUB_RSA')
+  GOOD_SSH_PUB_DSA            = read_fixture('good_pub_dsa.ssh') unless const_defined?('GOOD_SSH_PUB_DSA')
+  GOOD_PEM_PRIV_DSA           = read_fixture('good_priv_dsa.pem') unless const_defined?('GOOD_PEM_PRIV_DSA')
 
   context :pem_public_key? do
     it 'recognizes valid keys' do

data/spec/validation/ssh_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
 describe RightSupport::Validation::SSH do
-  GOOD_PEM_PRIV_RSA           = read_fixture('good_priv_rsa.pem')
-  GOOD_ENCRYPTED_PEM_PRIV_RSA = read_fixture('encrypted_priv_rsa.pem')
-  GOOD_SSH_PUB_RSA            = read_fixture('good_pub_rsa.ssh')
-  GOOD_SSH_PUB_DSA            = read_fixture('good_pub_dsa.ssh')
-  GOOD_PEM_PRIV_DSA           = read_fixture('good_priv_dsa.pem')
+  GOOD_PEM_PRIV_RSA           = read_fixture('good_priv_rsa.pem') unless const_defined?('GOOD_PEM_PUB_RSA')
+  GOOD_ENCRYPTED_PEM_PRIV_RSA = read_fixture('encrypted_priv_rsa.pem') unless const_defined?('GOOD_ENCRYPTED_PEM_PRIV_RSA')
+  GOOD_SSH_PUB_RSA            = read_fixture('good_pub_rsa.ssh') unless const_defined?('GOOD_SSH_PUB_RSA')
+  GOOD_SSH_PUB_DSA            = read_fixture('good_pub_dsa.ssh') unless const_defined?('GOOD_SSH_PUB_DSA')
+  GOOD_PEM_PRIV_DSA           = read_fixture('good_priv_dsa.pem') unless const_defined?('GOOD_PEM_PRIV_DSA')
 
   context :ssh_private_key? do
     it 'recognizes valid keys' do

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: right_support
 version: !ruby/object:Gem::Version
-  version: 2.8.34
+  version: 2.8.35
+  prerelease: 
 platform: ruby
 authors:
 - Tony Spataro
@@ -13,76 +14,86 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2014-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: ruby-debug
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A toolkit of useful, reusable foundation code created by RightScale.
@@ -93,10 +104,10 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
-- ".coveralls.yml"
-- ".rspec"
-- ".simplecov"
-- ".travis.yml"
+- .coveralls.yml
+- .rspec
+- .simplecov
+- .travis.yml
 - CHANGELOG.rdoc
 - Gemfile
 - Gemfile.lock
@@ -222,25 +233,29 @@ files:
 homepage: https://github.com/rightscale/right_support
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -578187549211322829
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Reusable foundation code.
 test_files: []

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 2b33df20f4893e7f64ab22c00fd808086fc89095
-  data.tar.gz: 122a7c34399879bd12fcc742849516be36273e5a
-SHA512:
-  metadata.gz: 584cc527971f1c292a2e2e6b7a52dcd1c1012c1ce28bced75664d7e1ee92428e1e9655ad013930a14416380354b75aa30df9ee21e8efd48a6180eb54a60eacc7
-  data.tar.gz: f27150448cc7b88daf33f25739137ec158c55a14c98393ca056d5c8ab8aa5ed8bd3b24a7f75687ac4cef52e191c8a09ba837a1f8f37664904baa411a5252b8b0