right_support 2.8.32 → 2.8.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2006046eff88bf5bcadd1cbae03279872cada84
-  data.tar.gz: 318dac67ca4962d08e4f990b92c6687b7bfa77c0
+  metadata.gz: fb9b8dbbf196cce60a01939073f03dd056ae8c22
+  data.tar.gz: f1d9aaf339977d0124b0f0f658a47cd6e28e678c
 SHA512:
-  metadata.gz: 7a1c5c26f1e59fba43adb37a272f5d1876a5a7c05704b83aa75c45cf9c5437780974d70f74546923ea32c76d661adb8044ac76a8321f180ffbbb26edf56bf21a
-  data.tar.gz: 0b03e8fa439261c5b64e62d673750d4d002fd022e179b846f51c6fcc9c2b732a2beefc7cc5de08737466a409f5dbf13d5594078fd4265aa10e38c8e4b68006e8
+  metadata.gz: 357ee9fddedc435739e1aa355a23f01d1177557b9a10bcd2149e60d0e20e360ee0aeafb39d5b497fecbed7b920e952aa94a4d85041df5b5e338e2fe662fd1881
+  data.tar.gz: 1a593d7bc80ef34e4fcabf650ed5c957f529bf9b9047fa27d46440f902d532163c72dbb39826b447e7f932a4faae58ef24bbb05c612776b2eb7ca626a2a9611b

data/.coveralls.yml

@@ -0,0 +1,2 @@
+service_name: travis-ci
+

data/.simplecov

@@ -0,0 +1,6 @@
+require 'coveralls'
+
+Coveralls.wear_merged! do
+  add_filter "/features/"
+  add_filter "/spec/"
+end

data/.travis.yml

@@ -0,0 +1,12 @@
+language: ruby
+cache: bundler
+rvm:
+  - 1.8
+  - 1.9
+  - 2.0
+  - 2.1
+script:
+  - bundle exec rake ci:spec
+  - bundle exec rake ci:cucumber
+  - bundle exec rake coveralls:push
+bundler_args: --without debugger development

data/Gemfile

@@ -3,25 +3,31 @@ source 'https://rubygems.org'
 # Gems that RightSupport can optionally make use of, but which it does
 # not require to be installed. These would be 'optional dependencies'
 # if gemspecs allowed for them.
+#
+# Note that these are all require-nil because we want to simulate the behavior
+# of the library in a context where it lazy-loads its optional dependencies.
 group :optional do
-  gem 'net-ssh', '~> 2.0'
-  gem 'mime-types', '~> 1.0' # mime-types 2.x is no longer compatible with Ruby 1.8 and mime-types 1.x is only being maintained for security issues
-  gem 'rest-client', '~> 1.6'
-  gem 'addressable', '~> 2.2.7'
+  gem 'net-ssh', '~> 2.0', :require => nil
+  # mime-types 2.x is no longer compatible with Ruby 1.8 and
+  # mime-types 1.x is only being maintained for security issues .. use 1.x for now, since we
+  # maintain 1.8 compatibility
+  gem 'mime-types', '~> 1.0', :require => nil
+  gem 'rest-client', '~> 1.6.7', :require => nil
+  gem 'addressable', '~> 2.2.7', :require => nil
   gem 'uuidtools', '~> 2.0', :require => nil
   gem 'simple_uuid', '~> 0.2', :require => nil
   gem 'uuid', '~> 2.3', :require => nil
-  gem 'yajl-ruby', '~> 1.1'
+  gem 'json', '~> 1.8', :require => nil
   gem 'iconv', :platforms => :ruby_18
 end
 
-# Gems used during test and development of RightSupport, but which should be omitted as development
-# dependencies when generating the gemspec.
+gem 'rake', '~> 10.0', :group=>[:development, :test]
+
+# Gems used to run RightSupport tests; omitted from the gemspec, but available in CI.
 group :test do
-  gem 'jeweler', '~> 2.0'
   gem 'flexmock', '~> 1.0'
   gem 'rspec', '~> 2.13.0'
-  gem 'right_develop', '~> 2.1'
+  gem 'right_develop', '~> 3.1'
 
   # Cuke >= 1.3.3 depends on RubyGems > 2.0 without specifying that in its gemspec
   gem 'cucumber', ['~> 1.0', '< 1.3.3']
@@ -31,11 +37,15 @@ group :test do
   # Work around the bug by locking ourselves to 1.5.x, guaranteeing that we can install our bundle
   # under Ruby 1.8.
   gem 'nokogiri', '~> 1.5.0'
+
+  # Code coverage reporting and metrics pp
+  gem 'coveralls', :require => false
 end
 
-# Gems that are used for development and not for CI.
+# Gems that are used purely for development; present in the gemspec, not available in CI.
 group :development do
+  gem 'jeweler', '~> 2.0'
   gem 'ruby-debug', :platforms => [:ruby_18]
   gem 'pry', :platforms => [:ruby_19, :ruby_20, :ruby_21]
-  gem 'pry-byebug', :platforms => [:ruby_19, :ruby_20, :ruby_21]
-end
+  gem 'pry-byebug', :platforms => [:ruby_20, :ruby_21]
+end

data/Gemfile.lock

@@ -8,6 +8,12 @@ GEM
       debugger-linecache (~> 1.2)
     coderay (1.1.0)
     columnize (0.8.9)
+    coveralls (0.7.1)
+      multi_json (~> 1.3)
+      rest-client
+      simplecov (>= 0.7)
+      term-ansicolor
+      thor
     cucumber (1.3.2)
       builder (>= 2.1.2)
       diff-lcs (>= 1.1.3)
@@ -15,7 +21,7 @@ GEM
       multi_json (~> 1.3)
     debugger-linecache (1.2.0)
     diff-lcs (1.2.5)
-    extlib (0.9.16)
+    docile (1.1.5)
     faraday (0.8.9)
       multipart-post (~> 1.2.0)
     flexmock (1.3.3)
@@ -44,6 +50,8 @@ GEM
     json (1.8.1)
     jwt (0.1.11)
       multi_json (>= 1.5)
+    linecache (0.46)
+      rbx-require-relative (> 0.0.4)
     macaddr (1.6.5)
       systemu (~> 2.6.2)
     method_source (0.8.2)
@@ -67,28 +75,25 @@ GEM
       byebug (~> 2.7)
       pry (~> 0.10)
     rack (1.5.2)
-    rake (0.9.6)
+    rake (10.3.2)
+    rbx-require-relative (0.0.9)
     rdoc (4.1.1)
       json (~> 1.4)
     rest-client (1.6.7)
       mime-types (>= 1.16)
     right_aws (3.1.0)
       right_http_connection (>= 1.2.5)
-    right_develop (2.3.0)
+    right_develop (3.1.4)
       builder (~> 3.0)
-      cucumber (~> 1.0, < 1.3.3)
-      extlib
       rack
-      rake (>= 0.8.7, < 0.10)
       right_aws (>= 2.1.0)
-      right_git (~> 0.1.0)
-      right_support (~> 2.0)
-      rspec (>= 1.3, < 3.0)
+      right_git (>= 1.0)
+      right_support (>= 2.8.31, < 3.0.0)
       trollop (>= 1.0, < 3.0)
-    right_git (0.1.0)
-      right_support (>= 2.8.10, < 3.0.0)
-    right_http_connection (1.4.0)
-    right_support (2.8.24)
+    right_git (1.0.1)
+      right_support (>= 2.8.10)
+    right_http_connection (1.5.0)
+    right_support (2.8.32)
     rspec (2.13.0)
       rspec-core (~> 2.13.0)
       rspec-expectations (~> 2.13.0)
@@ -97,34 +102,49 @@ GEM
     rspec-expectations (2.13.0)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.13.1)
+    ruby-debug (0.10.4)
+      columnize (>= 0.1)
+      ruby-debug-base (~> 0.10.4.0)
+    ruby-debug-base (0.10.4)
+      linecache (>= 0.3)
     simple_uuid (0.4.0)
+    simplecov (0.9.1)
+      docile (~> 1.1.0)
+      multi_json (~> 1.0)
+      simplecov-html (~> 0.8.0)
+    simplecov-html (0.8.0)
     slop (3.6.0)
     systemu (2.6.3)
+    term-ansicolor (1.3.0)
+      tins (~> 1.0)
+    thor (0.19.1)
+    tins (1.3.3)
     trollop (2.0)
     uuid (2.3.7)
       macaddr (~> 1.0)
     uuidtools (2.1.4)
-    yajl-ruby (1.2.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   addressable (~> 2.2.7)
+  coveralls
   cucumber (~> 1.0, < 1.3.3)
   flexmock (~> 1.0)
   iconv
   jeweler (~> 2.0)
+  json (~> 1.8)
   mime-types (~> 1.0)
   net-ssh (~> 2.0)
   nokogiri (~> 1.5.0)
   pry
   pry-byebug
-  rest-client (~> 1.6)
-  right_develop (~> 2.1)
+  rake (~> 10.0)
+  rest-client (~> 1.6.7)
+  right_develop (~> 3.1)
   rspec (~> 2.13.0)
   ruby-debug
   simple_uuid (~> 0.2)
   uuid (~> 2.3)
   uuidtools (~> 2.0)
-  yajl-ruby (~> 1.1)

data/{README.rdoc → README.md}

@@ -1,10 +1,16 @@
-RightSupport is a library of reusable, unit- and functional-tested Ruby code that RightScale has found broadly useful.
+# RightSupport
 
-Maintained by the RightScale Teal Team
+This is a library of reusable, unit- and functional-tested Ruby code that RightScale has found broadly useful.
 
-== What Does It Do?
+[![Build Status](https://travis-ci.org/rightscale/right_support.svg?branch=master)](https://travis-ci.org/rightscale/right_support)
 
-=== Logging
+[![Coverage Status](https://img.shields.io/coveralls/rightscale/right_support.svg)](https://coveralls.io/r/rightscale/right_support?branch=master)
+
+Maintained by the RightScale Technicolor Team
+
+# What Does It Do?
+
+## Logging
 
 SystemLogger is a rewrite of the seattle.rb SyslogLogger class that features the following improvements:
 * Contains several bugfixes vs. SyslogLogger 1.4.0
@@ -26,7 +32,7 @@ loggers!
   #but MY jet
   @my_jet.logger = Logger.new(StringIO.new)
 
-==== Logging for Rack Applications
+### Logging for Rack Applications
 
 RightSupport also provides Rack middleware that allows a Rack app to use any log sink it wishes. The
 stock Rack logger middleware is inflexible and gives the end user no control over which logger is used
@@ -56,9 +62,9 @@ After that all rack requests to MyApp will be logged, and since we mixed Log::Mi
 
   logger.info "Hello world\nThis will appear on separate lines\nand without \e[33;0mbeautiful colors"
 
-=== Networking Stuff
+## Networking Stuff
 
-==== HTTP Client
+### HTTP Client
 
 We provide a very thin wrapper around the rest-client gem that enables simple but
 robust rest requests with a timeout, headers, etc.
@@ -80,7 +86,7 @@ optional timeout to be specified as an extra parameter.
    @client.get('http://localhost/moo', {:query=>{:a=>{:b=>:c}}} )
    # the url that would be requested is http://localhost/moo?a[b]=c
 
-==== Client-Side Load Balancer
+### Client-Side Load Balancer
 
 RequestBalancer randomly chooses endpoints for a network request, which lets
 you perform easy client-side load balancing:
@@ -95,7 +101,7 @@ you perform easy client-side load balancing:
 The balancer will keep trying requests until one of them succeeds without
 throwing any exceptions. (NB: a nil return value counts as success!!)
 
-==== HTTP Request Tracking for Rack
+### HTTP Request Tracking for Rack
 
 Correlate data flows across your entire architecture with the RequestTracker
 middleware, which uses custom HTTP headers to "tag" every Web request with
@@ -110,7 +116,7 @@ To use this functionality you need:
 
   use RightSupport::Rack::RequestTracker
 
-=== Statistics Gathering
+## Statistics Gathering
 
 Profile your compute-heavy and network activities using a Stats::Activity counter.
 
@@ -125,7 +131,7 @@ Profile your compute-heavy and network activities using a Stats::Activity counte
 
   puts "Only %.1f lines/sec? You are a slow typist!" % [stats.avg_rate]
 
-=== Input Validation
+## Input Validation
 
 Validation  contains several format-checkers that can be used to validate your
 web app's models before saving, check for preconditions in your controllers,
@@ -149,7 +155,7 @@ but does not pollute the dispatch table of your application classes.
   the_key = STDIN.read
   raise ArgumentError unless RightSupport::Validation.ssh_public_key?(the_key)
 
-=== String Manipulation
+## String Manipulation
 
 StringExtensions contains String#camelize, which is only defined if the
 ActiveSupport gem cannot be loaded. It also has some RightScale-specific
@@ -160,7 +166,7 @@ methods:
 
 Net::StringEncoder applies and removes URL-escape, base64 and other encodings.
 
-=== Configuration
+## Configuration
 
 RightSupport::Config contains functionality, which provides possibility 
 to use human-readable yaml configuration files. For example, you have following yaml 

data/Rakefile

@@ -3,13 +3,21 @@ require 'rubygems'
 require 'bundler/setup'
 
 require 'rake'
-require 'rdoc/task'
 require 'rubygems/package_task'
 
 require 'rake/clean'
 require 'rspec/core/rake_task'
 require 'cucumber/rake/task'
 
+# These dependencies can be omitted using "bundle install --without"; tolerate their absence.
+['rdoc/task', 'jeweler', 'coveralls/rake/task'].each do |optional|
+  begin
+    require optional
+  rescue LoadError
+    # ignore
+  end
+end
+
 # But, we have a very special need, because OUR Cucumbers need to run with a pristine
 # environment that isn't polluted by RVM or RubyGems or anyone else, in order to validate
 # that RightSupport's CI harness doesn't break your app if those gems are unavailable.
@@ -31,34 +39,41 @@ Cucumber::Rake::Task.new do |t|
   t.cucumber_opts = %w{--color --format pretty}
 end
 
-desc 'Generate documentation for the right_support gem.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'doc'
-  rdoc.title    = 'RightSupport'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-  rdoc.rdoc_files.exclude('features/**/*')
-  rdoc.rdoc_files.exclude('spec/**/*')
+if defined?(Rake::RDocTask)
+  desc 'Generate documentation for the right_support gem.'
+  Rake::RDocTask.new(:rdoc) do |rdoc|
+    rdoc.rdoc_dir = 'doc'
+    rdoc.title    = 'RightSupport'
+    rdoc.options << '--line-numbers' << '--inline-source'
+    rdoc.rdoc_files.include('README.rdoc')
+    rdoc.rdoc_files.include('lib/**/*.rb')
+    rdoc.rdoc_files.exclude('features/**/*')
+    rdoc.rdoc_files.exclude('spec/**/*')
+  end
 end
 
-require 'jeweler'
-tasks = Jeweler::Tasks.new do |gem|
-  # gem is a Gem::Specification; see http://docs.rubygems.org/read/chapter/20 for more options
-  gem.name = "right_support"
-  gem.homepage = "https://github.com/rightscale/right_support"
-  gem.license = "MIT"
-  gem.summary = %Q{Reusable foundation code.}
-  gem.description = %Q{A toolkit of useful, reusable foundation code created by RightScale.}
-  gem.email = "support@rightscale.com"
-  gem.authors = ['Tony Spataro', 'Sergey Sergyenko', 'Ryan Williamson', 'Lee Kirchhoff', 'Alexey Karpik', 'Scott Messier']
-end
+if defined?(Jeweler)
+  tasks = Jeweler::Tasks.new do |gem|
+    # gem is a Gem::Specification; see http://docs.rubygems.org/read/chapter/20 for more options
+    gem.name = "right_support"
+    gem.homepage = "https://github.com/rightscale/right_support"
+    gem.license = "MIT"
+    gem.summary = %Q{Reusable foundation code.}
+    gem.description = %Q{A toolkit of useful, reusable foundation code created by RightScale.}
+    gem.email = "support@rightscale.com"
+    gem.authors = ['Tony Spataro', 'Sergey Sergyenko', 'Ryan Williamson', 'Lee Kirchhoff', 'Alexey Karpik', 'Scott Messier']
+  end
 
-# Never auto-commit during operations that change the repository. Allows developers to decide on their own commit comment
-# and/or aggregate version bumps into other fixes.
-tasks.jeweler.commit = false
+  # Never auto-commit during operations that change the repository. Allows developers to decide on their own commit comment
+  # and/or aggregate version bumps into other fixes.
+  tasks.jeweler.commit = false
 
-Jeweler::RubygemsDotOrgTasks.new
+  Jeweler::RubygemsDotOrgTasks.new
+end
+
+if defined?(Coveralls)
+  Coveralls::RakeTask.new
+end
 
 CLEAN.include('pkg')
 

data/VERSION

@@ -1 +1 @@
-2.8.32
+2.8.33

data/features/serialization.feature

@@ -33,7 +33,7 @@ Feature: JSON serialization
 
   Scenario: invalid UTF-8 characters
     When I serialize the Ruby value: "\xC0\xBCscript>\xC0\xBC/script>"
-    Then the serialized value should be: "??script>??/script>"
+    Then the serialized value should have no invalid characters
 
   Scenario: valid UTF-8 characters
     When I serialize the Ruby value: "onê"

data/features/step_definitions/serialization_steps.rb

@@ -77,6 +77,24 @@ Then /^the serialized value should round-trip cleanly$/ do
   end
 end
 
+Then /^the serialized value should have no invalid characters$/ do
+  if @serialized_value.respond_to?(:valid_encoding?)
+    # modern Rubies
+    @serialized_value.valid_encoding?.should be_true
+  else
+    # Ruby 1.8
+    raised = false
+    begin
+      iconv = Iconv.new('UTF-8', 'UTF-8')
+      iconv.iconv(@serialized_value)
+    rescue Exception => e
+      raised = true
+    end
+
+    raised.should be_false
+  end
+end
+
 When /^the serialized value should fail to round\-trip$/ do
   @serializer.load(@serialized_value).should_not == @ruby_value
 end

data/features/support/env.rb

@@ -26,6 +26,8 @@ require 'tmpdir'
 require 'rubygems'
 require 'bundler/setup'
 
+require 'simplecov'
+
 $:.unshift(File.expand_path('../../../lib', __FILE__)) #ensure we load THIS project's code, not an installed gem
 require 'right_support'
 require 'right_support/ci'

data/lib/right_support/ci/java_cucumber_formatter.rb

@@ -24,6 +24,7 @@
 # RightSupport's main file. Make up for Cucumber's shortcomings.
 require 'right_support'
 
+# :nocov:
 module RightSupport::CI
   if require_succeeds?('cucumber/formatter/junit')
     # @deprecated Please do not use this class
@@ -57,3 +58,4 @@ module RightSupport::CI
     end
   end
 end
+# :nocov:

data/lib/right_support/ci/java_spec_formatter.rb

@@ -22,6 +22,7 @@
 
 require 'time'
 
+# :nocov:
 module RightSupport::CI
   if require_succeeds?('spec/runner/formatter/base_text_formatter')
     # RSpec 1.x
@@ -194,3 +195,4 @@ module RightSupport::CI
     end
   end
 end
+# :nocov:

data/lib/right_support/ci/rake_task.rb

@@ -25,6 +25,7 @@ require 'rake/tasklib'
 # required directly.
 require 'right_support'
 
+# :nocov:
 module RightSupport::CI
   # A Rake task definition that creates a CI namespace with appropriate
   # tests.
@@ -88,3 +89,4 @@ module RightSupport::CI
     end
   end
 end
+# :nocov:

data/lib/right_support/data/serializer.rb

@@ -163,9 +163,11 @@ module RightSupport::Data
           # Nothing to do
           dirty
         else
-          # Some other encoding, or string has invalid characters. Scrub, and possibly lose
-          # data in the process
-          dirty.dup.encode(Encoding::UTF_8,
+          # String has encoding other than UTF-8, or has invalid UTF-8 characters. Force the
+          # encoding to binary (if it's already UTF-8) to ensure that transcoding occurs,
+          # then transcode to UTF-8 and replace invalid characters with a question mark.
+          dirty.force_encoding(Encoding::BINARY) if dirty.encoding == Encoding::UTF_8
+          dirty.encode(Encoding::UTF_8,
                            :invalid => :replace,
                            :undef => :replace,
                            :replace => '?')

data/lib/right_support/rack/runtime.rb

@@ -0,0 +1,52 @@
+#
+# Copyright (c) 2007, 2008, 2009, 2010, 2011, 2012 Christian Neukirchen <purl.org/net/chneukirchen>
+# Copyright (c) 2014 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+# Copied and modified from
+# https://github.com/rack/rack/blob/master/lib/rack/runtime.rb
+module RightSupport::Rack
+  # Sets an "X-Runtime" response header, indicating the response
+  # time of the request, in milliseconds
+  #
+  # You can put it right before the application to see the processing
+  # time, or before all the other middlewares to include time for them,
+  # too.
+  class Runtime
+    def initialize(app, name = nil)
+      @app = app
+      @header_name = "X-Runtime"
+      @header_name << "-#{name}" if name
+    end
+
+    def call(env)
+      start_time = Time.now
+      status, headers, body = @app.call(env)
+      request_time = Time.now - start_time
+
+      if !headers.has_key?(@header_name)
+        headers[@header_name] = (request_time * 1000).truncate.to_s
+      end
+
+      [status, headers, body]
+    end
+  end
+end

data/lib/right_support/rack.rb

@@ -32,3 +32,4 @@ end
 require 'right_support/rack/log_setter'
 require 'right_support/rack/request_logger'
 require 'right_support/rack/request_tracker'
+require 'right_support/rack/runtime'

data/right_support.gemspec

@@ -2,29 +2,32 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: right_support 2.8.32 ruby lib
+# stub: right_support 2.8.33 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "right_support"
-  s.version = "2.8.32"
+  s.version = "2.8.33"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2014-09-30"
+  s.date = "2014-10-18"
   s.description = "A toolkit of useful, reusable foundation code created by RightScale."
   s.email = "support@rightscale.com"
   s.extra_rdoc_files = [
     "LICENSE",
-    "README.rdoc"
+    "README.md"
   ]
   s.files = [
+    ".coveralls.yml",
     ".rspec",
+    ".simplecov",
+    ".travis.yml",
     "CHANGELOG.rdoc",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE",
-    "README.rdoc",
+    "README.md",
     "Rakefile",
     "VERSION",
     "features/balancer_error_handling.feature",
@@ -85,6 +88,7 @@ Gem::Specification.new do |s|
     "lib/right_support/rack/log_setter.rb",
     "lib/right_support/rack/request_logger.rb",
     "lib/right_support/rack/request_tracker.rb",
+    "lib/right_support/rack/runtime.rb",
     "lib/right_support/ruby.rb",
     "lib/right_support/ruby/easy_singleton.rb",
     "lib/right_support/ruby/object_extensions.rb",
@@ -131,6 +135,7 @@ Gem::Specification.new do |s|
     "spec/rack/log_setter_spec.rb",
     "spec/rack/request_logger_spec.rb",
     "spec/rack/request_tracker_spec.rb",
+    "spec/rack/runtime_spec.rb",
     "spec/ruby/easy_singleton_spec.rb",
     "spec/ruby/object_extensions_spec.rb",
     "spec/ruby/string_extensions_spec.rb",
@@ -150,15 +155,21 @@ Gem::Specification.new do |s|
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+      s.add_development_dependency(%q<rake>, ["~> 10.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_development_dependency(%q<ruby-debug>, [">= 0"])
       s.add_development_dependency(%q<pry>, [">= 0"])
       s.add_development_dependency(%q<pry-byebug>, [">= 0"])
     else
+      s.add_dependency(%q<rake>, ["~> 10.0"])
+      s.add_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_dependency(%q<ruby-debug>, [">= 0"])
       s.add_dependency(%q<pry>, [">= 0"])
       s.add_dependency(%q<pry-byebug>, [">= 0"])
     end
   else
+    s.add_dependency(%q<rake>, ["~> 10.0"])
+    s.add_dependency(%q<jeweler>, ["~> 2.0"])
     s.add_dependency(%q<ruby-debug>, [">= 0"])
     s.add_dependency(%q<pry>, [">= 0"])
     s.add_dependency(%q<pry-byebug>, [">= 0"])

data/spec/data/hash_tools_spec.rb

@@ -220,8 +220,17 @@ describe RightSupport::Data::HashTools do
     {
       :empty => {},
       :shallow => { :x => 1, :y => 2 },
-      :deep => { :x => 1, :y => { :a => 'A' }, :z => { :b => 'B', :c => { :foo => :bar } } },
-      :arrayed => [ { :x => 1 }, { :y => { :a => 'A' } }, :z => { :b => 'B', :c => { :foo => :bar } } ],
+      :deep => {
+        :x => 1,
+        :y => { :a => 'A' },
+        :z => { :b => 'B',
+                :c => { :foo => :bar } } },
+      :arrayed => [
+        { :x => 1 },
+        { :y => { :a => 'A' } },
+        { :z => { :b => 'B',
+                  :c => { :foo => :bar } } }
+      ],
       :duplicable => {
         :tree => {
           :branch => {

data/spec/rack/runtime_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+class FasterApp
+  def self.call(env)
+    sleep 0.05; [200, {}, "50ms"]
+  end
+end
+
+class SlowerApp
+  def self.call(env)
+    sleep 0.2; [200, {}, "200ms"]
+  end
+end
+
+describe RightSupport::Rack::Runtime do
+  before(:each) do
+    @app = flexmock('Rack app')
+    @app.should_receive(:call).and_return([200, {}, 'body']).by_default
+    @env = {'rack.logger' => @logger}
+    @middleware = RightSupport::Rack::Runtime.new(@app)
+  end
+
+  context :call do
+    it 'sets an X-Runtime header in response' do
+      @middleware.call(@env).should == [200, {"X-Runtime"=>"0"}, 'body']
+    end
+
+    it 'sets a correct X-Runtime value for 50 ms app' do
+      faster = RightSupport::Rack::Runtime.new(FasterApp)
+      result = faster.call(@env)
+      result[1].keys.should == ['X-Runtime']
+      result[1]['X-Runtime'].to_i.should >= 50
+      result[1]['X-Runtime'].to_i.should < 70
+    end
+
+    it 'sets a correct X-Runtime value for 200 ms app' do
+      slower = RightSupport::Rack::Runtime.new(SlowerApp)
+      result = slower.call(@env)
+      result[1].keys.should == ['X-Runtime']
+      result[1]['X-Runtime'].to_i.should >= 200
+      result[1]['X-Runtime'].to_i.should < 270
+    end
+
+    it 'allows appending custom name to X-Runtime header' do
+      customized = RightSupport::Rack::Runtime.new(@app, "Test")
+      customized.call(@env).should == [200, {"X-Runtime-Test"=>"0"}, 'body']
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -23,6 +23,8 @@ require 'rubygems'
 require 'bundler/setup'
 require 'flexmock'
 
+require 'simplecov'
+
 $:.unshift(File.expand_path('../../../lib', __FILE__)) #ensure we load THIS project's code, not an installed gem
 require 'right_support'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: right_support
 version: !ruby/object:Gem::Version
-  version: 2.8.32
+  version: 2.8.33
 platform: ruby
 authors:
 - Tony Spataro
@@ -13,8 +13,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-18 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: jeweler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: ruby-debug
   requirement: !ruby/object:Gem::Requirement
@@ -63,14 +91,17 @@ executables: []
 extensions: []
 extra_rdoc_files:
 - LICENSE
-- README.rdoc
+- README.md
 files:
+- ".coveralls.yml"
 - ".rspec"
+- ".simplecov"
+- ".travis.yml"
 - CHANGELOG.rdoc
 - Gemfile
 - Gemfile.lock
 - LICENSE
-- README.rdoc
+- README.md
 - Rakefile
 - VERSION
 - features/balancer_error_handling.feature
@@ -131,6 +162,7 @@ files:
 - lib/right_support/rack/log_setter.rb
 - lib/right_support/rack/request_logger.rb
 - lib/right_support/rack/request_tracker.rb
+- lib/right_support/rack/runtime.rb
 - lib/right_support/ruby.rb
 - lib/right_support/ruby/easy_singleton.rb
 - lib/right_support/ruby/object_extensions.rb
@@ -177,6 +209,7 @@ files:
 - spec/rack/log_setter_spec.rb
 - spec/rack/request_logger_spec.rb
 - spec/rack/request_tracker_spec.rb
+- spec/rack/runtime_spec.rb
 - spec/ruby/easy_singleton_spec.rb
 - spec/ruby/object_extensions_spec.rb
 - spec/ruby/string_extensions_spec.rb