right_support 2.8.23 → 2.8.24

data/VERSION

@@ -1 +1 @@
-2.8.23
+2.8.24

data/lib/right_support/log/mixin.rb

@@ -59,6 +59,11 @@ module RightSupport::Log
   #   processor.logger = Logger.new(File.open("#{processor.object_id}.log", 'w'))
   #
   module Mixin
+    # List of base classes to which a class-level .logger call is NEVER delegated, even if the base
+    # class object responds to .logger; this protects against other metaprogramming that defines
+    # Class#logger or Object#logger.
+    UNDELEGATED = [Class, Object]
+
     # A decorator class which will be wrapped around any logger that is
     # provided to any of the setter methods. This ensures that ExceptionLogger's
     # methods will always be available to anyone who uses this mixin for logging.
@@ -69,8 +74,8 @@ module RightSupport::Log
       def logger
         if @logger
           @logger
-        elsif respond_to?(:superclass) && superclass.respond_to?(:logger) && superclass.logger
-          superclass.logger
+        elsif scl = (respond_to?(:superclass) && superclass.respond_to?(:logger) && !UNDELEGATED.include?(superclass) && superclass.logger)
+          scl
         else
           RightSupport::Log::Mixin.default_logger
         end

data/right_support.gemspec

@@ -4,14 +4,14 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.name = "right_support"
-  s.version = "2.8.23"
+  s.name = %q{right_support}
+  s.version = "2.8.24"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2014-05-27"
-  s.description = "A toolkit of useful, reusable foundation code created by RightScale."
-  s.email = "support@rightscale.com"
+  s.date = %q{2014-06-23}
+  s.description = %q{A toolkit of useful, reusable foundation code created by RightScale.}
+  s.email = %q{support@rightscale.com}
   s.extra_rdoc_files = [
     "LICENSE",
     "README.rdoc"
@@ -136,31 +136,35 @@ Gem::Specification.new do |s|
     "spec/validation/openssl_spec.rb",
     "spec/validation/ssh_spec.rb"
   ]
-  s.homepage = "https://github.com/rightscale/right_support"
+  s.homepage = %q{https://github.com/rightscale/right_support}
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.26"
-  s.summary = "Reusable foundation code."
+  s.rubygems_version = %q{1.3.7}
+  s.summary = %q{Reusable foundation code.}
 
   if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_development_dependency(%q<flexmock>, ["~> 1.0"])
       s.add_development_dependency(%q<rspec>, ["~> 2.13.0"])
-      s.add_development_dependency(%q<cucumber>, ["< 1.3.3", "~> 1.0"])
+      s.add_development_dependency(%q<cucumber>, ["~> 1.0", "< 1.3.3"])
+      s.add_development_dependency(%q<ruby-debug>, [">= 0"])
     else
       s.add_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_dependency(%q<flexmock>, ["~> 1.0"])
       s.add_dependency(%q<rspec>, ["~> 2.13.0"])
-      s.add_dependency(%q<cucumber>, ["< 1.3.3", "~> 1.0"])
+      s.add_dependency(%q<cucumber>, ["~> 1.0", "< 1.3.3"])
+      s.add_dependency(%q<ruby-debug>, [">= 0"])
     end
   else
     s.add_dependency(%q<jeweler>, ["~> 2.0"])
     s.add_dependency(%q<flexmock>, ["~> 1.0"])
     s.add_dependency(%q<rspec>, ["~> 2.13.0"])
-    s.add_dependency(%q<cucumber>, ["< 1.3.3", "~> 1.0"])
+    s.add_dependency(%q<cucumber>, ["~> 1.0", "< 1.3.3"])
+    s.add_dependency(%q<ruby-debug>, [">= 0"])
   end
 end
 

data/spec/log/mixin_spec.rb

@@ -117,4 +117,25 @@ describe RightSupport::Log::Mixin do
       Bystander.logger.error('foo')
     end
   end
+
+  context 'given someone has defined Class#logger' do
+    before(:all) do
+      InnocentVictim.logger = nil
+      class Class
+        def logger
+          raise "THIS SHOULD NEVER BE CALLED"
+        end
+      end
+    end
+
+    after(:all) do
+      class Class
+        remove_method :logger
+      end
+    end
+
+    it 'should never delegate to Class#logger' do
+      InnocentVictim.logger.info 'test log'
+    end
+  end
 end

metadata

@@ -1,10 +1,15 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: right_support
-version: !ruby/object:Gem::Version
-  version: 2.8.23
-  prerelease: 
+version: !ruby/object:Gem::Version 
+  hash: 31
+  prerelease: false
+  segments: 
+  - 2
+  - 8
+  - 24
+  version: 2.8.24
 platform: ruby
-authors:
+authors: 
 - Tony Spataro
 - Sergey Sergyenko
 - Ryan Williamson
@@ -14,86 +19,89 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-27 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: jeweler
-  requirement: !ruby/object:Gem::Requirement
+
+date: 2014-06-24 00:00:00 -07:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 2
+        - 0
+        version: "2.0"
+  name: jeweler
+  requirement: *id001
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  type: :development
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
+      - !ruby/object:Gem::Version 
+        hash: 15
+        segments: 
+        - 1
+        - 0
+        version: "1.0"
   name: flexmock
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+  requirement: *id002
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
+  type: :development
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        hash: 59
+        segments: 
+        - 2
+        - 13
+        - 0
         version: 2.13.0
-  type: :development
+  name: rspec
+  requirement: *id003
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  type: :development
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.13.0
-- !ruby/object:Gem::Dependency
-  name: cucumber
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
+      - !ruby/object:Gem::Version 
+        hash: 15
+        segments: 
+        - 1
+        - 0
+        version: "1.0"
     - - <
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
+        hash: 29
+        segments: 
+        - 1
+        - 3
+        - 3
         version: 1.3.3
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+  name: cucumber
+  requirement: *id004
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - <
-      - !ruby/object:Gem::Version
-        version: 1.3.3
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.0'
+  type: :development
 description: A toolkit of useful, reusable foundation code created by RightScale.
 email: support@rightscale.com
 executables: []
+
 extensions: []
-extra_rdoc_files:
+
+extra_rdoc_files: 
 - LICENSE
 - README.rdoc
-files:
+files: 
 - .rspec
 - CHANGELOG.rdoc
 - Gemfile
@@ -212,32 +220,39 @@ files:
 - spec/stats/helpers_spec.rb
 - spec/validation/openssl_spec.rb
 - spec/validation/ssh_spec.rb
+has_rdoc: true
 homepage: https://github.com/rightscale/right_support
-licenses:
+licenses: 
 - MIT
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
       - 0
-      hash: -4455262276770369018
-required_rubygems_version: !ruby/object:Gem::Requirement
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.26
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Reusable foundation code.
 test_files: []
+