right_hook 0.2.2 → 0.2.3

data/lib/right_hook/authenticator.rb

@@ -25,7 +25,7 @@ module RightHook
     # Create a new GitHub authorization with the given note.
     # If one already exists with that note, it will not create a duplicate.
     def create_authorization(note)
-      _client.create_authorization(scopes: %w(repo), note: note, idempotent: true).token
+      _client.create_authorization(scopes: %w(repo), note: note).token
     end
 
     # Returns an array of all of the authorizations for the authenticated account.
@@ -33,6 +33,16 @@ module RightHook
       _client.list_authorizations
     end
 
+    # If there is already an authorization by this note, use it; otherwise create it
+    def find_or_create_authorization_by_note(note)
+      found_auth = list_authorizations.find {|auth| auth.note == note}
+      if found_auth
+        found_auth.token
+      else
+        create_authorization(note)
+      end
+    end
+
     private
     attr_reader :_client
     # Enforce use of build methods

data/lib/right_hook/version.rb

@@ -1,3 +1,3 @@
 module RightHook
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/authenticator_spec.rb

@@ -21,7 +21,7 @@ describe RightHook::Authenticator do
 
   describe '#create_authorization' do
     it 'delegates to create_authorization' do
-      Octokit::Client.any_instance.should_receive(:create_authorization).with(scopes: %w(repo), note: 'test note', idempotent: true).and_return(OpenStruct.new(token: 'my_token'))
+      Octokit::Client.any_instance.should_receive(:create_authorization).with(scopes: %w(repo), note: 'test note').and_return(OpenStruct.new(token: 'my_token'))
 
       expect(described_class.build('octocat', 'pass').create_authorization('test note')).to eq('my_token')
     end
@@ -34,4 +34,24 @@ describe RightHook::Authenticator do
       expect(described_class.build('octocat', 'pass').list_authorizations).to eq(:the_authorizations)
     end
   end
+
+  describe '#find_or_create_authorization_by_note' do
+    let(:auth) { OpenStruct.new(token: 'a token', note: 'the note')}
+    context 'when #list_authorizations has a note that is an exact match' do
+      before { Octokit::Client.any_instance.should_receive(:list_authorizations).and_return([auth]) }
+      it 'returns that authorization' do
+        authenticator = described_class.build('octocat', 'pass')
+        expect(authenticator.find_or_create_authorization_by_note('the note')).to eq('a token')
+      end
+    end
+
+    context 'when #list_authorizations does not have a note that matches' do
+      before { Octokit::Client.any_instance.should_receive(:list_authorizations).and_return([]) }
+      before { Octokit::Client.any_instance.should_receive(:create_authorization).and_return(auth) }
+      it 'creates a new authorization' do
+        authenticator = described_class.build('octocat', 'pass')
+        expect(authenticator.find_or_create_authorization_by_note('the note')).to eq('a token')
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: right_hook
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
   prerelease: 
 platform: ruby
 authors: