right_amqp 0.3.2 → 0.3.3

data/lib/right_amqp/amqp/client.rb

@@ -247,13 +247,7 @@ module AMQP
     def reconnect force = false
       if @reconnecting and not force
         # Wait after first reconnect attempt and in between each subsequent attempt
-        EM.add_timer(@settings[:reconnect_interval] || 5) do
-          begin
-            reconnect(true)
-          rescue Exception => e
-            logger.exception("[amqp] Failed to reconnect", e, :trace)
-          end
-        end
+        EM.add_timer(@settings[:reconnect_interval] || 5) { reconnect(true) }
         return
       end
 
@@ -271,13 +265,7 @@ module AMQP
         again = again.call if again.is_a?(Proc)
         if again.is_a?(Numeric)
           # Wait before making initial reconnect attempt
-          EM.add_timer(again) do
-            begin
-              reconnect(true)
-            rescue Exception => e
-              logger.exception("[amqp] Failed to reconnect", e, :trace)
-            end
-          end
+          EM.add_timer(again) { reconnect(true) }
           return
         elsif ![nil, true].include?(again)
           raise ::AMQP::Error, "Could not interpret :reconnect_delay => #{again.inspect}; expected nil, true, or Numeric"
@@ -287,6 +275,9 @@ module AMQP
       log 'reconnecting'
       logger.info("[amqp] Attempting to reconnect to #{@settings[:identity]}")
       EM.reconnect(@settings[:host], @settings[:port], self)
+    rescue Exception => e
+      logger.exception("[amqp] Failed to reconnect", e, :trace)
+      failed
     end
 
     def self.connect opts = {}
@@ -300,14 +291,14 @@ module AMQP
 
     def failed
       @connection_status.call(:failed) if @connection_status
-      @failed = true
+      @has_failed = true
       close_connection
     end
 
     private
 
     def disconnected
-      unless @failed
+      unless @has_failed
         @connection_status.call(:disconnected) if @connection_status
         reconnect
       end

data/right_amqp.gemspec

@@ -24,8 +24,8 @@ require 'rubygems'
 
 Gem::Specification.new do |spec|
   spec.name      = 'right_amqp'
-  spec.version   = '0.3.2'
-  spec.date      = '2012-10-04'
+  spec.version   = '0.3.3'
+  spec.date      = '2012-10-30'
   spec.authors   = ['Lee Kirchhoff']
   spec.email     = 'lee@rightscale.com'
   spec.homepage  = 'https://github.com/rightscale/right_amqp'

data/spec/amqp/client_extensions_spec.rb

@@ -33,7 +33,7 @@ describe AMQP::Client do
     class SUT
       include AMQP::Client
 
-      attr_accessor :reconnecting, :settings, :channels
+      attr_accessor :reconnecting, :settings, :channels, :has_failed
     end
 
     before(:each) do
@@ -88,7 +88,7 @@ describe AMQP::Client do
       end
     end
 
-    context 'with a :reconnect_interval of 5 seconds'  do
+    context 'with a :reconnect_interval of 5 seconds' do
       it 'should schedule reconnect attempts on a 5s interval' do
         @sut.reconnecting = true
         @sut.settings[:reconnect_delay] = 15
@@ -101,6 +101,17 @@ describe AMQP::Client do
       end
     end
 
+    context 'with a reconnect failure' do
+      it 'should fail the connection' do
+        @logger.should_receive(:error).with(/Failed to reconnect/).once
+        flexmock(EM).should_receive(:reconnect).and_raise(Exception).once
+        flexmock(@sut).should_receive(:close_connection).once
+
+        @sut.reconnect()
+        @sut.has_failed.should be_true
+      end
+    end
+
   end
 
   context "heartbeat" do

metadata

@@ -2,7 +2,7 @@
 name: right_amqp
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors: 
 - Lee Kirchhoff
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-10-04 00:00:00 Z
+date: 2012-10-30 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: right_support
@@ -108,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 60400910479135744
+      hash: 3853339962188716916
       segments: 
       - 0
       version: "0"