right-rails 0.5.0 → 0.5.1

data/lib/right_rails/helpers/basic.rb

@@ -23,7 +23,7 @@ module RightRails::Helpers::Basic
     end
     
     # use the sources in the development environment
-    if defined? RAILS_ENV && RAILS_ENV == 'development'
+    if defined?(RAILS_ENV) && RAILS_ENV == 'development'
       scripts.collect!{ |name| name + '-src' }
     end
     

data/lib/right_rails/helpers/forms.rb

@@ -119,7 +119,7 @@ module RightRails::Helpers::Forms
   #
   def rater_display(value, options={})
     content_tag :div, (0...(options[:size] || 5)).to_a.collect{ |i|
-      content_tag :div, '★', :class => i < value ? 'right-rater-glow' : nil
+      content_tag :div, '&#9733;', :class => i < value ? 'right-rater-glow' : nil
     }.join(''), :class => 'right-rater right-rater-disabled'
   end
   

data/lib/right_rails/helpers/misc.rb

@@ -6,9 +6,12 @@ module RightRails::Helpers::Misc
   # Just a simple flashes generator, might be replaced in the application
   #
   def flashes
-    content_tag(:div, flash.collect{ |key, text|
+    items = flash.collect{ |key, text|
       content_tag(:div, text, :class => key)
-    }.sort, :id => :flashes, :style => (flash.empty? ? 'display: none' : nil))
+    }.sort.join("")
+    
+    content_tag(:div, items.send(''.respond_to?(:html_safe) ? :html_safe : :to_s),
+      :id => :flashes, :style => (flash.empty? ? 'display: none' : nil))
   end
   
   
@@ -33,10 +36,12 @@ module RightRails::Helpers::Misc
     escape    = options[:escape].nil? ? true : options[:escape]
     field     = args.first
     
-    content_tag :ul, entries.collect{ |entry|
+    items     = entries.collect{ |entry|
       entry = entry.send(field) if field
       content_tag :li, highlight ? highlight(entry, highlight) : escape ? h(entry) : entry
-    }
+    }.join("")
+    
+    content_tag :ul, items.send(''.respond_to?(:html_safe) ? :html_safe : :to_s)
   end
   
   

data/spec/lib/right_rails/helpers/basic_spec.rb

@@ -41,14 +41,6 @@ describe RightRails::Helpers::Basic do
     rightjs_scripts
   end
   
-  it "should use the source scripts in the development environment" do
-    should_receive(:javascript_include_tag).with(*%w{right-src right/rails-src})
-    
-    RAILS_ENV = 'development'
-    
-    rightjs_scripts
-  end
-  
   it "should build a script-generator for the rjs method" do
     rjs.should be_a(RightRails::JavaScriptGenerator)
   end
@@ -70,4 +62,20 @@ describe RightRails::Helpers::Basic do
       page.boo.boo.boo
     end.to_s.should == 'javascript_tag'
   end
+  
+  describe "in the development mode" do
+    before :all do
+      Kernel::RAILS_ENV = 'development'
+    end
+    
+    after :all do 
+      Kernel::RAILS_ENV = 'production'
+    end
+    
+    it "should use the source scripts" do
+      should_receive(:javascript_include_tag).with(*%w{right-src right/rails-src})
+
+      rightjs_scripts
+    end
+  end
 end

data/spec/lib/right_rails/helpers/forms_spec.rb

@@ -46,6 +46,6 @@ describe RightRails::Helpers::Forms do
   
   it "should generate the #rater_display tag" do
     rater_display(4).should ==
-      %Q{<div class="right-rater right-rater-disabled"><div class="right-rater-glow">★</div><div class="right-rater-glow">★</div><div class="right-rater-glow">★</div><div class="right-rater-glow">★</div><div>★</div></div>}
+      %Q{<div class="right-rater right-rater-disabled"><div class="right-rater-glow">&#9733;</div><div class="right-rater-glow">&#9733;</div><div class="right-rater-glow">&#9733;</div><div class="right-rater-glow">&#9733;</div><div>&#9733;</div></div>}
   end
 end

data/spec/lib/right_rails/helpers/rails_spec.rb

@@ -17,6 +17,16 @@ module ActionView::Helpers::RailsLegacyHelper
       link_to_function(name, remote_function(options), html_options || options.delete(:html))
     end
     
+    def link_to_function(name, *args, &block)
+      html_options = args.extract_options!.symbolize_keys
+    
+      function = block_given? ? update_page(&block) : args[0] || ''
+      onclick = "#{"#{html_options[:onclick]}; " if html_options[:onclick]}#{function}; return false;"
+      href = html_options[:href] || '#'
+    
+      content_tag(:a, name, html_options.merge(:href => href, :onclick => onclick))
+    end
+    
     def button_to_remote(name, options = {}, html_options = {})
       button_to_function(name, remote_function(options), html_options)
     end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 5
-  - 0
-  version: 0.5.0
+  - 1
+  version: 0.5.1
 platform: ruby
 authors: 
 - Nikolay Nemshilov
@@ -14,11 +14,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-28 00:00:00 +03:00
+date: 2010-03-31 00:00:00 +04:00
 default_executable: 
 dependencies: []
 
-description: RightRails provides support of the RightJS framework with transparent Rails/Prototype replacements, plus it has a new RJS processor, the most common ajax operations interface, RightJS own features support, remote files uploading handler, etc.
+description: RightRails provides support of the RightJS JavaScript framework. It has transparent Prototype helpers replacement, plus there is a new RJS processor, the most common ajax operations interface, RightJS own features support, remote files uploading handler, etc.
 email: nemshilov@gmail.com
 executables: []
 
@@ -113,9 +113,7 @@ has_rdoc: true
 homepage: http://github.com/MadRabbit/right-rails
 licenses: []
 
-post_install_message: "\n\
-  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< RIGHT RAILS >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>\n\n  Please run the following command to copy RightJS scripts and modules in place\n  \n  script/generate right_rails\n\n\
-  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< RIGHT RAILS >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>\n  "
+post_install_message: 
 rdoc_options: []
 
 require_paths: