riemann-bacula 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6352841033d7fa669793cba957a59cc4fa35369d2866914dbb782bb3b507f97
-  data.tar.gz: 66826e73f558d5f2c788d0a5b3b60a413b420f76e47957a517727f51ae7ec15c
+  metadata.gz: c7c2bdcd4f13414f04163482d874341b8771dbff7ecb84fe2c96d68ec75e8553
+  data.tar.gz: 22a3eb9612eeec5727e800a915dc534d47978baf7b055425efe0f24c13966c7c
 SHA512:
-  metadata.gz: 3d1888b9a7920c0dab4b5c3c30ae8b06acf5ed8e54eaa70e6e848db3ff1dd1087282b42b2a0be1a857935e6497ff662e445383c2be07276a033d7a1ce84fb042
-  data.tar.gz: 74117f74b1181b5d619e27d04f888627ee1d212a9fc66aa78a657374847f8fad9a3b1c999976126db5fab600ef5698a9b699b4d562997a39bbc6940bd3850acb
+  metadata.gz: 6cd99cf77b7e0ca07f2d8d4d48f408cdf7a134ff9e2f43ac512e5ddc9b75cc54dda3c120583983a32ca3d1824da2cf68df3ebfd4ded7efd75f6bdb9fbd11d382
+  data.tar.gz: 6929197169f1a28d3bfcf094120f8adde8a289a2e8cc2f89ca07a1b8659e1757c0f935488de75274d72a21fe9418365eb1d676a1a3b395b6e340d7b3334f2ce8

data/.github/CODEOWNERS

@@ -1,4 +1 @@
-# DO NOT EDIT THIS FILE!
-# This file is managed by ModuleSync.
-
-* @opus-codium/core
+* @opus-codium/core, @opus-codium/vittoria-conseil

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [v2.0.0](https://github.com/opus-codium/riemann-bacula/tree/v2.0.0) (2022-11-14)
+
+[Full Changelog](https://github.com/opus-codium/riemann-bacula/compare/v1.2.0...v2.0.0)
+
+**Breaking changes:**
+
+- Add parameters and make them mandatory [\#7](https://github.com/opus-codium/riemann-bacula/pull/7) ([smortex](https://github.com/smortex))
+
+**Merged pull requests:**
+
+- Fix how we set the host of bacula events [\#8](https://github.com/opus-codium/riemann-bacula/pull/8) ([smortex](https://github.com/smortex))
+
 ## [v1.2.0](https://github.com/opus-codium/riemann-bacula/tree/v1.2.0) (2022-10-27)
 
 [Full Changelog](https://github.com/opus-codium/riemann-bacula/compare/v1.1.0...v1.2.0)

data/README.md

@@ -17,7 +17,7 @@ In your Bacula Director configuration, add a Message resource like this (the pro
 ```
 Messages {
   Name = Standard
-  MailCommand = "riemann-bacula"
+  MailCommand = "riemann-bacula --event-host \"%h\" --job-name \"%n\" --backup-level \"%l\" --status \"%e\" --bytes \"%b\" --files \"%F\""
   Mail = sysadmin@example.com = all, !skipped
 }
 ```

data/lib/riemann/tools/bacula/version.rb

@@ -3,7 +3,7 @@
 module Riemann
   module Tools # :nodoc:
     class Bacula
-      VERSION = '1.2.0'
+      VERSION = '2.0.0'
     end
   end
 end

data/lib/riemann/tools/bacula.rb

@@ -9,16 +9,54 @@ module Riemann
     class Bacula
       include Riemann::Tools
 
-      opt :details, 'Send detailed metrics beyond overall status', default: true
+      opt :job_name,     'Job name (%n)',        short: :none, type: :string
+      opt :backup_level, 'Job Level (%l)',       short: :none, type: :string
+      opt :status,       'Job Exit Status (%e)', short: :none, type: :string
+
+      opt :bytes, 'Job Bytes (%b)', short: :none, type: :integer
+      opt :files, 'Job Files (%F)', short: :none, type: :integer
+
+      opt :details, 'Send detailed metrics beyond overall status', short: :none, default: true
 
       def self.process_stdin
         new.process_stdin
       end
 
       def run
-        options
+        %i[job_name backup_level status].each do |name|
+          raise("Parameter #{name} is required") unless opts[name]
+        end
+
         data = parse($stdin.read)
-        send_events(data) if data
+
+        report({
+                 service: "bacula backup #{opts[:job_name]}",
+                 state: bacula_backup_state,
+                 job_name: opts[:job_name],
+                 backup_level: opts[:backup_level],
+                 description: data['Termination'],
+               })
+
+        %i[bytes files].each do |metric|
+          next unless opts[metric]
+
+          report({
+                   service: "bacula backup #{opts[:job_name]} #{opts[:backup_level].downcase} #{metric}",
+                   metric: opts[metric],
+                   job_name: opts[:job_name],
+                   backup_level: opts[:backup_level],
+                 })
+        end
+
+        send_details(data) if options[:details]
+      end
+
+      def bacula_backup_state
+        case opts[:status]
+        when 'OK' then 'ok'
+        else
+          'critical'
+        end
       end
 
       def parse(text)
@@ -43,19 +81,14 @@ module Riemann
           line_continuation = (key if line.length == 998)
         end
 
-        return nil unless valid?(data)
-
         enhance(data)
       end
 
-      def valid?(data)
-        %w[
-          Job
-          Termination
-        ].all? { |key| data.key?(key) }
-      end
-
       def enhance(data)
+        # If the message on stdin was trucated, the last item might not make
+        # sense.
+        data.delete(data.keys.last) if data.keys.last != 'Termination'
+
         {
           parse_size: [
             'FD Bytes Written',
@@ -103,7 +136,6 @@ module Riemann
 
         extract_client_info(data)
         extract_backup_level_info(data)
-        extract_job_name(data)
 
         data
       end
@@ -126,10 +158,6 @@ module Riemann
         data['Client Version'] = Regexp.last_match(2)
       end
 
-      def extract_job_name(data)
-        data['Job Name'] = data['Job'].sub(/\.\d{4}-\d{2}-\d{2}_\d{2}\.\d{2}\.\d{2}_\d{2}\z/, '')
-      end
-
       def extract_source(item, data)
         return unless /\A"([^"]+)" \(From (Client|Job|Pool) resource\)\z/.match(data[item])
 
@@ -189,22 +217,7 @@ module Riemann
         value.split('|')
       end
 
-      def send_events(data)
-        event = {}
-        event[:service] = "bacula backup #{data['Job Name']}"
-        event[:state] = case data['Termination']
-                        when /\A(Backup|Restore) OK\z/ then 'ok'
-                        when 'Backup OK -- with warnings' then 'warning'
-                        else
-                          'critical'
-                        end
-        event[:description] = data['Termination']
-        event[:job_name] = data['Job Name']
-        event[:backup_level] = data['Backup Level']
-        report(event)
-
-        return unless options[:details]
-
+      def send_details(data)
         [
           'Elapsed time',
           'FD Files Written',
@@ -217,12 +230,14 @@ module Riemann
           'Comm Line Compression',
           'Non-fatal FD errors',
         ].each do |metric|
-          event = {}
-          event[:service] = "bacula backup #{data['Job Name']} #{data['Backup Level'].downcase} #{metric.downcase}"
-          event[:metric] = data[metric]
-          event[:job_name] = data['Job Name']
-          event[:backup_level] = data['Backup Level']
-          report(event)
+          next unless data[metric]
+
+          report({
+                   service: "bacula backup #{opts[:job_name]} #{opts[:backup_level].downcase} #{metric.downcase}",
+                   metric: data[metric],
+                   job_name: opts[:job_name],
+                   backup_level: opts[:backup_level],
+                 })
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: riemann-bacula
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Romain Tartière
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-27 00:00:00.000000000 Z
+date: 2022-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: riemann-tools
@@ -122,7 +122,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - romain@blogreen.org
 executables:
@@ -153,7 +153,7 @@ metadata:
   source_code_uri: https://github.com/opus-codium/riemann-bacula
   changelog_uri: https://github.com/opus-codium/riemann-bacula
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -168,8 +168,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.5
-signing_key: 
+rubygems_version: 3.3.23
+signing_key:
 specification_version: 4
 summary: Submits bacula information to riemann
 test_files: []