ridley 2.4.1 → 2.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb6b2d972e7cad1c5ff8f3146d8f89bb13b195d8
-  data.tar.gz: 528c096c325dbd733bdf34bfd9db7626e0b4c881
+  metadata.gz: 362b667bff0340e4cba7d750a251c91003811218
+  data.tar.gz: 173dd3384ef80483faa2d7f4137e2ffca339a310
 SHA512:
-  metadata.gz: f61bf70fb4e308195fa5217b993a5e4bc143532ed544f2904b97936b054a5c5f123a0a7e204b14b836fec1e1deb3189111252ed78c0bc876273d31b6470a51a5
-  data.tar.gz: ac987d268761de5aeb80435726d81c0436c8adf40b750774d7e129b98f29838dcd748a3e0234333edb1876b10a78c44b1f75b1bb6e41646ce13fefc5dd5160fa
+  metadata.gz: 21d2e559ff5a3dc38a4dbae1fed6b33013aa8612771bac3199442ed7844eeea767fcc5a8affa920df3a2c48f2872b33709b81cab643655d4f9d683105325d215
+  data.tar.gz: 07af89b3508d66d6533ac7b8c7353ca015d461fd240a9942b6af6466b6457b85027fffa8067b4e18f4405abc98ef34e614284a5830c55fd8407455c56e934158

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.4.2
+
+* [#244](https://github.com/RiotGames/ridley/pull/244) Fix a bug with deleting deeply nested environment attributes.
+
 # 2.4.0
 
 * Add support for Chef 11 User Objects

data/README.md

@@ -201,6 +201,13 @@ ridley.role.all #=> [
   #<Ridley::RoleObject chef_id:motherbrain_proxy ...>
 ]
 ```
+Notify: You have to send the #reload message to node objects returned from a full listing. Their attributes aren't automatically populated from the initial search.
+
+```ruby
+ridley = Ridley.new(...)
+ridley.role.all.first  => #<Ridley::RoleObject chef_id:some_chef_id, attributes:#<VariaModel::Attributes chef_type="role" default_attributes=#<Hashie::Mash> description="" env_run_lists=#<VariaModel::Attributes> json_class="Chef::Role" name="some_chef_id" override_attributes=#<Hashie::Mash> run_list=[]>>
+ridley.role.all.first.reload => #<Ridley::RoleObject chef_id:some_chef_id, attributes:#<VariaModel::Attributes chef_type="role" default_attributes=#<Hashie::Mash SOME ATTRIBUTES> description="Some description" env_run_lists=#<VariaModel::Attributes> json_class="Chef::Role" name="some_chef_id" override_attributes=#<Hashie::Mash> run_list=[ SOME RUN LIST ]>>
+````
 
 ##### Finding
 

data/lib/ridley/chef_objects/environment_object.rb

@@ -96,7 +96,7 @@ module Ridley
         when :override
           attributes_to_change = self.override_attributes
         end
-        leaf_hash = dotted_path.inject(attributes_to_change) { |hash, element| hash[element] }
+        leaf_hash = dotted_path.inject(attributes_to_change) { |hash, element| hash[element] unless hash == nil }
         leaf_hash.delete(leaf_key) unless leaf_hash.nil?
         attributes_to_change
       end

data/lib/ridley/version.rb

@@ -1,3 +1,3 @@
 module Ridley
-  VERSION = "2.4.1"
+  VERSION = "2.4.2"
 end

data/spec/unit/ridley/chef_objects/environment_object_spec.rb

@@ -75,6 +75,19 @@ describe Ridley::EnvironmentObject do
           expect(subject.default_attributes[:hello][:world]).to be_true
         end
       end
+
+      context "when an internal hash is nil" do
+        let(:delete_default_attribute) { subject.delete_default_attribute("never.not.existing") }
+
+        before do
+          subject.default_attributes = Hash.new
+        end
+
+        it "does not delete anything" do
+          delete_default_attribute
+          expect(subject.default_attributes).to be_empty
+        end
+      end
     end
 
     describe "#delete_override_attribute" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ridley
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.4.2
 platform: ruby
 authors:
 - Jamie Winsor
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-16 00:00:00.000000000 Z
+date: 2014-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable