richurls 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8022d5e37dee37aa4e7a47b1cecd65075bcb88cce334109ed7df216f2f7971f
-  data.tar.gz: 3630be60335862908a877de2c9c751febb103a53c1e57517e64f309ff2e11f11
+  metadata.gz: 5198667f5f8b0ab26bfb13bd20f7631e59242abeced6b244f63f275626162ee6
+  data.tar.gz: 5faf0205ed0a278f9fe2bbcc4d0cf3d2cfccf3916fee2546c21fcb5ae4661462
 SHA512:
-  metadata.gz: 7f1f87d3f68b20d44f8303f4922f196e1acfc7a84954880de3b4abdee4b0a669edc33913accc9bcf61bf680c9992f347f1de6fbbc407837dfaf91c0df95532e2
-  data.tar.gz: 7bd2d865aeab876e83f7100039ebfd38d3e14d06dbcb11bdcdeeb0111703ec6ea91858006e085834aa5c6312138ff620d45ee7615df79e99501b498a526a4f9c
+  metadata.gz: 5a693158c7276651a01899ce1db0eb0f32bbe97d16812f3fa6fe9bbd76b70314838259c45ccafa2a2b0ce041cd29f5c34d2249206b345cace3fa3f7968c39897
+  data.tar.gz: 5087bbc294f8adc06c563d8763fc9db3d6db529b77cedd99e7cb784641e265492db431906d67af84fdcd503858b1593a9d584c1f9ffbbd0ed91eb92c55afa4de

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    richurls (0.5.3)
+    richurls (0.5.4)
       addressable (~> 2)
       oj (~> 3)
       ox (~> 2)
@@ -18,12 +18,12 @@ GEM
     oj (3.10.6)
     ox (2.13.2)
     parallel (1.19.1)
-    parser (2.7.0.5)
+    parser (2.7.1.1)
       ast (~> 2.4.0)
     patron (0.13.3)
     public_suffix (4.0.4)
     rainbow (3.0.0)
-    redis (4.1.3)
+    redis (4.1.4)
     rexml (3.2.4)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
@@ -38,7 +38,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
-    rubocop (0.81.0)
+    rubocop (0.82.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)

data/lib/url_helper.rb

@@ -1,22 +1,38 @@
 require 'addressable'
 
-module UrlHelper
+class UrlHelper
   def self.url_for(domain, url)
-    return if url.nil?
-    return url if valid_url?(url)
+    new(domain, url).url
+  end
+
+  private_class_method :new
 
-    domain_uri = URI(domain)
+  def initialize(domain, url)
+    @domain = domain
+
+    # In some rare cases it appears to be that URL's are ending with a
+    # single whitespace character resulting in an invalid URL.
+    @url = url&.strip
+  end
+
+  def url
+    return if @url.nil?
+    return @url if valid_url?
+
+    domain_uri = URI(@domain)
     base = domain_uri.scheme + '://' + domain_uri.host
-    escaped_url = Addressable::URI.escape(url)
+    escaped_url = Addressable::URI.escape(@url)
 
-    if url.start_with?('/')
+    if @url.start_with?('/')
       base + escaped_url
     else
       base + domain_uri.path + '/' + escaped_url
     end
   end
 
-  def self.valid_url?(url)
-    url.start_with?('//') || url =~ URI::DEFAULT_PARSER.make_regexp
+  private
+
+  def valid_url?
+    @url.start_with?('//') || @url =~ URI::DEFAULT_PARSER.make_regexp
   end
 end

data/richurls.gemspec

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name = 'richurls'
-  spec.version = '0.5.3'
+  spec.version = '0.5.4'
   spec.authors = ['grdw']
   spec.email = ['gerard@wetransfer.com']
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: richurls
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - grdw
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-16 00:00:00.000000000 Z
+date: 2020-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable