rice 4.11.3 → 4.11.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2b52ff5ddc64209e1c252d529111695d833a57d1362e15b6d223777194dc6750
-  data.tar.gz: 214c2b675683e68d026440cc83499a7de0faa6282563c0bfa028c925e677f195
+  metadata.gz: '07196451c8152b8110d5a2aa17d9d1073c846139a8e08d3fe71217095c3386d6'
+  data.tar.gz: d0a84860a008461a29396679953abe8377f24b92ee9085ed84820dd946065390
 SHA512:
-  metadata.gz: fdee833532115137ec7e375e83e377c5e21a634b44e0b67bb5954ea3ad04a2983ef3c6ffc5d5deb804b1d94c7b76f04d2cc94b73b054aaa0722f01fd39f58c37
-  data.tar.gz: 23e9990bbf398a067608c29028018840506254f3a8a00a7f6cc56840ec88e70007d0309656b297b20ab31776805b3deccb14e16fface820b0ec7d3340aafc0f3
+  metadata.gz: 1d560e79db1a4645bd6d1084e0df00a44d79795b14d963292e731912c1bcabf29578846ff18a2bf8f8cdb171419c1b13be66b358582328ff5e4d18c61aee8731
+  data.tar.gz: bfa6478914622bf559db804f3ccb10fd51c39973ff7032a07d2ced37c7d5fbbacd3b9417ed4399499f97f209ec115daecabd7e9ab75a145dfaba9c6c2d94478e

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 4.11.4 (2026-03-13)
+
+### Bug Fixes
+
+* Fix memory leak (#397)
+
 ## 4.11.3 (2026-03-11)
 
 ### Bug Fixes

data/include/rice/rice.hpp

@@ -10283,8 +10283,9 @@ namespace Rice::detail
     if constexpr (is_complete_v<T>)
     {
       // is_abstract_v requires a complete type, so nest inside is_complete_v.
-      // Deleting an abstract class through a non-virtual destructor is UB.
-      if constexpr (std::is_destructible_v<T> && !std::is_abstract_v<T>)
+      // Deleting an abstract class through a non-virtual destructor is UB,
+      // but it is safe if the destructor is virtual.
+      if constexpr (std::is_destructible_v<T> && (!std::is_abstract_v<T> || std::has_virtual_destructor_v<T>))
       {
         if (this->isOwner_)
         {

data/lib/rice/version.rb

@@ -1,3 +1,3 @@
 module Rice
-  VERSION = "4.11.3"
+  VERSION = "4.11.4"
 end

data/rice/detail/Wrapper.ipp

@@ -122,8 +122,9 @@ namespace Rice::detail
     if constexpr (is_complete_v<T>)
     {
       // is_abstract_v requires a complete type, so nest inside is_complete_v.
-      // Deleting an abstract class through a non-virtual destructor is UB.
-      if constexpr (std::is_destructible_v<T> && !std::is_abstract_v<T>)
+      // Deleting an abstract class through a non-virtual destructor is UB,
+      // but it is safe if the destructor is virtual.
+      if constexpr (std::is_destructible_v<T> && (!std::is_abstract_v<T> || std::has_virtual_destructor_v<T>))
       {
         if (this->isOwner_)
         {

data/test/test_Ownership.cpp

@@ -188,6 +188,36 @@ namespace
     static inline MyCopyableClass* instance_ = nullptr;
   };
 
+  // Abstract class with virtual destructor - deletion through base pointer is safe
+  class AbstractVirtualDtor
+  {
+  public:
+    static inline int destructorCalls = 0;
+
+    static void reset()
+    {
+      destructorCalls = 0;
+    }
+
+    virtual ~AbstractVirtualDtor()
+    {
+      destructorCalls++;
+    }
+
+    virtual int compute() const = 0;
+  };
+
+  class ConcreteChild : public AbstractVirtualDtor
+  {
+  public:
+    int compute() const override { return 42; }
+  };
+
+  AbstractVirtualDtor* createChild()
+  {
+    return new ConcreteChild();
+  }
+
   class OwnerBox;
 
   class AliasBox
@@ -327,6 +357,14 @@ SETUP(Ownership)
     .define_constructor(Constructor<SharedFactory>())
     .define_method("create_owned", &SharedFactory::createOwned, Return().takeOwnership())
     .define_method("get_borrowed", &SharedFactory::getBorrowed);
+
+  define_class<AbstractVirtualDtor>("AbstractVirtualDtor")
+    .define_method("compute", &AbstractVirtualDtor::compute);
+
+  define_class<ConcreteChild, AbstractVirtualDtor>("ConcreteChild");
+
+  define_module("AbstractVirtualDtorTest")
+    .define_module_function("create_child", &createChild, Return().takeOwnership());
 }
 
 TEARDOWN(Ownership)
@@ -541,3 +579,23 @@ TESTCASE(MultipleOwnerReferences)
   result = m.module_eval(code);
   ASSERT_EQUAL(Qfalse, result.value());
 }
+
+TESTCASE(AbstractVirtualDestructor)
+{
+  AbstractVirtualDtor::reset();
+
+  Module m = define_module("TestingModule");
+
+  std::string code = R"(child = AbstractVirtualDtorTest.create_child
+                        child.compute)";
+
+  Object result = m.module_eval(code);
+  ASSERT_EQUAL(detail::To_Ruby<int>().convert(42), result.value());
+
+  // Force GC to clean up the object - destructor should be called
+  // since AbstractVirtualDtor has a virtual destructor
+  rb_gc_start();
+  rb_gc_start();
+
+  ASSERT_EQUAL(1, AbstractVirtualDtor::destructorCalls);
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rice
 version: !ruby/object:Gem::Version
-  version: 4.11.3
+  version: 4.11.4
 platform: ruby
 authors:
 - Paul Brannan