riak-client 1.4.4 → 1.4.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f602fb1292ff4446d86a41720d2268f1f4af2d0f
-  data.tar.gz: 1bb7e3e3c23a897d31bd49d8e724ab449b1a7e3f
+  metadata.gz: f0470172bce5c87b1894c0b14f10f3305944361b
+  data.tar.gz: a27f23fe2344aa79477f037d741621aca64acef9
 SHA512:
-  metadata.gz: ac4c30bf7e8862ad4daa6875f993ddb15069b727f1a82f581e0f9f73a6c9d1b722f0b1a5588346ae92bd206a09ec297b207ea62ba84804ae71aebff4659a8bed
-  data.tar.gz: 565c25a5210899cbb8344917921180c005fb66015e64935efb88b9a7e9e2a4775d0bd32d77323deb4a0cabb51c3b9e8051ca4a66ff466de469095270a5014bad
+  metadata.gz: 83dd6430cf599ab6d682dff05bc15247ad8912c5d771dc70cd41170fb78e1b9535ccb51c89aa1d03d26f707bd34b1d3a3114e1dc0c6177504135f1f9f90bddac
+  data.tar.gz: 656b3e793a6e54820d0ab851064121d702c126619296a0ac4b911801c106e49d116fc08162390edf6f70b92c3a8aedba3d2b950ed8a085e32707803393b2add0

data/RELEASE_NOTES.md

@@ -1,5 +1,19 @@
 # Riak Ruby Client Release Notes
 
+## 1.4.4.1 Bugfix Release - 2014-04-17
+
+Release 1.4.4.1 includes the intended 1.4.4 bugfix:
+
+* Remove freedom-patched `Net::HTTPHeader#each_capitalized` method. This
+  caused infinite loops when parsing HTTP headers not related to Riak,
+  and is not necessary in Riak versions newer than 1.1.0. Thanks to
+  Morten Primdahl and Steven Davidovitz at Zendesk for helping isolate and
+  troubleshoot this.
+
+## 1.4.4 - 2014-04-17
+
+No changes from 1.4.3.
+
 ## 1.4.3 Bugfix Release - 2013-12-31
 
 Release 1.4.3 fixes some bugs and improves documentation.

data/lib/riak/util/headers.rb

@@ -1,26 +1,5 @@
 require 'net/http'
 
-# Splits headers into < 8KB chunks
-# @private
-module Net::HTTPHeader
-  def each_capitalized
-    # 1.9 check
-    respond_to?(:enum_for) and (block_given? or return enum_for(__method__))
-    @header.each do |k,v|
-      base_length = "#{k}: \r\n".length
-      values = v.map {|i| i.to_s.split(", ") }.flatten
-      while !values.empty?
-        current_line = ""
-        while values.first && current_line.length + base_length + values.first.length + 2 < 8192
-          val = values.shift.strip
-          current_line += current_line.empty? ? val : ", #{val}"
-        end
-        yield capitalize(k), current_line
-      end
-    end
-  end
-end
-
 module Riak
   module Util
     # Represents headers from an HTTP request or response.

data/lib/riak/version.rb

@@ -1,3 +1,3 @@
 module Riak
-  VERSION = "1.4.4"
+  VERSION = "1.4.4.1"
 end

data/spec/riak/headers_spec.rb

@@ -18,21 +18,4 @@ describe Riak::Util::Headers do
     h.parse("Content-Type: text/plain\r\n")
     h.to_hash.should == {"content-type" => ["text/plain"]}
   end
-
-  it "should split headers larger than 8KB" do
-    # This really tests Net::HTTPHeader#each_capitalized, which is
-    # used by Net::HTTP to write the headers to the socket. It does
-    # not cover the case where a single value is larger than 8KB. If
-    # you're doing that, you have something else wrong.
-    h = Riak::Util::Headers.new
-    10.times do
-      h.add_field "Link", "f" * 820
-    end
-    count = 0
-    h.each_capitalized do |k,v|
-      count += 1
-      "#{k}: #{v}\r\n".length.should < 8192
-    end
-    count.should > 1
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: riak-client
 version: !ruby/object:Gem::Version
-  version: 1.4.4
+  version: 1.4.4.1
 platform: ruby
 authors:
 - Sean Cribbs