riaction 1.3.3 → 1.3.4

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG #
 
+## 1.3.4 ##
+
+* background logging of events will first check if the profile exists, and re-enqueue the job if it doesn't, up to a max number of retries, at which point it will log the event regardless.
+
 ## 1.3.3 ##
 
 * fixed serious bug where object-wrapping of the API response was defaulting to false, instead of true

data/lib/riaction/constants.rb

@@ -9,6 +9,12 @@ module Riaction
     def self.retry_attempts_for_internal_error
       3
     end
+    
+    # sets the default number of attempts to retry to log an event when the profile is missing
+    # this is for when the logging of an event accidentally happens before, or too soon afterwards, the creation of a profile
+    def self.retry_attempts_for_missing_profile
+      4
+    end
 
     # sets the valid supported identifiers
     # @return  returns an array of symbols

data/lib/riaction/event_performer.rb

@@ -16,11 +16,26 @@ module Riaction
             klass_name.constantize.riaction_events? &&
             klass_name.constantize.riaction_defines_event?(event_name_sym) )
         if event_params.has_key?(event_name_sym)
-          iactionable_api.log_event(  event_params[event_name_sym][:profile][:type],
-                                      event_params[event_name_sym][:profile][:id_type],
-                                      event_params[event_name_sym][:profile][:id],
-                                      event_name_sym,
-                                      event_params[event_name_sym][:params])
+          begin
+            iactionable_api.get_profile_summary(event_params[event_name_sym][:profile][:type], 
+                                                event_params[event_name_sym][:profile][:id_type], 
+                                                event_params[event_name_sym][:profile][:id])
+            iactionable_api.log_event(  event_params[event_name_sym][:profile][:type],
+                                        event_params[event_name_sym][:profile][:id_type],
+                                        event_params[event_name_sym][:profile][:id],
+                                        event_name_sym,
+                                        event_params[event_name_sym][:params])
+          rescue IActionable::Error::BadRequest => e
+            if attempt < ::Riaction::Constants.retry_attempts_for_missing_profile
+              Resque.enqueue(self, event_name, klass_name, id, attempt+1)
+            else
+              iactionable_api.log_event(  event_params[event_name_sym][:profile][:type],
+                                          event_params[event_name_sym][:profile][:id_type],
+                                          event_params[event_name_sym][:profile][:id],
+                                          event_name_sym,
+                                          event_params[event_name_sym][:params])
+            end
+          end
         else
           raise ::Riaction::ConfigurationError.new("Instance of #{klass_name} with ID #{id} could not construct event parameters for event #{event_name}.  Is the profile a valid one?")
         end

data/lib/riaction/version.rb

@@ -1,3 +1,3 @@
 module Riaction
-  VERSION = "1.3.3"
+  VERSION = "1.3.4"
 end

data/riaction.gemspec

@@ -29,5 +29,5 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "activerecord", ">= 3.0.0"
   s.add_runtime_dependency "activesupport", ">= 3.0.0"
   s.add_runtime_dependency "resque"
-  s.add_runtime_dependency "ruby-iactionable", ">= 0.1.0"
+  s.add_runtime_dependency "ruby-iactionable", ">= 0.1.1"
 end

data/spec/event_performer_spec.rb

@@ -31,6 +31,7 @@ describe "sending an event to IActionable from the name of a riaction class and
     ActiveRecord::Base.connection.begin_db_transaction
     
     @api = mock("mocked IActionable API")
+    @api.stub!(:get_profile_summary)
     IActionable::Api.stub!(:new).and_return(@api)
     Resque.stub(:enqueue).and_return true
     
@@ -92,6 +93,36 @@ describe "sending an event to IActionable from the name of a riaction class and
       end
     end
     
+    describe "when the profile attached to the event does not exist on IActionable" do
+      before do
+        Comment.class_eval do
+          riaction :event, :name => :make_a_comment, :trigger => :create, :profile => :user, :profile_type => :player
+        end
+        
+        @comment = Comment.riactionless{ Comment.create(:user_id => @user.id, :content => 'this is a comment') }
+        
+        @api.stub!(:get_profile_summary).and_raise(IActionable::Error::BadRequest.new(nil))
+      end
+      
+      it "should not log the event, but reschedule the job with an incremented attempt count" do
+        @api.should_not_receive(:log_event)
+        Resque.should_receive(:enqueue).once.with(Riaction::EventPerformer, :make_a_comment, 'Comment', @comment.id, 1)
+        ::Riaction::EventPerformer.perform(:make_a_comment, 'Comment', @comment.id)
+      end
+      
+      describe "and the number of attempts has reached the max" do
+        it "should log the event, and not re-enqueue" do
+          @api.should_receive(:log_event).once.with(@comment.riaction_event_params[:make_a_comment][:profile][:type], 
+                                                    @comment.riaction_event_params[:make_a_comment][:profile][:id_type],
+                                                    @comment.riaction_event_params[:make_a_comment][:profile][:id],
+                                                    :make_a_comment, 
+                                                    {})
+          Resque.should_not_receive(:enqueue)
+          ::Riaction::EventPerformer.perform(:make_a_comment, 'Comment', @comment.id, Riaction::Constants.retry_attempts_for_missing_profile)
+        end
+      end
+    end
+    
     describe "when fetching the event params raises a" do
       before do
         Comment.class_eval do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: riaction
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
   prerelease: 
 platform: ruby
 authors:
@@ -11,11 +11,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-26 00:00:00.000000000Z
+date: 2012-05-03 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152390720 !ruby/object:Gem::Requirement
+  requirement: &2156249940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -23,10 +23,10 @@ dependencies:
         version: '2.8'
   type: :development
   prerelease: false
-  version_requirements: *2152390720
+  version_requirements: *2156249940
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2152389660 !ruby/object:Gem::Requirement
+  requirement: &2156249240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -34,10 +34,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152389660
+  version_requirements: *2156249240
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &2152388620 !ruby/object:Gem::Requirement
+  requirement: &2156248380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -45,10 +45,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152388620
+  version_requirements: *2156248380
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &2152387840 !ruby/object:Gem::Requirement
+  requirement: &2156247540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -56,10 +56,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152387840
+  version_requirements: *2156247540
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &2152386820 !ruby/object:Gem::Requirement
+  requirement: &2156246220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -67,10 +67,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152386820
+  version_requirements: *2156246220
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152386020 !ruby/object:Gem::Requirement
+  requirement: &2156244600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -78,10 +78,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152386020
+  version_requirements: *2156244600
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2152384740 !ruby/object:Gem::Requirement
+  requirement: &2156243000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -89,10 +89,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152384740
+  version_requirements: *2156243000
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2152383340 !ruby/object:Gem::Requirement
+  requirement: &2156241380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -100,10 +100,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152383340
+  version_requirements: *2156241380
 - !ruby/object:Gem::Dependency
   name: resque
-  requirement: &2152382840 !ruby/object:Gem::Requirement
+  requirement: &2156240400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -111,18 +111,18 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152382840
+  version_requirements: *2156240400
 - !ruby/object:Gem::Dependency
   name: ruby-iactionable
-  requirement: &2152381880 !ruby/object:Gem::Requirement
+  requirement: &2156238780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.1.1
   type: :runtime
   prerelease: false
-  version_requirements: *2152381880
+  version_requirements: *2156238780
 description: Wrapper for IActionable's restful API and an "acts-as" style interface
   for models to behave as profiles and drive game events.
 email: