rgabo-readability 0.1.2 → 0.1.3

data/VERSION

@@ -1 +1 @@
-0.1.2
+0.1.3

data/lib/readability/js/readability.js

@@ -575,7 +575,7 @@ var readability = {
                             dbg("replacing text node with a p tag with the same content.");
                             var p = document.createElement('p');
                             p.innerHTML = childNode.nodeValue;
-                            p.style.display = 'inline';
+														p.setAttribute('style', 'display: inline;')
                             p.className = 'readability-styled';
                             childNode.parentNode.replaceChild(p, childNode);
                         }
@@ -962,7 +962,7 @@ var readability = {
                 var embedCount = 0;
                 var embeds     = tagsList[i].getElementsByTagName("embed");
                 for(var ei=0,il=embeds.length; ei < il; ei++) {
-                    if (embeds[ei].src.search(readability.regexps.videoRe) == -1) {
+                    if (embeds[ei].src == null || embeds[ei].src.search(readability.regexps.videoRe) == -1) {
                       embedCount++; 
                     }
                 }

data/lib/readability/readable.rb

@@ -23,8 +23,6 @@ module Readability
     alias :remove :unlink
     
     def to_readable(args = {})
-      args[:content_only] ||= false
-      
       # dup document
       readable_doc = self.dup
       
@@ -42,6 +40,12 @@ module Readability
         page.load(File.join(File.dirname(__FILE__), 'js', 'readability.js'))
       end
       
+      # remove all linebreaks if needed
+      readable_doc.remove('br') if args[:remove_br]
+      
+      # remove footer if needed
+      readable_doc.remove('#readFooter') if args[:remove_footer]
+      
       # return <div id="readInner">...</div> if content_only
       if args[:content_only]
         return readable_doc.at_css("#readInner")

data/rgabo-readability.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rgabo-readability}
-  s.version = "0.1.2"
+  s.version = "0.1.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Gabor Ratky"]

data/spec/readability/readable_spec.rb

@@ -50,27 +50,16 @@ describe Readability::Readable do
     content = @doc.to_readable(:content_only => true)
     content.to_html.should_not include "Original Page"
   end
-end
-
-describe "Readability.js" do
-  class << self
-    def test_with(url)
-      self.class_eval do <<-EOF
-        def it "should work on #{url}" do
-          # load webpage
-          @doc = Nokogiri::HTML(open("#{url}"))
-
-          # run readability in place
-          @doc.to_readable!
-
-          @doc.to_html.should include('Readability version 1.5.0')
-        end
-  EOF
-      end
-    end
+  
+  it "can remove the footer" do
+    content = @doc.to_readable
+    content.to_html.should include "An Arc90 Laboratory Experiment"
+    
+    content = @doc.to_readable(:remove_footer => true)
+    content.to_html.should_not include "An Arc90 Laboratory Experiment"
   end
   
-  it "should not execute any Javascript" do
+  it "should not execute any Javascript in the document" do
     # load modified version of the tomdoc post
     @doc = Nokogiri::HTML(open(File.dirname(__FILE__) + '/../files/tomdoc-script_test.html'))
     
@@ -80,7 +69,9 @@ describe "Readability.js" do
     # check whether any script could change the title of the document
     @doc.window.document.title.should_not == "failed"  
   end
-  
+end
+
+describe "Readability.js" do
   it "should not fail on any article" do
     urls = YAML.load(File.open(File.join(File.dirname(__FILE__), 'urls.yaml')))
     

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rgabo-readability
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: false
   segments: 
   - 0
   - 1
-  - 2
-  version: 0.1.2
+  - 3
+  version: 0.1.3
 platform: ruby
 authors: 
 - Gabor Ratky