rfix 1.0.7.pre.61 → 1.0.7.pre.65

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f0ca636e0b0fdf5b52df3d8fdf1a0c6e5598e1099ea2827783f392d859554b02
-  data.tar.gz: b2fcdef1b9427af6c957bc8660217a58ffbe113ac6f61b10d90c25d66db65cd9
+  metadata.gz: ab51832758a2766094d61f5568dccf230cecd9ffe2527c0b90c574ac75a8243e
+  data.tar.gz: 0466e6aee2a5a63fdfff88038ad159c6e08b964f32576618a24574f3ded57429
 SHA512:
-  metadata.gz: 423bb5ff85314b5f962fd577d8edbf60190015ba16b45f2580867551fe84dd31c3464dd2e7c24789db67cda3db9810cd4fa268359112c3b6fed4a1a4576fd810
-  data.tar.gz: 26da76674da91b00c261a3d55d88d07ae6650665168cbe4963d7abf1ba3385f670569175e5360b62cdd38e1204187c11a7a307c17446b615c649faf2286ab3bb
+  metadata.gz: 2c2d60ae33674c5aa8ece23e46b69a82dc51b554cc3b11d9d4b4c597e6eab54a855851414d8f7f3dcd825fb18f4e107f8dcd60e12504bb4e8a3428e9d70c2bee
+  data.tar.gz: 125bd91a63181e343f0bc888f9e418ccaf125059aebcc88062e2f8f676feaf2621fa310bb98890542690d6c9cb65793764ce250a6638f760d0a0ad8386fcdb88

data/.travis.yml

@@ -1,4 +1,11 @@
 language: ruby
+cache:
+  bundler: true
+  directories:
+    - $HOME/.rvm
+    - $HOME/Library/Caches/Homebrew
+before_cache:
+  - brew cleanup
 rvm:
   - 2.5.0
   - 2.6.2
@@ -17,8 +24,7 @@ gemfile:
   - ci/Gemfile.rubocop-0.85.1
 before_install:
   - yes | gem update --system --force
-  - gem uninstall bundler
-  - gem install bundler -v 2.1.4
+  - gem install bundler
   - bundle config git.allow_insecure true
 install:
   - bundle install

data/README.md

@@ -1,4 +1,4 @@
-# Rfix [![Build Status](https://travis-ci.org/oleander/rfix-rb.svg?branch=master)](https://travis-ci.org/oleander/rfix-rb) ![Gem](https://img.shields.io/gem/dt/rfix)
+# Rfix [![Build Status](https://travis-ci.org/oleander/rfix-rb.svg?branch=master)](https://travis-ci.org/oleander/rfix-rb) [![Gem](https://img.shields.io/gem/dt/rfix)](https://rubygems.org/gems/rfix)
 
 RuboCop CLI that only complains about your latest changes
 

data/lib/rfix.rb

@@ -5,9 +5,22 @@
 
 require "rfix/version"
 require "rfix/log"
-require "rfix/extensions"
+require "rfix/extensions/extensions"
+require "rfix/extensions/offense"
 require "rfix/rfix"
 
 module Rfix
+  module Ext; end
   extend self
 end
+
+RuboCop::Options.prepend(Rfix::Ext::Options)
+RuboCop::Runner.prepend(Rfix::Ext::Runner)
+RuboCop::CommentConfig.prepend(Rfix::Ext::CommentConfig)
+RuboCop::Cop::Offense.prepend(Rfix::Ext::Offense)
+
+# TODO: Handle cases where color can't be resolved by CLI::UI
+RuboCop::Formatter::SimpleTextFormatter::COLOR_FOR_SEVERITY.each do |severity, color|
+  id = RuboCop::Cop::Severity::CODE_TABLE.invert.fetch(severity)
+  CLI::UI::Glyph.new(id.to_s, 0x25cf, CLI::UI.resolve_color(color))
+end

data/lib/rfix/extensions/extensions.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require "rubocop"
+require "rainbow"
+
+module Rfix::Ext
+  module CommentConfig
+    # Called by RuboCop on every line to see
+    # if its suppose to run against it or not
+    def cop_enabled_at_line?(_cop, line)
+      Rfix.enabled?(processed_source.file_path, line) && super
+    end
+  end
+
+  module Runner
+    # Called _after_ @source has been 'auto fixed' by Rubocop
+    def check_for_infinite_loop(source, offences)
+      # rubocop:disable Style/Semicolon
+      Rfix.refresh!(source); super # TODO: Before or after?
+      # rubocop:enable Style/Semicolon
+    end
+  end
+
+  module Options
+    # Appends custom --args to RuboCop CLI
+    def define_options
+      super.tap do |options|
+        @ons.each do |args, block|
+          option(options, *args, &block)
+        end
+      end
+    end
+
+    # Helper method used by rfix to append cli --args to Rubocop
+    def on(*args, &block)
+      @ons ||= []
+      @ons += [[args, block]]
+    end
+  end
+end

data/lib/rfix/extensions/offense.rb

@@ -0,0 +1,77 @@
+module Rfix::Ext
+  module Offense
+    def where
+      line.to_s + ":" + real_column.to_s
+    end
+
+    def info
+      message.split(": ", 2).last.delete("\n")
+    end
+
+    def msg
+      CLI::UI.resolve_text("{{italic:#{info}}}", truncate_to: CLI::UI::Terminal.width - 10)
+    end
+
+    def code
+      message.split(": ", 2).first
+    end
+
+    def star
+      Rainbow("⭑")
+    end
+
+    def cross
+      Rainbow("✗").red
+    end
+
+    def check
+      Rainbow("✓").green
+    end
+
+    def circle
+      Rainbow("⍟")
+    end
+
+    def relative_path
+      Rfix.to_relative(path: location.source_buffer.name)
+    end
+
+    def clickable_path
+      "{{italic:#{relative_path}:#{where}}}"
+    end
+
+    def clickable_plain_severity
+      to_url("https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/#{code}", code)
+    end
+
+    def clickable_severity
+      "{{#{severity.code}}} {{italic:#{clickable_plain_severity}}}"
+    end
+
+    def icon
+      return check.green if corrected?
+      return star.yellow if correctable?
+
+      cross.red
+    end
+
+    def to_clickable(url, title)
+      esc = CLI::UI::ANSI::ESC
+      cmd = esc + "]8;;"
+      slash = "\x07"
+      cmd + "#{escape(url)}#{slash}#{escape(title)}" + cmd + slash
+    end
+
+    def to_path(path, title)
+      to_clickable("file://#{path}", title)
+    end
+
+    def to_url(url, title)
+      to_clickable(url, title)
+    end
+
+    def escape(str)
+      Shellwords.escape(str)
+    end
+  end
+end

data/lib/rfix/formatter.rb

@@ -30,37 +30,14 @@ module Rfix
       report_summary(files.size, offenses.count, corrected.count)
     end
 
-    def to_clickable(url, title)
-      esc = CLI::UI::ANSI::ESC
-      cmd = esc + "]8;;"
-      slash = "\x07"
-      cmd + "#{escape(url)}#{slash}#{escape(title)}" + cmd + slash
-    end
-
-    def to_path(path, title)
-      to_clickable("file://#{path}", title)
-    end
-
-    def to_url(url, title)
-      to_clickable(url, title)
-    end
-
-    def escape(str)
-      Shellwords.escape(str)
-    end
-
     def render_file(file, offenses)
       return if offenses.empty?
 
-      path = Rfix.to_relative(path: file)
-      url = to_url(file, path)
       offenses.each do |offense|
         out("\n\n")
-        clickable_path = "{{italic:#{path}:#{offense.where}}}"
-        clickable_code = to_url("https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/#{offense.code}", offense.code)
         CLI::UI::Frame.open("#{offense.icon} #{offense.msg}", color: :reset)
         report_line(file, offense, offense.location, offense.highlighted_area)
-        CLI::UI::Frame.close("#{clickable_path} » {{italic:#{clickable_code}}}", color: :reset)
+        CLI::UI::Frame.close("#{offense.clickable_severity} » #{offense.clickable_path}", color: :reset)
       end
     end
 

data/rfix.gemspec

@@ -48,6 +48,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib", "vendor/cli-ui/lib"]
 
+  spec.requirements << "git, v2.0+"
+
   spec.add_runtime_dependency "rainbow", "~> 3.0"
   spec.add_runtime_dependency "rouge", "~> 3.20"
   spec.add_runtime_dependency "rubocop", "~> 0.80"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rfix
 version: !ruby/object:Gem::Version
-  version: 1.0.7.pre.61
+  version: 1.0.7.pre.65
 platform: ruby
 authors:
 - Linus Oleander
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-17 00:00:00.000000000 Z
+date: 2020-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -96,7 +96,8 @@ files:
 - exe/rfix
 - lib/rfix.rb
 - lib/rfix/cmd.rb
-- lib/rfix/extensions.rb
+- lib/rfix/extensions/extensions.rb
+- lib/rfix/extensions/offense.rb
 - lib/rfix/formatter.rb
 - lib/rfix/git_file.rb
 - lib/rfix/git_helper.rb
@@ -151,7 +152,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   - - ">"
     - !ruby/object:Gem::Version
       version: 1.3.1
-requirements: []
+requirements:
+- git, v2.0+
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4

data/lib/rfix/extensions.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-require "rainbow"
-
-module Rfix::Ext
-  module CommentConfig
-    # Called by RuboCop on every line to see
-    # if its suppose to run against it or not
-    def cop_enabled_at_line?(_cop, line)
-      Rfix.enabled?(processed_source.file_path, line) && super
-    end
-  end
-
-  module Runner
-    # Called _after_ @source has been 'auto fixed' by Rubocop
-    def check_for_infinite_loop(source, offences)
-      Rfix.refresh!(source); super # TODO: Before or after?
-    end
-  end
-
-  module Options
-    # Appends custom --args to RuboCop CLI
-    def define_options
-      super.tap do |options|
-        @ons.each do |args, block|
-          option(options, *args, &block)
-        end
-      end
-    end
-
-    # Helper method used by rfix to append cli --args to Rubocop
-    def on(*args, &block)
-      @ons ||= []
-      @ons += [[args, block]]
-    end
-  end
-
-  module Offense
-    def where
-      line.to_s + ":" + real_column.to_s
-    end
-
-    def info
-      message.split(": ", 2).last.delete("\n")
-    end
-
-    def msg
-      CLI::UI.resolve_text("{{italic:#{info}}}", truncate_to: CLI::UI::Terminal.width - 10)
-    end
-
-    def code
-      message.split(": ", 2).first
-    end
-
-    def star
-      Rainbow("⭑")
-    end
-
-    def cross
-      Rainbow("✗")
-    end
-
-    def check
-      Rainbow("✓")
-    end
-
-    def level
-      colors = {
-        refactor: star.lightcyan,
-        convention: star.lightblue,
-        warning: star.lightyellow,
-        error: cross.indianred,
-        fatal: cross.lightsalmon
-      }
-
-      colors[severity.name]
-    end
-
-    def icon
-      return check.green if corrected?
-      return check.lightgreen if correctable?
-
-      cross.indianred
-    end
-  end
-end
-
-RuboCop::Options.prepend(Rfix::Ext::Options)
-RuboCop::Runner.prepend(Rfix::Ext::Runner)
-RuboCop::CommentConfig.prepend(Rfix::Ext::CommentConfig)
-RuboCop::Cop::Offense.prepend(Rfix::Ext::Offense)