rf-stylez 0.2.12 → 0.2.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7df6e0db6c26722063fd17eaeba95892bdc7a83a3f9157f246f91aeea104d671
-  data.tar.gz: a0b68384bc85436ed593a5fbbe734896b08498ea50d0d35fc6be1bc1e6af5c87
+  metadata.gz: 4637e73990ffdf9494d85b346bef5679a32cfb2f7dd80cf4a619e2367a16f0e3
+  data.tar.gz: b8bc8869394241260e18f9fad024473a8ead0330fe06d099ca1af56c1b32dff7
 SHA512:
-  metadata.gz: beb10f74bd156bc68abfb38bff258f483842fe115b9de58b1c8f641a032f121fbc3eb10400941ecf45845b3d5899cfc087bd1ec4e5d58fc9c5c3059ae3f9c611
-  data.tar.gz: 288d7639d488622900c7a801350120aed9a88825d4215386df27242e68774e67a37e0e666ad83969df40e5f313bce9223df7946a63a4ae35a57f08b8862bcc85
+  metadata.gz: 501fc3fb8b183136ae320a937ca6e02f52162d057c7d93897e1424fe6a25f8b3bb6410ccf95de8a3b959854d4f7f6f455e9704ea7337e27cc5c932d1a9923e66
+  data.tar.gz: 2a969a0daac927c764988423b3c03aa283e8ee202d62e11c323c144dc3dc4bdf7752d348abb48cbcb74cb80c1595ef3bc445eb358ca2848b53da3065c1490faf

data/lib/rf/stylez.rb

@@ -1,6 +1,9 @@
 require "rf/stylez/version"
 require 'rubocop/cop/lint/no_env'
 require 'rubocop/cop/lint/no_http_party'
+require 'rubocop/cop/lint/obscure'
+require 'rubocop/cop/lint/no_grape_api'
+require 'rubocop/cop/lint/use_positive_int32_validator'
 
 
 module Rf

data/lib/rf/stylez/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Rf
   module Stylez
-    VERSION = '0.2.12'
+    VERSION = '0.2.15'
   end
 end

data/lib/rubocop/cop/lint/no_grape_api.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Lint
+      # @example
+      #   # bad
+      #   class Foo < Grape::API
+      #
+      #   # good
+      #   class Foo < Api::AuthBase
+      #
+      #   # good
+      #   class Foo < Api::Base
+      class NoGrapeAPI < Cop
+        MSG = 'Prefer inheriting `Api::AuthBase` or `Api::Base` instead of `Grape::API`.'.freeze
+
+        def_node_matcher :inherits_Grape_API?, '(class (const ...) (const (const nil? :Grape) :API) ...)'
+
+        def on_class(node)
+          return unless inherits_Grape_API?(node)
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/lint/use_positive_int32_validator.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+require 'byebug'
+
+module RuboCop
+  module Cop
+    module Lint
+      # @example
+      #   # bad
+      #   params do
+      #     requires :id, type: Integer
+      #   end
+      #
+      #   # good
+      #   params do
+      #     requires :id, type: Integer, positive_int32: true
+      #   end
+      class UsePositiveInt32Validator < Cop
+        MSG = 'If this Integer maps to a postgres Integer column, validate with `positive_int32: true`'.freeze
+
+        # if a params block, return all the nodes in it
+        def_node_matcher :is_grape_params?, '(block (send nil? :params) (args) $...)'
+        # check if the param is `requires` / `optional`
+        def_node_search :find_params_hashes, <<~PATTERN
+        (send nil? {:requires :optional}
+          (sym _)
+          $(hash ...) ...)
+        PATTERN
+        # check if hash contains `type: Integer`
+        def_node_search :is_type_integer?, '(pair (sym :type) (const nil? :Integer))'
+        # check if the hash contains the `positive_int32` validator
+        def_node_search :validates_integer?, '(pair (sym :positive_int32) (true))'
+
+        def on_block(node)
+          params = is_grape_params?(node)
+          return unless 
+          hash = find_params_hashes(node)
+          hash&.each do |param|
+            if is_type_integer?(param) && !validates_integer?(param)
+              add_offense(param)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/ruby/rubocop.yml

@@ -19,12 +19,17 @@ inherit_from:
 require:
   - rf/stylez
 
+# Custom cops
 Lint/NoENV:
   Enabled: true
 Lint/NoHTTParty:
   Enabled: true
 Lint/Obscure:
   Enabled: true
+Lint/NoGrapeAPI:
+  Enabled: true
+Lint/UserPositiveInt32Validator:
+  Enabled: true
 
 # Good style cops
 Layout/BlockAlignment:
@@ -105,6 +110,10 @@ Naming/FileName:
 Naming/MethodName:
   Enabled: true
 
+Style/SpecialGlobalVars:
+  Enabled: true
+Style/GlobalVars:
+  Enabled: true
 Style/FrozenStringLiteralComment:
   Enabled: true
   EnforcedStyle: always

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rf-stylez
 version: !ruby/object:Gem::Version
-  version: 0.2.12
+  version: 0.2.15
 platform: ruby
 authors:
 - Emanuel Evans
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-12 00:00:00.000000000 Z
+date: 2018-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -100,8 +100,10 @@ files:
 - lib/rf/stylez.rb
 - lib/rf/stylez/version.rb
 - lib/rubocop/cop/lint/no_env.rb
+- lib/rubocop/cop/lint/no_grape_api.rb
 - lib/rubocop/cop/lint/no_http_party.rb
 - lib/rubocop/cop/lint/obscure.rb
+- lib/rubocop/cop/lint/use_positive_int32_validator.rb
 - rf-stylez.gemspec
 - ruby/rubocop.yml
 - ruby/rubocop_lint.yml