rf-stylez 0.2.11 → 0.2.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b3df1c229c340e1c581b417f7f9fab4634d5606c5cd22f132e2c6b42dc6270b
-  data.tar.gz: 04cf9acef3339e937a9c4676ec4770c749bfdac49a870939a936b7e938c39a01
+  metadata.gz: 7df6e0db6c26722063fd17eaeba95892bdc7a83a3f9157f246f91aeea104d671
+  data.tar.gz: a0b68384bc85436ed593a5fbbe734896b08498ea50d0d35fc6be1bc1e6af5c87
 SHA512:
-  metadata.gz: 78fae2b89d5701a8397af7da2a250ff5420fd4a30ff3210971b9174c497dc11600144724ccdce207264317fa3574bc0afb10d2dfeab83d5c7eea707c799bf46a
-  data.tar.gz: 852ca3254c2a26ce3e30dda5fd5203fd394eccd62214d23791f81eb1c1c7ac49b27ccd5789c523ab09d1e7dc22c6ffde1adba3742fce093d987931d176c71feb
+  metadata.gz: beb10f74bd156bc68abfb38bff258f483842fe115b9de58b1c8f641a032f121fbc3eb10400941ecf45845b3d5899cfc087bd1ec4e5d58fc9c5c3059ae3f9c611
+  data.tar.gz: 288d7639d488622900c7a801350120aed9a88825d4215386df27242e68774e67a37e0e666ad83969df40e5f313bce9223df7946a63a4ae35a57f08b8862bcc85

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+.byebug_history

data/README.md

@@ -4,5 +4,23 @@ This is a place for style configurations for [Rainforest QA](https://www.rainfor
 
 ### Releasing
 
-- Make sure you're an owner on rubygems.org
-- `rake release`
+- Make sure your changes are merged into `master` and...
+- that `VERSION` in `lib/rf/stylez/version.rb` file is updated
+- pull latest master
+- run `rake release:source_control_push`
+- CI/CD will take care of releasing rf-stylez to rubygems
+
+## Adding `rf-stylez` to a new project
+
+Create a `.rubocop.yml` in the root project directory and paste the following:
+```yml
+inherit_gem:
+  rf-stylez: ruby/rubocop.yml
+Style/HashSyntax:
+  Enabled: true
+```
+
+To use it install rubocop and rf-stylez locally:
+```bash
+gem install rf-stylez
+```

data/lib/rf/stylez/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Rf
   module Stylez
-    VERSION = '0.2.11'
+    VERSION = '0.2.12'
   end
 end

data/lib/rubocop/cop/lint/no_http_party.rb

@@ -5,16 +5,10 @@ module RuboCop
     module Lint
       # @example
       #   # bad
-      #   ENV[]
-      #
-      #   # bad
-      #   ENV.fetch(..)
-      #
-      #   # good
-      #   GetEnv[]
+      #   HTTParty.get(..)
       #
       #   # good
-      #   GetEnv.fetch(...)
+      #   TimedRequest.get(...)
       class NoHTTParty < Cop
         MSG = 'Prefer `TimedRequest` instead of raw `HTTParty` calls.'.freeze
 

data/lib/rubocop/cop/lint/obscure.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+# Custom rubocop to warn against using obscure Ruby language features as
+# defined in our internal Ruby coding standards
+# https://paper.dropbox.com/doc/Coding-Standards-for-Ruby-gV22vwXEHhE5Ahsb1r06c
+module RuboCop
+  module Cop
+    module Lint
+      # @example
+      #   # bad
+      #   if (a...b)
+      #
+      #   # bad
+      #   if (a..b)
+      #
+      # https://ruby-doc.org/core-2.4.0/doc/syntax/control_expressions_rdoc.html#label-Flip-Flop
+      #
+      #   # bad
+      #   "%s" % "string"
+      #
+      # https://ruby-doc.org/core-2.4.0/String.html#method-i-25
+      class Obscure < Cop
+        MSG = 'Do not use the flipflop operator'.freeze
+
+        def_node_matcher :is_stringformat?, <<-PATTERN
+          (send {str dstr} $:% ...)
+        PATTERN
+
+        def on_iflipflop(node)
+          add_offense(node)
+        end
+
+        def on_eflipflop(node)
+          add_offense(node)
+        end
+
+        def on_send(node)
+          return unless is_stringformat?(node)
+          add_offense(node, message: 'Do not use String#%')
+        end
+      end
+    end
+  end
+end

data/rf-stylez.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '>= 3.4'
+  spec.add_development_dependency 'byebug'
 end

data/ruby/rubocop.yml

@@ -23,6 +23,8 @@ Lint/NoENV:
   Enabled: true
 Lint/NoHTTParty:
   Enabled: true
+Lint/Obscure:
+  Enabled: true
 
 # Good style cops
 Layout/BlockAlignment:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rf-stylez
 version: !ruby/object:Gem::Version
-  version: 0.2.11
+  version: 0.2.12
 platform: ruby
 authors:
 - Emanuel Evans
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-07 00:00:00.000000000 Z
+date: 2018-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Configurations for Rubocop and other style enforcers/linters
 email:
 - emanuel@rainforestqa.com
@@ -87,6 +101,7 @@ files:
 - lib/rf/stylez/version.rb
 - lib/rubocop/cop/lint/no_env.rb
 - lib/rubocop/cop/lint/no_http_party.rb
+- lib/rubocop/cop/lint/obscure.rb
 - rf-stylez.gemspec
 - ruby/rubocop.yml
 - ruby/rubocop_lint.yml