rews 0.2.7 → 0.2.9

data/README.rdoc

@@ -1,6 +1,6 @@
 = rews
 
-Rews is a simple Ruby client for Exchange Web Services. It has been tested against Exchange 2007 SP1 and Exchange 2010 RTM
+Rews is a simple Ruby client for Exchange Web Services
 
 * Find, Get and Delete of Items and Folders is supported.
 * Filtering, ordering, and arbitrary property retrieval are supported.
@@ -10,6 +10,11 @@ Rews is a simple Ruby client for Exchange Web Services. It has been tested again
 Method names generally follow the Exchange Web Services API
 http://msdn.microsoft.com/en-us/library/bb409286(EXCHG.140).aspx 
 
+It has been tested against
+
+* Exchange 2007 SP1 (Version 8.1, Build 240.6)
+* Exchange 2010 SP1 (Version 14.1, Build 218.15)
+
 to use : 
 
   # create a client
@@ -36,11 +41,11 @@ to use :
 
 == Install
 
-slightly painful : to use NTLM authentication, you need versions of httpclient and ntlm-http 
-gems with fixes for NTLM authentication
+slightly painful : because of bugs in released versions of gems relating to NTLM authentication, you need 
+versions of httpclient and ntlm-http gems with fixes :
 
-  * httpclient branch ntlm_domain : https://github.com/mccraigmccraig/httpclient/tree/ntlm_domain
-  * ntlm-http branch fix_unicode : https://github.com/trampoline/ntlm-http/tree/fix_unicode
+  * httpclient v2.1.6.1.1 : branch ntlm_domain from : https://github.com/mccraigmccraig/httpclient/tree/ntlm_domain
+  * ntlm-http v0.1.1.1 : branch fix_ntlm_domain from: https://github.com/trampoline/ntlm-http/commits/fix_ntlm_domain
 
 then:
 

data/VERSION

@@ -1 +1 @@
-0.2.7
+0.2.9

data/lib/rews/folder.rb

@@ -70,6 +70,14 @@ module Rews
         result[key]
       end
 
+      def first
+        result.first
+      end
+
+      def last
+        result.last
+      end
+
       def inspect
         attrs = VIEW_ATTRS.map{|attr| "@#{attr}=#{self.send(attr)}"}.join(", ")
         "#<#{self.class} #{attrs}, @result=#{@result.inspect}>"

data/lib/rews/util.rb

@@ -1,9 +1,19 @@
 require 'set'
 
 module Rews
+  class Error < RuntimeError
+  end
+
   module Util
     module_function
 
+    def tag_exception(e, tags)
+      tags.each do |k,v|
+        mc = class << e ; self ; end
+        mc.send(:define_method, k){v}
+      end
+    end
+
     # validates an options hash against a constraints hash
     # in the constraints hash :
     # * keys ending in ! indicate option is required
@@ -59,19 +69,25 @@ module Rews
     def with_error_check(client, *response_msg_keys)
       raise "no block" if !block_given?
 
-      response = yield
-      hash_response = response.to_hash
-      statuses = hash_response.fetch_in(*response_msg_keys)
-
-      if statuses.is_a?(Array)
-        all_statuses = statuses
-      else
-        all_statuses = [statuses]
+      begin
+        response = yield
+        hash_response = response.to_hash
+        statuses = hash_response.fetch_in(*response_msg_keys)
+        
+        if statuses.is_a?(Array)
+          all_statuses = statuses
+        else
+          all_statuses = [statuses]
+        end
+        
+        errors = all_statuses.map{|s| single_error_check(client, s)}.compact
+      rescue Exception=>e
+        client.log.warn(e)
+        tag_exception(e, :savon_response=>response)
+        raise e
       end
 
-      errors = all_statuses.map{|s| single_error_check(client, s)}.compact
-      raise errors.join("\n") if !errors.empty?
-
+      raise Error.new(errors.join("\n")) if !errors.empty?
       statuses
     end
 

data/spec/rews/util_spec.rb

@@ -36,7 +36,7 @@ module Rews
         end
       end
 
-      it "should raise if there are any errors" do
+      it "should raise a Rews::Error if there are any errors" do
         client = Object.new
         lambda {
           Util.with_error_check(client, :foo, :bar) do
@@ -45,8 +45,27 @@ module Rews
             mock(response).to_hash{response_hash}
             response
           end
-        }.should raise_error
+        }.should raise_error(Rews::Error)
       end
+
+      it "should tag any unexpected exceptions with the savon response" do
+        client = Object.new
+        exception = RuntimeError.new("boo")
+        mock(client).log.mock!.warn(exception)
+
+        savon_response = Object.new
+
+        lambda {
+          Util.with_error_check(client, :foo, :bar) do
+            mock(savon_response).to_hash{raise exception}
+            savon_response
+          end
+        }.should raise_error{|error|
+          error.respond_to?(:savon_response).should == true
+          error.savon_response.should == savon_response
+        }
+      end
+      
     end
 
     describe "single_error_check" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rews
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 5
   prerelease: 
   segments: 
   - 0
   - 2
-  - 7
-  version: 0.2.7
+  - 9
+  version: 0.2.9
 platform: ruby
 authors: 
 - Trampoline Systems Ltd
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-23 00:00:00 +00:00
+date: 2011-03-30 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency