revs-utils 2.0.6 → 2.0.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NGE4MzU4NGVjZjc4YzkxYWNlNjlhNGM2MzRmM2JmNDFiYTZiMmZiNw==
+    YjgyNzZkYTI2YTNmODVlNTZjOTRkZDNhMWUzNjE3ZjY0NzI5NmNlOQ==
   data.tar.gz: !binary |-
-    ODg2NzMxNDAzYWIxYmVmZjA5NDA3MjRkNTVkZDI1MDQzOTgxMTU0Yw==
+    N2U1NzkxNjNmNzE0MmQ3OWQ5ZTA1YWMzMTE1M2IwMTNhNTQ1Yzk5OA==
 SHA512:
   metadata.gz: !binary |-
-    ODI5MDcwMzIwMGY1ZTcxYmViNjk5NjI4ZGY2ZmIxMzJhNmMzMWViMDUzZTE2
-    MzIyMDViZWQ2ZWVlYzdlNGQwZWY1MTU2YzFlMGJiM2JhMTAwMDlhZDVhMjAz
-    OTE0N2U3MTFjOWQ4MzhlOGNjYTMwMDMwMTQ4YjI0MTIwY2RhYjA=
+    ZmMzODNjM2Q3MTM1NDhlMWNjNjkyZmViNzNmMmZhMzZlNGE1OTUxOGI2YjY5
+    Zjk3MzMwMzMxMjQ0ZWY3YjliNTlkNjE0YjY5YTI1YTY1NDhmNTg2YWZmMzIx
+    M2JhNmM4YTU1YTFhMThiNjgyNTc2YzI5Y2NlZDUxNWU5MjNlYmM=
   data.tar.gz: !binary |-
-    YWVkNmY2Y2E0NTYyZTRjZGQ2YmVkOTRkNDczYjEzM2QxYTI0YzU2NmQxMDFm
-    MzEyZjczMDA2MDc2MGQ3Y2NiZjQxYjg2M2U2YzE2NGEwN2VjMTAyMjFkNTIy
-    N2E4MmQ4Yzk5OGM0YzM4YzI1NmU0Y2Q2NjU2Mzk3MGY0MmZmOWM=
+    ODVlYTBiNzYzMTY3NDc4N2JmMzVlMjM0NzM4N2VhZDNhNjQwYTk4OGUyNzY1
+    MWY2ZjYzMTZlODFiZmU4N2E5Y2U3NTE1MzQ2ZDJmNTQxOTVmYmQ2NGNlZmVh
+    NWIwNjM5NTk0MGUwMTRiMzVmOWY4N2FmMzQ1N2NmMzY5ZmMyYzg=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    revs-utils (2.0.5)
+    revs-utils (2.0.6)
       actionpack (~> 4.1.6)
       chronic
       countries (= 0.9.2)

data/lib/revs-utils/version.rb

@@ -1,5 +1,5 @@
 module Revs
   module Utils
-    VERSION = "2.0.6"
+    VERSION = "2.0.7"
   end
 end

data/lib/revs-utils.rb

@@ -239,6 +239,7 @@ module Revs
       # tell us if the string passed is in is a full date of the format M/D/YYYY or m-d-yyyy or m-d-yy or M/D/YY, and returns the date object if it is valid
       def get_full_date(date_string)
         begin
+          return false if date_string.scan(/(-|\/)/).count < 2 # we need at least two / or - characters to count as a full date
           date_obj=Chronic.parse(date_string).to_date
           date_obj=date_obj.prev_year(100) if date_obj > Date.today # if the parsing yields a date in the future, this is a problem, so adjust back a century (due to this issue: http://stackoverflow.com/questions/27058068/ruby-incorrectly-parses-2-digit-year)
           is_valid_year?(date_obj.year.to_s) ? date_obj : false

data/spec/revs-utils_spec.rb

@@ -75,17 +75,29 @@ describe "Revs-Utils" do
    end
       
    it "should indicate if a date is valid" do
+     
+     # formats that are ok
      @revs.get_full_date('5/1/1959').should == Date.strptime("5/1/1959", '%m/%d/%Y')
      @revs.get_full_date('5-1-1959').should == Date.strptime("5/1/1959", '%m/%d/%Y')
      @revs.get_full_date('5-1-2014').should == Date.strptime("5/1/2014", '%m/%d/%Y')
-     @revs.get_full_date('5-1-59').should == Date.strptime("5/1/1959", '%m/%d/%Y') # deal with two digit years ok too
-     @revs.get_full_date('1/1/71').should == Date.strptime("1/1/1971", '%m/%d/%Y') # deal with two digit years ok too
-     @revs.get_full_date('5-1-14').should == Date.strptime("5/1/2014", '%m/%d/%Y') # deal with two digit years ok too     
-     @revs.get_full_date('5-1-21').should == Date.strptime("5/1/1921", '%m/%d/%Y') # deal with two digit years ok too     
-     @revs.get_full_date('1966-02-27').should == Date.strptime("2/27/1966", '%m/%d/%Y') # deal with alternate formats
-     @revs.get_full_date('1966-2-5').should == Date.strptime("2/5/1966", '%m/%d/%Y') # deal with alternate formats
-     @revs.get_full_date('1966-14-11').should be_falsey
-     @revs.get_full_date('bogus').should be_falsey
+     @revs.get_full_date('5-1-59').should == Date.strptime("5/1/1959", '%m/%d/%Y') 
+     @revs.get_full_date('1/1/71').should == Date.strptime("1/1/1971", '%m/%d/%Y') 
+     @revs.get_full_date('5-1-14').should == Date.strptime("5/1/2014", '%m/%d/%Y')  
+     @revs.get_full_date('5-1-21').should == Date.strptime("5/1/1921", '%m/%d/%Y')  
+     @revs.get_full_date('1966-02-27').should == Date.strptime("2/27/1966", '%m/%d/%Y') 
+     @revs.get_full_date('1966-2-5').should == Date.strptime("2/5/1966", '%m/%d/%Y') 
+     
+     # bad full dates
+     @revs.get_full_date('1966-14-11').should be_falsey# bad month
+     @revs.get_full_date('1966\4\11').should be_falsey# slashes are the wrong way
+     @revs.get_full_date('bogus').should be_falsey# crap string
+     @revs.get_full_date('').should be_falsey# blank
+     @revs.get_full_date('1965').should be_falsey# only the year
+     @revs.get_full_date('1965-68').should be_falsey# range of years
+     @revs.get_full_date('1965,1968').should be_falsey# multiple years
+     @revs.get_full_date('1965|1968').should be_falsey# multiple years
+     @revs.get_full_date('1965-1968').should be_falsey# multiple years
+     @revs.get_full_date('1965-8').should be_falsey# multiple years
    end
 
    it "should indicate if we have a valid year" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: revs-utils
 version: !ruby/object:Gem::Version
-  version: 2.0.6
+  version: 2.0.7
 platform: ruby
 authors:
 - Peter Mangiafico