revo-loans_api 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b344ac77904ab206407b2762d68f50890933f40a73f63de5c3eefb68d154f78
-  data.tar.gz: bf43a3bfcfb727ad27957682edacd67cde85731207ebc5d57bff41932a6839dc
+  metadata.gz: f25b09191c1800508f8b50afd1c81e9ea7f29670da428a58d5e653322d42bf8b
+  data.tar.gz: 1958857fa83311a7540fa1418d78a7196917cc35013cdda8ec1a9d5020342d4c
 SHA512:
-  metadata.gz: a647053d57bc28663f66500b7d168bfb014509aac6d27e5d68e24be3220c3484f1d65215ed0d8f4e14ab3a0cc1d92f68b38bbaadca3ac8773794c0606337e373
-  data.tar.gz: 53bd6cda8ffd1ea66bf228cdb75ec6f44a552799a1c967e4ccdc639e68aa100d458e0b5c468dc1a904e1f33e317627edf676e8ad74ca8e77a2eda7da5150806f
+  metadata.gz: 9e7f3171df9b3c3406a57b17958e8ce280bae87d19dc16ad51b33203eb7c4d6e1a0d11e16273be1463fbe15bf561ca5fd2e3d7de0778466e292a0f5d0b0d6e0e
+  data.tar.gz: 72738901d7b8f719efc8f64c5560ec0489f93881bd4c05250dcbf67e60bc8a4bf22820972c1e994cefacf13d4a4bc8225b878b8fdf346b28565b3b751e9fe841

data/lib/revo/loans_api/client.rb

@@ -152,7 +152,9 @@ class Revo::LoansApi::Client
 
   private
 
-  attr_reader :connection, :base_url, :login, :password
+  API_CONTENT_TYPE = 'application/json'.freeze
+
+  attr_reader :base_url, :login, :password
 
   def connection
     @connection ||= HTTP.persistent(base_url)
@@ -162,15 +164,15 @@ class Revo::LoansApi::Client
     result = make_request(:get, "loan_requests/#{loan_request_token}", &block)
     return result if result.success?
 
-    Result.new(success?: false, response: { errors: { loan_request_terms: :cant_fetch } })
+    Result.new(success?: false, response: { errors: { loan_request_terms: [:cant_fetch] } })
   end
 
   def make_request(method, endpoint, params = {}, &block)
     headers = { Authorization: session_token }.compact
     response = connection.public_send(method, url_for(endpoint), json: params, headers: headers)
     handle_response(response, &block)
-  rescue HTTP::Error => exception
-    handle_error(exception)
+  rescue HTTP::Error => e
+    handle_error(e)
   end
 
   def handle_response(response)
@@ -192,7 +194,7 @@ class Revo::LoansApi::Client
       if response.status.unauthorized?
         raise Revo::LoansApi::InvalidAccessTokenError
       else
-        Result.new(success?: false, response: parse(response))
+        Result.new(success?: false, response: parse_errors(response))
       end
     else
       raise Revo::LoansApi::UnexpectedResponseError, response_or_exception
@@ -205,6 +207,14 @@ class Revo::LoansApi::Client
     response.to_s.presence
   end
 
+  def parse_errors(response)
+    if response.content_type.mime_type == API_CONTENT_TYPE
+      parse(response)
+    else
+      { errors: { base: [:unexpected_response] } }
+    end
+  end
+
   def url_for(endpoint)
     [base_url, endpoint].join('/')
   end

data/lib/revo/loans_api/version.rb

@@ -1,5 +1,5 @@
 module Revo
   module LoansApi
-    VERSION = '0.0.9'
+    VERSION = '0.0.10'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: revo-loans_api
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Revo Developers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-23 00:00:00.000000000 Z
+date: 2019-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http