revision_plate 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b7a681b78b1521300089eec60a31ddf500e2497
-  data.tar.gz: 00b444374ae5a0364fcee8fa9b9dfada64bc30a0
+  metadata.gz: 79c5fecbb74c1167c4ababa438d21c0d4a335de2
+  data.tar.gz: 2d6d2dea11eeb2cf53811677bf3c36a44ff1d234
 SHA512:
-  metadata.gz: 2d0a4f7068344548015eceb82d7c8273683be979cb85726f8445514a3a2e62ba9c0548737d4128b75ae57d378b4febc82a3e33bf764dbddef0b21beba3b2be4d
-  data.tar.gz: b0b47299856a9c9373a3c468c7e65d799050e2d88622fb5e59cb57c8b01059429fd485b5dc21fb5687756dc91cef43a0d6687cccc61d98b3eb49c0fc01f474a0
+  metadata.gz: 6b968fd20dc480ccaffec595c29739e369dff49d8545a475bd067c067a62d8d9f704ea3b603b71e2dee4449823d089a8e6abaacfc71f2c4c74d3e6a0a9698681
+  data.tar.gz: 909f0979af1ca2d06799d396f2e99322aa8d9bd791a50cb906f8275cae2ef11a1039532b0674184652e3a4a024dad88301a489dd7bd83d293f2ec2b2f4cb0a13

data/Rakefile

@@ -1,4 +1,3 @@
-ENV['gem_push']='false'
 require "bundler/gem_tasks"
 require 'rake/testtask'
 

data/lib/revision_plate/app.rb

@@ -24,19 +24,31 @@ module RevisionPlate
       end
     end
 
+    ACCEPT_METHODS = ['GET', 'HEAD'].freeze
+
     def call(env)
-      unless env['REQUEST_METHOD'] == 'GET' && (@path ? env['PATH_INFO'] == @path : true)
+      unless ACCEPT_METHODS.include?(env['REQUEST_METHOD']) && (@path ? env['PATH_INFO'] == @path : true)
         return [404, {'Content-Type' => 'text/plain'}, []]
       end
 
       if @revision
         if @file.exist?
-          [200, {'Content-Type' => 'text/plain'}, [@revision, ?\n]]
+          status = 200
+          body = [@revision, ?\n]
         else
-          [404, {'Content-Type' => 'text/plain'}, ["REVISION_FILE_REMOVED\n"]]
+          status = 404
+          body = ["REVISION_FILE_REMOVED\n"]
         end
       else
-        [404, {'Content-Type' => 'text/plain'}, ["REVISION_FILE_NOT_FOUND\n"]]
+        status = 404
+        body = ["REVISION_FILE_NOT_FOUND\n"]
+      end
+
+      headers = {'Content-Type' => 'text/plain'}
+      if env['REQUEST_METHOD'] == 'HEAD'
+        [status, headers, []]
+      else
+        [status, headers, body]
       end
     end
   end

data/lib/revision_plate/middleware.rb

@@ -8,8 +8,10 @@ module RevisionPlate
       @revision_app = App.new(file, **options)
     end
 
+    ACCEPT_METHODS = %w[GET HEAD].freeze
+
     def call(env)
-      if env['PATH_INFO'] == @path && env['REQUEST_METHOD'] == 'GET'
+      if env['PATH_INFO'] == @path && ACCEPT_METHODS.include?(env['REQUEST_METHOD'])
         @revision_app.call(env)
       else
         @app.call(env)

data/lib/revision_plate/version.rb

@@ -1,3 +1,3 @@
 module RevisionPlate
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/test/app_test.rb

@@ -42,6 +42,14 @@ class AppTest < Minitest::Spec
           assert_equal 200, response.status
           assert_equal "a\n", response.body
         end
+
+        describe 'HEAD request' do
+          it 'returns 200' do
+            head '/'
+            assert_equal 200, response.status
+            assert_equal '', response.body
+          end
+        end
       end
 
       describe 'without Rails' do
@@ -59,12 +67,19 @@ class AppTest < Minitest::Spec
         assert_equal 200, response.status
         assert_equal "a\n", response.body
 
+        head '/site/sha'
+        assert_equal 200, response.status
+        assert_equal "", response.body
+
         post '/site/sha'
         assert_equal 404, response.status
 
         get '/site/sha/a'
         assert_equal 404, response.status
 
+        head '/site/sha/a'
+        assert_equal 404, response.status
+
         get '/'
         assert_equal 404, response.status
       end
@@ -90,6 +105,12 @@ class AppTest < Minitest::Spec
       assert_equal 404, response.status
     end
 
+    it 'returns 200 for HEAD request' do
+      head '/'
+      assert_equal 200, response.status
+      assert_equal '', response.body
+    end
+
     it 'returns 404 if removed' do
       app # ensure to instantiate
       file.unlink
@@ -99,6 +120,15 @@ class AppTest < Minitest::Spec
       assert_equal "REVISION_FILE_REMOVED\n", response.body
     end
 
+    it 'returns 404 for HEAD request if removed' do
+      app # ensure to instantiate
+      file.unlink
+
+      head '/'
+      assert_equal 404, response.status
+      assert_equal '', response.body
+    end
+
     it 'returns 404 if not exists' do
       file.unlink
       app # instantiate
@@ -108,6 +138,15 @@ class AppTest < Minitest::Spec
       assert_equal "REVISION_FILE_NOT_FOUND\n", response.body
     end
 
+    it 'returns 404 for HEAD request if not exists' do
+      file.unlink
+      app # instantiate
+
+      head '/'
+      assert_equal 404, response.status
+      assert_equal '', response.body
+    end
+
     it 'returns 404 if created but it was not existed' do
       file.unlink
       app # instantiate
@@ -117,5 +156,15 @@ class AppTest < Minitest::Spec
       assert_equal 404, response.status
       assert_equal "REVISION_FILE_NOT_FOUND\n", response.body
     end
+
+    it 'returns 404 for HEAD request if created but it was not existed' do
+      file.unlink
+      app # instantiate
+      File.write file.to_s, "b\n"
+
+      head '/'
+      assert_equal 404, response.status
+      assert_equal '', response.body
+    end
   end
 end

data/test/middleware_test.rb

@@ -32,6 +32,8 @@ class AppTest < Minitest::Spec
         def call(env)
           [200, {'Content-Type' => 'text/plain'}, "deadbeef"]
         end
+
+        const_set(:ACCEPT_METHODS, %w[GET HEAD].freeze)
       end
     end
 
@@ -57,18 +59,22 @@ class AppTest < Minitest::Spec
 
     it 'pass-through requests to nextapp' do
       get '/'
-      assert_equal response.body, 'hi'
+      assert_equal 'hi', response.body
       post '/'
-      assert_equal response.body, 'hi'
+      assert_equal 'hi', response.body
       get '/site'
-      assert_equal response.body, 'hi'
+      assert_equal 'hi', response.body
       post '/site/sha'
-      assert_equal response.body, 'hi'
+      assert_equal 'hi', response.body
     end
 
     it 'pass requests to RevisionPlate::App on specific path' do
       get '/site/sha'
-      assert_equal response.body, 'deadbeef'
+      assert_equal 'deadbeef', response.body
+
+      head '/site/sha'
+      assert_equal 200, response.status
+      assert_equal 'deadbeef', response.body
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: revision_plate
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Shota Fukumori (sora_h)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-21 00:00:00.000000000 Z
+date: 2015-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler