reviewlette 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e27384dca017ce87a51f0d5294af705a4f81e062
-  data.tar.gz: 4974fdc49a22a1ae0055c11d2c1915d3cd066b97
+  metadata.gz: 163d81e853831b82b114bf4705a4b89621e308dc
+  data.tar.gz: 75186e2b3813ee25c38b8ebdf60df1c9a5205171
 SHA512:
-  metadata.gz: 04c388d3737fbdf3a2207c9b5793a1a12e452b2bfc995c0dbba8fe0a29272bf69eab0fccda519ada85c2bb765367ac7374adfdfa992924e5fb06f36075ca7e44
-  data.tar.gz: 9606460e5c74fdcfabcae37a34a4eac47a8a0721e1215c45708819f0fda30b6aa07154d31ea537a95e64a5465543b24fdaf6076395f28b9f88bbd52667bb8bf9
+  metadata.gz: 4daa9c0f5d7e62f4dc08604b66a6b8888b3ae5d6ca4486ac29d67cff05bec0ea9d5e7659e682b3107562e7021ac665e0d25e4955d067d4729e64c3d8a1d572ed
+  data.tar.gz: 56f797d47df14a587b4b3bbfe99ad5290e345565c47548adb33f5d11641cc6fefdcd62f413798ad974d07bea0a3340f44a293a5684e44cea224b8c5d21e5e7f4

data/Gemfile

@@ -15,3 +15,10 @@ gem 'prophet'
 gem 'coveralls'
 gem 'sequel'
 gem 'sqlite3'
+
+
+group :development do
+  gem 'guard'
+  gem 'guard-rspec'
+  gem 'libnotify'
+end

data/Gemfile.lock

@@ -16,6 +16,9 @@ GEM
     builder (3.2.2)
     byebug (3.1.2)
       columnize (~> 0.8)
+    celluloid (0.16.0)
+      timers (~> 4.0.0)
+    coderay (1.1.0)
     columnize (0.8.9)
     coveralls (0.7.0)
       multi_json (~> 1.3)
@@ -29,25 +32,61 @@ GEM
     docile (1.1.3)
     faraday (0.9.1)
       multipart-post (>= 1.2, < 3)
+    ffi (1.9.8)
+    formatador (0.2.5)
+    guard (2.12.6)
+      formatador (>= 0.2.4)
+      listen (~> 2.7)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.5.2)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
     haml (4.0.5)
       tilt
+    hitimes (1.2.2)
     httparty (0.13.1)
       json (~> 1.8)
       multi_xml (>= 0.5.2)
     i18n (0.6.9)
     json (1.8.1)
+    libnotify (0.9.1)
+      ffi (>= 1.0.11)
+    listen (2.10.1)
+      celluloid (~> 0.16.0)
+      rb-fsevent (>= 0.9.3)
+      rb-inotify (>= 0.9)
+    lumberjack (1.0.9)
+    method_source (0.8.2)
     mime-types (2.3)
     minitest (5.3.4)
     multi_json (1.10.0)
     multi_xml (0.5.5)
     multipart-post (2.0.0)
+    nenv (0.2.0)
+    notiffany (0.0.6)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
     oauth (0.4.7)
     octokit (3.8.0)
       sawyer (~> 0.6.0, >= 0.5.3)
     prophet (1.5.5)
       octokit
       rspec
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
     rake (10.3.2)
+    rb-fsevent (0.9.5)
+    rb-inotify (0.9.5)
+      ffi (>= 0.5.0)
     rdoc (4.1.1)
       json (~> 1.4)
     rest-client (1.6.7)
@@ -75,17 +114,21 @@ GEM
       addressable (~> 2.3.5)
       faraday (~> 0.8, < 0.10)
     sequel (4.13.0)
+    shellany (0.0.1)
     simplecov (0.8.2)
       docile (~> 1.1.0)
       multi_json
       simplecov-html (~> 0.8.0)
     simplecov-html (0.8.0)
+    slop (3.6.0)
     sqlite3 (1.3.9)
     term-ansicolor (1.3.0)
       tins (~> 1.0)
     thor (0.19.1)
     thread_safe (0.3.4)
     tilt (2.0.1)
+    timers (4.0.1)
+      hitimes
     tins (1.1.0)
     tzinfo (1.2.1)
       thread_safe (~> 0.1)
@@ -100,8 +143,11 @@ DEPENDENCIES
   ap
   byebug
   coveralls
+  guard
+  guard-rspec
   haml
   json
+  libnotify
   octokit (~> 3.8.0)
   prophet
   rake
@@ -112,3 +158,6 @@ DEPENDENCIES
   simplecov
   sqlite3
   webmock
+
+BUNDLED WITH
+   1.10.6

data/Guardfile

@@ -0,0 +1,70 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Rails files
+  rails = dsl.rails(view_extensions: %w(erb haml slim))
+  dsl.watch_spec_files_for(rails.app_files)
+  dsl.watch_spec_files_for(rails.views)
+
+  watch(rails.controllers) do |m|
+    [
+      rspec.spec.("routing/#{m[1]}_routing"),
+      rspec.spec.("controllers/#{m[1]}_controller"),
+      rspec.spec.("acceptance/#{m[1]}")
+    ]
+  end
+
+  # Rails config changes
+  watch(rails.spec_helper)     { rspec.spec_dir }
+  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
+  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
+
+  # Capybara features specs
+  watch(rails.view_dirs)     { |m| rspec.spec.("features/#{m[1]}") }
+  watch(rails.layouts)       { |m| rspec.spec.("features/#{m[1]}") }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+end

data/config/github_example.yml

@@ -1,3 +1,5 @@
 # generate the token here: https://github.com/settings/tokens/new
+
 token:
-repo: SUSE/connect
+  repos: ["SUSE/connect", "SUSE/happy-customer", "SUSE/reviewlette", "SUSE/scc-docker-images",
+    "SUSE/scc-provisioning", "SUSE/scc-token", "SUSE/TeamDashboard" ]

data/lib/reviewlette/github_connection.rb

@@ -1,15 +1,13 @@
 require 'yaml'
 require 'octokit'
 
-GITHUB_CONFIG = YAML.load_file("#{File.dirname(__FILE__)}/../../config/github.yml")
-
 class GithubConnection
 
   attr_accessor :client, :repo
 
-  def initialize
-    @client = Octokit::Client.new(:access_token => GITHUB_CONFIG['token'])
-    @repo = GITHUB_CONFIG['repo']
+  def initialize(repo, token)
+    @client  = Octokit::Client.new(access_token: token)
+    @repo    = repo
   end
 
   def list_pulls
@@ -37,4 +35,8 @@ class GithubConnection
     list_pulls.select { |issue| !issue[:assignee] }
   end
 
+  def repo_exists?
+    @client.repository?(@repo)
+  end
+
 end

data/lib/reviewlette/trello_connection.rb

@@ -1,18 +1,18 @@
 require 'yaml'
 require 'trello'
 
-TRELLO_CONFIG = YAML.load_file("#{File.dirname(__FILE__)}/../../config/trello.yml")
 
 class TrelloConnection
 
   attr_accessor :board
 
   def initialize
+    @trello = YAML.load_file("#{File.dirname(__FILE__)}/../../config/trello.yml")
     Trello.configure do |config|
-      config.developer_public_key = TRELLO_CONFIG['consumerkey']
-      config.member_token = TRELLO_CONFIG['oauthtoken']
+      config.developer_public_key = @trello['consumerkey']
+      config.member_token = @trello['oauthtoken']
     end
-    @board = Trello::Board.find(TRELLO_CONFIG['board_id'])
+    @board = Trello::Board.find(@trello['board_id'])
   end
 
   def add_reviewer_to_card(reviewer, card)

data/lib/reviewlette/vacations.rb

@@ -19,8 +19,8 @@ class Vacations
     vacations
   end
 
-  def self.members_on_vacation
-    members_on_vacation = MEMBERS_CONFIG['members'].collect do |member|
+  def self.members_on_vacation(members)
+    members_on_vacation = members.collect do |member|
       username = member['suse_username']
       username if (username && Vacations.find_vacations(username).any? { |v| v === Date.today })
     end

data/lib/reviewlette.rb

@@ -3,50 +3,72 @@ require 'reviewlette/github_connection'
 require 'reviewlette/vacations'
 require 'yaml'
 
-VERSION = '0.0.8'
-MEMBERS_CONFIG = YAML.load_file("#{File.dirname(__FILE__)}/../config/members.yml")
+VERSION = '0.0.9'
 
 class Reviewlette
-
   def initialize
-    @github = GithubConnection.new
-    @trello = TrelloConnection.new
+    @trello  = TrelloConnection.new
+    @members = YAML.load_file("#{File.dirname(__FILE__)}/../config/members.yml")
+    @github  = YAML.load_file("#{File.dirname(__FILE__)}/../config/github.yml")
   end
 
   def run
-    @github.unassigned_pull_requests.each do |issue|
-      issue_id = issue[:number]
+    @github['repos'].each do |repo|
+      puts "Checking repository #{repo}..."
+      check_repo(repo, @github['token'])
+    end
+  end
+
+  def check_repo(repo_name, token)
+    repo = GithubConnection.new(repo_name, token)
+
+    unless repo.repo_exists?
+      puts "Repository #{repo_name} does not exist. Check your configuration"
+      return
+    end
+
+    repo.unassigned_pull_requests.each do |issue|
+      issue_id    = issue[:number]
       issue_title = issue[:title]
+
       puts "*** Checking unassigned github pull request: #{issue_title}"
       card_id = issue_title.split(/[_ -#\.]/).last.to_i
-      if card = @trello.find_card_by_id(card_id)
-        puts "Found matching trello card: #{card.name}"
-        reviewer = select_reviewer(issue, card)
-        if reviewer
-          @github.add_assignee(issue_id, reviewer['github_username'])
-          @github.reviewer_comment(issue_id, reviewer['github_username'], card)
-          comment = "@#{reviewer['trello_username']} will review https://github.com/#{@github.repo}/issues/#{issue_id}"
-          @trello.comment_on_card(comment, card)
-          @trello.move_card_to_list(card, 'In review')
-        else
-          puts "Could not find a reviewer for card: #{card.name}"
-        end
-      else
+      card    = @trello.find_card_by_id(card_id)
+
+      unless card
         puts "No matching card found (id #{card_id})"
+        next
       end
-    end
 
+      puts "Found matching trello card: #{card.name}"
+      reviewer = select_reviewer(issue, card)
+
+      unless reviewer
+        puts "Could not find a reviewer for card: #{card.name}"
+        next
+      end
+
+      repo.add_assignee(issue_id, reviewer['github_username'])
+      repo.reviewer_comment(issue_id, reviewer['github_username'], card)
+      comment = "@#{reviewer['trello_username']} will review https://github.com/#{repo_name}/issues/#{issue_id}"
+
+      @trello.comment_on_card(comment, card)
+      @trello.move_card_to_list(card, 'In review')
+    end
   end
 
   def select_reviewer(issue, card)
-    reviewers = MEMBERS_CONFIG['members']
+    reviewers = @members['members']
+
     # remove people on vacation
-    members_on_vacation = Vacations.members_on_vacation
-    reviewers = reviewers.reject{|r| members_on_vacation.include? r['suse_username'] }
+    members_on_vacation = Vacations.members_on_vacation(reviewers)
+
+    reviewers = reviewers.reject {|r| members_on_vacation.include? r['suse_username'] }
+
     # remove trello card owner
-    reviewers = reviewers.reject{|r| card.members.map(&:username).include? r['trello_username'] }
+    reviewers = reviewers.reject {|r| card.members.map(&:username).include? r['trello_username'] }
     reviewer = reviewers.sample
-    puts "Selected reviewer: #{reviewer['name']} from pool #{reviewers.map{|r| r['name']}}" if reviewer
+    puts "Selected reviewer: #{reviewer['name']} from pool #{reviewers.map {|r| r['name'] }}" if reviewer
     reviewer
   end
 

data/spec/github_connection_spec.rb

@@ -2,22 +2,21 @@ require 'spec_helper'
 
 describe GithubConnection do
 
-  GITHUB_CONFIG = { token: '661', repo: 'SUSE/reviewlette' }
   subject { GithubConnection }
-  let( :connection ) { subject.new }
+  let( :connection ) { subject.new(repo, token) }
+  let( :repo ) { "test" }
+  let( :token ) { "foo" }
 
   describe '.new' do
-
     it 'initializes octokit client and repo' do
-      expect(Octokit::Client).to receive(:new).with(:access_token => GITHUB_CONFIG['token'])
-      connection = subject.new
-      expect(connection.repo).to eq(GITHUB_CONFIG['repo'])
+      expect(Octokit::Client).to receive(:new).with(:access_token => token)
+      expect(connection.repo).to eq(repo)
     end
   end
 
   describe '#add_assignee' do
     it 'adds an assignee to the gh issue' do
-      expect(connection.client).to receive(:update_issue).with(connection.repo, 11, :assignee => 'test')
+      expect(connection.client).to receive(:update_issue).with(repo, 11, :assignee => 'test')
       connection.add_assignee(11, 'test')
     end
   end
@@ -26,16 +25,23 @@ describe GithubConnection do
     it 'comments on a given issue' do
       card = Trello::Card.new
       allow(card).to receive(:url).and_return('url')
-      expect(connection.client).to receive(:add_comment).with(connection.repo, 11, anything)
+      expect(connection.client).to receive(:add_comment).with(repo, 11, anything)
       connection.reviewer_comment(11, 'test', card)
     end
   end
 
   describe '#list_pulls' do
     it 'lists all pullrequests for a given repository' do
-      expect(connection.client).to receive(:pull_requests).with(connection.repo)
+      expect(connection.client).to receive(:pull_requests).with(repo)
       connection.list_pulls
     end
   end
 
+  describe '#repo_exists?' do
+    it 'checks if a certain repository exists' do
+      expect(connection.client).to receive(:repository?).with(repo)
+      connection.repo_exists?
+    end
+
+  end
 end

data/spec/reviewlette_spec.rb

@@ -1,71 +1,85 @@
 require 'spec_helper'
 
 describe Reviewlette do
-
   subject { Reviewlette }
-  let( :reviewlette ) { subject.new }
 
-  before {
-    allow(GithubConnection).to receive(:new).and_return GithubConnection
-    allow(TrelloConnection).to receive(:new).and_return TrelloConnection
-  }
+  let(:reviewlette)    { subject.new }
+
+  let(:members_config) { { 'members' => [member1, member2] } }
+  let(:member1)        { { 'name' => 'test1',  'suse_username' => 'test1', 'trello_username' => 'trellotest1' } }
+  let(:member2)        { { 'name' => 'test2', 'suse_username' => 'test2', 'trello_username' => 'trellotest2' } }
 
+  let(:github_config)  { { token: token, repos: [repo, repo2] } }
+  let(:token)          { '1234' }
+  let(:repo)           { 'SUSE/test' }
+  let(:repo2)          { 'SUSE/foo' }
+
+  before do
+    allow(TrelloConnection).to receive(:new).and_return TrelloConnection
+    allow(GithubConnection).to receive(:new).with(repo, token).and_return GithubConnection
+    allow(YAML).to receive(:load_file).with(/github\.yml/).and_return github_config
+    allow(YAML).to receive(:load_file).with(/members\.yml/).and_return members_config
+  end
 
   describe '.new' do
-    it 'sets github and trello connections' do
-       expect(GithubConnection).to receive (:new)
-       expect(TrelloConnection).to receive (:new)
-       subject.new
+    it 'sets trello connections' do
+      expect(TrelloConnection).to receive(:new)
+      subject.new
     end
   end
 
   describe '.run' do
+    it 'iterates over all open repositories and looks for unassigned pull requests' do
+      github_config[:repos].each do |r|
+        expect(reviewlette).to receive(:check_repo).with(r, token)
+        reviewlette.check_repo(r, token)
+      end
+    end
+  end
 
+  describe '.check_repo' do
     it 'iterates over all open pull requests and extracts trello ids from name' do
+      expect(GithubConnection).to receive(:repo_exists?).and_return true
       expect(GithubConnection).to receive(:unassigned_pull_requests).and_return([{number: 11, title: 'test_issue_12'}])
       expect(TrelloConnection).to receive(:find_card_by_id).with(12)
 
-      reviewlette.run
+      reviewlette.check_repo(repo, token)
     end
 
     it 'adds assignee and reviewer comment on github, adds comment on trello and moves card' do
       card = Trello::Card.new
+
+      expect(GithubConnection).to receive(:repo_exists?).and_return true
       expect(GithubConnection).to receive(:unassigned_pull_requests).and_return([{number: 11, title: 'test_issue_12'}])
       expect(TrelloConnection).to receive(:find_card_by_id).with(12).and_return(card)
       expect(reviewlette).to receive(:select_reviewer).and_return({'suse_username' => 'test', 'github_username' => 'testgit'})
 
       expect(GithubConnection).to receive(:add_assignee).with(11, 'testgit')
       expect(GithubConnection).to receive(:reviewer_comment).with(11, 'testgit', card)
-      expect(GithubConnection).to receive(:repo).and_return('SUSE/test')
 
       expect(TrelloConnection).to receive(:comment_on_card).with("@ will review https://github.com/SUSE/test/issues/11", card)
       expect(TrelloConnection).to receive(:move_card_to_list).with(card, 'In review')
 
-      reviewlette.run
+      reviewlette.check_repo(repo, token)
     end
 
   end
 
   describe '.select_reviewer' do
-
-    MEMBERS_CONFIG['members'] = [{'suse_username' => 'test1', 'trello_username' => 'trellotest1'},
-                                 {'suse_username' => 'test2', 'trello_username' => 'trellotest2'}]
-
     it 'excludes members on vacation' do
-      card = Trello::Card.new
+      card       = Trello::Card.new
+
       allow(card).to receive(:members).and_return([])
-      expect(Vacations).to receive(:members_on_vacation).and_return(MEMBERS_CONFIG['members'].first['suse_username'])
-      expect(reviewlette.select_reviewer(nil, card)).to eq(MEMBERS_CONFIG['members'].last)
+      expect(Vacations).to receive(:members_on_vacation).and_return([member1['suse_username']])
+      expect(reviewlette.select_reviewer(nil, card)).to eq(member2)
     end
 
     it 'excludes the owner of the trello card' do
       card = Trello::Card.new
+
       allow(card).to receive_message_chain(:members, :map).and_return(['trellotest1'])
       expect(Vacations).to receive(:members_on_vacation).and_return([])
-      expect(reviewlette.select_reviewer(nil, card)).to eq(MEMBERS_CONFIG['members'].last)
+      expect(reviewlette.select_reviewer(nil, card)).to eq(members_config['members'].last)
     end
-
   end
-
-
 end

data/spec/trello_connection_spec.rb

@@ -1,26 +1,31 @@
 require 'spec_helper'
 
 describe TrelloConnection do
-
-  TRELLO_CONFIG = { :consumerkey => '4a6', :consumersecret => '899', :oauthtoken => 'a8e', :board_id => 'T5S' }
   subject { TrelloConnection }
-  let (:trello) { subject.new }
-  let (:card) { Trello::Card.new }
 
-  before {
+  let(:trello)        { subject.new }
+  let(:card)          { Trello::Card.new }
+  let(:trello_config) { { 'consumerkey' => consumerkey, 'oauthtoken' => oauthtoken } }
+  let(:consumerkey)   { '4a6' }
+  let(:oauthtoken)    { 'a8e' }
+
+
+  before do
     allow(Trello::Board).to receive(:find).and_return(Trello::Board.new)
-  }
+    allow(YAML).to receive(:load_file).and_return(trello_config)
+  end
+
 
   describe '.new' do
     it 'sets up trello' do
-      expect_any_instance_of(Trello::Configuration).to receive(:developer_public_key=).with(TRELLO_CONFIG['consumerkey'])
-      expect_any_instance_of(Trello::Configuration).to receive(:member_token=).with(TRELLO_CONFIG['oauthtoken'])
+      expect_any_instance_of(Trello::Configuration).to receive(:developer_public_key=).with(consumerkey)
+      expect_any_instance_of(Trello::Configuration).to receive(:member_token=).with(oauthtoken)
       subject.new
     end
   end
 
   describe '#add_reviewer_to_card' do
-    it "adds the valid member to the trello card and comments it" do
+    it 'adds the valid member to the trello card and comments it' do
       expect(trello).to receive(:find_member_by_username).with('testuser1').and_return 'testuser1'
       expect_any_instance_of(Trello::Card).to receive(:add_member).with('testuser1')
       trello.add_reviewer_to_card('testuser1', card)
@@ -28,7 +33,7 @@ describe TrelloConnection do
   end
 
   describe '#comment_on_card' do
-    it "comments on the assigned trello card " do
+    it 'comments on the assigned trello card ' do
       allow(card).to receive(:add_comment).with('comment').and_return true
       expect(trello.comment_on_card('comment', card)).to eq true
     end
@@ -50,18 +55,16 @@ describe TrelloConnection do
   end
 
   describe '#find_member_by_username' do
-    it "finds a member based on a username and returns a trello member object" do
+    it 'finds a member based on a username and returns a trello member object' do
       expect_any_instance_of(Trello::Board).to receive_message_chain(:members, :find)
       trello.find_member_by_username('testuser')
     end
   end
 
   describe '#find_card_by_id(id)' do
-    it "finds the right card based on the trello id" do
+    it 'finds the right card based on the trello id' do
       expect_any_instance_of(Trello::Board).to receive_message_chain(:cards, :find)
       trello.find_card_by_id(123)
     end
   end
-
-
 end

data/spec/vacation_spec.rb

@@ -1,34 +1,36 @@
 require 'spec_helper'
 
 describe Vacations do
-
   subject { Vacations }
 
-  describe '.find_vacations' do
+  let(:members_config) { { members: [member1, member2, member3] } }
+  let(:member1) { { 'suse_username' => 'testuser1' } }
+  let(:member2) { { 'suse_username' => 'testuser2' } }
+  let(:member3) { { 'suse_username' => 'testuser3' } }
+  let(:timestamp) { 'Absence    : Thu 2015-04-02 - Tue 2015-04-07' }
 
+  describe '.find_vacations' do
     it 'parses the vacations dates out of tel' do
-      expect_any_instance_of(Net::Telnet).to receive(:cmd).with('testuser1').and_return "Absence    : Thu 2015-04-02 - Tue 2015-04-07"
+      stub_telnet = double
+      expect(stub_telnet).to receive(:cmd).with('testuser1').and_return(timestamp)
+      expect(stub_telnet).to receive(:close).and_return(true)
 
+      expect(Net::Telnet).to receive(:new).and_return(stub_telnet)
       vacations = subject.find_vacations('testuser1')
+
       expect(vacations).to be_kind_of(Array)
       expect(vacations).to eq([Date.parse('2015-04-02')..Date.parse('2015-04-07')])
     end
-
   end
 
-
   describe '.members_on_vacation' do
-
     it 'finds members on vacation' do
-      MEMBERS_CONFIG['members'] = [{'suse_username' => 'testuser1'}, {'suse_username' =>'testuser2'}, {'suse_username' =>'testuser3'}]
       allow(subject).to receive(:find_vacations).with('testuser1').and_return [(Date.today - 1)..(Date.today + 2)]
       allow(subject).to receive(:find_vacations).with('testuser2').and_return [(Date.today - 1)..(Date.today - 1)]
       allow(subject).to receive(:find_vacations).with('testuser3').and_return []
 
-      expect(subject.members_on_vacation).to be_kind_of(Array)
-      expect(subject.members_on_vacation).to eq(['testuser1'])
+      expect(subject.members_on_vacation(members_config[:members])).to be_kind_of(Array)
+      expect(subject.members_on_vacation(members_config[:members])).to eq(['testuser1'])
     end
-
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reviewlette
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - jschmid1
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-10 00:00:00.000000000 Z
+date: 2015-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-trello
@@ -79,6 +79,7 @@ files:
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE
 - README.md
 - Rakefile