reviewed 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58217355d3b7a2794201386a1ecc80a4834afb70
-  data.tar.gz: 6652fe39fa92662e178d802c991161eed465cdcb
+  metadata.gz: db3a05b1d0b2a929328c41ab48c40b9b8707fd35
+  data.tar.gz: 0ccd060550059118ec043d4e85a062daf6f88d4a
 SHA512:
-  metadata.gz: 8eaff18df51c8dde20eefe6c14a879e51a75e9074b8e3d8bf715ba19cbc0e8eeb79f399143c70f85c9d03aa662de8821c3a140b3245bdc95f0340a552d819e7e
-  data.tar.gz: 4f2d885fac82e767e0267c85046cfb0cfb1ba66491c97ab7a519e6936b30f5a87339aa2e92ca2e78a36a3ee92f71804b1fe3b800c590bd6c58ab6a8bdfaf32c7
+  metadata.gz: 54659e246365f426c614d133af5e7abe9a327e4c004274ae7b97903d26e164d15e2812dd46d3715d63f8298b7b479ecf67f5602bdafa8dfb05c5fe88b6451377
+  data.tar.gz: b22a947086bd78edcf8d8e6bba98f56f6e0e00bff71aaba12d26a0e723c605547b3185eff0598becd5274220072c5fb440a1f03da4e431fbf5125840dc027919

data/lib/reviewed/attachable.rb

@@ -16,7 +16,7 @@ module Reviewed
         end
 
         if fetch.present?
-          attachments << fetch_attachments(opts.merge!(tags: fetch))
+          attachments << fetch_attachments(opts.merge!(tags: fetch)).to_a
         end
       else
         attachments = fetch_attachments(opts).to_a

data/lib/reviewed/version.rb

@@ -1,4 +1,4 @@
 module Reviewed
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
   API_VERSION = 'v1'
 end

data/spec/attachable_spec.rb

@@ -22,7 +22,7 @@ describe Reviewed::Article, vcr: true do
 
   it 'merges local and fetched tags' do
     @article.stub(:fetch_attachments).
-      and_return(Reviewed::Article.new(tags: ['fetched']))
+      and_return([Reviewed::Article.new(tags: ['fetched'])])
     @article.should_receive(:fetch_attachments).with({tags: ['foobar']})
     attachments = @article.attachments(tags: ['hero', 'foobar'])
     attachments.count.should eql(2)

data/spec/fixtures/vcr/Reviewed_Article/associations/attachments/assigns_attachments_to_the_correct_class.yml

@@ -428,4 +428,128 @@ http_interactions:
       string: '{"data":[]}'
     http_version: 
   recorded_at: Tue, 10 Sep 2013 16:02:06 GMT
+- request:
+    method: get
+    uri: https://the-guide-staging.herokuapp.com/api/v1/articles/50fb2e6fbd0286d5550135a2/attachments?tags%5B0%5D=gallery
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      X-Reviewed-Authorization:
+      - 38e397252ec670ec441733a95204f141
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Headers:
+      - x-pagination, x-requested-with, x-requested-by, x-reviewed-authorization,
+        x-skip-cache, Content-Type
+      Access-Control-Allow-Methods:
+      - OPTIONS, GET, POST, PUT, DELETE
+      Access-Control-Allow-Origin:
+      - '*'
+      Access-Control-Max-Age:
+      - '1000'
+      Cache-Control:
+      - no-cache, no-store
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Tue, 10 Sep 2013 17:57:57 GMT
+      Etag:
+      - '"e0aa021e21dddbd6d8cecec71e9cf564"'
+      Status:
+      - 200 OK
+      Strict-Transport-Security:
+      - max-age=31536000
+      Vary:
+      - Accept-Encoding
+      X-Rack-Cache:
+      - miss
+      X-Request-Id:
+      - c9fe9cdd76759b1ff47970f9c36318cc
+      X-Runtime:
+      - '0.001218'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"data":[]}'
+    http_version: 
+  recorded_at: Tue, 10 Sep 2013 17:57:58 GMT
+- request:
+    method: get
+    uri: https://the-guide-staging.herokuapp.com/api/v1/articles/50fb2e6fbd0286d5550135a2/attachments?tags%5B0%5D=gallery
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      X-Reviewed-Authorization:
+      - 38e397252ec670ec441733a95204f141
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Headers:
+      - x-pagination, x-requested-with, x-requested-by, x-reviewed-authorization,
+        x-skip-cache, Content-Type
+      Access-Control-Allow-Methods:
+      - OPTIONS, GET, POST, PUT, DELETE
+      Access-Control-Allow-Origin:
+      - '*'
+      Access-Control-Max-Age:
+      - '1000'
+      Cache-Control:
+      - no-cache, no-store
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Tue, 10 Sep 2013 17:58:04 GMT
+      Etag:
+      - '"e0aa021e21dddbd6d8cecec71e9cf564"'
+      Status:
+      - 200 OK
+      Strict-Transport-Security:
+      - max-age=31536000
+      Vary:
+      - Accept-Encoding
+      X-Rack-Cache:
+      - miss
+      X-Request-Id:
+      - 8f1d7cbf94f870340a2a9582a4970c44
+      X-Runtime:
+      - '0.001032'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"data":[]}'
+    http_version: 
+  recorded_at: Tue, 10 Sep 2013 17:58:05 GMT
 recorded_with: VCR 2.5.0

data/spec/fixtures/vcr/Reviewed_Article/associations/attachments/does_not_have_any_matching_attachments.yml

@@ -428,4 +428,66 @@ http_interactions:
       string: '{"data":[]}'
     http_version: 
   recorded_at: Tue, 10 Sep 2013 16:02:06 GMT
+- request:
+    method: get
+    uri: https://the-guide-staging.herokuapp.com/api/v1/articles/50fb2e6fbd0286d5550135a2/attachments?tags%5B0%5D=doesnotcompute
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      X-Reviewed-Authorization:
+      - 38e397252ec670ec441733a95204f141
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Headers:
+      - x-pagination, x-requested-with, x-requested-by, x-reviewed-authorization,
+        x-skip-cache, Content-Type
+      Access-Control-Allow-Methods:
+      - OPTIONS, GET, POST, PUT, DELETE
+      Access-Control-Allow-Origin:
+      - '*'
+      Access-Control-Max-Age:
+      - '1000'
+      Cache-Control:
+      - no-cache, no-store
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Tue, 10 Sep 2013 17:58:09 GMT
+      Etag:
+      - '"e0aa021e21dddbd6d8cecec71e9cf564"'
+      Status:
+      - 200 OK
+      Strict-Transport-Security:
+      - max-age=31536000
+      Vary:
+      - Accept-Encoding
+      X-Rack-Cache:
+      - miss
+      X-Request-Id:
+      - 69eb819d768e4d69a16cea6456d2e5a0
+      X-Runtime:
+      - '0.000934'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"data":[]}'
+    http_version: 
+  recorded_at: Tue, 10 Sep 2013 17:58:10 GMT
 recorded_with: VCR 2.5.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reviewed
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Nick Plante