reviewed 0.0.8 → 0.0.9

data/lib/faraday/branches.rb

@@ -0,0 +1,19 @@
+module Faraday
+  class Branches < Faraday::Middleware
+
+    def call(env)
+      path = env[:url].path
+      branch = Reviewed::Article.branch
+
+      if path =~ /#{Reviewed::Article.resource_url}/ && branch
+        query = env[:url].query || {}
+        branch = Reviewed::Article.branch
+        env[:url].query = Faraday::Utils.build_query(query.merge(branch: branch))
+      end
+
+      @app.call(env)
+    end
+  end
+end
+
+Faraday.register_middleware :request, branches: Faraday::Branches

data/lib/reviewed/article.rb

@@ -8,6 +8,10 @@ module Reviewed
     has_many :products
     has_many :attachments
 
+    class << self
+      attr_accessor :branch
+    end
+
     def find_page(slug)
       pages.find { |page| page.slug.match(/#{slug}/i) }
     end

data/lib/reviewed/client.rb

@@ -48,6 +48,7 @@ module Reviewed
       @connection ||= ::Faraday.new(url: url) do |faraday|
         faraday.response :mashify
         faraday.response :json
+        faraday.request  :branches
         faraday.request  :url_encoded
         faraday.adapter  Faraday.default_adapter
       end

data/lib/reviewed/collection.rb

@@ -19,7 +19,7 @@ module Reviewed
       self.items = []
 
       data.each do |obj|
-        self.items << klass.from_response(obj)
+        self.items << klass.new(obj)
       end
     end
 

data/lib/reviewed/manufacturer_spec.rb

@@ -0,0 +1,4 @@
+module Reviewed
+  class ManufacturerSpec < Base
+  end
+end

data/lib/reviewed/product.rb

@@ -3,6 +3,7 @@ require 'reviewed/attachment'
 module Reviewed
   class Product < Base
     has_many :attachments
+    has_many :manufacturer_specs
 
     def attachments(tag=nil)
       if tag.present?

data/lib/reviewed/utils.rb

@@ -9,17 +9,13 @@ module Reviewed
 
       def object_from_response(method, url, params={})
         response = Reviewed.send(method, url, params)
-        self.from_response(response.body)
+        self.new(response.body)
       end
 
       def collection_from_response(method, url, params={})
         response = Reviewed.send(method, url, params)
         Reviewed::Collection.new(self, response, params)
       end
-
-      def from_response(data)
-        self.new(data)
-      end
     end
   end
 end

data/lib/reviewed/version.rb

@@ -1,4 +1,4 @@
 module Reviewed
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
   API_VERSION = 'v1'
 end

data/lib/reviewed.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__)))
 
 require 'faraday'
 require 'faraday_middleware'
+require 'faraday/branches'
 require 'active_support/inflector'
 require 'active_support/core_ext'
 require 'active_model'
@@ -14,6 +15,7 @@ require 'reviewed/client'
 require 'reviewed/collection'
 require 'reviewed/base'
 
+require 'reviewed/manufacturer_spec'
 require 'reviewed/product'
 require 'reviewed/article'
 require 'reviewed/author'

data/spec/article_spec.rb

@@ -2,6 +2,18 @@ require 'spec_helper'
 
 describe Reviewed::Article do
 
+  describe 'accessors' do
+
+    after(:each) do
+      Reviewed::Article.branch = nil
+    end
+
+    it 'global params' do
+      Reviewed::Article.branch = 'test'
+      Reviewed::Article.branch.should eql('test')
+    end
+  end
+
   describe 'associations' do
 
     describe 'pages' do

data/spec/embeddable_spec.rb

@@ -95,18 +95,32 @@ describe Reviewed::Embeddable do
 
   describe 'objectify_has_many' do
 
-    let(:data) { { "articles" => [{},{}] } }
     let(:mocked) { Reviewed::MockEmbeddable.new }
 
     before(:each) do
       Reviewed::MockEmbeddable._embedded_many = [ { "articles" => Reviewed::Article } ]
     end
 
-    it 'objectifies' do
-      mocked.objectify_has_many(data)["articles"].each do |obj|
-        obj.should be_an_instance_of Reviewed::Article
+    context 'relationship exists in json' do
+
+      let(:data) { { "articles" => [{},{}] } }
+
+      it 'objectifies' do
+        mocked.objectify_has_many(data)["articles"].each do |obj|
+          obj.should be_an_instance_of Reviewed::Article
+        end
+      end
+    end
+
+    context 'relationship does not have json' do
+
+      let(:data) { { foo: 'bar' } }
+
+      it 'does not error' do
+        mocked.objectify_has_many(data).should eql( { foo: 'bar' } )
       end
     end
+
   end
 
   describe 'objectify_has_one' do

data/spec/faraday/branches_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper.rb'
+
+describe Faraday::Branches do
+
+  class FauxApp
+    def call(env)
+      return env
+    end
+  end
+
+  let(:faraday) { Faraday::Branches.new(FauxApp.new) }
+
+  context 'Articles' do
+
+    let(:env) { { url: URI.parse("http://www.the-guide-staging.com/api/v1/articles") } }
+
+    context 'branch present' do
+
+      before(:each) do
+        Reviewed::Article.stub!(:branch).and_return("test")
+      end
+
+      it 'adds the branch to the query params' do
+        out = faraday.call(env)
+        out[:url].query.should eql("branch=test")
+      end
+    end
+
+    context 'no branch present' do
+
+      it 'does not add the branch to the query params' do
+        out = faraday.call(env)
+        out[:url].query.should be_nil
+      end
+    end
+  end
+
+  context 'Others' do
+
+    let(:env) { { url: URI.parse("http://www.the-guide-staging.com/api/v1/products") } }
+
+    context 'branch present' do
+
+      before(:each) do
+        Reviewed::Article.stub!(:branch).and_return("test")
+      end
+
+      it 'adds the branch to the query params' do
+        out = faraday.call(env)
+        out[:url].query.should eql(nil)
+      end
+    end
+
+    context 'no branch present' do
+
+      it 'does not add the branch to the query params' do
+        out = faraday.call(env)
+        out[:url].query.should be_nil
+      end
+    end
+  end
+end

data/spec/fixtures/vcr/faraday/global_params/request.yml

@@ -0,0 +1,109 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://the-guide-staging.herokuapp.com/api/v1/products/minden-master-ii
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      X-Reviewed-Authorization:
+      - '1234567890'
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - ! '*/*'
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: !binary |-
+        T0s=
+    headers:
+      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctQ3JlZGVudGlhbHM=":
+      - !binary |-
+        dHJ1ZQ==
+      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctSGVhZGVycw==":
+      - !binary |-
+        eC1wYWdpbmF0aW9uLCB4LXJlcXVlc3RlZC13aXRoLCB4LXJlcXVlc3RlZC1i
+        eSwgeC1yZXZpZXdlZC1hdXRob3JpemF0aW9uLCBDb250ZW50LVR5cGU=
+      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctTWV0aG9kcw==":
+      - !binary |-
+        T1BUSU9OUywgR0VULCBQT1NULCBQVVQsIERFTEVURQ==
+      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctT3JpZ2lu":
+      - !binary |-
+        Kg==
+      !binary "QWNjZXNzLUNvbnRyb2wtTWF4LUFnZQ==":
+      - !binary |-
+        MTAwMA==
+      !binary "Q2FjaGUtQ29udHJvbA==":
+      - !binary |-
+        bm8tY2FjaGUsIG5vLXN0b3Jl
+      !binary "Q29udGVudC1FbmNvZGluZw==":
+      - !binary |-
+        Z3ppcA==
+      !binary "Q29udGVudC1UeXBl":
+      - !binary |-
+        YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
+      !binary "RGF0ZQ==":
+      - !binary |-
+        TW9uLCAyNiBOb3YgMjAxMiAyMDozOTowMSBHTVQ=
+      !binary "TGFzdC1Nb2RpZmllZA==":
+      - !binary |-
+        RnJpLCAwOSBOb3YgMjAxMiAyMDoxNjo0MCBHTVQ=
+      !binary "U2VydmVy":
+      - !binary |-
+        dGhpbiAxLjUuMCBjb2RlbmFtZSBLbmlmZQ==
+      !binary "U3RyaWN0LVRyYW5zcG9ydC1TZWN1cml0eQ==":
+      - !binary |-
+        bWF4LWFnZT0zMTUzNjAwMA==
+      !binary "VmFyeQ==":
+      - !binary |-
+        QWNjZXB0LUVuY29kaW5n
+      !binary "WC1SYWNrLUNhY2hl":
+      - !binary |-
+        bWlzcw==
+      !binary "WC1SYXRlLUxpbWl0":
+      - !binary |-
+        MTAwMDAw
+      !binary "WC1SZXF1ZXN0LUlk":
+      - !binary |-
+        M2U2ZDkzNmYzM2MxODlhYmU5YzAxNWE4Y2YwY2ExZGE=
+      !binary "WC1SdW50aW1l":
+      - !binary |-
+        MC4yMDk1NTQ=
+      !binary "WC1VYS1Db21wYXRpYmxl":
+      - !binary |-
+        SUU9RWRnZSxjaHJvbWU9MQ==
+      !binary "VHJhbnNmZXItRW5jb2Rpbmc=":
+      - !binary |-
+        Y2h1bmtlZA==
+      !binary "Q29ubmVjdGlvbg==":
+      - !binary |-
+        a2VlcC1hbGl2ZQ==
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAKhknVAAA8RWS2/bOBD+K4au6wdJvSxd9rJAN4cAiyKnLRbC8CGHrV4g
+        qWTTIP+9Q8l25LZWUCBQfbA9nE+cb16aeQ60DPIgJpkIMwDFBCQqyeJYCJqJ
+        JFgHwihwShbgEMcIZRsSb2h8x2hOWU7jfxHTd/I7DKUbkt0xktMkj4jHNFAr
+        1N7qRqpmdQvWKbO6uUGNrfoDaupBs6kHzUZr1BTuqfMP/d3WKs8/GF1VFn/B
+        os6rbJB/Cv4xbQeNCv5bB51pZS9cYcDpBu9s+qpaBwaaL4P4HLjWQTU9H/+/
+        rIPami7IozTbknUAxmlRqULLwQJGR9Is5gmRKpU8SwVJIsm4N/mouNVuChVM
+        KTpCSxHGBD8cBnY9r7S9L9pmGsn9Hc3yMMoJ+YMQ/B7CKU4cO6OFKg4GOFem
+        GHKFANNzPC/OqWMlyS4sRlGJMI4eyglKlekFiu3T82U+Om/d92Mp+DTv75iv
+        gzxMr5fCJeZYCqilK0zmakjs6uPIA31WptbW6raxnhUaRV7O9OrE4CSNtk6S
+        VNaZ9mkUX17OqfF5mfr2s+zM+xbl8bxvYc4yrPSJb2Ot3jRluxVt7Z81WHfB
+        YTjWr8eilQP84827OY6VVkPTlyBcb7BobKeEjwGeg3Mg7mvVuMugyCSC/RiU
+        VNCU0GQv2dWgXPb1L/f+JkzI7V+bB2i0e9p+7g7HZkZAqSvlJTgMzTRCfOs8
+        KHMOi43J/zFB9L1zXb7bWYRje2+NetDqUcntxMutDbdQw9e2gUfrQ757Ve5C
+        zqSkkVSJoDwDXkIJRJaxwrcAj6MU20WknMvdaLG4Tt9SRNCFSR1tztFiCGEL
+        0zranKMVEmRO2aK0jjbnaOHLANO8dGUNNudoJQiJFqZ1tDlHK4uWp3W0+Rat
+        cOGSP9p8ixaly9NCmzO0WqORhN+IlqN1jc3LMMiE0Z3TfkMa9x+cLeBf+uP4
+        9CTtb2W5HmZUYfVXnFcsi8O9n+GNw8tPy6qu4aB2nzs1+PRuM31Y5i63tJ/v
+        c3MLO83ZlU3mR8zF0P5+TT9tNGOWqvbQFhP5vTY4A4+FFa3xO9wzylZAhayn
+        R7jqK+CVZ9o3Z+H1/M/T5e/D6RsAAAD//wMAIVflnjANAAA=
+    http_version: 
+  recorded_at: Mon, 26 Nov 2012 20:39:03 GMT
+recorded_with: VCR 2.3.0