review 5.8.0 → 5.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 368cf93a0b3ae0f5aaecebdef459f759ab45998b9236cfa983294711a4f135b6
-  data.tar.gz: 9990d2ed06a889cc951c3db58b47431e8ad414842fb4e6868082e2c33dd73139
+  metadata.gz: 6140d24dcd1cdbb98fe8f67131bb080c3bd82a397eb2569d11455b7ac954ef9b
+  data.tar.gz: 23ca68ed05c615d4535d65ca1120f8180336310a5ea0c157f4001cea8e1e4223
 SHA512:
-  metadata.gz: a78a8e4f75a856c15c492a9ef466efd72cad538a6c3378023b6c0dd83ec268e7a99126b16cb3d2ec158035b9f620380a50b759319131227c403b09b27bd8e8b6
-  data.tar.gz: 7f14b429a757435416de52eb8bed9d05925c1694e647c2165b68c46c835fcea9f0f1e4ea7d908219ceceb3edb179bf130ffe2ef811fe58416d00aba6f0d4e068
+  metadata.gz: 4d23fb91a4951a077c2d48ff9cf68227dc91e0bc238e4c0825795b7708da887da3bd1f3467c4cace936f07972a279b14cdd57fa8bb3d176e274a47918a3858a0
+  data.tar.gz: '0005176058f24404f388c55c1b5db58daa034b6b1be049b9b4ca8348c2f8a889cef2bfc3df3eaa96b504186014058a5ca90530b5dd3b60453981816b9c580f11'

data/.github/workflows/rubocop.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.7', '3.0', '3.1', '3.2']
+        ruby: ['3.0', '3.1', '3.2', '3.3']
         os: [ubuntu-latest]
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/ruby-tex.yml

@@ -13,11 +13,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.7', '3.2']
-        os: [ubuntu-20.04]
+        ruby: ['3.2']
+        os: [ubuntu-22.04]
     steps:
     - uses: actions/checkout@v2
-    - name: Install TeXLive 2020 in ubuntu
+    - name: Install TeXLive 2021 in ubuntu
       if: runner.os == 'Linux'
       run: |
         sudo apt-get update -y -qq && sudo apt-get install -y -qq texlive-lang-japanese texlive-fonts-recommended texlive-fonts-extra texlive-luatex texlive-extra-utils texlive-latex-extra dvipng poppler-utils

data/.github/workflows/ruby-win.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ '3.2', '3.1', '3.0', '2.7' ]
+        ruby: [ '3.3', '3.2', '3.1', '3.0' ]
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/ruby.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.7', '3.0', '3.1', '3.2']
+        ruby: ['3.0', '3.1', '3.2', '3.3']
         os: [ubuntu-latest, macOS-latest]
     steps:
     - uses: actions/checkout@v2

data/.rubocop.yml

@@ -5,7 +5,7 @@ AllCops:
     - tmp/*
   DisplayCopNames: true
   NewCops: enable
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.0
 
 require:
   - rubocop-performance
@@ -41,6 +41,9 @@ Performance/CollectionLiteralInLoop:
 Performance/MapCompact:
   Enabled: false
 
+Performance/StringIdentifierArgument:
+  Enabled: false
+
 #### Style
 
 Style/AsciiComments:

data/NEWS.ja.md

@@ -1,3 +1,20 @@
+# Version 5.9.0
+## バグ修正
+* LATEXBuilder: `@<code>`, `@<tt>`, `@<tti>`, `@<ttb>`での空白幅が適切になるよう修正しました。またPDF栞の扱いを改善しました([#1906],[#1907])。
+
+## 機能強化
+* `review-jlreq.cls`のUsers Guideで用紙サイズの指定にJIS B列とISO B列を区別するようにしました([#1904])
+* `config.yml.sample`での誤記を修正しました([#1909])
+
+## コントリビューターのみなさん
+* [@munepi](https://github.com/munepi)
+* [@koshikawa](https://github.com/koshikawa)
+
+[#1904]: https://github.com/kmuto/review/pull/1904
+[#1906]: https://github.com/kmuto/review/issues/1906
+[#1907]: https://github.com/kmuto/review/pull/1907
+[#1909]: https://github.com/kmuto/review/pull/1909
+
 # Version 5.8.0
 ## 新機能
 * `//graph` 命令でMermaid記法によるグラフ記述ができるようになりました。外部ツールの用意や設定については`doc/format.ja.md`を参照してください ([#1885])

data/NEWS.md

@@ -1,3 +1,20 @@
+# Version 5.9.0
+## Bug Fixes
+* LATEXBuilder: fix the spacing for `@<code>`, `@<tt>`, `@<tti>`, `@<ttb>` to be more appropriate. Also improved handling of PDF bookmarks ([#1906], [#1907]).
+
+## Enhancements
+* differentiated between JIS B and ISO B paper sizes in `review-jlreq.cls` Users Guide ([#1904]).
+* fix typos in `config.yml.sample` ([#1909]).
+
+## Contributors
+* [@munepi](https://github.com/munepi)
+* [@koshikawa](https://github.com/koshikawa)
+
+[#1904]: https://github.com/kmuto/review/pull/1904
+[#1906]: https://github.com/kmuto/review/issues/1906
+[#1907]: https://github.com/kmuto/review/pull/1907
+[#1909]: https://github.com/kmuto/review/pull/1909
+
 # Version 5.8.0
 ## New Features
 * The `//graph` operator allows graphical description in Mermaid notation. See `doc/format.md` for details on prepairing and setting up external tools ([#1885])

data/README.md

@@ -117,4 +117,4 @@ Exception:
 
 ## Copyright
 
-Copyright (c) 2006-2023 Minero Aoki, Kenshi Muto, Masayoshi Takahashi, Masanori Kado.
+Copyright (c) 2006-2024 Minero Aoki, Kenshi Muto, Masayoshi Takahashi, Masanori Kado.

data/doc/config.yml.sample

@@ -332,7 +332,7 @@ epubmaker:
   # 画像ファイルの縦x横の最大ピクセル数許容値
   # image_maxpixels: 4000000
   #
-  # Re:VIEWファイル名を使わず、前付にpre01,pre02...、本文にchap01,chap02l...、後付にpost01,post02...という名前付けルールにするか
+  # Re:VIEWファイル名を使わず、前付にpre01,pre02...、本文にchap01,chap02...、後付にpost01,post02...という名前付けルールにするか
   # rename_for_legacy: null
   #
   # ePUBアーカイブの非圧縮実行

data/lib/review/builder.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2002-2023 Minero Aoki, Kenshi Muto
+# Copyright (c) 2002-2024 Minero Aoki, Kenshi Muto
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -133,7 +133,7 @@ module ReVIEW
     end
 
     def target_name
-      self.class.to_s.gsub(/ReVIEW::/, '').gsub(/Builder/, '').downcase
+      self.class.to_s.gsub('ReVIEW::', '').gsub('Builder', '').downcase
     end
 
     def load_words(file)
@@ -405,10 +405,10 @@ module ReVIEW
     def inline_ruby(arg)
       base, *ruby = *arg.scan(/(?:(?:(?:\\\\)*\\,)|[^,\\]+)+/)
       if base
-        base = base.gsub(/\\,/, ',').strip
+        base = base.gsub('\,', ',').strip
       end
       if ruby
-        ruby = ruby.join(',').gsub(/\\,/, ',').strip
+        ruby = ruby.join(',').gsub('\,', ',').strip
       end
       compile_ruby(base, ruby)
     end
@@ -420,9 +420,9 @@ module ReVIEW
 
     def inline_href(arg)
       url, label = *arg.scan(/(?:(?:(?:\\\\)*\\,)|[^,\\]+)+/).map(&:lstrip)
-      url = url.gsub(/\\,/, ',').strip
+      url = url.gsub('\,', ',').strip
       if label
-        label = label.gsub(/\\,/, ',').strip
+        label = label.gsub('\,', ',').strip
       end
       compile_href(url, label)
     end
@@ -640,7 +640,7 @@ module ReVIEW
       tf.puts content
       tf.close
       begin
-        file_path = send("graph_#{command}".to_sym, id, file_path, content, tf.path)
+        file_path = send(:"graph_#{command}", id, file_path, content, tf.path)
       ensure
         tf.unlink
       end

data/lib/review/compiler.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2009-2022 Minero Aoki, Kenshi Muto
+# Copyright (c) 2009-2024 Minero Aoki, Kenshi Muto
 # Copyright (c) 2002-2007 Minero Aoki
 #
 # This program is free software.
@@ -681,7 +681,7 @@ module ReVIEW
                   end
         break if words.empty?
 
-        result << compile_inline(revert_replace_fence(words.shift.gsub(/\\\}/, '}').gsub(/\\\\/, '\\')))
+        result << compile_inline(revert_replace_fence(words.shift.gsub('\\}', '}').gsub('\\\\', '\\')))
       end
       result
     rescue StandardError => e

data/lib/review/htmltoc.rb

@@ -35,7 +35,7 @@ module ReVIEW
     end
 
     def encode_args(args)
-      args.delete_if { |_k, v| v.nil? }.map { |k, v| "#{k}=#{v}" }.join(',')
+      args.compact.map { |k, v| "#{k}=#{v}" }.join(',')
     end
   end
 end

data/lib/review/idgxmlbuilder.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2008-2023 Minero Aoki, Kenshi Muto
+# Copyright (c) 2008-2024 Minero Aoki, Kenshi Muto
 #               2002-2007 Minero Aoki
 #
 # This program is free software.
@@ -532,9 +532,9 @@ module ReVIEW
           next
         end
         if @tablewidth
-          rows.push(line.gsub(/\t\.\t/, "\tDUMMYCELLSPLITTER\t").gsub(/\t\.\.\t/, "\t.\t").gsub(/\t\.\Z/, "\tDUMMYCELLSPLITTER").gsub(/\t\.\.\Z/, "\t.").gsub(/\A\./, ''))
+          rows.push(line.gsub("\t.\t", "\tDUMMYCELLSPLITTER\t").gsub("\t..\t", "\t.\t").gsub(/\t\.\Z/, "\tDUMMYCELLSPLITTER").gsub(/\t\.\.\Z/, "\t.").gsub(/\A\./, ''))
         else
-          rows.push(line.gsub(/\t\.\t/, "\t\t").gsub(/\t\.\.\t/, "\t.\t").gsub(/\t\.\Z/, "\t").gsub(/\t\.\.\Z/, "\t.").gsub(/\A\./, ''))
+          rows.push(line.gsub("\t.\t", "\t\t").gsub("\t..\t", "\t.\t").gsub(/\t\.\Z/, "\t").gsub(/\t\.\.\Z/, "\t.").gsub(/\A\./, ''))
         end
         col2 = rows[rows.length - 1].split(table_row_separator_regexp).length
         @col = col2 if col2 > @col

data/lib/review/logger.rb

@@ -32,7 +32,7 @@ module ReVIEW
     end
 
     def ttylogger?
-      nil
+      false
     end
 
     def success(_log)

data/lib/review/markdownbuilder.rb

@@ -190,19 +190,19 @@ module ReVIEW
     end
 
     def inline_i(str)
-      "*#{str.gsub(/\*/, '\*')}*"
+      "*#{str.gsub('*', '\*')}*"
     end
 
     def inline_em(str)
-      "*#{str.gsub(/\*/, '\*')}*"
+      "*#{str.gsub('*', '\*')}*"
     end
 
     def inline_b(str)
-      "**#{str.gsub(/\*/, '\*')}**"
+      "**#{str.gsub('*', '\*')}**"
     end
 
     def inline_strong(str)
-      "**#{str.gsub(/\*/, '\*')}**"
+      "**#{str.gsub('*', '\*')}**"
     end
 
     def inline_code(str)

data/lib/review/textutils.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2008-2020 Minero Aoki, Kenshi Muto, Masayoshi Takahashi,
+# Copyright (c) 2008-2023 Minero Aoki, Kenshi Muto, Masayoshi Takahashi,
 #                         KADO Masanori
 #               2002-2007 Minero Aoki
 #
@@ -49,7 +49,7 @@ module ReVIEW
       tail = line1[-1]
       head = line2[0]
       if tail.nil? || head.nil?
-        return nil
+        return false
       end
 
       space = true

data/lib/review/version.rb

@@ -1,3 +1,3 @@
 module ReVIEW
-  VERSION = '5.8.0'.freeze
+  VERSION = '5.9.0'.freeze
 end

data/lib/review/yamlloader.rb

@@ -16,7 +16,9 @@ module ReVIEW
             YAML.safe_load(f, [Date])
           rescue Psych::DisallowedClass
             # < Ruby 2.5
+            # rubocop:disable Style/YAMLFileRead
             YAML.safe_load(File.read(file), [Date])
+            # rubocop:enable Style/YAMLFileRead
           end
         end
       end

data/review.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency('playwright-runner')
   gem.add_development_dependency('pygments.rb')
   gem.add_development_dependency('rake')
-  gem.add_development_dependency('rubocop', '~> 1.45.1')
+  gem.add_development_dependency('rubocop', '~> 1.59.0')
   gem.add_development_dependency('rubocop-performance')
   gem.add_development_dependency('rubocop-rake')
   gem.add_development_dependency('simplecov')

data/samples/sample-book/src/config-epub2.yml

@@ -153,7 +153,7 @@ colophon: true
 #  verify_target_images: null
 #  verify_target_imagesがtrueの状態において、解析で発見されなくても強制的に取り込むファイルの相対パスの配列
 #  force_include_images: []
-# Re:VIEWファイル名を使わず、前付にpre01,pre02...、本文にchap01,chap02l...、後付にpost01,post02...という名前付けルールにするか
+# Re:VIEWファイル名を使わず、前付にpre01,pre02...、本文にchap01,chap02...、後付にpost01,post02...という名前付けルールにするか
 #  rename_for_legacy: null
 # ePUBアーカイブの非圧縮実行
 #  zip_stage1: "zip -0Xq"

data/samples/syntax-book/config-jlreq.yml

@@ -1,5 +1,5 @@
 # call me by 'REVIEW_TEMPLATE=review-jlreq REVIEW_CONFIG_FILE=config-jlreq.yml rake pdf'
 inherit: ["config.yml"]
-# texdocumentclass: ["review-jlreq", "media=print,paper=b5"]
-texdocumentclass: ["review-jlreq", "media=ebook,paper=b5"]
-# texdocumentclass: ["review-jlreq", "media=print,paper=b5,bleed_margin=3mm,cover=true,Q=14,startpage=3,serial_pagination=true,hiddenfolio=nikko-pc"]
+# texdocumentclass: ["review-jlreq", "media=print,paper=b5j"]
+texdocumentclass: ["review-jlreq", "media=ebook,paper=b5j"]
+# texdocumentclass: ["review-jlreq", "media=print,paper=b5j,bleed_margin=3mm,cover=true,Q=14,startpage=3,serial_pagination=true,hiddenfolio=nikko-pc"]

data/templates/latex/review-jlreq/README.md

@@ -47,7 +47,8 @@ texdocumentclass: ["review-jlreq", "クラスオプションたち（省略可
 利用可能な特定の用紙サイズを指定できます。［デフォルト］は a5 です。
 
  * `a0` 〜 `a10`：A 列
- * `b0` 〜 `b10`：JIS B 列
+ * `b0j` 〜 `b10j`：JIS B 列
+ * `b0` 〜 `b10`：ISO B 列
  * `c0` 〜 `c8`：C 列
  * `a4var`：210mm x 283mm
  * `b5var`：182mm x 230mm
@@ -57,6 +58,8 @@ texdocumentclass: ["review-jlreq", "クラスオプションたち（省略可
  * `hagaki`：葉書き、100mm x 148mm
  * `{横幅,縦幅}`：任意の指定サイズ
 
+日本の B 列サイズにするには `b5j` のように j 付きで指定することに注意してください。
+
 ### トンボ用紙サイズ `tombopaper=<用紙サイズ>` および塗り足し幅 `bleed_margin=<幅>`
 
 `tombopaper` ではトンボ用紙サイズを指定できます。

data/templates/latex/review-jlreq/review-base.sty

@@ -202,6 +202,11 @@
   \def\reviewinsert#1{#1}
   \def\reviewstrike#1{#1}
   \def\reviewunderline#1{#1}
+  \def\reviewtt#1{#1}
+  \def\reviewcode#1{#1}
+  \def\reviewtti#1{#1}
+  \def\reviewttb#1{#1}
+  \let\reviewicon\@gobble
 }
 \newif\ifreview@ba@break
 \def\review@ba@end{\review@ba@end@}
@@ -247,10 +252,10 @@
   \review@ba@breaktrue
   \review@break@all@a
 }
-\DeclareRobustCommand{\reviewtt}[1]{{\ttfamily\reviewbreakall{#1}}}
-\DeclareRobustCommand{\reviewcode}[1]{{\ttfamily\reviewbreakall{#1}}}
-\DeclareRobustCommand{\reviewtti}[1]{{\ttfamily\itshape\reviewbreakall{#1}}}
-\DeclareRobustCommand{\reviewttb}[1]{{\ttfamily\bfseries\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewtt}[1]{{\frenchspacing\ttfamily\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewcode}[1]{{\frenchspacing\ttfamily\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewtti}[1]{{\frenchspacing\ttfamily\itshape\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewttb}[1]{{\frenchspacing\ttfamily\bfseries\reviewbreakall{#1}}}
 
 \DeclareRobustCommand{\reviewbou}[1]{\kenten{#1}}
 

data/templates/latex/review-jsbook/review-base.sty

@@ -277,6 +277,11 @@
   \def\reviewinsert#1{#1}
   \def\reviewstrike#1{#1}
   \def\reviewunderline#1{#1}
+  \def\reviewtt#1{#1}
+  \def\reviewcode#1{#1}
+  \def\reviewtti#1{#1}
+  \def\reviewttb#1{#1}
+  \let\reviewicon\@gobble
 }
 \newif\ifreview@ba@break
 \def\review@ba@end{\review@ba@end@}
@@ -322,10 +327,10 @@
   \review@ba@breaktrue
   \review@break@all@a
 }
-\DeclareRobustCommand{\reviewtt}[1]{{\ttfamily\reviewbreakall{#1}}}
-\DeclareRobustCommand{\reviewcode}[1]{{\ttfamily\reviewbreakall{#1}}}
-\DeclareRobustCommand{\reviewtti}[1]{{\ttfamily\itshape\reviewbreakall{#1}}}
-\DeclareRobustCommand{\reviewttb}[1]{{\ttfamily\bfseries\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewtt}[1]{{\frenchspacing\ttfamily\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewcode}[1]{{\frenchspacing\ttfamily\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewtti}[1]{{\frenchspacing\ttfamily\itshape\reviewbreakall{#1}}}
+\DeclareRobustCommand{\reviewttb}[1]{{\frenchspacing\ttfamily\bfseries\reviewbreakall{#1}}}
 
 \DeclareRobustCommand{\reviewbou}[1]{\kenten{#1}}
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: review
 version: !ruby/object:Gem::Version
-  version: 5.8.0
+  version: 5.9.0
 platform: ruby
 authors:
 - kmuto
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-29 00:00:00.000000000 Z
+date: 2024-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: image_size
@@ -143,14 +143,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.45.1
+        version: 1.59.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.45.1
+        version: 1.59.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -620,7 +620,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.14
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: 'Re:VIEW: a easy-to-use digital publishing system'