review 5.6.0 → 5.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 644d242fdcddb452c2cfd780a13a165ee89f49b11f349b682ad87c47255f8758
-  data.tar.gz: 77636486441ca626f068bec8f1cabae980bb4832946d98ef6c5bc329bee30b56
+  metadata.gz: 11969067c8cb25999f37895ba330bd5c030c62402d1540510e241c6029c38d90
+  data.tar.gz: 4294e10f33abcb6063ea0098c3b7256374a5696d693fe2284dcb0fed4f2b2348
 SHA512:
-  metadata.gz: 96d2d70825a306d384e832312527e956f23b81832a71fe766b102e6705b5b3dfad50c3cde19b767eaa124e79a6d5096a5cf9ee882ef1335cb96864d3dd4de992
-  data.tar.gz: 06336e0ca7578002aa195d1a08d4f354da2842fe0eb0812d38825be48c68130d6a78da8df9ae064ba24d138f6f5bb11c9383bf8a3eb9d4ea06f8458c8813be44
+  metadata.gz: dddd61f8870c1f2e0d1117d3318cb456bcf49db10a12c4c93dc8b7638b08e5b6894efdfbdbd635d432196f82d40f906b29435f4f6e5ddbb78d2dcbd3829715af
+  data.tar.gz: 695257c02903d581c061cd7813e8951923a4a63986e879aa6e6ee31d963d627bf0e9512f85ffc56ca6a596a8f8f114ed012c3cce9daa7dd41072aabc89a9cb3d

data/.github/workflows/rubocop.yml

@@ -0,0 +1,31 @@
+name: Lint by RuboCop
+
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+
+jobs:
+  build:
+
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['2.7', '3.0', '3.1', '3.2']
+        os: [ubuntu-latest]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: fix ImageMagick policy.xml on Linux
+      if: runner.os == 'Linux'
+      run: sudo sed -i 's/none/read|write/g' /etc/ImageMagick-6/policy.xml
+    - name: Build and test with Rake
+      run: |
+        gem install bundler --no-document
+        bundle install --retry 3
+        bundle exec rubocop -P

data/.github/workflows/ruby-tex.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.5', '3.0', '3.1']
+        ruby: ['2.7', '3.2']
         os: [ubuntu-20.04]
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/ruby-win.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ '3.0', '2.7', '2.6', '2.5', '2.4' ]
+        ruby: [ '3.2', '3.1', '3.0', '2.7' ]
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/ruby.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1']
+        ruby: ['2.7', '3.0', '3.1', '3.2']
         os: [ubuntu-latest, macOS-latest]
     steps:
     - uses: actions/checkout@v2
@@ -28,4 +28,4 @@ jobs:
       run: |
         gem install bundler --no-document
         bundle install --retry 3
-        bundle exec rake
+        bundle exec rake test

data/.rubocop.yml

@@ -5,7 +5,7 @@ AllCops:
     - tmp/*
   DisplayCopNames: true
   NewCops: enable
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
 
 require:
   - rubocop-performance
@@ -38,6 +38,9 @@ Performance/StringInclude:
 Performance/CollectionLiteralInLoop:
   Enabled: false
 
+Performance/MapCompact:
+  Enabled: false
+
 #### Style
 
 Style/AsciiComments:
@@ -109,7 +112,7 @@ Style/LineEndConcatenation:
   Enabled: false
 
 Style/MethodCallWithArgsParentheses:
-  IgnoredMethods:
+  AllowedMethods:
     - 'require'
     - 'include'
     - 'file'
@@ -194,6 +197,9 @@ Style/OptionalBooleanParameter:
 Style/CombinableLoops:
   Enabled: false
 
+Style/FetchEnvVar:
+  Enabled: false
+
 ### Layout
 
 Layout/BlockAlignment:
@@ -296,3 +302,8 @@ Naming/VariableNumber:
 
 Gemspec/RequiredRubyVersion:
   Enabled: false
+
+Gemspec/DevelopmentDependencies:
+  EnforcedStyle: gemspec
+  Exclude:
+    - samples/syntax-book/Gemfile

data/NEWS.ja.md

@@ -1,3 +1,25 @@
+# Version 5.7.0
+## バグ修正
+* Windows において、`review-init -w` の実行時にバインドアドレスを省略したときにエラーが発生するのを修正しました ([#1824])
+* PDFMaker: `//blankline` でページをまたいだときに、ページの先頭に空行が入るのを抑制しました ([#1872])
+* EPUBMaker: MathJax で数式を表現する際に、`<`, `>`, `&` を変換し、HTML のエラーが出ないようにしました ([#1876], [#1877])
+
+## 非互換の変更
+* 動作検証済みバージョンを Ruby 2.7 以降としました ([#1871])
+* EPUMaker: EPUB の検証ルールに従い、EPUB の目次に表紙へのリンクを含めました ([#1874])
+
+## その他
+* Ruby 3.2 を動作検証テスト対象に含めました ([#1871])
+* RuboCop 1.45.1 の指摘を反映しました ([#1878])
+
+[#1824]: https://github.com/kmuto/review/issues/1824
+[#1871]: https://github.com/kmuto/review/pull/1871
+[#1872]: https://github.com/kmuto/review/issues/1872
+[#1874]: https://github.com/kmuto/review/issues/1874
+[#1876]: https://github.com/kmuto/review/pull/1876
+[#1877]: https://github.com/kmuto/review/pull/1877
+[#1878]: https://github.com/kmuto/review/pull/1878
+
 # Version 5.6.0
 ## 新機能
 * IDGXMLBuilder: `//texequation` と `@<m>` で `imgmath` math_formatに対応しました ([#1829])

data/NEWS.md

@@ -1,3 +1,24 @@
+# Version 5.7.0
+## Bug Fixes
+* Fixed error when omitting a bind address of `review-init -w` on Windows ([#1824])
+* EPUBMaker: escape `<`, `>`, and `&` when converting to MathJax to avoid HTML errors ([#1876], [#1877])
+
+## Breaking Changes
+* Ruby 2.6 or earlier was excluded from the operation verification ([#1871])
+* EPUMaker: included a link to the cover in the table of contents according to EPUB validation rules ([#1874])
+
+## Others
+* Ruby 3.2 is now included in the testing target ([#1871])
+* refactor code with RuboCop 1.45.1 ([#1878])
+
+[#1824]: https://github.com/kmuto/review/issues/1824
+[#1871]: https://github.com/kmuto/review/pull/1871
+[#1872]: https://github.com/kmuto/review/issues/1872
+[#1874]: https://github.com/kmuto/review/issues/1874
+[#1876]: https://github.com/kmuto/review/pull/1876
+[#1877]: https://github.com/kmuto/review/pull/1877
+[#1878]: https://github.com/kmuto/review/pull/1878
+
 # Version 5.6.0
 ## New Features
 * IDGXMLBuilder: support `imgmath` math_format in `//texequation` and `@<m>` ([#1829])

data/README.md

@@ -117,4 +117,4 @@ Exception:
 
 ## Copyright
 
-Copyright (c) 2006-2022 Minero Aoki, Kenshi Muto, Masayoshi Takahashi, Masanori Kado.
+Copyright (c) 2006-2023 Minero Aoki, Kenshi Muto, Masayoshi Takahashi, Masanori Kado.

data/lib/review/book/base.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2009-2022 Minero Aoki, Kenshi Muto, Masayoshi Takahashi
+# Copyright (c) 2009-2023 Minero Aoki, Kenshi Muto, Masayoshi Takahashi
 #               2002-2008 Minero Aoki
 #
 # This program is free software.

data/lib/review/builder.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2002-2022 Minero Aoki, Kenshi Muto
+# Copyright (c) 2002-2023 Minero Aoki, Kenshi Muto
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -234,7 +234,8 @@ module ReVIEW
       sepidx = nil
       rows = []
       lines.each_with_index do |line, idx|
-        if /\A[=\-]{12}/ =~ line || /\A[={\-}]{12}/ =~ line
+        # {} is for LaTeX
+        if /\A[=-]{12}/ =~ line || /\A[={}-]{12}/ =~ line
           sepidx ||= idx
           next
         end
@@ -512,12 +513,7 @@ module ReVIEW
     end
 
     def inline_wb(s)
-      translated = @dictionary[s]
-      if translated
-        inline_b(translated)
-      else
-        inline_b("[missing word: #{s}]")
-      end
+      inline_b(@dictionary[s] || "[missing word: #{s}]")
     end
 
     def raw(str)

data/lib/review/epubmaker/epubcommon.rb

@@ -1,6 +1,6 @@
 # = epubcommon.rb -- super class for EPUBv2 and EPUBv3
 #
-# Copyright (c) 2010-2022 Kenshi Muto and Masayoshi Takahashi
+# Copyright (c) 2010-2023 Kenshi Muto and Masayoshi Takahashi
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -231,6 +231,10 @@ module ReVIEW
         ReVIEW::Template.generate(path: template_name, binding: binding)
       end
 
+      def coveritem
+        []
+      end
+
       def hierarchy_ncx(type)
         require 'rexml/document'
         level = 1
@@ -264,7 +268,7 @@ module ReVIEW
         doc.context[:attribute_quote] = :quote
 
         e = doc.root.elements[1] # first <li/>
-        contents.each do |item|
+        (coveritem + contents).each do |item|
           next if !item.notoc.nil? || item.level.nil? || item.file.nil? || item.title.nil? || item.level > toclevel
 
           if item.level == level
@@ -304,7 +308,7 @@ module ReVIEW
 
       def flat_ncx(type, indent = nil)
         s = %Q(<#{type} class="toc-h1">\n)
-        contents.each do |item|
+        (coveritem + contents).each do |item|
           next if !item.notoc.nil? || item.level.nil? || item.file.nil? || item.title.nil? || item.level > config['toclevel'].to_i
 
           is = indent == true ? '　' * item.level : ''
@@ -324,10 +328,12 @@ module ReVIEW
         FileUtils.mkdir_p("#{tmpdir}/OEBPS")
         File.write(File.join(tmpdir, opf_path), opf)
 
-        if File.exist?("#{basedir}/#{config['cover']}")
-          FileUtils.cp("#{basedir}/#{config['cover']}", "#{tmpdir}/OEBPS")
-        else
-          File.write("#{tmpdir}/OEBPS/#{config['cover']}", cover)
+        if config['cover']
+          if File.exist?("#{basedir}/#{config['cover']}")
+            FileUtils.cp("#{basedir}/#{config['cover']}", "#{tmpdir}/OEBPS")
+          else
+            File.write("#{tmpdir}/OEBPS/#{config['cover']}", cover)
+          end
         end
 
         if config['colophon'] && !config['colophon'].is_a?(String)

data/lib/review/epubmaker/epubv2.rb

@@ -22,11 +22,6 @@ module ReVIEW
       CREATOR_ATTRIBUTES = %w[aut a-adp a-ann a-arr a-art a-asn a-aqt a-aft a-aui a-ant a-bkp a-clb a-cmm a-dsr a-edt a-ill a-lyr a-mdc a-mus a-nrt a-oth a-pht a-prt a-red a-rev a-spn a-ths a-trc a-trl]
       CONTRIBUTER_ATTRIBUTES = %w[adp ann arr art asn aqt aft aui ant bkp clb cmm dsr edt ill lyr mdc mus nrt oth pht prt red rev spn ths trc trl]
 
-      # Construct object with parameter hash +config+ and message resource hash +res+.
-      def initialize(producer) # rubocop:disable Lint/UselessMethodDefinition
-        super
-      end
-
       # Return opf file content.
       def opf
         @opf_metainfo = opf_metainfo

data/lib/review/epubmaker/epubv3.rb

@@ -1,6 +1,6 @@
 # = epubv3.rb -- EPUB version 3 producer.
 #
-# Copyright (c) 2010-2022 Kenshi Muto
+# Copyright (c) 2010-2023 Kenshi Muto
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -213,6 +213,14 @@ module ReVIEW
         ReVIEW::Template.generate(path: template_name, binding: binding)
       end
 
+      def coveritem
+        if config['cover']
+          [Content.new(file: config['cover'], title: ReVIEW::I18n.t('covertitle'), level: 1, chaptype: 'cover')]
+        else
+          []
+        end
+      end
+
       # Produce EPUB file +epubfile+.
       # +work_dir+ points the directory has contents.
       # +tmpdir+ defines temporary directory.

data/lib/review/epubmaker/producer.rb

@@ -1,6 +1,6 @@
 # = producer.rb -- EPUB producer.
 #
-# Copyright (c) 2010-2021 Kenshi Muto
+# Copyright (c) 2010-2023 Kenshi Muto
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -119,8 +119,7 @@ module ReVIEW
           epubfile = "#{current}/#{epubfile}"
         end
 
-        # FIXME: error check
-        File.unlink(epubfile) if File.exist?(epubfile)
+        FileUtils.rm_f(epubfile)
 
         begin
           @epub.produce(epubfile, work_dir, new_tmpdir, base_dir: base_dir)

data/lib/review/epubmaker.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2010-2022 Kenshi Muto and Masayoshi Takahashi
+# Copyright (c) 2010-2023 Kenshi Muto and Masayoshi Takahashi
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -106,9 +106,7 @@ module ReVIEW
     def build_path
       if @config['debug']
         path = File.expand_path("#{@config['bookname']}-epub", Dir.pwd)
-        if File.exist?(path)
-          FileUtils.rm_rf(path, secure: true)
-        end
+        FileUtils.rm_rf(path, secure: true)
         Dir.mkdir(path)
         path
       else

data/lib/review/htmlbuilder.rb

@@ -656,7 +656,7 @@ module ReVIEW
         p = MathML::LaTeX::Parser.new(symbol: MathML::Symbol::CharacterReference)
         print p.parse(lines.join("\n") + "\n", true)
       elsif @book.config['math_format'] == 'mathjax'
-        puts "$$#{lines.join("\n")}$$"
+        puts "$$#{lines.join("\n").gsub('<', '\lt{}').gsub('>', '\gt{}').gsub('&', '&amp;')}$$"
       elsif @book.config['math_format'] == 'imgmath'
         fontsize = @book.config['imgmath_options']['fontsize'].to_f
         lineheight = @book.config['imgmath_options']['lineheight'].to_f
@@ -1051,7 +1051,7 @@ EOS
         parser = MathML::LaTeX::Parser.new(symbol: MathML::Symbol::CharacterReference)
         %Q(<span class="equation">#{parser.parse(str, nil)}</span>)
       elsif @book.config['math_format'] == 'mathjax'
-        %Q(<span class="equation">\\( #{str} \\)</span>)
+        %Q(<span class="equation">\\( #{str.gsub('<', '\lt{}').gsub('>', '\gt{}').gsub('&', '&amp;')} \\)</span>)
       elsif @book.config['math_format'] == 'imgmath'
         math_str = '$' + str + '$'
         key = Digest::SHA256.hexdigest(str)

data/lib/review/idgxmlbuilder.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2008-2022 Minero Aoki, Kenshi Muto
+# Copyright (c) 2008-2023 Minero Aoki, Kenshi Muto
 #               2002-2007 Minero Aoki
 #
 # This program is free software.
@@ -136,7 +136,8 @@ module ReVIEW
       when 5
         @subsubsubsection += 1
         print %Q(<sect4 id="sect:#{@chapter.number}.#{@section}.#{@subsection}.#{@subsubsection}.#{@subsubsubsection}">) if @secttags
-      when 6 # rubocop:disable Lint/EmptyWhen
+      when 6
+        # ignore
       else
         raise "caption level too deep or unsupported: #{level}"
       end
@@ -526,7 +527,7 @@ module ReVIEW
       sepidx = nil
       rows = []
       lines.each_with_index do |line, idx|
-        if /\A[=\-]{12}/.match?(line)
+        if /\A[=-]{12}/.match?(line)
           sepidx ||= idx
           next
         end

data/lib/review/img_math.rb

@@ -1,3 +1,10 @@
+#
+# Copyright (c) 2021-2023 Masayoshi Takahashi, Kenshi Muto
+#
+# This program is free software.
+# You can distribute/modify this program under the terms of
+# the GNU LGPL, Lesser General Public License version 2.1.
+#
 require 'fileutils'
 require 'shellwords'
 require 'review/loggable'
@@ -29,7 +36,7 @@ module ReVIEW
       # Re:VIEW 2 compatibility
 
       img_path = File.join(@math_dir, "_gen_#{key}.#{@config['imgmath_options']['format']}")
-      Dir.mkdir(@math_dir) unless Dir.exist?(@math_dir)
+      FileUtils.mkdir_p(@math_dir)
       fontsize2 = (fontsize * 1.2).round.to_i
       texsrc = <<-EOB
 \\documentclass[12pt]{article}
@@ -63,7 +70,7 @@ module ReVIEW
     def make_math_images
       return if @math_maps.empty?
 
-      Dir.mkdir(@math_dir) unless Dir.exist?(@math_dir)
+      FileUtils.mkdir_p(@math_dir)
       fontsize = @config['imgmath_options']['fontsize'].to_f
       lineheight = @config['imgmath_options']['lineheight'].to_f
 

data/lib/review/init.rb

@@ -61,7 +61,7 @@ module ReVIEW
 
     def parse_options(args)
       @port = 18000
-      @bind = '0'
+      @bind = '0.0.0.0'
 
       opts = OptionParser.new
       opts.version = ReVIEW::VERSION
@@ -97,7 +97,7 @@ module ReVIEW
       opts.on('', '--port port', 'port to use for Web based layout configuration. (default: 18000)') do |port|
         @port = port
       end
-      opts.on('', '--bind bindaddress', 'address to use for Web based layout configuration. (default: 0 (any))') do |bind|
+      opts.on('', '--bind bindaddress', 'address to use for Web based layout configuration. (default: 0.0.0.0 (any))') do |bind|
         @bind = bind
       end
 
@@ -321,7 +321,7 @@ EOS
         AccessLog: [[File.open(IO::NULL, 'w'), '']]
       }
 
-      bind_address = (@bind == '0') ? '<thishost>' : @bind
+      bind_address = (@bind == '0.0.0.0') ? '<thishost>' : @bind
       puts "Please access http://#{bind_address}:#{web_config[:Port]} from Web browser."
       begin
         @web_server = WEBrick::HTTPServer.new(web_config)

data/lib/review/latexbuilder.rb

@@ -1038,7 +1038,7 @@ module ReVIEW
     end
 
     def blankline
-      puts '\vspace*{\baselineskip}'
+      puts '\par\vspace{\baselineskip}\par'
     end
 
     def noindent

data/lib/review/lineinput.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2002-2020 Minero Aoki, Masayoshi Takahashi, Kenshi Muto
+# Copyright (c) 2002-2023 Minero Aoki, Masayoshi Takahashi, Kenshi Muto
 #
 # This program is free software.
 # You can distribute/modify this program under the terms of
@@ -21,7 +21,7 @@ module ReVIEW
     end
 
     def inspect
-      "\#<#{self.class} file=#{@input.inspect} line=#{lineno}>"
+      "#<#{self.class} file=#{@input.inspect} line=#{lineno}>"
     end
 
     def eof?

data/lib/review/makerhelper.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2012-2020 Yuto HAYAMIZU, Kenshi Muto
+# Copyright (c) 2012-2023 Yuto HAYAMIZU, Kenshi Muto
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -48,7 +48,7 @@ module ReVIEW
           if FileTest.directory?("#{from_dir}/#{fname}")
             image_files += copy_images_to_dir("#{from_dir}/#{fname}", "#{to_dir}/#{fname}", options)
           else
-            FileUtils.mkdir_p(to_dir) unless File.exist?(to_dir)
+            FileUtils.mkdir_p(to_dir)
 
             is_converted = false
             (options[:convert] || {}).each do |orig_type, conv_type|

data/lib/review/pdfmaker.rb

@@ -1,4 +1,4 @@
-# Copyright (c) 2010-2022 Kenshi Muto and Masayoshi Takahashi
+# Copyright (c) 2010-2023 Kenshi Muto and Masayoshi Takahashi
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -69,9 +69,7 @@ module ReVIEW
     def build_path
       if @config['debug']
         path = "#{@config['bookname']}-pdf"
-        if File.exist?(path)
-          FileUtils.rm_rf(path, secure: true)
-        end
+        FileUtils.rm_rf(path, secure: true)
         Dir.mkdir(path)
         path
       else
@@ -517,7 +515,7 @@ module ReVIEW
         dir.sort.each do |fname|
           next unless File.extname(fname).downcase == '.' + extname
 
-          FileUtils.mkdir_p(copybase) unless Dir.exist?(copybase)
+          FileUtils.mkdir_p(copybase)
           if extname == 'erb'
             File.open(File.join(copybase, fname.sub(/\.erb\Z/, '')), 'w') do |f|
               f.print erb_content(File.join(dirname, fname))

data/lib/review/update.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2018-2022 Kenshi Muto
+# Copyright (c) 2018-2023 Kenshi Muto
 #
 # This program is free software.
 # You can distribute or modify this program under the terms of
@@ -258,9 +258,7 @@ module ReVIEW
 
     def update_rakefile(dir)
       taskdir = File.join(dir, 'lib/tasks')
-      unless File.exist?(taskdir)
-        FileUtils.mkdir_p(taskdir)
-      end
+      FileUtils.mkdir_p(taskdir)
 
       master_rakefile = File.join(@review_dir, 'samples/sample-book/src/Rakefile')
 
@@ -474,9 +472,7 @@ module ReVIEW
 
     def update_tex_stys(template, dir)
       texmacrodir = File.join(dir, 'sty')
-      unless File.exist?(texmacrodir)
-        FileUtils.mkdir(texmacrodir)
-      end
+      FileUtils.mkdir_p(texmacrodir)
 
       tdir = File.join(@review_dir, 'templates/latex', template)
       Dir.glob(File.join(tdir, '*.*')).each do |master_styfile|

data/lib/review/version.rb

@@ -1,3 +1,3 @@
 module ReVIEW
-  VERSION = '5.6.0'.freeze
+  VERSION = '5.7.0'.freeze
 end

data/lib/review/yamlloader.rb

@@ -36,9 +36,6 @@ module ReVIEW
       end
     end
 
-    def initialize
-    end
-
     # load YAML files
     #
     # `inherit: [3.yml, 6.yml]` in 7.yml; `inherit: [1.yml, 2.yml]` in 3.yml; `inherit: [4.yml, 5.yml]` in 6.yml

data/review.gemspec

@@ -14,8 +14,7 @@ Gem::Specification.new do |gem|
   gem.required_rubygems_version = Gem::Requirement.new('>= 0') if gem.respond_to?(:required_rubygems_version=)
   gem.metadata = { 'rubygems_mfa_required' => 'true' }
 
-  gem.files         = `git ls-files`.split("\n")
-  gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  gem.files         = `git ls-files`.split("\n").reject { |f| f.match(/^test/) }
   gem.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   gem.extra_rdoc_files = []
   gem.require_paths = ['lib']
@@ -28,7 +27,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency('mini_magick')
   gem.add_development_dependency('pygments.rb')
   gem.add_development_dependency('rake')
-  gem.add_development_dependency('rubocop', '~> 1.12.0')
+  gem.add_development_dependency('rubocop', '~> 1.45.1')
   gem.add_development_dependency('rubocop-performance')
   gem.add_development_dependency('rubocop-rake')
   gem.add_development_dependency('simplecov')

data/samples/syntax-book/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
 gem 'rake'
-gem 'review', '4.2.0'
+gem 'review', '~> 5.3.0'

data/templates/opf/epubv2.opf.erb

@@ -7,7 +7,9 @@
 <%= @opf_manifest %>
 <%= @opf_toc %>
   <guide>
+<% if @config['cover'].present? %>
     <reference type="cover" title="<%= ReVIEW::I18n.t('covertitle') %>" href="<%= @config['cover'] %>"/>
+<% end %>
 <% if @config['titlepage'].present? %>
     <reference type="title-page" title="<%= ReVIEW::I18n.t('titlepagetitle') %>" href="titlepage.<%= @config['htmlext'] %>"/>
 <% end %>

data/templates/opf/epubv3.opf.erb

@@ -7,7 +7,9 @@
 <%= @opf_manifest %>
 <%= @opf_toc %>
   <guide>
+<% if @config['cover'].present? %>
     <reference type="cover" title="<%= ReVIEW::I18n.t('covertitle') %>" href="<%= @config['cover'] %>"/>
+<% end %>
 <% if @config["titlepage"].present? %>
     <reference type="title-page" title="<%= ReVIEW::I18n.t('titlepagetitle') %>" href="titlepage.<%= @config['htmlext'] %>"/>
 <% end %>

data/templates/opf/opf_manifest_epubv2.opf.erb

@@ -1,6 +1,8 @@
   <manifest>
     <item id="ncx" href="<%= @config['bookname'] %>.ncx" media-type="application/x-dtbncx+xml"/>
+<% if @config['cover'] %>
     <item id="<%= @config['bookname'] %>" href="<%= @config['cover'] %>" media-type="application/xhtml+xml"/>
+<% end %>
 <% if @config['toc'] && @config['mytoc'] %>
     <item id="toc" href="<%= @config['bookname'] %>-toc.<%= @config['htmlext'] %>" media-type="application/xhtml+xml"/>
 <% end %>

data/templates/opf/opf_manifest_epubv3.opf.erb

@@ -1,6 +1,8 @@
   <manifest>
     <item properties="nav" id="<%= @config['bookname'] %>-toc.<%= @config['htmlext'] %>" href="<%= @config['bookname'] %>-toc.<%= @config['htmlext'] %>" media-type="application/xhtml+xml"/>
+<% if @config['cover'] %>
     <item id="<%= @config['bookname'] %>" href="<%= @config['cover'] %>" media-type="application/xhtml+xml"/>
+<% end %>
 <% if @coverimage %>
     <item properties="cover-image" id="cover-<%= @coverimage.id %>" href="<%= @coverimage.file %>" media-type="<%= @coverimage.media %>"/>
 <% end %>

data/templates/opf/opf_tocx_epubv3.opf.erb

@@ -3,7 +3,9 @@
 <% else %>
   <spine>
 <% end %>
+<% if @config['cover'].present? %>
     <itemref idref="<%= @config['bookname'] %>" linear="<%= @cover_linear %>"/>
+<% end %>
 <% toc = nil %>
 <% @tocx_contents.each do |item| %>
 <%   if toc.nil? && item.chaptype != 'pre' %>