reversibility_checker 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8716ded2cae0032c7edbbed7c8984b81d713d87fc6db20e65e78b127b96d492
-  data.tar.gz: ed5c4a55d4d0a22e56455b5ef97f1081f4825f84de998ddcc8a61f307d82bbb5
+  metadata.gz: 4b91654dea3e5c95c23d07864caadb872035768bf3138133e56e06ddce86e910
+  data.tar.gz: 4f7b994b1386b66fdfedb7970459d29ce521d1a6a962a96442939126e622fd28
 SHA512:
-  metadata.gz: 864547946fd5688164ba9f629d85518b8a48f93d9b3a56e5c711e58ec763306ca255fee03ec86ea65323e6c29845bfca70552de1ab71354be7516d6d50eb7e78
-  data.tar.gz: fa59da40b51345a7a53342e3a55e1fb1c0138ec71fe3e9a5f3fa8b316183a32d33870ad9cd5cb8d9af303bf4fbbab21751b948b4320b025024cee196e0f92142
+  metadata.gz: 997f9a560d5606c4ff4a3269c9381be065610fe20c685cc3e6155a0cf86adf18823af3aaf2ad85d7a1e601af469f5103a537df8a8ad0ea346c9b7fcf879696b7
+  data.tar.gz: '088af56d236e3636ea9ce5e05f2811b6b2d49adec4dd7db500aadc89e7ff134ddfe95892276d73cbb2795745f973d1835cce33ebb767bb37116e1eaa4343216e'

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+# Changelog
+
+## [Unreleased]
+
+## [[0.2.0]](https://github.com/naoty/reversibility_checker/compare/v0.1.1...v0.2.0) - 2018-10-21
+### Added
+* Support `CURRENT_VERSION` environment variable to specify a current schema version before migration.
+
+### Changed
+* Check the reversibility of each migrations.
+
+## [[0.1.1]](https://github.com/naoty/reversibility_checker/compare/v0.1.0...v0.1.1) - 2018-10-19
+### Added
+* Support sql schema format.
+
+## [0.1.0] - 2018-10-17
+### Added
+* Add fundamental features.

data/README.md

@@ -16,6 +16,12 @@ $ rails db:migrate:check_reversibility
 
 This task checks diffs between a current schema and a schema which migrated and rollbacked. If there are diffs, it will print the diffs and exit with exit status `1`.
 
+```bash
+$ rails db:migrate:check_reversibility CURRENT_VERSION=20181020120000
+```
+
+`CURRENT_VERSION` environment variable specifies a current schema version before migration. If it isn't passed, a current schema version will be the one of local database.
+
 ## Example
 
 if you create a following migration file,
@@ -36,6 +42,7 @@ when you run `db:migrate:check_reversibility` task, this task will run `db:migra
 
 ```bash
 $ rails db:migrate:check_reversibility
+== +20181020041241 ============================================================
  # This file is auto-generated from the current state of the database. Instead
  # of editing this file, please use the migrations feature of Active Record to
  # incrementally modify your database, and then regenerate this schema definition.
@@ -59,4 +66,5 @@ $ rails db:migrate:check_reversibility
    end
 
  end
+== -20181019134724 ============================================================
 ```

data/lib/reversibility_checker.rb

@@ -17,4 +17,27 @@ module ReversibilityChecker
       file.read
     end
   end
+
+  def self.current_version(config)
+    return ENV["CURRENT_VERSION"].to_i unless ENV["CURRENT_VERSION"].nil?
+
+    ActiveRecord::Base.establish_connection(config)
+    version = ActiveRecord::Migrator.current_version
+    ActiveRecord::Base.remove_connection
+
+    return version
+  end
+
+  def self.target_versions(config, current_version)
+    ActiveRecord::Base.establish_connection(config)
+    migration_context = ActiveRecord::Base.connection.migration_context
+    ActiveRecord::Base.remove_connection
+
+    versions = ActiveRecord::Tasks::DatabaseTasks.migrations_paths.flat_map do |migrations_path|
+      Dir["#{migrations_path}/*.rb"].map do |filepath|
+        migration_context.parse_migration_filename(filepath).first.to_i
+      end
+    end
+    versions.select { |version| version > current_version }.sort
+  end
 end

data/lib/reversibility_checker/railties/reversible.rake

@@ -8,12 +8,10 @@ namespace :db do
       require "active_record/schema_dumper"
 
       config = ActiveRecord::Base.configurations.fetch(Rails.env)
+      current_version = ReversibilityChecker.current_version(config)
+      target_versions = ReversibilityChecker.target_versions(config, current_version)
       migrations_paths = ActiveRecord::Tasks::DatabaseTasks.migrations_paths
 
-      ActiveRecord::Base.establish_connection(config)
-      current_version = ActiveRecord::Migrator.current_version
-      ActiveRecord::Base.remove_connection
-
       # Use a temporary database
       config["database"] += "_tmp"
 
@@ -21,28 +19,38 @@ namespace :db do
       $stdout = Tempfile.new
 
       ActiveRecord::Tasks::DatabaseTasks.create(config)
-      at_exit { ActiveRecord::Tasks::DatabaseTasks.drop(config) }
-
       ActiveRecord::Base.establish_connection(config)
-      ActiveRecord::Base.connection.migration_context.up(current_version)
 
-      # Take a snapshot of the temporary schema
-      current_schema = ReversibilityChecker.dump(config)
+      at_exit {
+        ActiveRecord::Tasks::DatabaseTasks.drop(config)
+        ActiveRecord::Base.remove_connection
+      }
 
-      # Migrate a temporary schema upto latest and rollback to current version
-      ActiveRecord::Base.connection.migration_context.up
-      ActiveRecord::Base.connection.migration_context.down(current_version)
+      reversible = true
+      base_version = current_version
 
-      # Take a snapshot again
-      rollbacked_schema = ReversibilityChecker.dump(config)
+      target_versions.each do |target_version|
+        ActiveRecord::Base.connection.migration_context.up(base_version)
+        base_schema = ReversibilityChecker.dump(config)
 
-      # Compare two snapshots
-      diff = Diffy::Diff.new(current_schema, rollbacked_schema)
+        ActiveRecord::Base.connection.migration_context.up(target_version)
+        ActiveRecord::Base.connection.migration_context.down(base_version)
+        rollbacked_schema = ReversibilityChecker.dump(config)
 
-      if diff.count > 0
-        Object::STDOUT.puts diff.to_s(:color)
-        exit 1
+        diff = Diffy::Diff.new(base_schema, rollbacked_schema)
+
+        if diff.count > 0
+          Object::STDOUT.puts "== +#{target_version} ============================================================"
+          Object::STDOUT.puts diff.to_s(:color)
+          Object::STDOUT.puts "== -#{base_version} ============================================================"
+          Object::STDOUT.puts ""
+          reversible = false
+        end
+
+        base_version = target_version
       end
+
+      exit 1 unless reversible
     end
   end
 end

data/lib/reversibility_checker/version.rb

@@ -1,3 +1,3 @@
 module ReversibilityChecker
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reversibility_checker
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Naoto Kaneko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-19 00:00:00.000000000 Z
+date: 2018-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -74,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt