reverse_markdown 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c57772b3497c7c256052c61ccd42a3c003671429
-  data.tar.gz: 2e90d7b68ce83784464dab7b3500b4a3fb5e22a8
+  metadata.gz: cfe67b1140e4f13da9e0503b72acc88379eb2be8
+  data.tar.gz: 0a7b5bcd1dba92dfef90949ea3e1655aca425f04
 SHA512:
-  metadata.gz: 6ece1678de088490e0e1442f9deeee55cc5346c2e8573643fdc628f298efe689ce145f0b87a04d1ed927784bcf452e3ecfc3751c861e747d1d96d76fcfec4d4d
-  data.tar.gz: 963b8984561fdea0eb8f7757ce1a727fdc6c0e7a7964a012e15844ca210988714232af08568c25d838d382de6a348f9b119187bfdcbb3a230110fbbb41bb1472
+  metadata.gz: 527a69664f9295f83f9ebaad8a3eda7f0a3b747012f0a67215d5b681d2de348ef135cbb0afcaa6f34c5e7c19c68e686b3b6006c497cfad9a66c5e5d1a01cbe60
+  data.tar.gz: 64784b22edb4a81bed4f34bdb5d1553422f9b1d2633f5df157e62a6c875e8735048fa94c6e8dcdc08aa6c3927a85a2ff3010d061d084b335712ec29fb1a6481b

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## 1.0.2 - Apr 2016
+### Changes
+- Handle edge case: exclamation mark before links, thanks @Easy-D (#57)
+
 ## 1.0.1 - Jan 2016
 ### Changes
 - Prevent double escaping of * and _, thanks @craig-day (#61)

data/lib/reverse_markdown/converters/a.rb

@@ -9,9 +9,17 @@ module ReverseMarkdown
         if href.to_s.start_with?('#') || href.to_s.empty? || name.empty?
           name
         else
-          " [#{name}](#{href}#{title})"
+          link = "[#{name}](#{href}#{title})"
+          link.prepend(' ') if prepend_space?(node)
+          link
         end
       end
+
+      private
+
+      def prepend_space?(node)
+        node.at_xpath("preceding::text()[1]").to_s.end_with?('!')
+      end
     end
 
     register :a, A.new

data/lib/reverse_markdown/version.rb

@@ -1,3 +1,3 @@
 module ReverseMarkdown
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/assets/anchors.html

@@ -4,7 +4,9 @@
     <a href="http://foobar.com">Foobar</a>
     <a href="http://foobar.com" title="f***** up beyond all recognition">Fubar</a>
     <a href="http://strong.foobar.com"><strong>Strong foobar</strong></a>
-    Period after the anchor: there shouldn't be an extra space after the <a href="http://foobar.com">anchor</a>. But inline, <a href="http://foobar.com">there</a> should be a space.
+    There should be no extra space before and after the anchor (<a href="http://foobar.com">stripped</a>).
+    Exception: after an !<a href="http://not.an.image.foobar.com">there</a> should be an extra space.
+    Even with stripped elements inbetween: !<span><a href="http://still.not.an.image.foobar.com">there</a></span> should be an extra space.
 
     ignore <a href="foo.html">   </a> anchor tags with no link text
     not ignore <a href="foo.html"><img src="image.png" alt="An Image" /></a> anchor tags with images

data/spec/components/anchors_spec.rb

@@ -6,15 +6,16 @@ describe ReverseMarkdown do
   let(:document) { Nokogiri::HTML(input) }
   subject { ReverseMarkdown.convert(input) }
 
-  it { is_expected.to include ' [Foobar](http://foobar.com) ' }
-  it { is_expected.to include ' [Fubar](http://foobar.com "f\*\*\*\*\* up beyond all recognition") ' }
-  it { is_expected.to include ' [**Strong foobar**](http://strong.foobar.com) ' }
+  it { is_expected.to include '[Foobar](http://foobar.com)' }
+  it { is_expected.to include '[Fubar](http://foobar.com "f\*\*\*\*\* up beyond all recognition")' }
+  it { is_expected.to include '[**Strong foobar**](http://strong.foobar.com)' }
 
   it { is_expected.to include ' ![](http://foobar.com/logo.png) ' }
   it { is_expected.to include ' ![foobar image](http://foobar.com/foobar.png) ' }
   it { is_expected.to include ' ![foobar image 2](http://foobar.com/foobar2.png "this is the foobar image 2") ' }
-  it { is_expected.to include 'extra space after the [anchor](http://foobar.com).'}
-  it { is_expected.to include 'But inline, [there](http://foobar.com) should be a space.'}
+  it { is_expected.to include 'no extra space before and after the anchor ([stripped](http://foobar.com)).'}
+  it { is_expected.to include 'after an ! [there](http://not.an.image.foobar.com) should be an extra space.'}
+  it { is_expected.to include 'with stripped elements inbetween: ! [there](http://still.not.an.image.foobar.com) should be an extra space.'}
 
   context "links to ignore" do
     it { is_expected.to include ' ignore anchor tags with no link text ' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reverse_markdown
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Johannes Opper
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-29 00:00:00.000000000 Z
+date: 2016-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri