reverse_markdown 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad925687978f44b00fbabc9a9a8f526033d94a4c
-  data.tar.gz: 39313ccac2c11accd0bb6b8c69f7c0ae39c3c1a1
+  metadata.gz: 883820fb93f917bc937cd5c12963f3482a0e808f
+  data.tar.gz: a02eedd1b8ab8d3e115947e55d72e6f559577e47
 SHA512:
-  metadata.gz: dcd1e5ecfc3f651122af1a5b452c7aea5faec608a4fcef1e853d5a03b331ed32795f7050c29a8464ff911b063805ebe0bd7a82dca21b634aa8b0346abb512ada
-  data.tar.gz: becbab17c4dbc95024f056f1099248a8b3ea35d1d1c2e3a34dfa4948f4a2e2bbe9c8a92fb39b209e4465ddcb92743f448c39dba02ece6b04febd2c436113915c
+  metadata.gz: 8a03b2214708c5bf1a56d76d9ce944f4b3a7ea76f0f00657c6873d3b25617122b2376b685980f7f149894274a617aedb01cd7d5952e518db737d406c1579a89a
+  data.tar.gz: 91371fc841d5b46cbb99a6af813ce404702ceffe0b46403f5eb61bc579609c00ade300dc174cc68b982e7a3f18b05c4a2a28abb4f7b7a8c0bf4132bdbdef3d0c

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## 0.8.2 - May 2015
+### Changes
+- Don't add whitespaces in links and images if they contain underscores
+
 ## 0.8.1 - April 2015
 ### Changes
 - Don't add newlines after nested lists

data/lib/reverse_markdown/cleaner.rb

@@ -64,6 +64,9 @@ module ReverseMarkdown
     def preserve_border_whitespaces(string, options = {}, &block)
       return string if string =~ /\A\s*\Z/
       default_border = options.fetch(:default_border, '')
+      # If the string contains part of a link so the characters [,],(,)
+      # then don't add any extra spaces
+      default_border = '' if string =~ /[\[\(\]\)]/
       string_start   = present_or_default(string[/\A\s*/], default_border)
       string_end     = present_or_default(string[/\s*\Z/], default_border)
       result         = yield

data/lib/reverse_markdown/config.rb

@@ -3,9 +3,11 @@ module ReverseMarkdown
     attr_accessor :unknown_tags, :github_flavored
 
     def initialize
-      @unknown_tags    = :pass_through
-      @github_flavored = false
-      @inline_options = {}
+      @unknown_tags     = :pass_through
+      @github_flavored  = false
+      @em_delimiter     = '_'
+      @strong_delimiter = '**'
+      @inline_options   = {}
     end
 
     def with(options = {})

data/lib/reverse_markdown/version.rb

@@ -1,3 +1,3 @@
 module ReverseMarkdown
-  VERSION = "0.8.1"
+  VERSION = "0.8.2"
 end

data/spec/lib/reverse_markdown/cleaner_spec.rb

@@ -79,6 +79,18 @@ describe ReverseMarkdown::Cleaner do
       expect(result).to eq "1 **fat** 2"
     end
 
+    it "doesn't add whitespaces to underscore'ed elements if they are part of links" do
+      input = "![im__age](sou__rce)"
+      result = cleaner.clean_tag_borders(input)
+      expect(result).to eq "![im__age](sou__rce)"
+    end
+
+    it "still cleans up whitespaces that aren't inside a link" do
+      input = "now __italic __with following [under__scored](link)"
+      result = cleaner.clean_tag_borders(input)
+      expect(result).to eq "now __italic__ with following [under__scored](link)"
+    end
+
     it 'cleans italic stuff as well' do
       input = "1 __italic __ 2 __ italic__ 3__italic __4"
       result = cleaner.clean_tag_borders(input)

data/spec/lib/reverse_markdown/converters/strong_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe ReverseMarkdown::Converters::Strong do
+  let(:converter) { ReverseMarkdown::Converters::Strong.new }
+
+  it 'returns an empty string if the node is empty' do
+    input = node_for('<strong></strong>')
+    expect(converter.convert(input)).to eq ''
+  end
+
+  it 'returns just the content if the strong tag is nested in another strong' do
+    input = node_for('<strong><strong>foo</strong></strong>')
+    expect(converter.convert(input.children.first)).to eq 'foo'
+  end
+
+  it 'moves border whitespaces outside of the delimiters tag' do
+    input = node_for("<strong> \n foo </strong>")
+    expect(converter.convert(input)).to eq " **foo** "
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reverse_markdown
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Johannes Opper
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-18 00:00:00.000000000 Z
+date: 2015-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -175,6 +175,7 @@ files:
 - spec/lib/reverse_markdown/converters/del_spec.rb
 - spec/lib/reverse_markdown/converters/li_spec.rb
 - spec/lib/reverse_markdown/converters/pre_spec.rb
+- spec/lib/reverse_markdown/converters/strong_spec.rb
 - spec/lib/reverse_markdown/converters/text_spec.rb
 - spec/lib/reverse_markdown/converters_spec.rb
 - spec/lib/reverse_markdown_spec.rb
@@ -235,6 +236,7 @@ test_files:
 - spec/lib/reverse_markdown/converters/del_spec.rb
 - spec/lib/reverse_markdown/converters/li_spec.rb
 - spec/lib/reverse_markdown/converters/pre_spec.rb
+- spec/lib/reverse_markdown/converters/strong_spec.rb
 - spec/lib/reverse_markdown/converters/text_spec.rb
 - spec/lib/reverse_markdown/converters_spec.rb
 - spec/lib/reverse_markdown_spec.rb