rev 0.3.0 → 0.3.1

data/CHANGES

@@ -1,3 +1,15 @@
+0.3.1:
+
+* Configurable intervals for Rev::StatWatcher
+
+* Fix broken version number :(
+
+* Removed warning about spuriously readable sockets from Rev::Listener
+
+* Rev::Listener ignores ECONNABORTED from accept_nonblock
+
+* Document rationale for EAGAIN/ECONNABORTED handling in Rev::Listener
+
 0.3.0:
 
 * Add Rev::StatWatcher to monitor filesystem changes

data/ext/rev/rev_stat_watcher.c

@@ -16,7 +16,7 @@ static VALUE cRev_Watcher = Qnil;
 static VALUE cRev_StatWatcher = Qnil;
 static VALUE cRev_Loop = Qnil;
 
-static VALUE Rev_StatWatcher_initialize(VALUE self, VALUE path);
+static VALUE Rev_StatWatcher_initialize(int argc, VALUE *argv, VALUE self);
 static VALUE Rev_StatWatcher_attach(VALUE self, VALUE loop);
 static VALUE Rev_StatWatcher_detach(VALUE self);
 static VALUE Rev_StatWatcher_enable(VALUE self);
@@ -39,7 +39,7 @@ void Init_rev_stat_watcher()
   cRev_StatWatcher = rb_define_class_under(mRev, "StatWatcher", cRev_Watcher);
   cRev_Loop = rb_define_class_under(mRev, "Loop", rb_cObject);
 
-  rb_define_method(cRev_StatWatcher, "initialize", Rev_StatWatcher_initialize, 1);
+  rb_define_method(cRev_StatWatcher, "initialize", Rev_StatWatcher_initialize, -1);
   rb_define_method(cRev_StatWatcher, "attach", Rev_StatWatcher_attach, 1);
   rb_define_method(cRev_StatWatcher, "detach", Rev_StatWatcher_detach, 0);
   rb_define_method(cRev_StatWatcher, "enable", Rev_StatWatcher_enable, 0);
@@ -50,15 +50,25 @@ void Init_rev_stat_watcher()
 
 /**
  *  call-seq:
- *    Rev::StatWatcher.initialize(path) -> Rev::StatWatcher
+ *    Rev::StatWatcher.initialize(path, interval = 0) -> Rev::StatWatcher
  * 
  * Create a new Rev::StatWatcher for the given path.  This will monitor the
- * given path for changes at the filesystem level.
+ * given path for changes at the filesystem level.  The interval argument
+ * specified how often in seconds the path should be polled for changes.
+ * Setting interval to zero uses an "automatic" value (typically around 5
+ * seconds) which optimizes performance.  Otherwise, values less than
+ * 0.1 are not particularly meaningful.  Where available (at present, on Linux)
+ * high performance file monitoring interfaces will be used instead of polling.
  */
-static VALUE Rev_StatWatcher_initialize(VALUE self, VALUE path)
+static VALUE Rev_StatWatcher_initialize(int argc, VALUE *argv, VALUE self)
 {
+	VALUE path, interval;
   struct Rev_Watcher *watcher_data;
 
+  rb_scan_args(argc, argv, "11", &path, &interval);
+  if(interval != Qnil)
+    interval = rb_convert_type(interval, T_FLOAT, "Float", "to_f");
+
   path = rb_String(path);
   rb_iv_set(self, "@path", path);
 
@@ -69,7 +79,7 @@ static VALUE Rev_StatWatcher_initialize(VALUE self, VALUE path)
       &watcher_data->event_types.ev_stat, 
       Rev_StatWatcher_libev_callback, 
       RSTRING_PTR(path), 
-      0
+      interval == Qnil ? 0 : NUM2DBL(interval)
   );  
   watcher_data->event_types.ev_stat.data = (void *)self;
 
@@ -179,4 +189,4 @@ static void Rev_StatWatcher_libev_callback(struct ev_loop *ev_loop, struct ev_st
 static void Rev_StatWatcher_dispatch_callback(VALUE self, int revents)
 { 
   rb_funcall(self, rb_intern("on_change"), 0, 0);
-}
+}

data/lib/rev.rb

@@ -23,6 +23,6 @@ require 'iobuffer'
 end
 
 module Rev
-  Rev::VERSION = '0.2.3' unless defined? Rev::VERSION
+  Rev::VERSION = '0.3.1' unless defined? Rev::VERSION
   def self.version() VERSION end
 end

data/lib/rev/listener.rb

@@ -39,8 +39,16 @@ module Rev
     def on_readable
       begin
         on_connection @listen_socket.accept_nonblock
-      rescue Errno::EAGAIN
-        STDERR.puts "warning: listener socket spuriously readable"
+      rescue Errno::EAGAIN, Errno::ECONNABORTED
+        # EAGAIN can be triggered here if the socket is shared between
+        # multiple processes and a thundering herd is woken up to accept
+        # one connection, only one process will get the connection and
+        # the others will be awoken.
+        # ECONNABORTED is documented in accept() manpages but modern TCP
+        # stacks with syncookies and/or accept()-filtering for DoS
+        # protection do not see it.  In any case this error is harmless
+        # and we should instead spend our time with clients that follow
+        # through on connection attempts.
       end
     end
   end

data/rev.gemspec

@@ -2,10 +2,10 @@ require 'rubygems'
 
 GEMSPEC = Gem::Specification.new do |s|
   s.name = "rev"
-  s.version = "0.3.0"
+  s.version = "0.3.1"
   s.authors = "Tony Arcieri"
   s.email = "tony@medioh.com"
-  s.date = "2009-08-26"
+  s.date = "2009-10-13"
   s.summary = "Rev is a Ruby binding to the libev high performance event library"
   s.platform = Gem::Platform::RUBY
   s.required_ruby_version = '>= 1.8.6'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rev
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors: 
 - Tony Arcieri
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-08-26 00:00:00 -06:00
+date: 2009-10-13 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency