rev-api 2.0.3 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d6d9816d10431466d097102deefc91846e2dc1b1
-  data.tar.gz: be67240ab97c0b3f4cab2eb3ce8e6f1d39787fa0
+  metadata.gz: c4126d05598d0db6d32e56f7e827b1fc96940e20
+  data.tar.gz: 4d47a8ce94a5bf50e3e90902f5bafac18651c271
 SHA512:
-  metadata.gz: d8aed8b6c55afc38a64d121e9eadbb6059e2ac1155ad0fc37c8b89aa020cd9e60b0ddfbdab321764c27bde0113250b07993d301818f2ae4c6de7398d26a4eea8
-  data.tar.gz: 68ae92704b2639777040c792765c4b73a13c05bcffc90a504562a256275c0c75829c3ab2c447221e25bf302656111560992058db5d4e184b3e97a970049c0434
+  metadata.gz: d565c4d92f78ef8f736f262c8e59edac3339ab4431f837d8134245b533216e4d84ee3b6de8ed65ec43292508f40a3b93f7edfffc897c37f2a94cb2a7331b46ea
+  data.tar.gz: 167b9597f691911f6a4534ebcff6b0292b4d1a06ba6941defd6623a9e3bc84ca6e23de45f8fccce49e75e083b58e0ddca85bcc47c9249e0d1fdfd29c2693014c

data/lib/rev-api/api.rb

@@ -220,7 +220,7 @@ module Rev
     def upload_input(path, content_type)
       filename = Pathname.new(path).basename
       headers = {
-        'Content-Disposition' => "attachment; filename=#{filename}",
+        'Content-Disposition' => "attachment; filename=\"#{filename}\"",
         'Content-Type' => content_type
       }
 

data/lib/rev-api/models/order_request.rb

@@ -152,6 +152,9 @@ module Rev
     # Array of file formats the captions should be delivered as.  (Optional, default is SubRip)
     attr_reader :output_file_formats
 
+    # Optional, Array of language codes to request foreign language subtitles
+    attr_reader :subtitle_languages
+
     # All supported output file formats
     OUTPUT_FILE_FORMATS = {
       :subrip => 'SubRip',
@@ -165,6 +168,10 @@ module Rev
       :cheetahcap => 'CheetahCap'
     }
 
+    # @param inputs [Array] list of inputs
+    # @param info [Hash] of fields to initialize instance. May contain:
+    #        - :subtitle_languages
+    # @see TranslationOptions for a list of language codes.
     def initialize(inputs, info = {})
       super(inputs, info)
       raise(ArgumentError, "invalid format(s)") unless validate_output_formats(info[:output_file_formats])

data/lib/rev-api/version.rb

@@ -1,3 +1,3 @@
 module Rev
-  VERSION = '2.0.3'
+  VERSION = '2.1.0'
 end

data/spec/fixtures/api_cassettes/link_input.yml

@@ -25,7 +25,7 @@ http_interactions:
       Expires:
       - '-1'
       Location:
-      - urn:foxtranslate:inputmedia:UHVwbG9hZHMvMjAxMy0wOS0xNy82NGRhOWY4Ny0zYTNlLTQ3NDgtYmI4Yi05MmE3ZmVhMTJjYzcvcmV2X2xvZ29fY29sb3JlZF90b3AucG5n
+      - urn:rev:inputmedia:UHVwbG9hZHMvMjAxMy0wOS0xNy82NGRhOWY4Ny0zYTNlLTQ3NDgtYmI4Yi05MmE3ZmVhMTJjYzcvcmV2X2xvZ29fY29sb3JlZF90b3AucG5n
       Server:
       - Microsoft-IIS/7.5
       X-Miniprofiler-Ids:

data/spec/fixtures/api_cassettes/link_input_with_all_attributes.yml

@@ -25,7 +25,7 @@ http_interactions:
       Expires:
       - '-1'
       Location:
-      - urn:foxtranslate:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy83MTZjOTAzNC1iMDkxLTRlYjgtOTAzMi1kNjU0NzMzNDJlZTcvc291cmNlZG9jdW1lbnQucG5n
+      - urn:rev:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy83MTZjOTAzNC1iMDkxLTRlYjgtOTAzMi1kNjU0NzMzNDJlZTcvc291cmNlZG9jdW1lbnQucG5n
       Server:
       - Microsoft-IIS/7.5
       X-Miniprofiler-Ids:

data/spec/fixtures/api_cassettes/link_input_with_spaces_in_filename.yml

@@ -0,0 +1,45 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://www.revtrunk.com/api/v1/inputs
+    body:
+      encoding: UTF-8
+      string: '{"url":"https://s3-us-west-2.amazonaws.com/public-rev/translation/Rev
+        Certified Template (2014-06-11).docx","filename":"Rev Certified Template (2014-06-11).docx","content_type":"application/vnd.openxmlformats-officedocument.wordprocessingml.document"}'
+    headers:
+      Authorization:
+      - Rev welcome:AAAAAu/YjZ3phXU5FsF35yIcgiA=
+      User-Agent:
+      - RevOfficialRubySDK/2.1.0
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 201
+      message: Created
+    headers:
+      Cache-Control:
+      - no-cache
+      Pragma:
+      - no-cache
+      Expires:
+      - '-1'
+      Location:
+      - urn:rev:inputmedia:YHVwbG9hZHMvMjAxNS0xMC0yMC80ZTlkNmFhZS02YmNhLTQzY2MtOTViNy1lM2E0MmNhNmQwMmQvUmV2IENlcnRpZmllZCBUZW1wbGF0ZSAoMjAxNC0wNi0xMSkuZG9jeA==
+      Server:
+      - Microsoft-IIS/8.5
+      X-Miniprofiler-Ids:
+      - '["a40c8bab-d6ad-4e2f-b277-d5691885e974"]'
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Tue, 20 Oct 2015 21:48:24 GMT
+      Content-Length:
+      - '0'
+    body:
+      encoding: UTF-8
+      string: ''
+    http_version:
+  recorded_at: Tue, 20 Oct 2015 21:48:23 GMT
+recorded_with: VCR 2.6.0

data/spec/fixtures/api_cassettes/submit_su_order.yml

@@ -0,0 +1,45 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://www.revtrunk.com/api/v1/orders
+    body:
+      encoding: UTF-8
+      string: ! '{"payment":{"type":"AccountBalance"},"caption_options":{"inputs":[{"external_link":"http://www.youtube.com/watch?v=UF8uR6Z6KLc"},{"video_length_seconds":900,"external_link":"https://vimeo.com/7976699"}],"subtitle_languages":["es","it"],"output_file_formats":["SubRip"]},"client_ref":"XB432423","comment":"Please
+        work quickly"}'
+    headers:
+      Content-Type:
+      - application/json
+      Authorization:
+      - Rev welcome:AAAAAu/YjZ3phXU5FsF35yIcgiA=
+      User-Agent:
+      - RevOfficialRubySDK/1.0.0
+  response:
+    status:
+      code: 201
+      message: Created
+    headers:
+      Cache-Control:
+      - no-cache
+      Pragma:
+      - no-cache
+      Expires:
+      - '-1'
+      Location:
+      - https://www.revtrunk.com/api/v1/orders/CP56789
+      Server:
+      - Microsoft-IIS/7.5
+      X-Miniprofiler-Ids:
+      - ! '["43bcb320-a1c9-4e9f-96c1-320e01a31549","ad8a37cd-e5ea-4134-ac9e-0390f722d6f6"]'
+      X-Powered-By:
+      - ASP.NET
+      Date:
+      - Wed, 18 Sep 2013 00:21:27 GMT
+      Content-Length:
+      - '0'
+    body:
+      encoding: US-ASCII
+      string: ''
+    http_version:
+  recorded_at: Wed, 18 Sep 2013 00:21:27 GMT
+recorded_with: VCR 2.5.0

data/spec/fixtures/api_cassettes/submit_tr_order.yml

@@ -5,7 +5,7 @@ http_interactions:
     uri: https://www.revtrunk.com/api/v1/orders
     body:
       encoding: UTF-8
-      string: ! '{"payment":{"type":"AccountBalance"},"translation_options":{"source_language_code":"es","destination_language_code":"en","inputs":[{"word_length":1000,"uri":"urn:foxtranslate:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy9lMzk4MWIzNS0wNzM1LTRlMDAtODY1NC1jNWY4ZjE4MzdlMTIvc291cmNlZG9jdW1lbnQucG5n"}]}}'
+      string: ! '{"payment":{"type":"AccountBalance"},"translation_options":{"source_language_code":"es","destination_language_code":"en","inputs":[{"word_length":1000,"uri":"urn:rev:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy9lMzk4MWIzNS0wNzM1LTRlMDAtODY1NC1jNWY4ZjE4MzdlMTIvc291cmNlZG9jdW1lbnQucG5n"}]}}'
     headers:
       Content-Type:
       - application/json

data/spec/fixtures/api_cassettes/upload_input.yml

@@ -52,7 +52,7 @@ http_interactions:
       User-Agent:
       - RevOfficialRubySDK/1.0.0
       Content-Disposition:
-      - attachment; filename=sourcedocument.png
+      - attachment; filename="sourcedocument.png"
       Content-Type:
       - image/png
       Accept:
@@ -71,7 +71,7 @@ http_interactions:
       Expires:
       - '-1'
       Location:
-      - urn:foxtranslate:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0yNi9jYzljNGE0MC03NTY3LTQ2YjYtYmVmMi0xMjU5ODgwODNhMWQvc291cmNlZG9jdW1lbnQucG5n
+      - urn:rev:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0yNi9jYzljNGE0MC03NTY3LTQ2YjYtYmVmMi0xMjU5ODgwODNhMWQvc291cmNlZG9jdW1lbnQucG5n
       Server:
       - Microsoft-IIS/7.5
       X-Miniprofiler-Ids:

data/spec/fixtures/api_cassettes/upload_input_with_invalid_content_type.yml

@@ -52,7 +52,7 @@ http_interactions:
       User-Agent:
       - RevOfficialRubySDK/1.0.0
       Content-Disposition:
-      - attachment; filename=sourcedocument.png
+      - attachment; filename="sourcedocument.png"
       Content-Type:
       - trololo
       Accept:

data/spec/lib/rev/post_inputs_spec.rb

@@ -11,14 +11,34 @@ describe 'POST /inputs' do
     content_type = 'image/png'
     new_input_location = client.create_input_from_link(link, filename, content_type)
 
-    new_input_location.must_match 'urn:foxtranslate:inputmedia:'
+    new_input_location.must_match 'urn:rev:inputmedia:'
+    expected_body = {
+      'url' => link,
+      'filename' => filename,
+      'content_type' => content_type
+    }
+    assert_requested(:post, /.*\/inputs/, :times => 1) do |req|
+      req.headers['Content-Type'].must_equal 'application/json'
+      actual_body = JSON.load req.body
+      actual_body.must_equal expected_body
+    end
+  end
+
+  it 'must quote the filename' do
+    VCR.insert_cassette 'link_input_with_spaces_in_filename'
+
+    link = 'https://s3-us-west-2.amazonaws.com/public-rev/translation/Rev Certified Template (2014-06-11).docx'
+    filename = 'Rev Certified Template (2014-06-11).docx'
+    content_type = 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'
+    new_input_location = client.create_input_from_link(link, filename, content_type)
+
+    new_input_location.must_match 'urn:rev:inputmedia:'
     expected_body = {
       'url' => link,
       'filename' => filename,
       'content_type' => content_type
     }
     assert_requested(:post, /.*\/inputs/, :times => 1) do |req|
-      req.headers['Content-Type'] == 'application/json'
       actual_body = JSON.load req.body
       actual_body.must_equal expected_body
     end
@@ -30,10 +50,10 @@ describe 'POST /inputs' do
     link = 'https://www.rev.com/content/img/rev/rev_logo_colored_top.png'
     new_input_location = client.create_input_from_link(link)
 
-    new_input_location.must_match 'urn:foxtranslate:inputmedia:'
+    new_input_location.must_match 'urn:rev:inputmedia:'
     expected_body = { 'url' => link }
     assert_requested(:post, /.*\/inputs/, :times => 1) do |req|
-      req.headers['Content-Type'] == 'application/json'
+      req.headers['Content-Type'].must_equal 'application/json'
       actual_body = JSON.load req.body
       actual_body.must_equal expected_body
     end
@@ -47,11 +67,11 @@ describe 'POST /inputs' do
 
     new_input_location = client.upload_input(filename, content_type)
 
-    new_input_location.must_match 'urn:foxtranslate:inputmedia:'
+    new_input_location.must_match 'urn:rev:inputmedia:'
     expected_body = File.read(filename)
     assert_requested(:post, /.*\/inputs/, :times => 1) do |req|
-      req.headers['Content-Type'] == content_type
-      req.headers['Content-Disposition'] == 'attachment; filename="sourcedocument.png'
+      req.headers['Content-Type'].must_equal content_type
+      req.headers['Content-Disposition'].must_equal 'attachment; filename="sourcedocument.png"'
       req.body.must_equal expected_body
     end
   end

data/spec/lib/rev/post_order_spec.rb

@@ -21,7 +21,7 @@ describe 'POST /orders' do
   }
   let(:translation_inputs) {
     inputs = []
-    inputs << Rev::Input.new(:word_length => 1000, :uri => 'urn:foxtranslate:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy9lMzk4MWIzNS0wNzM1LTRlMDAtODY1NC1jNWY4ZjE4MzdlMTIvc291cmNlZG9jdW1lbnQucG5n')
+    inputs << Rev::Input.new(:word_length => 1000, :uri => 'urn:rev:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy9lMzk4MWIzNS0wNzM1LTRlMDAtODY1NC1jNWY4ZjE4MzdlMTIvc291cmNlZG9jdW1lbnQucG5n')
   }
   let(:caption_inputs) {
     inputs = []
@@ -34,6 +34,10 @@ describe 'POST /orders' do
   let(:caption_options) {
     Rev::CaptionOptions.new(caption_inputs, :output_file_formats => ['SubRip'])
   }
+  let(:subtitle_options) {
+    Rev::CaptionOptions.new(caption_inputs, :subtitle_languages => ['es','it'],
+    :output_file_formats => ['SubRip'])
+  }
 
   it 'must place order using account balance' do
     VCR.insert_cassette 'submit_tc_order_with_account_balance'
@@ -59,11 +63,7 @@ describe 'POST /orders' do
         'timestamps' => true
       }
     }
-    assert_requested(:post, /.*\/orders/, :times => 1) do |req|
-      req.headers['Content-Type'] == 'application/json'
-      actual_body = JSON.load req.body
-      actual_body.must_equal expected_body
-    end
+    assert_order_placement_success(expected_body)
   end
 
   it 'must default to account balance if payment property not set' do
@@ -90,19 +90,14 @@ describe 'POST /orders' do
             'timestamps' => true
         }
     }
-    assert_requested(:post, /.*\/orders/, :times => 1) do |req|
-      req.headers['Content-Type'] == 'application/json'
-      actual_body = JSON.load req.body
-      actual_body.must_equal expected_body
-    end
+    assert_order_placement_success(expected_body)
   end
 
   it 'must raise BadRequest error in case of request validation failure' do
     VCR.insert_cassette 'submit_tc_order_with_invalid_request'
 
     # example - missing transcription options
-    request = Rev::OrderRequest.new(
-    )
+    request = Rev::OrderRequest.new
 
     action = lambda { client.submit_order(request) }
     exception = action.must_raise Rev::BadRequestError
@@ -127,26 +122,22 @@ describe 'POST /orders' do
       'priority' => Rev::OrderRequest::PRIORITY[:normal],
       'translation_options' => {
         'inputs'=> [
-          { 'word_length' => 1000, 'uri' => 'urn:foxtranslate:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy9lMzk4MWIzNS0wNzM1LTRlMDAtODY1NC1jNWY4ZjE4MzdlMTIvc291cmNlZG9jdW1lbnQucG5n' },
+          { 'word_length' => 1000, 'uri' => 'urn:rev:inputmedia:SnVwbG9hZHMvMjAxMy0wOS0xNy9lMzk4MWIzNS0wNzM1LTRlMDAtODY1NC1jNWY4ZjE4MzdlMTIvc291cmNlZG9jdW1lbnQucG5n' },
         ],
         'source_language_code' => 'es',
         'destination_language_code' => 'en'
       }
     }
-    assert_requested(:post, /.*\/orders/, :times => 1) do |req|
-      req.headers['Content-Type'] == 'application/json'
-      actual_body = JSON.load req.body
-      actual_body.must_equal expected_body
-    end
+    assert_order_placement_success(expected_body)
   end
-  
+
   it 'must submit caption order with options' do
     VCR.insert_cassette 'submit_cp_order'
-    
+
     request = Rev::OrderRequest.new(:caption_options => caption_options)
-    
+
     new_order_num = client.submit_order(request)
-    
+
     new_order_num.must_equal 'CP12345'
     expected_body = {
       'payment' => {
@@ -160,15 +151,45 @@ describe 'POST /orders' do
         'output_file_formats' => [Rev::CaptionOptions::OUTPUT_FILE_FORMATS[:subrip]]
       }
     }
-    assert_requested(:post, /.*\/orders/, :times => 1) do |req|
-      req.headers['Content-Type'] == 'application/json'
-      actual_body = JSON.load req.body
-      actual_body.must_equal expected_body
-    end
+    assert_order_placement_success(expected_body)
+  end
+
+  it 'must submit subtitle order with options' do
+    VCR.insert_cassette 'submit_su_order'
+
+    request = Rev::OrderRequest.new(:caption_options => subtitle_options)
+
+    new_order_num = client.submit_order(request)
+
+    new_order_num.must_equal 'CP56789'
+    expected_body = {
+      'payment' => {
+        'type' => 'AccountBalance'
+      },
+      'priority' => Rev::OrderRequest::PRIORITY[:normal],
+      'caption_options' => {
+        'inputs'=> [
+          { 'video_length_seconds' => 900, 'external_link' => 'http://www.youtube.com/watch?v=UF8uR6Z6KLc' }
+        ],
+        'subtitle_languages' => ['es','it'],
+        'output_file_formats' => [Rev::CaptionOptions::OUTPUT_FILE_FORMATS[:subrip]]
+      }
+    }
+    assert_order_placement_success(expected_body)
   end
 
   after do
     VCR.eject_cassette
   end
 
-end
+  private
+
+  def assert_order_placement_success(expected_body)
+    assert_requested(:post, /.*\/orders/, :times => 1) do |req|
+      req.headers['Content-Type'].must_equal 'application/json'
+      actual_body = JSON.load req.body
+      actual_body.must_equal expected_body
+    end
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rev-api
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.1.0
 platform: ruby
 authors:
 - Rev.com, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-02 00:00:00.000000000 Z
+date: 2015-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -209,8 +209,10 @@ files:
 - spec/fixtures/api_cassettes/get_tr_order.yml
 - spec/fixtures/api_cassettes/link_input.yml
 - spec/fixtures/api_cassettes/link_input_with_all_attributes.yml
+- spec/fixtures/api_cassettes/link_input_with_spaces_in_filename.yml
 - spec/fixtures/api_cassettes/not_found_order.yml
 - spec/fixtures/api_cassettes/submit_cp_order.yml
+- spec/fixtures/api_cassettes/submit_su_order.yml
 - spec/fixtures/api_cassettes/submit_tc_order_with_account_balance.yml
 - spec/fixtures/api_cassettes/submit_tc_order_with_invalid_request.yml
 - spec/fixtures/api_cassettes/submit_tc_order_without_specifying_payment.yml
@@ -276,8 +278,10 @@ test_files:
 - spec/fixtures/api_cassettes/get_tr_order.yml
 - spec/fixtures/api_cassettes/link_input.yml
 - spec/fixtures/api_cassettes/link_input_with_all_attributes.yml
+- spec/fixtures/api_cassettes/link_input_with_spaces_in_filename.yml
 - spec/fixtures/api_cassettes/not_found_order.yml
 - spec/fixtures/api_cassettes/submit_cp_order.yml
+- spec/fixtures/api_cassettes/submit_su_order.yml
 - spec/fixtures/api_cassettes/submit_tc_order_with_account_balance.yml
 - spec/fixtures/api_cassettes/submit_tc_order_with_invalid_request.yml
 - spec/fixtures/api_cassettes/submit_tc_order_without_specifying_payment.yml