rets 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2d46af696793fde645c0c712cdb2e8a708bb93a1
-  data.tar.gz: dd858c7811d76a390e178afd853f73a6f1d9807b
+  metadata.gz: 40ba28e99fa147a1f23f7cf4e7e04fcd5c9a4218
+  data.tar.gz: 8abca9ffb82c600b2f0ca9c6caf774c17eb0a4cb
 SHA512:
-  metadata.gz: 6358cf33cb29fb6801dc0e6046f281a41deb49b1163f8a8344f9441ee7737edbd70b2cb5b04190da9abfd5c29c7721062ae7caf7885815efef11fe28b93aea27
-  data.tar.gz: 4ac48ac0f4230210b4e52c9fcd49db1896510f4d819c2ebf7fb075618c1e7bfcfc4b76cccdbc135c5948c6a8903987c42d958387c5b77c3ebf8b5166421a3b36
+  metadata.gz: c510f13d8823562c48a2fd87421ada813c3766846082c6dd8bdad442c4fe4922de65cbd0d2d486b7fcbe8fb48c69651b61fc844812bbc2e7b307152ca327d2e1
+  data.tar.gz: 19f7bd93de8858158118108266f78d344c65c23f9f7c68ed20e19b7a77b0d42f4d187654c3a18ff817d5e35b1480b5e86741bd88acdf2a483a9510feb00777f8

data/CHANGELOG.md

@@ -1,11 +1,15 @@
+### 0.8.1 / 2015-06-09
+
+* fix: actually make the httpclient version more specific this time
+
 ### 0.8.0 / 2015-06-09
 
-* reduce memory usage on parsing metadata
-* correctly raise authorization error when given XHTML instead of XML
-* unescape HTML encoded responses
-* make httpclient version requirement more specific
-* add ability to print metadata to a file
-* remove Gemfile.lock from repository
+* feature: reduce memory usage on parsing metadata
+* fix: correctly raise authorization error when given XHTML instead of XML
+* fix: unescape HTML encoded responses
+* fix: make httpclient version requirement more specific
+* feature: add ability to print metadata to a file
+* fix: remove Gemfile.lock from repository
 
 ### 0.7.0 / 2015-01-16
 

data/Rakefile

@@ -9,7 +9,7 @@ Hoe.plugin :gemspec
 Hoe.spec 'rets' do
   developer 'Estately, Inc. Open Source', 'opensource@estately.com'
 
-  extra_deps << [ "httpclient", "~> 2.4" ]
+  extra_deps << [ "httpclient", "~> 2.4.0" ]
   extra_deps << [ "nokogiri",   "~> 1.5" ]
 
   extra_dev_deps << [ "mocha", "~> 0.11" ]

data/lib/rets.rb

@@ -3,7 +3,7 @@ require 'digest/md5'
 require 'nokogiri'
 
 module Rets
-  VERSION = '0.8.0'
+  VERSION = '0.8.1'
 
   MalformedResponse    = Class.new(ArgumentError)
   UnknownResponse      = Class.new(ArgumentError)

data/test/test_error_checker.rb

@@ -0,0 +1,69 @@
+require_relative "helper"
+
+class TestErrorChecker < MiniTest::Test
+  def test_check_with_status_code_412
+    response = mock
+    response.stubs(:status_code).returns(412)
+    response.stubs(:body).returns('junk')
+    assert_raises Rets::HttpError do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+
+  def test_401_with_empty_body_is_auth_failure
+    # 401 with no body is an auth failure
+    response = mock
+    response.stubs(:status_code).returns(401)
+    response.stubs(:ok?).returns(false)
+    response.stubs(:body).returns('')
+    assert_raises Rets::AuthorizationFailure do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+
+  def test_401_with_html_body_is_auth_failure
+    # 401 with html body returns auth failure
+    response = mock
+    response.stubs(:status_code).returns(401)
+    response.stubs(:ok?).returns(false)
+    response.stubs(:body).returns(HTML_AUTH_FAILURE)
+    assert_raises Rets::AuthorizationFailure do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+
+  def test_401_with_xhtml_body_is_auth_failure
+    # 401 with xhtml body returns auth failure
+    response = mock
+    response.stubs(:status_code).returns(401)
+    response.stubs(:ok?).returns(false)
+    response.stubs(:body).returns(XHTML_AUTH_FAILURE)
+    assert_raises Rets::AuthorizationFailure do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+
+  def test_no_records_found_failure
+    response = mock
+    response.stubs(:body).returns(RETS_NO_RECORDS_ERROR)
+    assert_raises Rets::NoRecordsFound do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+
+  def test_no_object_found_failure
+    response = mock
+    response.stubs(:body).returns(RETS_NO_OBJECT_ERROR)
+    assert_raises Rets::NoObjectFound do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+
+  def test_invalid_request_failure
+    response = mock
+    response.stubs(:body).returns(RETS_INVALID_REQUEST_ERROR)
+    assert_raises Rets::InvalidRequest do
+      Rets::Parser::ErrorChecker.check(response)
+    end
+  end
+end

data/test/test_http_client.rb

@@ -0,0 +1,49 @@
+require_relative "helper"
+
+class TestHttpClient < MiniTest::Test
+  def setup
+    @cm = WebAgent::CookieManager.new
+
+    @http = HTTPClient.new
+    @http.cookie_manager = @cm
+
+    @logger = Rets::Client::FakeLogger.new
+    @logger.stubs(:debug?).returns(false)
+
+    @http_client = Rets::HttpClient.new(@http, {}, @logger, "http://rets.rets.com/somestate/login.aspx")
+  end
+
+  def test_http_cookie_with_webagent_cookie
+    cookie1 = "RETS-Session-ID=879392834723043209; path=/; domain=rets.rets.com; expires=Wednesday, 31-Dec-2037 12:00:00 GMT"
+    @cm.parse(cookie1, URI.parse("http://www.rets.rets.com"))
+
+    cookie2 = "Foo=Bar; path=/; domain=rets.rets.com; expires=Wednesday, 31-Dec-2037 12:00:00 GMT"
+    @cm.parse(cookie2, URI.parse("http://www.rets.rets.com"))
+
+    assert_equal "879392834723043209", @http_client.http_cookie('RETS-Session-ID')
+  end
+
+  def test_http_cookie_without_webagent_cookie
+    assert_equal nil, @http_client.http_cookie('RETS-Session-ID')
+  end
+
+  def test_http_get_delegates_to_client
+    url = 'foo@example.com'
+    response = stub(:response)
+    response.stubs(:body).returns('response data')
+
+    @http.stubs(:get).with(url, anything, anything).returns(response)
+
+    assert_equal @http_client.http_get(url, {}), response
+  end
+
+  def test_http_post_delegates_to_client
+    url = 'foo@example.com'
+    response = stub(:response)
+    response.stubs(:body).returns('response data')
+
+    @http.stubs(:post).with(url, anything, anything).returns(response)
+
+    assert_equal @http_client.http_post(url, {}), response
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rets
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Estately, Inc. Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-09 00:00:00.000000000 Z
+date: 2015-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 2.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.13'
+        version: '3.6'
 description: |-
   [![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
   A pure-ruby library for fetching data from [RETS] servers.
@@ -147,14 +147,15 @@ files:
 - test/fixtures.rb
 - test/helper.rb
 - test/test_client.rb
+- test/test_error_checker.rb
+- test/test_http_client.rb
 - test/test_locking_http_client.rb
 - test/test_metadata.rb
 - test/test_parser_compact.rb
 - test/test_parser_multipart.rb
 - test/vcr_cassettes/unauthorized_response.yml
 homepage: http://github.com/estately/rets
-licenses:
-- MIT
+licenses: []
 metadata: {}
 post_install_message: 
 rdoc_options:
@@ -173,10 +174,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.3
+rubyforge_project: rets
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: "[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
   A pure-ruby library for fetching data from [RETS] servers"
-test_files: []
+test_files:
+- test/test_client.rb
+- test/test_error_checker.rb
+- test/test_http_client.rb
+- test/test_locking_http_client.rb
+- test/test_metadata.rb
+- test/test_parser_compact.rb
+- test/test_parser_multipart.rb