rets 0.2.0 → 0.2.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.2.1 / 2012-04-20
+
+* fix: better handling of malformed RETS responses
+
 ### 0.2.0 / 2012-04-20
 
 * feature: Ruby 1.9 compatibility!

data/Rakefile

@@ -11,6 +11,8 @@ Hoe.spec 'rets' do
   extra_deps << [ "nokogiri",            "~> 1.5.2" ]
 
   extra_dev_deps << [ "mocha", "~> 0.11.0" ]
+  extra_dev_deps << [ "vcr", "~> 2.2.2" ]
+  extra_dev_deps << [ "webmock", "~> 1.8.0" ]
 
   ### Use markdown for changelog and readme
   self.history_file = 'CHANGELOG.md'

data/lib/rets.rb

@@ -8,7 +8,7 @@ require 'net/http/persistent'
 require 'nokogiri'
 
 module Rets
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 
   AuthorizationFailure = Class.new(ArgumentError)
   InvalidRequest       = Class.new(ArgumentError)

data/lib/rets/client.rb

@@ -159,6 +159,10 @@ module Rets
     def create_parts_from_response(response)
       content_type = response["content-type"]
 
+      if content_type.nil?
+        raise MalformedResponse, "Unable to read content-type from response: #{response.inspect}"
+      end
+
       if content_type.include?("multipart")
         boundary = content_type.scan(/boundary="?([^;"]*)?/).join
 

data/test/helper.rb

@@ -4,3 +4,11 @@ require "mocha"
 require "rets"
 
 require "fixtures"
+
+require 'vcr'
+
+VCR.configure do |c|
+  c.cassette_library_dir = 'test/vcr_cassettes'
+  c.hook_into :webmock
+end
+

data/test/test_client.rb

@@ -521,6 +521,15 @@ DIGEST
     @client.objects([1,2], :foo => :bar)
   end
 
+  def test_object_handles_empty_bodies
+    @client = Rets::Client.new(:password=>"fake", :agent=>"agent", :login_url=>"http://www.example.com:6103/", :username=>"fake_user")
+    assert_raise Rets::MalformedResponse do
+      VCR.use_cassette('empty_body') do
+        @client.objects([1], :resource => 'Property', :object_type => 'Photo', :resource_id => '480346')
+      end
+    end
+  end
+
   def test_objects_raises_on_other_arguments
     assert_raise ArgumentError do
       @client.objects(Object.new, :foo => :bar)

metadata

@@ -1,113 +1,107 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: rets
-version: !ruby/object:Gem::Version 
-  hash: 23
+version: !ruby/object:Gem::Version
+  version: 0.2.1
   prerelease: 
-  segments: 
-  - 0
-  - 2
-  - 0
-  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Estately, Inc. Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-04-23 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-06-28 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: net-http-persistent
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70181484516980 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 1
-        segments: 
-        - 1
-        - 7
-        version: "1.7"
+      - !ruby/object:Gem::Version
+        version: '1.7'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: nokogiri
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70181484516980
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: &70181484516560 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 1
-        - 5
-        - 2
+      - !ruby/object:Gem::Version
         version: 1.5.2
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rdoc
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *70181484516560
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: &70181484516140 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 19
-        segments: 
-        - 3
-        - 10
-        version: "3.10"
+      - !ruby/object:Gem::Version
+        version: 0.11.0
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: mocha
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *70181484516140
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: &70181484515720 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 51
-        segments: 
-        - 0
-        - 11
-        - 0
-        version: 0.11.0
+      - !ruby/object:Gem::Version
+        version: 2.2.2
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: hoe
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: *70181484515720
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: &70181484515300 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        version: "3.0"
+      - !ruby/object:Gem::Version
+        version: 1.8.0
   type: :development
-  version_requirements: *id005
-description: |-
-  [![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
+  prerelease: false
+  version_requirements: *70181484515300
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: &70181484514880 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.10'
+  type: :development
+  prerelease: false
+  version_requirements: *70181484514880
+- !ruby/object:Gem::Dependency
+  name: hoe
+  requirement: &70181484514460 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.13'
+  type: :development
+  prerelease: false
+  version_requirements: *70181484514460
+description: ! '[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
+
   A pure-ruby library for fetching data from [RETS] servers.
-  
-  [RETS]: http://www.rets.org
-email: 
+
+
+  [RETS]: http://www.rets.org'
+email:
 - opensource@estately.com
-executables: 
+executables:
 - rets
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - Manifest.txt
-files: 
+files:
 - CHANGELOG.md
 - Manifest.txt
 - README.md
@@ -134,39 +128,32 @@ files:
 - .gemtest
 homepage: http://github.com/estately/rets
 licenses: []
-
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --main
 - README.md
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: rets
-rubygems_version: 1.8.23
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
-summary: "[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets) A pure-ruby library for fetching data from [RETS] servers"
-test_files: 
+summary: ! '[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
+  A pure-ruby library for fetching data from [RETS] servers'
+test_files:
 - test/test_client.rb
 - test/test_metadata.rb
 - test/test_parser_compact.rb